@nx/eslint-plugin 23.1.0 → 23.1.1

package/dist/src/rules/nx-plugin-checks.d.ts

@@ -11,7 +11,7 @@ export type Options = [
         tsConfig?: string;
     }
 ];
-export type MessageIds = 'missingRequiredSchema' | 'invalidSchemaPath' | 'missingImplementation' | 'invalidImplementationPath' | 'invalidImplementationModule' | 'unableToReadImplementationExports' | 'invalidPromptPath' | 'invalidVersion' | 'missingVersion' | 'noGeneratorsOrSchematicsFound' | 'noExecutorsOrBuildersFound' | 'valueShouldBeObject';
+export type MessageIds = 'missingRequiredSchema' | 'invalidSchemaPath' | 'missingImplementation' | 'invalidImplementationPath' | 'invalidImplementationModule' | 'unableToReadImplementationExports' | 'invalidPromptPath' | 'invalidVersion' | 'missingVersion' | 'noGeneratorsOrSchematicsFound' | 'noExecutorsOrBuildersFound' | 'valueShouldBeObject' | 'duplicateKey';
 export declare const RULE_NAME = "nx-plugin-checks";
 declare const _default: TSESLint.RuleModule<MessageIds, Options, unknown, TSESLint.RuleListener> & {
     name: string;
@@ -23,5 +23,12 @@ export declare function validateEntry(baseNode: AST.JSONObjectExpression, key: s
 export declare function validateImplementationNode(implementationNode: AST.JSONProperty, key: string, context: TSESLint.RuleContext<MessageIds, Options>, projects: Record<string, ProjectConfiguration>): void;
 export declare function validatePromptNode(promptNode: AST.JSONProperty, key: string, context: TSESLint.RuleContext<MessageIds, Options>): void;
 export declare function validatePackageGroup(baseNode: AST.JSONObjectExpression, context: TSESLint.RuleContext<MessageIds, Options>): void;
+/**
+ * A duplicate key anywhere in these manifests silently drops data:
+ * JSON parsers keep only the last occurrence, so a duplicated generator,
+ * executor, or migration entry key discards the earlier definition with no
+ * error at runtime.
+ */
+export declare function validateNoDuplicateKeys(node: AST.JSONObjectExpression | AST.JSONArrayExpression, context: TSESLint.RuleContext<MessageIds, Options>): void;
 export declare function validateVersionJsonExpression(node: AST.JSONExpression, context: TSESLint.RuleContext<MessageIds, Options>): string | boolean;
 export declare function checkIfIdentifierIsFunction(filePath: string, identifier: string): boolean;

package/dist/src/rules/nx-plugin-checks.js

@@ -7,6 +7,7 @@ exports.validateEntry = validateEntry;
 exports.validateImplementationNode = validateImplementationNode;
 exports.validatePromptNode = validatePromptNode;
 exports.validatePackageGroup = validatePackageGroup;
+exports.validateNoDuplicateKeys = validateNoDuplicateKeys;
 exports.validateVersionJsonExpression = validateVersionJsonExpression;
 exports.checkIfIdentifierIsFunction = checkIfIdentifierIsFunction;
 const tslib_1 = require("tslib");
@@ -82,6 +83,7 @@ exports.default = utils_1.ESLintUtils.RuleCreator(() => ``)({
             missingImplementation: '{{ key }}: Missing required property - `implementation`',
             invalidPromptPath: '{{ key }}: Prompt path should point to a valid file',
             missingVersion: '{{ key }}: Missing required property - `version`',
+            duplicateKey: '{{ key }}: Duplicate key. JSON parsers keep only the last occurrence, silently dropping the earlier one',
         },
     },
     defaultOptions: [DEFAULT_OPTIONS],
@@ -109,6 +111,7 @@ exports.default = utils_1.ESLintUtils.RuleCreator(() => ``)({
         }
         return {
             ['JSONExpressionStatement > JSONObjectExpression'](node) {
+                validateNoDuplicateKeys(node, context);
                 if (sourceFilePath === generatorsJson) {
                     checkCollectionFileNode(node, 'generator', context, projects);
                 }
@@ -425,6 +428,43 @@ function validatePackageGroup(baseNode, context) {
         }
     }
 }
+/**
+ * A duplicate key anywhere in these manifests silently drops data:
+ * JSON parsers keep only the last occurrence, so a duplicated generator,
+ * executor, or migration entry key discards the earlier definition with no
+ * error at runtime.
+ */
+function validateNoDuplicateKeys(node, context) {
+    if (node.type === 'JSONObjectExpression') {
+        const seen = new Set();
+        for (const property of node.properties) {
+            const key = property.key.type === 'JSONLiteral'
+                ? String(property.key.value)
+                : property.key.name;
+            if (seen.has(key)) {
+                context.report({
+                    messageId: 'duplicateKey',
+                    data: { key },
+                    node: property.key,
+                });
+            }
+            seen.add(key);
+            if (property.value.type === 'JSONObjectExpression' ||
+                property.value.type === 'JSONArrayExpression') {
+                validateNoDuplicateKeys(property.value, context);
+            }
+        }
+    }
+    else {
+        for (const element of node.elements) {
+            if (element &&
+                (element.type === 'JSONObjectExpression' ||
+                    element.type === 'JSONArrayExpression')) {
+                validateNoDuplicateKeys(element, context);
+            }
+        }
+    }
+}
 function validateVersionJsonExpression(node, context) {
     return (node &&
         node.type === 'JSONLiteral' &&

package/dist/src/utils/project-graph-utils.js

@@ -2,9 +2,10 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.ensureGlobalProjectGraph = ensureGlobalProjectGraph;
 exports.readProjectGraph = readProjectGraph;
+const tslib_1 = require("tslib");
 const devkit_1 = require("@nx/devkit");
 const runtime_lint_utils_1 = require("./runtime-lint-utils");
-const chalk = require("chalk");
+const picocolors_1 = tslib_1.__importDefault(require("picocolors"));
 const find_project_for_path_1 = require("nx/src/project-graph/utils/find-project-for-path");
 const configuration_1 = require("nx/src/config/configuration");
 const internal_1 = require("@nx/js/internal");
@@ -32,8 +33,8 @@ function ensureGlobalProjectGraph(ruleName) {
             globalThis.targetProjectLocator = new internal_1.TargetProjectLocator(projectGraph.nodes, projectGraph.externalNodes);
         }
         catch {
-            const WARNING_PREFIX = `${chalk.reset.keyword('orange')('warning')}`;
-            const RULE_NAME_SUFFIX = `${chalk.reset.dim(`@nx/${ruleName}`)}`;
+            const WARNING_PREFIX = `${picocolors_1.default.reset(picocolors_1.default.yellow('warning'))}`;
+            const RULE_NAME_SUFFIX = `${picocolors_1.default.reset(picocolors_1.default.dim(`@nx/${ruleName}`))}`;
             process.stdout
                 .write(`${WARNING_PREFIX} No cached ProjectGraph is available. The rule will be skipped.
           If you encounter this error as part of running standard \`nx\` commands then please open an issue on https://github.com/nrwl/nx

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/eslint-plugin",
-  "version": "23.1.0",
+  "version": "23.1.1",
   "private": false,
   "type": "commonjs",
   "files": [
@@ -95,17 +95,17 @@
     "@phenomnomnominal/tsquery": "~6.2.0",
     "@typescript-eslint/type-utils": "^8.0.0",
     "@typescript-eslint/utils": "^8.0.0",
-    "chalk": "^4.1.0",
     "confusing-browser-globals": "^1.0.9",
     "globals": "^17.0.0",
     "jsonc-eslint-parser": "^2.1.0",
+    "picocolors": "^1.1.0",
     "semver": "^7.6.3",
     "tslib": "^2.3.0",
-    "@nx/devkit": "23.1.0",
-    "@nx/js": "23.1.0"
+    "@nx/devkit": "23.1.1",
+    "@nx/js": "23.1.1"
   },
   "devDependencies": {
-    "nx": "23.1.0"
+    "nx": "23.1.1"
   },
   "publishConfig": {
     "access": "public"