@nx/eslint-plugin 23.0.0-beta.10 → 23.0.0-beta.12

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/eslint-plugin",
-  "version": "23.0.0-beta.10",
+  "version": "23.0.0-beta.12",
   "private": false,
   "description": "The eslint-plugin package is an ESLint plugin that contains a collection of recommended ESLint rule configurations which you can extend from in your own ESLint configs, as well as an Nx-specific lint rule called enforce-module-boundaries.",
   "repository": {
@@ -35,8 +35,8 @@
     }
   },
   "dependencies": {
-    "@nx/devkit": "23.0.0-beta.10",
-    "@nx/js": "23.0.0-beta.10",
+    "@nx/devkit": "23.0.0-beta.12",
+    "@nx/js": "23.0.0-beta.12",
     "@phenomnomnominal/tsquery": "~6.2.0",
     "@typescript-eslint/type-utils": "^8.0.0",
     "@typescript-eslint/utils": "^8.0.0",
@@ -48,7 +48,7 @@
     "tslib": "^2.3.0"
   },
   "devDependencies": {
-    "nx": "23.0.0-beta.10"
+    "nx": "23.0.0-beta.12"
   },
   "publishConfig": {
     "access": "public"

package/src/rules/dependency-checks.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"dependency-checks.d.ts","sourceRoot":"","sources":["../../../../../packages/eslint-plugin/src/rules/dependency-checks.ts"],"names":[],"mappings":"AAGA,OAAO,EAAE,WAAW,EAAE,MAAM,0BAA0B,CAAC;AAmBvD,MAAM,MAAM,OAAO,GAAG;IACpB;QACE,YAAY,CAAC,EAAE,MAAM,EAAE,CAAC;QACxB,wBAAwB,CAAC,EAAE,OAAO,CAAC;QACnC,yBAAyB,CAAC,EAAE,OAAO,CAAC;QACpC,sBAAsB,CAAC,EAAE,OAAO,CAAC;QACjC,mBAAmB,CAAC,EAAE,MAAM,EAAE,CAAC;QAC/B,YAAY,CAAC,EAAE,MAAM,EAAE,CAAC;QACxB,6BAA6B,CAAC,EAAE,OAAO,CAAC;QACxC,qCAAqC,CAAC,EAAE,OAAO,CAAC;QAChD,cAAc,CAAC,EAAE,MAAM,EAAE,CAAC;QAC1B,uBAAuB,CAAC,EAAE,WAAW,GAAG,WAAW,CAAC;KACrD;CACF,CAAC;AAEF,MAAM,MAAM,UAAU,GAClB,mBAAmB,GACnB,oBAAoB,GACpB,iBAAiB,GACjB,0BAA0B,GAC1B,yBAAyB,CAAC;AAE9B,eAAO,MAAM,SAAS,sBAAsB,CAAC;;;;AAE7C,wBAkgBG"}
+{"version":3,"file":"dependency-checks.d.ts","sourceRoot":"","sources":["../../../../../packages/eslint-plugin/src/rules/dependency-checks.ts"],"names":[],"mappings":"AAGA,OAAO,EAAE,WAAW,EAAE,MAAM,0BAA0B,CAAC;AAmBvD,MAAM,MAAM,OAAO,GAAG;IACpB;QACE,YAAY,CAAC,EAAE,MAAM,EAAE,CAAC;QACxB,wBAAwB,CAAC,EAAE,OAAO,CAAC;QACnC,yBAAyB,CAAC,EAAE,OAAO,CAAC;QACpC,sBAAsB,CAAC,EAAE,OAAO,CAAC;QACjC,mBAAmB,CAAC,EAAE,MAAM,EAAE,CAAC;QAC/B,YAAY,CAAC,EAAE,MAAM,EAAE,CAAC;QACxB,6BAA6B,CAAC,EAAE,OAAO,CAAC;QACxC,qCAAqC,CAAC,EAAE,OAAO,CAAC;QAChD,cAAc,CAAC,EAAE,MAAM,EAAE,CAAC;QAC1B,uBAAuB,CAAC,EAAE,WAAW,GAAG,WAAW,CAAC;KACrD;CACF,CAAC;AAEF,MAAM,MAAM,UAAU,GAClB,mBAAmB,GACnB,oBAAoB,GACpB,iBAAiB,GACjB,0BAA0B,GAC1B,yBAAyB,CAAC;AAE9B,eAAO,MAAM,SAAS,sBAAsB,CAAC;;;;AAE7C,wBAghBG"}

package/src/rules/dependency-checks.js

@@ -97,6 +97,17 @@ exports.default = utils_1.ESLintUtils.RuleCreator(() => `https://github.com/nrwl
             runtimeHelpers,
         });
         const expectedDependencyNames = Object.keys(npmDependencies);
+        // Packages eligible for `workspace:*` rewrites under
+        // `peerDepsVersionStrategy: 'workspace'`. Must be both a workspace project
+        // and registered in the package manager's workspaces — otherwise
+        // `workspace:*` won't resolve at install time.
+        const workspacePackageNames = new Set();
+        for (const node of Object.values(projectGraph.nodes)) {
+            const js = node.data?.metadata?.js;
+            if (js?.packageName && js.isInPackageManagerWorkspaces) {
+                workspacePackageNames.add(js.packageName);
+            }
+        }
         const packageJson = JSON.parse(context.sourceCode.getText());
         const projPackageJsonDeps = (0, package_json_utils_1.getProductionDependencies)(packageJson);
         const rootPackageJsonDeps = (0, package_json_utils_1.getAllDependencies)(rootPackageJson);
@@ -189,7 +200,8 @@ exports.default = utils_1.ESLintUtils.RuleCreator(() => `https://github.com/nrwl
                     fix(fixer) {
                         missingDeps.forEach((d) => {
                             if (dependencySection === 'peerDependencies' &&
-                                peerDepsVersionStrategy === 'workspace') {
+                                peerDepsVersionStrategy === 'workspace' &&
+                                workspacePackageNames.has(d)) {
                                 projPackageJsonDeps[d] = WORKSPACE_VERSION_WILDCARD;
                             }
                             else {
@@ -237,7 +249,8 @@ exports.default = utils_1.ESLintUtils.RuleCreator(() => `https://github.com/nrwl
             const dependencySection = getDependencySection(node);
             if (dependencySection === 'peerDependencies' &&
                 peerDepsVersionStrategy === 'workspace' &&
-                !packageRange.startsWith('workspace:')) {
+                !packageRange.startsWith('workspace:') &&
+                workspacePackageNames.has(packageName)) {
                 context.report({
                     node: node,
                     messageId: 'versionMismatch',