@nx/eslint-plugin 21.3.0-beta.0 → 21.3.0-beta.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/eslint-plugin",
-  "version": "21.3.0-beta.0",
+  "version": "21.3.0-beta.2",
   "private": false,
   "description": "The eslint-plugin package is an ESLint plugin that contains a collection of recommended ESLint rule configurations which you can extend from in your own ESLint configs, as well as an Nx-specific lint rule called enforce-module-boundaries.",
   "repository": {
@@ -34,8 +34,9 @@
     }
   },
   "dependencies": {
-    "@nx/devkit": "21.3.0-beta.0",
-    "@nx/js": "21.3.0-beta.0",
+    "@nx/devkit": "21.3.0-beta.2",
+    "@nx/js": "21.3.0-beta.2",
+    "@phenomnomnominal/tsquery": "~5.0.1",
     "@typescript-eslint/type-utils": "^8.0.0",
     "@typescript-eslint/utils": "^8.0.0",
     "chalk": "^4.1.0",

package/src/rules/nx-plugin-checks.d.ts

@@ -24,3 +24,4 @@ export declare function validateEntry(baseNode: AST.JSONObjectExpression, key: s
 export declare function validateImplementationNode(implementationNode: AST.JSONProperty, key: string, context: TSESLint.RuleContext<MessageIds, Options>, options: NormalizedOptions): void;
 export declare function validatePackageGroup(baseNode: AST.JSONObjectExpression, context: TSESLint.RuleContext<MessageIds, Options>): void;
 export declare function validateVersionJsonExpression(node: AST.JSONExpression, context: TSESLint.RuleContext<MessageIds, Options>): string | boolean;
+export declare function checkIfIdentifierIsFunction(filePath: string, identifier: string): boolean;

package/src/rules/nx-plugin-checks.js

@@ -7,8 +7,11 @@ exports.validateEntry = validateEntry;
 exports.validateImplementationNode = validateImplementationNode;
 exports.validatePackageGroup = validatePackageGroup;
 exports.validateVersionJsonExpression = validateVersionJsonExpression;
+exports.checkIfIdentifierIsFunction = checkIfIdentifierIsFunction;
 const tslib_1 = require("tslib");
 const utils_1 = require("@typescript-eslint/utils");
+const fs_1 = require("fs");
+const tsquery_1 = require("@phenomnomnominal/tsquery");
 const devkit_1 = require("@nx/devkit");
 const js_1 = require("@nx/js");
 const internal_1 = require("@nx/js/src/internal");
@@ -346,8 +349,7 @@ function validateImplementationNode(implementationNode, key, context, options) {
         }
         if (identifier) {
             try {
-                const m = require(resolvedPath);
-                if (!(identifier in m && typeof m[identifier] === 'function')) {
+                if (!checkIfIdentifierIsFunction(resolvedPath, identifier)) {
                     context.report({
                         messageId: 'invalidImplementationModule',
                         node: implementationNode.value,
@@ -359,6 +361,7 @@ function validateImplementationNode(implementationNode, key, context, options) {
                 }
             }
             catch {
+                // require can throw if the module is not found
                 context.report({
                     messageId: 'unableToReadImplementationExports',
                     node: implementationNode.value,
@@ -429,3 +432,26 @@ function validateVersionJsonExpression(node, context) {
         ((0, semver_1.valid)(node.value) ||
             context.options[0]?.allowedVersionStrings.includes(node.value)));
 }
+function checkIfIdentifierIsFunction(filePath, identifier) {
+    try {
+        const ts = require('typescript');
+        const sourceCode = (0, fs_1.readFileSync)(filePath, 'utf-8');
+        const sourceFile = ts.createSourceFile(filePath, sourceCode, ts.ScriptTarget.Latest, true);
+        const exportedFunctions = (0, tsquery_1.tsquery)(sourceFile, `
+      FunctionDeclaration[name.text="${identifier}"][modifiers],
+      ExportDeclaration > FunctionDeclaration[name.text="${identifier}"],
+      VariableStatement[modifiers] VariableDeclaration[name.text="${identifier}"] ArrowFunction,
+      VariableStatement[modifiers] VariableDeclaration[name.text="${identifier}"] FunctionExpression,
+      ExportDeclaration > VariableStatement VariableDeclaration[name.text="${identifier}"] ArrowFunction,
+      ExportDeclaration > VariableStatement VariableDeclaration[name.text="${identifier}"] FunctionExpression,
+      ExportDeclaration ExportSpecifier[name.text="${identifier}"]
+    `);
+        return exportedFunctions.length > 0;
+    }
+    catch {
+        // ignore
+    }
+    // Fallback to require()
+    const m = require(filePath);
+    return identifier in m && typeof m[identifier] === 'function';
+}