@nx/eslint-plugin 19.5.0-beta.0 → 19.5.0-beta.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/eslint-plugin",
-  "version": "19.5.0-beta.0",
+  "version": "19.5.0-beta.1",
   "private": false,
   "description": "The eslint-plugin package is an ESLint plugin that contains a collection of recommended ESLint rule configurations which you can extend from in your own ESLint configs, as well as an Nx-specific lint rule called enforce-module-boundaries.",
   "repository": {
@@ -34,16 +34,16 @@
     }
   },
   "dependencies": {
-    "@nx/devkit": "19.5.0-beta.0",
-    "@nx/js": "19.5.0-beta.0",
-    "@typescript-eslint/type-utils": "^7.3.0",
-    "@typescript-eslint/utils": "^7.3.0",
+    "@nx/devkit": "19.5.0-beta.1",
+    "@nx/js": "19.5.0-beta.1",
+    "@typescript-eslint/type-utils": "^7.16.0",
+    "@typescript-eslint/utils": "^7.16.0",
     "chalk": "^4.1.0",
     "confusing-browser-globals": "^1.0.9",
     "jsonc-eslint-parser": "^2.1.0",
     "semver": "^7.5.3",
     "tslib": "^2.3.0",
-    "@nrwl/eslint-plugin-nx": "19.5.0-beta.0"
+    "@nrwl/eslint-plugin-nx": "19.5.0-beta.1"
   },
   "publishConfig": {
     "access": "public"

package/src/migrations/update-16-0-0-add-nx-packages/update-16-0-0-add-nx-packages.js

@@ -1,5 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+exports.default = replacePackage;
 const devkit_1 = require("@nx/devkit");
 const replace_package_1 = require("@nx/devkit/src/utils/replace-package");
 const path_1 = require("path");
@@ -40,4 +41,3 @@ async function replacePackage(tree) {
     });
     await (0, devkit_1.formatFiles)(tree);
 }
-exports.default = replacePackage;

package/src/migrations/update-17-2-6-rename-workspace-rules/rename-workspace-rules.js

@@ -1,5 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+exports.default = renameWorkspaceRule;
 const devkit_1 = require("@nx/devkit");
 const binary_extensions_1 = require("@nx/devkit/src/utils/binary-extensions");
 const constants_1 = require("../../constants");
@@ -26,4 +27,3 @@ async function renameWorkspaceRule(tree) {
     });
     await (0, devkit_1.formatFiles)(tree);
 }
-exports.default = renameWorkspaceRule;

package/src/migrations/update-19-1-0-migrate-no-extra-semi/migrate-no-extra-semi.js

@@ -1,5 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+exports.default = migrate;
 const devkit_1 = require("@nx/devkit");
 async function migrate(tree) {
     (0, devkit_1.visitNotIgnoredFiles)(tree, '.', (path) => {
@@ -33,7 +34,6 @@ This is because those rules have been migrated to the https://eslint.style/ proj
     });
     await (0, devkit_1.formatFiles)(tree);
 }
-exports.default = migrate;
 /**
  * @returns {boolean} whether the json was updated
  */

package/src/rules/nx-plugin-checks.js

@@ -1,6 +1,12 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.validateVersionJsonExpression = exports.validatePackageGroup = exports.validateImplemenationNode = exports.validateEntry = exports.checkCollectionNode = exports.checkCollectionFileNode = exports.RULE_NAME = void 0;
+exports.RULE_NAME = void 0;
+exports.checkCollectionFileNode = checkCollectionFileNode;
+exports.checkCollectionNode = checkCollectionNode;
+exports.validateEntry = validateEntry;
+exports.validateImplemenationNode = validateImplemenationNode;
+exports.validatePackageGroup = validatePackageGroup;
+exports.validateVersionJsonExpression = validateVersionJsonExpression;
 const tslib_1 = require("tslib");
 const utils_1 = require("@typescript-eslint/utils");
 const devkit_1 = require("@nx/devkit");
@@ -168,7 +174,6 @@ function checkCollectionFileNode(baseNode, mode, context) {
         }
     }
 }
-exports.checkCollectionFileNode = checkCollectionFileNode;
 function checkCollectionNode(baseNode, mode, context) {
     const entries = baseNode.properties;
     for (const entryNode of entries) {
@@ -184,7 +189,6 @@ function checkCollectionNode(baseNode, mode, context) {
         }
     }
 }
-exports.checkCollectionNode = checkCollectionNode;
 function validateEntry(baseNode, key, mode, context) {
     const schemaNode = baseNode.properties.find((x) => x.key.type === 'JSONLiteral' && x.key.value === 'schema');
     if (mode !== 'migration' && !schemaNode) {
@@ -274,7 +278,6 @@ function validateEntry(baseNode, key, mode, context) {
         }
     }
 }
-exports.validateEntry = validateEntry;
 function validateImplemenationNode(implementationNode, key, context) {
     if (implementationNode.value.type !== 'JSONLiteral' ||
         typeof implementationNode.value.value !== 'string') {
@@ -328,7 +331,6 @@ function validateImplemenationNode(implementationNode, key, context) {
         }
     }
 }
-exports.validateImplemenationNode = validateImplemenationNode;
 function validatePackageGroup(baseNode, context) {
     const migrationsNode = baseNode.properties.find((x) => x.key.type === 'JSONLiteral' &&
         x.value.type === 'JSONObjectExpression' &&
@@ -381,7 +383,6 @@ function validatePackageGroup(baseNode, context) {
         }
     }
 }
-exports.validatePackageGroup = validatePackageGroup;
 function validateVersionJsonExpression(node, context) {
     return (node &&
         node.type === 'JSONLiteral' &&
@@ -389,4 +390,3 @@ function validateVersionJsonExpression(node, context) {
         ((0, semver_1.valid)(node.value) ||
             context.options[0]?.allowedVersionStrings.includes(node.value)));
 }
-exports.validateVersionJsonExpression = validateVersionJsonExpression;

package/src/utils/ast-utils.js

@@ -1,6 +1,8 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.getRelativeImportPath = exports.getBarrelEntryPointProjectNode = exports.getBarrelEntryPointByImportScope = void 0;
+exports.getBarrelEntryPointByImportScope = getBarrelEntryPointByImportScope;
+exports.getBarrelEntryPointProjectNode = getBarrelEntryPointProjectNode;
+exports.getRelativeImportPath = getRelativeImportPath;
 const devkit_1 = require("@nx/devkit");
 const js_1 = require("@nx/js");
 const type_utils_1 = require("@typescript-eslint/type-utils");
@@ -50,7 +52,6 @@ function getBarrelEntryPointByImportScope(importScope) {
         return [];
     return tryPaths(tsConfigBase.compilerOptions.paths, importScope);
 }
-exports.getBarrelEntryPointByImportScope = getBarrelEntryPointByImportScope;
 function getBarrelEntryPointProjectNode(projectNode) {
     const tsConfigBase = tryReadBaseJson();
     if (tsConfigBase?.compilerOptions?.paths) {
@@ -70,7 +71,6 @@ function getBarrelEntryPointProjectNode(projectNode) {
     }
     return null;
 }
-exports.getBarrelEntryPointProjectNode = getBarrelEntryPointProjectNode;
 function hasMemberExport(exportedMember, filePath) {
     const fileContent = (0, fs_1.readFileSync)(filePath, 'utf8');
     // use the TypeScript AST to find the path to the file where exportedMember is defined
@@ -217,4 +217,3 @@ function getRelativeImportPath(exportedMember, filePath, basePath) {
     }
     return null;
 }
-exports.getRelativeImportPath = getRelativeImportPath;

package/src/utils/config-utils.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.packageExists = void 0;
+exports.packageExists = packageExists;
 /**
  * Checks if package is available
  * @param name name of the package
@@ -15,4 +15,3 @@ function packageExists(name) {
         return false;
     }
 }
-exports.packageExists = packageExists;

package/src/utils/graph-utils.js

@@ -1,6 +1,10 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.findFilesWithDynamicImports = exports.findFilesInCircularPath = exports.checkCircularPath = exports.pathExists = exports.getPath = void 0;
+exports.getPath = getPath;
+exports.pathExists = pathExists;
+exports.checkCircularPath = checkCircularPath;
+exports.findFilesInCircularPath = findFilesInCircularPath;
+exports.findFilesWithDynamicImports = findFilesWithDynamicImports;
 const project_graph_1 = require("nx/src/config/project-graph");
 const reach = {
     graph: null,
@@ -83,7 +87,6 @@ function getPath(graph, sourceProjectName, targetProjectName) {
         return [];
     }
 }
-exports.getPath = getPath;
 function pathExists(graph, sourceProjectName, targetProjectName) {
     if (sourceProjectName === targetProjectName)
         return true;
@@ -95,13 +98,11 @@ function pathExists(graph, sourceProjectName, targetProjectName) {
     }
     return !!reach.matrix[sourceProjectName][targetProjectName];
 }
-exports.pathExists = pathExists;
 function checkCircularPath(graph, sourceProject, targetProject) {
     if (!graph.nodes[targetProject.name])
         return [];
     return getPath(graph, targetProject.name, sourceProject.name);
 }
-exports.checkCircularPath = checkCircularPath;
 function findFilesInCircularPath(projectFileMap, circularPath) {
     const filePathChain = [];
     for (let i = 0; i < circularPath.length - 1; i++) {
@@ -113,7 +114,6 @@ function findFilesInCircularPath(projectFileMap, circularPath) {
     }
     return filePathChain;
 }
-exports.findFilesInCircularPath = findFilesInCircularPath;
 function findFilesWithDynamicImports(projectFileMap, sourceProjectName, targetProjectName) {
     const files = [];
     projectFileMap[sourceProjectName].forEach((file) => {
@@ -126,4 +126,3 @@ function findFilesWithDynamicImports(projectFileMap, sourceProjectName, targetPr
     });
     return files;
 }
-exports.findFilesWithDynamicImports = findFilesWithDynamicImports;

package/src/utils/package-json-utils.js

@@ -1,6 +1,8 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.getPackageJson = exports.getProductionDependencies = exports.getAllDependencies = void 0;
+exports.getAllDependencies = getAllDependencies;
+exports.getProductionDependencies = getProductionDependencies;
+exports.getPackageJson = getPackageJson;
 const devkit_1 = require("@nx/devkit");
 const fs_1 = require("fs");
 const runtime_lint_utils_1 = require("./runtime-lint-utils");
@@ -12,7 +14,6 @@ function getAllDependencies(packageJson) {
         ...packageJson.optionalDependencies,
     };
 }
-exports.getAllDependencies = getAllDependencies;
 function getProductionDependencies(packageJsonPath) {
     if (!globalThis.projPackageJsonDeps ||
         !globalThis.projPackageJsonDeps[packageJsonPath] ||
@@ -27,11 +28,9 @@ function getProductionDependencies(packageJsonPath) {
     }
     return globalThis.projPackageJsonDeps[packageJsonPath];
 }
-exports.getProductionDependencies = getProductionDependencies;
 function getPackageJson(path) {
     if ((0, fs_1.existsSync)(path)) {
         return (0, devkit_1.readJsonFile)(path);
     }
     return {};
 }
-exports.getPackageJson = getPackageJson;

package/src/utils/project-graph-utils.js

@@ -1,6 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.readProjectGraph = exports.ensureGlobalProjectGraph = void 0;
+exports.ensureGlobalProjectGraph = ensureGlobalProjectGraph;
+exports.readProjectGraph = readProjectGraph;
 const devkit_1 = require("@nx/devkit");
 const runtime_lint_utils_1 = require("./runtime-lint-utils");
 const chalk = require("chalk");
@@ -40,7 +41,6 @@ function ensureGlobalProjectGraph(ruleName) {
         }
     }
 }
-exports.ensureGlobalProjectGraph = ensureGlobalProjectGraph;
 function readProjectGraph(ruleName) {
     ensureGlobalProjectGraph(ruleName);
     return {
@@ -50,4 +50,3 @@ function readProjectGraph(ruleName) {
         targetProjectLocator: globalThis.targetProjectLocator,
     };
 }
-exports.readProjectGraph = readProjectGraph;

package/src/utils/runtime-lint-utils.js

@@ -1,6 +1,28 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.getParserServices = exports.appIsMFERemote = exports.belongsToDifferentNgEntryPoint = exports.groupImports = exports.isTerminalRun = exports.hasBuildExecutor = exports.isDirectDependency = exports.hasBannedDependencies = exports.findTransitiveExternalDependencies = exports.hasBannedImport = exports.getSourceFilePath = exports.hasStaticImportOfDynamicResource = exports.findConstraintsFor = exports.findProjectUsingImport = exports.isAbsoluteImportIntoAnotherProject = exports.findProject = exports.getTargetProjectBasedOnRelativeImport = exports.isRelative = exports.matchImportWithWildcard = exports.findDependenciesWithTags = exports.isComboDepConstraint = exports.hasNoneOfTheseTags = exports.stringifyTags = void 0;
+exports.stringifyTags = stringifyTags;
+exports.hasNoneOfTheseTags = hasNoneOfTheseTags;
+exports.isComboDepConstraint = isComboDepConstraint;
+exports.findDependenciesWithTags = findDependenciesWithTags;
+exports.matchImportWithWildcard = matchImportWithWildcard;
+exports.isRelative = isRelative;
+exports.getTargetProjectBasedOnRelativeImport = getTargetProjectBasedOnRelativeImport;
+exports.findProject = findProject;
+exports.isAbsoluteImportIntoAnotherProject = isAbsoluteImportIntoAnotherProject;
+exports.findProjectUsingImport = findProjectUsingImport;
+exports.findConstraintsFor = findConstraintsFor;
+exports.hasStaticImportOfDynamicResource = hasStaticImportOfDynamicResource;
+exports.getSourceFilePath = getSourceFilePath;
+exports.hasBannedImport = hasBannedImport;
+exports.findTransitiveExternalDependencies = findTransitiveExternalDependencies;
+exports.hasBannedDependencies = hasBannedDependencies;
+exports.isDirectDependency = isDirectDependency;
+exports.hasBuildExecutor = hasBuildExecutor;
+exports.isTerminalRun = isTerminalRun;
+exports.groupImports = groupImports;
+exports.belongsToDifferentNgEntryPoint = belongsToDifferentNgEntryPoint;
+exports.appIsMFERemote = appIsMFERemote;
+exports.getParserServices = getParserServices;
 const tslib_1 = require("tslib");
 const devkit_1 = require("@nx/devkit");
 const js_1 = require("@nx/js");
@@ -13,15 +35,12 @@ const graph_utils_1 = require("./graph-utils");
 function stringifyTags(tags) {
     return tags.map((t) => `"${t}"`).join(', ');
 }
-exports.stringifyTags = stringifyTags;
 function hasNoneOfTheseTags(proj, tags) {
     return tags.filter((tag) => hasTag(proj, tag)).length === 0;
 }
-exports.hasNoneOfTheseTags = hasNoneOfTheseTags;
 function isComboDepConstraint(depConstraint) {
     return !!depConstraint.allSourceTags;
 }
-exports.isComboDepConstraint = isComboDepConstraint;
 /**
  * Check if any of the given tags is included in the project
  * @param proj ProjectGraphProjectNode
@@ -38,7 +57,6 @@ function findDependenciesWithTags(targetProject, tags, graph) {
         ? [targetProject]
         : (0, graph_utils_1.getPath)(graph, targetProject.name, project));
 }
-exports.findDependenciesWithTags = findDependenciesWithTags;
 const regexMap = new Map();
 function hasTag(proj, tag) {
     if (tag === '*')
@@ -83,11 +101,9 @@ allowableImport, extractedImport) {
         return new RegExp(allowableImport).test(extractedImport);
     }
 }
-exports.matchImportWithWildcard = matchImportWithWildcard;
 function isRelative(s) {
     return s.startsWith('./') || s.startsWith('../');
 }
-exports.isRelative = isRelative;
 function getTargetProjectBasedOnRelativeImport(imp, projectPath, projectGraph, projectRootMappings, sourceFilePath) {
     if (!isRelative(imp)) {
         return undefined;
@@ -96,23 +112,19 @@ function getTargetProjectBasedOnRelativeImport(imp, projectPath, projectGraph, p
     const targetFile = (0, devkit_1.normalizePath)(path.resolve(sourceDir, imp)).substring(projectPath.length + 1);
     return findProject(projectGraph, projectRootMappings, targetFile);
 }
-exports.getTargetProjectBasedOnRelativeImport = getTargetProjectBasedOnRelativeImport;
 function findProject(projectGraph, projectRootMappings, sourceFilePath) {
     return projectGraph.nodes[(0, find_project_for_path_1.findProjectForPath)(sourceFilePath, projectRootMappings)];
 }
-exports.findProject = findProject;
 function isAbsoluteImportIntoAnotherProject(imp, workspaceLayout = { libsDir: 'libs', appsDir: 'apps' }) {
     return (imp.startsWith(`${workspaceLayout.libsDir}/`) ||
         imp.startsWith(`/${workspaceLayout.libsDir}/`) ||
         imp.startsWith(`${workspaceLayout.appsDir}/`) ||
         imp.startsWith(`/${workspaceLayout.appsDir}/`));
 }
-exports.isAbsoluteImportIntoAnotherProject = isAbsoluteImportIntoAnotherProject;
 function findProjectUsingImport(projectGraph, targetProjectLocator, filePath, imp) {
     const target = targetProjectLocator.findProjectFromImport(imp, filePath);
     return projectGraph.nodes[target] || projectGraph.externalNodes?.[target];
 }
-exports.findProjectUsingImport = findProjectUsingImport;
 function findConstraintsFor(depConstraints, sourceProject) {
     return depConstraints.filter((f) => {
         if (isComboDepConstraint(f)) {
@@ -123,7 +135,6 @@ function findConstraintsFor(depConstraints, sourceProject) {
         }
     });
 }
-exports.findConstraintsFor = findConstraintsFor;
 function hasStaticImportOfDynamicResource(node, graph, sourceProjectName, targetProjectName) {
     if (node.type !== utils_1.AST_NODE_TYPES.ImportDeclaration ||
         node.importKind === 'type') {
@@ -131,7 +142,6 @@ function hasStaticImportOfDynamicResource(node, graph, sourceProjectName, target
     }
     return onlyLoadChildren(graph, sourceProjectName, targetProjectName, []);
 }
-exports.hasStaticImportOfDynamicResource = hasStaticImportOfDynamicResource;
 function onlyLoadChildren(graph, sourceProjectName, targetProjectName, visited) {
     if (visited.indexOf(sourceProjectName) > -1) {
         return false;
@@ -154,7 +164,6 @@ function getSourceFilePath(sourceFileName, projectPath) {
     const normalizedSourceFileName = (0, devkit_1.normalizePath)(sourceFileName);
     return normalizedSourceFileName.slice(normalizedProjectPath.length + 1);
 }
-exports.getSourceFilePath = getSourceFilePath;
 /**
  * Find constraint (if any) that explicitly banns the given target npm project
  * @param externalProject
@@ -189,7 +198,6 @@ function hasBannedImport(source, target, depConstraints, imp) {
     });
     return depConstraints.find((constraint) => isConstraintBanningProject(target, constraint, imp));
 }
-exports.hasBannedImport = hasBannedImport;
 /**
  * Find all unique (transitive) external dependencies of given project
  * @param graph
@@ -221,7 +229,6 @@ function findTransitiveExternalDependencies(graph, source) {
     }
     return externalDependencies;
 }
-exports.findTransitiveExternalDependencies = findTransitiveExternalDependencies;
 /**
  * Check if
  * @param externalDependencies
@@ -238,12 +245,10 @@ function hasBannedDependencies(externalDependencies, graph, depConstraint, imp)
         depConstraint,
     ]);
 }
-exports.hasBannedDependencies = hasBannedDependencies;
 function isDirectDependency(source, target) {
     return (packageExistsInPackageJson(target.data.packageName, '.') ||
         packageExistsInPackageJson(target.data.packageName, source.data.root));
 }
-exports.isDirectDependency = isDirectDependency;
 function packageExistsInPackageJson(packageName, projectRoot) {
     const content = (0, fileutils_1.readFileIfExisting)(path.join(devkit_1.workspaceRoot, projectRoot, 'package.json'));
     if (content) {
@@ -280,7 +285,6 @@ function hasBuildExecutor(projectGraph, buildTargets = ['build']) {
         buildTargets.some((target) => projectGraph.data.targets[target] &&
             projectGraph.data.targets[target].executor !== ''));
 }
-exports.hasBuildExecutor = hasBuildExecutor;
 const ESLINT_REGEX = /node_modules.*[\/\\]eslint(?:\.js)?$/;
 const JEST_REGEX = /node_modules\/.bin\/jest$/; // when we run unit tests in jest
 const NRWL_CLI_REGEX = /nx[\/\\]bin[\/\\]run-executor\.js$/;
@@ -291,7 +295,6 @@ function isTerminalRun() {
             !!process.argv[1].match(ESLINT_REGEX) ||
             !!process.argv[1].endsWith('/bin/jest.js')));
 }
-exports.isTerminalRun = isTerminalRun;
 /**
  * Takes an array of imports and tries to group them, so rather than having
  * `import { A } from './some-location'` and `import { B } from './some-location'` you get
@@ -319,7 +322,6 @@ function groupImports(importsToRemap) {
         .map((entry) => `import { ${entry.member} } from '${entry.importPath}';`)
         .join('\n');
 }
-exports.groupImports = groupImports;
 /**
  * Checks if source file belongs to a secondary entry point different than the import one
  */
@@ -334,7 +336,6 @@ function belongsToDifferentNgEntryPoint(importExpr, filePath, projectRoot) {
     // check if the entry point of import expression is different than the source file's entry point
     return importEntryPoint !== srcEntryPoint;
 }
-exports.belongsToDifferentNgEntryPoint = belongsToDifferentNgEntryPoint;
 function getAngularEntryPoint(file, projectRoot) {
     let parent = (0, devkit_1.joinPathFragments)(file, '../');
     while (parent !== `${projectRoot}/`) {
@@ -361,7 +362,6 @@ function appIsMFERemote(project) {
     }
     return false;
 }
-exports.appIsMFERemote = appIsMFERemote;
 /**
  * parserServices moved from the context object to the nested sourceCode object in v8,
  * and was removed from its original location in v9.
@@ -376,4 +376,3 @@ function getParserServices(context) {
     }
     return parserServices;
 }
-exports.getParserServices = getParserServices;