@nx/eslint-plugin 19.2.0-beta.1 → 19.2.0-beta.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/eslint-plugin",
-  "version": "19.2.0-beta.1",
+  "version": "19.2.0-beta.2",
   "private": false,
   "description": "The eslint-plugin package is an ESLint plugin that contains a collection of recommended ESLint rule configurations which you can extend from in your own ESLint configs, as well as an Nx-specific lint rule called enforce-module-boundaries.",
   "repository": {
@@ -34,8 +34,8 @@
     }
   },
   "dependencies": {
-    "@nx/devkit": "19.2.0-beta.1",
-    "@nx/js": "19.2.0-beta.1",
+    "@nx/devkit": "19.2.0-beta.2",
+    "@nx/js": "19.2.0-beta.2",
     "@typescript-eslint/type-utils": "^7.3.0",
     "@typescript-eslint/utils": "^7.3.0",
     "chalk": "^4.1.0",
@@ -43,7 +43,7 @@
     "jsonc-eslint-parser": "^2.1.0",
     "semver": "^7.5.3",
     "tslib": "^2.3.0",
-    "@nrwl/eslint-plugin-nx": "19.2.0-beta.1"
+    "@nrwl/eslint-plugin-nx": "19.2.0-beta.2"
   },
   "publishConfig": {
     "access": "public"

package/src/rules/enforce-module-boundaries.d.ts

@@ -1,5 +1,5 @@
-import { DepConstraint } from '../utils/runtime-lint-utils';
 import { ESLintUtils } from '@typescript-eslint/utils';
+import { DepConstraint } from '../utils/runtime-lint-utils';
 type Options = [
     {
         allow: string[];

package/src/rules/enforce-module-boundaries.js

@@ -2,16 +2,16 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.RULE_NAME = void 0;
 const devkit_1 = require("@nx/devkit");
-const fileutils_1 = require("nx/src/utils/fileutils");
-const graph_utils_1 = require("../utils/graph-utils");
-const runtime_lint_utils_1 = require("../utils/runtime-lint-utils");
 const utils_1 = require("@typescript-eslint/utils");
+const internal_1 = require("@nx/js/src/internal");
+const fileutils_1 = require("nx/src/utils/fileutils");
 const path_1 = require("path");
 const ast_utils_1 = require("../utils/ast-utils");
+const graph_utils_1 = require("../utils/graph-utils");
 const project_graph_utils_1 = require("../utils/project-graph-utils");
-const utils_2 = require("@typescript-eslint/utils");
+const runtime_lint_utils_1 = require("../utils/runtime-lint-utils");
 exports.RULE_NAME = 'enforce-module-boundaries';
-exports.default = utils_2.ESLintUtils.RuleCreator(() => `https://github.com/nrwl/nx/blob/${devkit_1.NX_VERSION}/docs/generated/packages/eslint-plugin/documents/enforce-module-boundaries.md`)({
+exports.default = utils_1.ESLintUtils.RuleCreator(() => `https://github.com/nrwl/nx/blob/${devkit_1.NX_VERSION}/docs/generated/packages/eslint-plugin/documents/enforce-module-boundaries.md`)({
     name: exports.RULE_NAME,
     meta: {
         type: 'suggestion',
@@ -107,7 +107,7 @@ exports.default = utils_2.ESLintUtils.RuleCreator(() => `https://github.com/nrwl
             projectWithoutTagsCannotHaveDependencies: `A project without tags matching at least one constraint cannot depend on any libraries`,
             bannedExternalImportsViolation: `A project tagged with "{{sourceTag}}" is not allowed to import "{{imp}}"`,
             nestedBannedExternalImportsViolation: `A project tagged with "{{sourceTag}}" is not allowed to import "{{imp}}". Nested import found at {{childProjectName}}`,
-            noTransitiveDependencies: `Transitive dependencies are not allowed. Only packages defined in the "package.json" can be imported`,
+            noTransitiveDependencies: `Only packages defined in the "package.json" can be imported. Transitive or unresolvable dependencies are not allowed.`,
             onlyTagsConstraintViolation: `A project tagged with "{{sourceTag}}" can only depend on libs tagged with {{tags}}`,
             emptyOnlyTagsConstraintViolation: 'A project tagged with "{{sourceTag}}" cannot depend on any libs with tags',
             notTagsConstraintViolation: `A project tagged with "{{sourceTag}}" can not depend on libs tagged with {{tags}}\n\nViolation detected in:\n{{projects}}`,
@@ -217,6 +217,20 @@ exports.default = utils_2.ESLintUtils.RuleCreator(() => `https://github.com/nrwl
                         messageId: 'noRelativeOrAbsoluteExternals',
                     });
                 }
+                else if (banTransitiveDependencies && !(0, internal_1.isBuiltinModuleImport)(imp)) {
+                    /**
+                     * At this point, the target project could not be found in the project graph, and it is not a relative or absolute import.
+                     * Therefore it could be an external/npm package dependency (but not a node built in module) which has not yet been installed
+                     * in the workspace.
+                     *
+                     * If the banTransitiveDependencies option is enabled, we should flag this case as an error because the user is trying to
+                     * depend on something which is not explicitly defined/resolvable on disk for their project.
+                     */
+                    context.report({
+                        node,
+                        messageId: 'noTransitiveDependencies',
+                    });
+                }
                 // If target is not found (including node internals) we bail early
                 return;
             }

package/src/utils/runtime-lint-utils.js

@@ -109,7 +109,7 @@ function isAbsoluteImportIntoAnotherProject(imp, workspaceLayout = { libsDir: 'l
 }
 exports.isAbsoluteImportIntoAnotherProject = isAbsoluteImportIntoAnotherProject;
 function findProjectUsingImport(projectGraph, targetProjectLocator, filePath, imp) {
-    const target = targetProjectLocator.findProjectWithImport(imp, filePath);
+    const target = targetProjectLocator.findProjectFromImport(imp, filePath);
     return projectGraph.nodes[target] || projectGraph.externalNodes?.[target];
 }
 exports.findProjectUsingImport = findProjectUsingImport;