@nx/eslint-plugin 17.3.0 → 17.3.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/eslint-plugin",
-  "version": "17.3.0",
+  "version": "17.3.2",
   "private": false,
   "description": "The eslint-plugin package is an ESLint plugin that contains a collection of recommended ESLint rule configurations which you can extend from in your own ESLint configs, as well as an Nx-specific lint rule called enforce-module-boundaries.",
   "repository": {
@@ -33,16 +33,16 @@
     }
   },
   "dependencies": {
-    "@nx/devkit": "17.3.0",
-    "@nx/js": "17.3.0",
+    "@nx/devkit": "17.3.2",
+    "@nx/js": "17.3.2",
     "@typescript-eslint/type-utils": "^6.13.2",
     "@typescript-eslint/utils": "^6.13.2",
     "chalk": "^4.1.0",
     "confusing-browser-globals": "^1.0.9",
     "jsonc-eslint-parser": "^2.1.0",
-    "semver": "7.5.3",
+    "semver": "^7.5.3",
     "tslib": "^2.3.0",
-    "@nrwl/eslint-plugin-nx": "17.3.0"
+    "@nrwl/eslint-plugin-nx": "17.3.2"
   },
   "publishConfig": {
     "access": "public"

package/src/configs/angular.js

@@ -1,10 +1,5 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-let angularEslintPlugin;
-try {
-    angularEslintPlugin = require('@angular-eslint/eslint-plugin');
-}
-catch { }
 /**
  * This configuration is intended to be applied to ALL .ts files in Angular
  * projects within an Nx workspace.
@@ -23,16 +18,7 @@ exports.default = {
         node: true,
     },
     plugins: ['@angular-eslint'],
-    extends: [
-        'plugin:@angular-eslint/recommended',
-        /**
-         * TODO: Consider dropping this extends and explicitly carrying over rules we care about
-         * into our typescript preset in v13
-         */
-        ...(angularEslintPlugin?.configs?.['recommended--extra']
-            ? ['plugin:@angular-eslint/recommended--extra']
-            : []),
-    ],
+    extends: ['plugin:@angular-eslint/recommended'],
     parserOptions: {
         // Unset the default value for parserOptions.project that is found in earlier versions of @angular-eslint
         project: [],

package/src/configs/javascript.d.ts

@@ -13,9 +13,6 @@
  * it should yield a performance improvement but could introduce subtle
  * breaking changes - we should also look to replace all the @typescript-eslint
  * related plugins and rules below.
- *
- * TODO: Reevaluate stylistic plugin and added specific rules in the next major
- * version of Nx. Related to https://github.com/nrwl/nx/pull/21066
  */
 declare const _default: {
     env: {
@@ -33,19 +30,6 @@ declare const _default: {
         '@typescript-eslint/explicit-member-accessibility': string;
         '@typescript-eslint/explicit-module-boundary-types': string;
         '@typescript-eslint/explicit-function-return-type': string;
-        /**
-         * These 3 rules:
-         *   `no-extra-semi`
-         *   `@typescript-eslint/no-extra-semi`
-         *   `@typescript-eslint/no-non-null-assertion`
-         * were added to preserve the linting rules that were
-         * previously defined v5 of `@typescript-eslint`. v6 of `@typescript-eslint`
-         * changed how configurations are defined. This should be reevaluated in
-         * the next major version of Nx.
-         */
-        'no-extra-semi': string;
-        '@typescript-eslint/no-extra-semi': string;
-        '@typescript-eslint/no-non-null-assertion': string;
         '@typescript-eslint/no-parameter-properties': string;
         /**
          * Until ESM usage in Node matures, using require in e.g. JS config files
@@ -53,6 +37,26 @@ declare const _default: {
          * having to frequently use "eslint-disable-next-line" in their configs.
          */
         '@typescript-eslint/no-var-requires': string;
+        /**
+         * From https://typescript-eslint.io/blog/announcing-typescript-eslint-v6/#updated-configuration-rules
+         *
+         * The following rules were added to preserve the linting rules that were
+         * previously defined v5 of `@typescript-eslint`. v6 of `@typescript-eslint`
+         * changed how configurations are defined.
+         *
+         * TODO(v19): re-evalute these deviations from @typescript-eslint/recommended in v19 of Nx
+         */
+        'no-extra-semi': string;
+        '@typescript-eslint/no-extra-semi': string;
+        '@typescript-eslint/no-non-null-assertion': string;
+        '@typescript-eslint/adjacent-overload-signatures': string;
+        '@typescript-eslint/prefer-namespace-keyword': string;
+        'no-empty-function': string;
+        '@typescript-eslint/no-empty-function': string;
+        '@typescript-eslint/no-inferrable-types': string;
+        '@typescript-eslint/no-unused-vars': string;
+        '@typescript-eslint/no-empty-interface': string;
+        '@typescript-eslint/no-explicit-any': string;
     };
 };
 export default _default;

package/src/configs/javascript.js

@@ -17,9 +17,6 @@ const isPrettierAvailable = (0, config_utils_1.packageExists)('prettier') && (0,
  * it should yield a performance improvement but could introduce subtle
  * breaking changes - we should also look to replace all the @typescript-eslint
  * related plugins and rules below.
- *
- * TODO: Reevaluate stylistic plugin and added specific rules in the next major
- * version of Nx. Related to https://github.com/nrwl/nx/pull/21066
  */
 exports.default = {
     env: {
@@ -36,32 +33,12 @@ exports.default = {
         'eslint:recommended',
         'plugin:@typescript-eslint/eslint-recommended',
         'plugin:@typescript-eslint/recommended',
-        /**
-         * This was added to preserve the linting rules that were previously
-         * defined v5 of @typescript-eslint. v6 of @typescript-eslint changed
-         * how configurations are defined. This should be reevaluated in the
-         * next major version of Nx.
-         */
-        'plugin:@typescript-eslint/stylistic',
         ...(isPrettierAvailable ? ['prettier'] : []),
     ],
     rules: {
         '@typescript-eslint/explicit-member-accessibility': 'off',
         '@typescript-eslint/explicit-module-boundary-types': 'off',
         '@typescript-eslint/explicit-function-return-type': 'off',
-        /**
-         * These 3 rules:
-         *   `no-extra-semi`
-         *   `@typescript-eslint/no-extra-semi`
-         *   `@typescript-eslint/no-non-null-assertion`
-         * were added to preserve the linting rules that were
-         * previously defined v5 of `@typescript-eslint`. v6 of `@typescript-eslint`
-         * changed how configurations are defined. This should be reevaluated in
-         * the next major version of Nx.
-         */
-        'no-extra-semi': 'off',
-        '@typescript-eslint/no-extra-semi': 'error',
-        '@typescript-eslint/no-non-null-assertion': 'warn',
         '@typescript-eslint/no-parameter-properties': 'off',
         /**
          * Until ESM usage in Node matures, using require in e.g. JS config files
@@ -69,5 +46,25 @@ exports.default = {
          * having to frequently use "eslint-disable-next-line" in their configs.
          */
         '@typescript-eslint/no-var-requires': 'off',
+        /**
+         * From https://typescript-eslint.io/blog/announcing-typescript-eslint-v6/#updated-configuration-rules
+         *
+         * The following rules were added to preserve the linting rules that were
+         * previously defined v5 of `@typescript-eslint`. v6 of `@typescript-eslint`
+         * changed how configurations are defined.
+         *
+         * TODO(v19): re-evalute these deviations from @typescript-eslint/recommended in v19 of Nx
+         */
+        'no-extra-semi': 'off',
+        '@typescript-eslint/no-extra-semi': 'error',
+        '@typescript-eslint/no-non-null-assertion': 'warn',
+        '@typescript-eslint/adjacent-overload-signatures': 'error',
+        '@typescript-eslint/prefer-namespace-keyword': 'error',
+        'no-empty-function': 'off',
+        '@typescript-eslint/no-empty-function': 'error',
+        '@typescript-eslint/no-inferrable-types': 'error',
+        '@typescript-eslint/no-unused-vars': 'warn',
+        '@typescript-eslint/no-empty-interface': 'error',
+        '@typescript-eslint/no-explicit-any': 'warn',
     },
 };

package/src/configs/typescript.d.ts

@@ -4,9 +4,6 @@
  *
  * It should therefore NOT contain any rules or plugins which are specific
  * to one ecosystem, such as React, Angular, Node etc.
- *
- * TODO: Reevaluate stylistic plugin and added specific rules in the next major
- * version of Nx. Related to https://github.com/nrwl/nx/pull/21066
  */
 declare const _default: {
     parser: string;
@@ -21,20 +18,27 @@ declare const _default: {
         '@typescript-eslint/explicit-member-accessibility': string;
         '@typescript-eslint/explicit-module-boundary-types': string;
         '@typescript-eslint/explicit-function-return-type': string;
+        '@typescript-eslint/no-parameter-properties': string;
         /**
-         * These 3 rules:
-         *   `no-extra-semi`
-         *   `@typescript-eslint/no-extra-semi`
-         *   `@typescript-eslint/no-non-null-assertion`
-         * were added to preserve the linting rules that were
+         * From https://typescript-eslint.io/blog/announcing-typescript-eslint-v6/#updated-configuration-rules
+         *
+         * The following rules were added to preserve the linting rules that were
          * previously defined v5 of `@typescript-eslint`. v6 of `@typescript-eslint`
-         * changed how configurations are defined. This should be reevaluated in
-         * the next major version of Nx.
+         * changed how configurations are defined.
+         *
+         * TODO(v19): re-evalute these deviations from @typescript-eslint/recommended in v19 of Nx
          */
         'no-extra-semi': string;
         '@typescript-eslint/no-extra-semi': string;
         '@typescript-eslint/no-non-null-assertion': string;
-        '@typescript-eslint/no-parameter-properties': string;
+        '@typescript-eslint/adjacent-overload-signatures': string;
+        '@typescript-eslint/prefer-namespace-keyword': string;
+        'no-empty-function': string;
+        '@typescript-eslint/no-empty-function': string;
+        '@typescript-eslint/no-inferrable-types': string;
+        '@typescript-eslint/no-unused-vars': string;
+        '@typescript-eslint/no-empty-interface': string;
+        '@typescript-eslint/no-explicit-any': string;
     };
 };
 export default _default;

package/src/configs/typescript.js

@@ -9,9 +9,6 @@ const isPrettierAvailable = (0, config_utils_1.packageExists)('prettier') && (0,
  *
  * It should therefore NOT contain any rules or plugins which are specific
  * to one ecosystem, such as React, Angular, Node etc.
- *
- * TODO: Reevaluate stylistic plugin and added specific rules in the next major
- * version of Nx. Related to https://github.com/nrwl/nx/pull/21066
  */
 exports.default = {
     parser: '@typescript-eslint/parser',
@@ -25,32 +22,32 @@ exports.default = {
         'eslint:recommended',
         'plugin:@typescript-eslint/eslint-recommended',
         'plugin:@typescript-eslint/recommended',
-        /**
-         * This was added to preserve the linting rules that were previously
-         * defined v5 of @typescript-eslint. v6 of @typescript-eslint changed
-         * how configurations are defined. This should be reevaluated in the
-         * next major version of Nx.
-         */
-        'plugin:@typescript-eslint/stylistic',
         ...(isPrettierAvailable ? ['prettier'] : []),
     ],
     rules: {
         '@typescript-eslint/explicit-member-accessibility': 'off',
         '@typescript-eslint/explicit-module-boundary-types': 'off',
         '@typescript-eslint/explicit-function-return-type': 'off',
+        '@typescript-eslint/no-parameter-properties': 'off',
         /**
-         * These 3 rules:
-         *   `no-extra-semi`
-         *   `@typescript-eslint/no-extra-semi`
-         *   `@typescript-eslint/no-non-null-assertion`
-         * were added to preserve the linting rules that were
+         * From https://typescript-eslint.io/blog/announcing-typescript-eslint-v6/#updated-configuration-rules
+         *
+         * The following rules were added to preserve the linting rules that were
          * previously defined v5 of `@typescript-eslint`. v6 of `@typescript-eslint`
-         * changed how configurations are defined. This should be reevaluated in
-         * the next major version of Nx.
+         * changed how configurations are defined.
+         *
+         * TODO(v19): re-evalute these deviations from @typescript-eslint/recommended in v19 of Nx
          */
         'no-extra-semi': 'off',
         '@typescript-eslint/no-extra-semi': 'error',
         '@typescript-eslint/no-non-null-assertion': 'warn',
-        '@typescript-eslint/no-parameter-properties': 'off',
+        '@typescript-eslint/adjacent-overload-signatures': 'error',
+        '@typescript-eslint/prefer-namespace-keyword': 'error',
+        'no-empty-function': 'off',
+        '@typescript-eslint/no-empty-function': 'error',
+        '@typescript-eslint/no-inferrable-types': 'error',
+        '@typescript-eslint/no-unused-vars': 'warn',
+        '@typescript-eslint/no-empty-interface': 'error',
+        '@typescript-eslint/no-explicit-any': 'warn',
     },
 };

package/src/utils/package-json-utils.js

@@ -14,15 +14,18 @@ function getAllDependencies(packageJson) {
 }
 exports.getAllDependencies = getAllDependencies;
 function getProductionDependencies(packageJsonPath) {
-    if (!globalThis.projPackageJsonDeps || !(0, runtime_lint_utils_1.isTerminalRun)()) {
+    if (!globalThis.projPackageJsonDeps ||
+        !globalThis.projPackageJsonDeps[packageJsonPath] ||
+        !(0, runtime_lint_utils_1.isTerminalRun)()) {
         const packageJson = getPackageJson(packageJsonPath);
-        globalThis.projPackageJsonDeps = {
+        globalThis.projPackageJsonDeps = globalThis.projPackageJsonDeps || {};
+        globalThis.projPackageJsonDeps[packageJsonPath] = {
             ...packageJson.dependencies,
             ...packageJson.peerDependencies,
             ...packageJson.optionalDependencies,
         };
     }
-    return globalThis.projPackageJsonDeps;
+    return globalThis.projPackageJsonDeps[packageJsonPath];
 }
 exports.getProductionDependencies = getProductionDependencies;
 function getPackageJson(path) {