@nx/eslint-plugin 17.3.0-beta.5 → 17.3.0-beta.8

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/eslint-plugin",
-  "version": "17.3.0-beta.5",
+  "version": "17.3.0-beta.8",
   "private": false,
   "description": "The eslint-plugin package is an ESLint plugin that contains a collection of recommended ESLint rule configurations which you can extend from in your own ESLint configs, as well as an Nx-specific lint rule called enforce-module-boundaries.",
   "repository": {
@@ -33,8 +33,8 @@
     }
   },
   "dependencies": {
-    "@nx/devkit": "17.3.0-beta.5",
-    "@nx/js": "17.3.0-beta.5",
+    "@nx/devkit": "17.3.0-beta.8",
+    "@nx/js": "17.3.0-beta.8",
     "@typescript-eslint/type-utils": "^6.13.2",
     "@typescript-eslint/utils": "^6.13.2",
     "chalk": "^4.1.0",
@@ -42,7 +42,7 @@
     "jsonc-eslint-parser": "^2.1.0",
     "semver": "7.5.3",
     "tslib": "^2.3.0",
-    "@nrwl/eslint-plugin-nx": "17.3.0-beta.5"
+    "@nrwl/eslint-plugin-nx": "17.3.0-beta.8"
   },
   "publishConfig": {
     "access": "public"

package/src/configs/javascript.d.ts

@@ -13,6 +13,9 @@
  * it should yield a performance improvement but could introduce subtle
  * breaking changes - we should also look to replace all the @typescript-eslint
  * related plugins and rules below.
+ *
+ * TODO: Reevaluate stylistic plugin and added specific rules in the next major
+ * version of Nx. Related to https://github.com/nrwl/nx/pull/21066
  */
 declare const _default: {
     env: {
@@ -30,6 +33,19 @@ declare const _default: {
         '@typescript-eslint/explicit-member-accessibility': string;
         '@typescript-eslint/explicit-module-boundary-types': string;
         '@typescript-eslint/explicit-function-return-type': string;
+        /**
+         * These 3 rules:
+         *   `no-extra-semi`
+         *   `@typescript-eslint/no-extra-semi`
+         *   `@typescript-eslint/no-non-null-assertion`
+         * were added to preserve the linting rules that were
+         * previously defined v5 of `@typescript-eslint`. v6 of `@typescript-eslint`
+         * changed how configurations are defined. This should be reevaluated in
+         * the next major version of Nx.
+         */
+        'no-extra-semi': string;
+        '@typescript-eslint/no-extra-semi': string;
+        '@typescript-eslint/no-non-null-assertion': string;
         '@typescript-eslint/no-parameter-properties': string;
         /**
          * Until ESM usage in Node matures, using require in e.g. JS config files

package/src/configs/javascript.js

@@ -17,6 +17,9 @@ const isPrettierAvailable = (0, config_utils_1.packageExists)('prettier') && (0,
  * it should yield a performance improvement but could introduce subtle
  * breaking changes - we should also look to replace all the @typescript-eslint
  * related plugins and rules below.
+ *
+ * TODO: Reevaluate stylistic plugin and added specific rules in the next major
+ * version of Nx. Related to https://github.com/nrwl/nx/pull/21066
  */
 exports.default = {
     env: {
@@ -33,12 +36,32 @@ exports.default = {
         'eslint:recommended',
         'plugin:@typescript-eslint/eslint-recommended',
         'plugin:@typescript-eslint/recommended',
+        /**
+         * This was added to preserve the linting rules that were previously
+         * defined v5 of @typescript-eslint. v6 of @typescript-eslint changed
+         * how configurations are defined. This should be reevaluated in the
+         * next major version of Nx.
+         */
+        'plugin:@typescript-eslint/stylistic',
         ...(isPrettierAvailable ? ['prettier'] : []),
     ],
     rules: {
         '@typescript-eslint/explicit-member-accessibility': 'off',
         '@typescript-eslint/explicit-module-boundary-types': 'off',
         '@typescript-eslint/explicit-function-return-type': 'off',
+        /**
+         * These 3 rules:
+         *   `no-extra-semi`
+         *   `@typescript-eslint/no-extra-semi`
+         *   `@typescript-eslint/no-non-null-assertion`
+         * were added to preserve the linting rules that were
+         * previously defined v5 of `@typescript-eslint`. v6 of `@typescript-eslint`
+         * changed how configurations are defined. This should be reevaluated in
+         * the next major version of Nx.
+         */
+        'no-extra-semi': 'off',
+        '@typescript-eslint/no-extra-semi': 'error',
+        '@typescript-eslint/no-non-null-assertion': 'warn',
         '@typescript-eslint/no-parameter-properties': 'off',
         /**
          * Until ESM usage in Node matures, using require in e.g. JS config files

package/src/configs/typescript.d.ts

@@ -4,6 +4,9 @@
  *
  * It should therefore NOT contain any rules or plugins which are specific
  * to one ecosystem, such as React, Angular, Node etc.
+ *
+ * TODO: Reevaluate stylistic plugin and added specific rules in the next major
+ * version of Nx. Related to https://github.com/nrwl/nx/pull/21066
  */
 declare const _default: {
     parser: string;
@@ -18,6 +21,19 @@ declare const _default: {
         '@typescript-eslint/explicit-member-accessibility': string;
         '@typescript-eslint/explicit-module-boundary-types': string;
         '@typescript-eslint/explicit-function-return-type': string;
+        /**
+         * These 3 rules:
+         *   `no-extra-semi`
+         *   `@typescript-eslint/no-extra-semi`
+         *   `@typescript-eslint/no-non-null-assertion`
+         * were added to preserve the linting rules that were
+         * previously defined v5 of `@typescript-eslint`. v6 of `@typescript-eslint`
+         * changed how configurations are defined. This should be reevaluated in
+         * the next major version of Nx.
+         */
+        'no-extra-semi': string;
+        '@typescript-eslint/no-extra-semi': string;
+        '@typescript-eslint/no-non-null-assertion': string;
         '@typescript-eslint/no-parameter-properties': string;
     };
 };

package/src/configs/typescript.js

@@ -9,6 +9,9 @@ const isPrettierAvailable = (0, config_utils_1.packageExists)('prettier') && (0,
  *
  * It should therefore NOT contain any rules or plugins which are specific
  * to one ecosystem, such as React, Angular, Node etc.
+ *
+ * TODO: Reevaluate stylistic plugin and added specific rules in the next major
+ * version of Nx. Related to https://github.com/nrwl/nx/pull/21066
  */
 exports.default = {
     parser: '@typescript-eslint/parser',
@@ -22,12 +25,32 @@ exports.default = {
         'eslint:recommended',
         'plugin:@typescript-eslint/eslint-recommended',
         'plugin:@typescript-eslint/recommended',
+        /**
+         * This was added to preserve the linting rules that were previously
+         * defined v5 of @typescript-eslint. v6 of @typescript-eslint changed
+         * how configurations are defined. This should be reevaluated in the
+         * next major version of Nx.
+         */
+        'plugin:@typescript-eslint/stylistic',
         ...(isPrettierAvailable ? ['prettier'] : []),
     ],
     rules: {
         '@typescript-eslint/explicit-member-accessibility': 'off',
         '@typescript-eslint/explicit-module-boundary-types': 'off',
         '@typescript-eslint/explicit-function-return-type': 'off',
+        /**
+         * These 3 rules:
+         *   `no-extra-semi`
+         *   `@typescript-eslint/no-extra-semi`
+         *   `@typescript-eslint/no-non-null-assertion`
+         * were added to preserve the linting rules that were
+         * previously defined v5 of `@typescript-eslint`. v6 of `@typescript-eslint`
+         * changed how configurations are defined. This should be reevaluated in
+         * the next major version of Nx.
+         */
+        'no-extra-semi': 'off',
+        '@typescript-eslint/no-extra-semi': 'error',
+        '@typescript-eslint/no-non-null-assertion': 'warn',
         '@typescript-eslint/no-parameter-properties': 'off',
     },
 };

package/src/rules/dependency-checks.js

@@ -10,7 +10,7 @@ const runtime_lint_utils_1 = require("../utils/runtime-lint-utils");
 const package_json_utils_1 = require("../utils/package-json-utils");
 const utils_1 = require("@typescript-eslint/utils");
 exports.RULE_NAME = 'dependency-checks';
-exports.default = utils_1.ESLintUtils.RuleCreator(() => ``)({
+exports.default = utils_1.ESLintUtils.RuleCreator(() => `https://github.com/nrwl/nx/blob/${devkit_1.NX_VERSION}/docs/generated/packages/eslint-plugin/documents/dependency-checks.md`)({
     name: exports.RULE_NAME,
     meta: {
         type: 'suggestion',

package/src/rules/enforce-module-boundaries.js

@@ -11,7 +11,7 @@ const ast_utils_1 = require("../utils/ast-utils");
 const project_graph_utils_1 = require("../utils/project-graph-utils");
 const utils_2 = require("@typescript-eslint/utils");
 exports.RULE_NAME = 'enforce-module-boundaries';
-exports.default = utils_2.ESLintUtils.RuleCreator(() => ``)({
+exports.default = utils_2.ESLintUtils.RuleCreator(() => `https://github.com/nrwl/nx/blob/${devkit_1.NX_VERSION}/docs/generated/packages/eslint-plugin/documents/enforce-module-boundaries.md`)({
     name: exports.RULE_NAME,
     meta: {
         type: 'suggestion',

package/src/utils/project-graph-utils.js

@@ -1,10 +1,9 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.readProjectGraph = exports.ensureGlobalProjectGraph = void 0;
-const tslib_1 = require("tslib");
 const devkit_1 = require("@nx/devkit");
 const runtime_lint_utils_1 = require("./runtime-lint-utils");
-const chalk = tslib_1.__importStar(require("chalk"));
+const chalk = require("chalk");
 const find_project_for_path_1 = require("nx/src/project-graph/utils/find-project-for-path");
 const configuration_1 = require("nx/src/config/configuration");
 const internal_1 = require("@nx/js/src/internal");