@nx/eslint-plugin 17.2.0-beta.12 → 17.2.0-beta.14

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/eslint-plugin",
-  "version": "17.2.0-beta.12",
+  "version": "17.2.0-beta.14",
   "private": false,
   "description": "The eslint-plugin package is an ESLint plugin that contains a collection of recommended ESLint rule configurations which you can extend from in your own ESLint configs, as well as an Nx-specific lint rule called enforce-module-boundaries.",
   "repository": {
@@ -33,8 +33,8 @@
     }
   },
   "dependencies": {
-    "@nx/devkit": "17.2.0-beta.12",
-    "@nx/js": "17.2.0-beta.12",
+    "@nx/devkit": "17.2.0-beta.14",
+    "@nx/js": "17.2.0-beta.14",
     "@typescript-eslint/type-utils": "^6.9.1",
     "@typescript-eslint/utils": "^6.9.1",
     "chalk": "^4.1.0",
@@ -42,7 +42,7 @@
     "jsonc-eslint-parser": "^2.1.0",
     "semver": "7.5.3",
     "tslib": "^2.3.0",
-    "@nrwl/eslint-plugin-nx": "17.2.0-beta.12"
+    "@nrwl/eslint-plugin-nx": "17.2.0-beta.14"
   },
   "publishConfig": {
     "access": "public"

package/src/rules/enforce-module-boundaries.d.ts

@@ -12,7 +12,7 @@ type Options = [
         checkNestedExternalImports: boolean;
     }
 ];
-export type MessageIds = 'noRelativeOrAbsoluteImportsAcrossLibraries' | 'noSelfCircularDependencies' | 'noCircularDependencies' | 'noImportsOfApps' | 'noImportsOfE2e' | 'noImportOfNonBuildableLibraries' | 'noImportsOfLazyLoadedLibraries' | 'projectWithoutTagsCannotHaveDependencies' | 'bannedExternalImportsViolation' | 'nestedBannedExternalImportsViolation' | 'noTransitiveDependencies' | 'onlyTagsConstraintViolation' | 'emptyOnlyTagsConstraintViolation' | 'notTagsConstraintViolation';
+export type MessageIds = 'noRelativeOrAbsoluteImportsAcrossLibraries' | 'noRelativeOrAbsoluteExternals' | 'noSelfCircularDependencies' | 'noCircularDependencies' | 'noImportsOfApps' | 'noImportsOfE2e' | 'noImportOfNonBuildableLibraries' | 'noImportsOfLazyLoadedLibraries' | 'projectWithoutTagsCannotHaveDependencies' | 'bannedExternalImportsViolation' | 'nestedBannedExternalImportsViolation' | 'noTransitiveDependencies' | 'onlyTagsConstraintViolation' | 'emptyOnlyTagsConstraintViolation' | 'notTagsConstraintViolation';
 export declare const RULE_NAME = "enforce-module-boundaries";
 declare const _default: ESLintUtils.RuleModule<MessageIds, Options, ESLintUtils.RuleListener>;
 export default _default;

package/src/rules/enforce-module-boundaries.js

@@ -97,6 +97,7 @@ exports.default = utils_2.ESLintUtils.RuleCreator(() => ``)({
         ],
         messages: {
             noRelativeOrAbsoluteImportsAcrossLibraries: `Projects cannot be imported by a relative or absolute path, and must begin with a npm scope`,
+            noRelativeOrAbsoluteExternals: `External resources cannot be imported using a relative or absolute path`,
             noCircularDependencies: `Circular dependency between "{{sourceProjectName}}" and "{{targetProjectName}}" detected: {{path}}\n\nCircular file chain:\n{{filePaths}}`,
             noSelfCircularDependencies: `Projects should use relative imports to import from other files within the same project. Use "./path/to/file" instead of import from "{{imp}}"`,
             noImportsOfApps: 'Imports of apps are forbidden',
@@ -208,8 +209,15 @@ exports.default = utils_2.ESLintUtils.RuleCreator(() => ``)({
             targetProject =
                 targetProject ||
                     (0, runtime_lint_utils_1.findProjectUsingImport)(projectGraph, targetProjectLocator, sourceFilePath, imp);
-            // If target is not part of an nx workspace, return.
             if (!targetProject) {
+                // non-project imports cannot use relative or absolute paths
+                if ((0, fileutils_1.isRelativePath)(imp) || imp.startsWith('/')) {
+                    context.report({
+                        node,
+                        messageId: 'noRelativeOrAbsoluteExternals',
+                    });
+                }
+                // If target is not found (including node internals) we bail early
                 return;
             }
             // we only allow relative paths within the same project