@nx/eslint-plugin 17.0.4 → 17.0.6

package/LICENSE

@@ -1,6 +1,6 @@
 (The MIT License)
 
-Copyright (c) 2017-2024 Narwhal Technologies Inc.
+Copyright (c) 2017-2023 Narwhal Technologies Inc.
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

package/README.md

@@ -1,9 +1,4 @@
-<p style="text-align: center;">
-  <picture>
-    <source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/nrwl/nx/master/images/nx-dark.svg">
-    <img alt="Nx - Smart Monorepos · Fast CI" src="https://raw.githubusercontent.com/nrwl/nx/master/images/nx-light.svg" width="100%">
-  </picture>
-</p>
+<p style="text-align: center;"><img src="https://raw.githubusercontent.com/nrwl/nx/master/images/nx.png" width="600" alt="Nx - Smart, Fast and Extensible Build System"></p>
 
 <div style="text-align: center;">
 
@@ -20,9 +15,9 @@
 
 <hr>
 
-# Nx: Smart Monorepos · Fast CI
+# Nx: Smart, Fast and Extensible Build System
 
-Nx is a build system with built-in tooling and advanced CI capabilities. It helps you maintain and scale monorepos, both locally and on CI.
+Nx is a next generation build system with first class monorepo support and powerful integrations.
 
 This package is an ESLint plugin for Nx.
 
@@ -64,5 +59,5 @@ npx nx@latest init
 - [Blog Posts About Nx](https://blog.nrwl.io/nx/home)
 
 <p style="text-align: center;"><a href="https://nx.dev/#learning-materials" target="_blank" rel="noreferrer"><img src="https://raw.githubusercontent.com/nrwl/nx/master/images/nx-courses-and-videos.svg" 
-width="100%" alt="Nx - Smart Monorepos · Fast CI"></a></p>
+width="100%" alt="Nx - Smart, Fast and Extensible Build System"></a></p>
 

package/migrations.json

@@ -5,12 +5,6 @@
       "version": "16.0.0-beta.1",
       "description": "Replace @nrwl/eslint-plugin-nx with @nx/eslint-plugin",
       "implementation": "./src/migrations/update-16-0-0-add-nx-packages/update-16-0-0-add-nx-packages"
-    },
-    "update-17-2-6-rename-workspace-rules": {
-      "cli": "nx",
-      "version": "17.2.6-beta.1",
-      "description": "Rename workspace rules from @nx/workspace/name to @nx/workspace-name",
-      "implementation": "./src/migrations/update-17-2-6-rename-workspace-rules/rename-workspace-rules"
     }
   },
   "packageJsonUpdates": {},

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/eslint-plugin",
-  "version": "17.0.4",
+  "version": "v17.0.6",
   "private": false,
   "description": "The eslint-plugin package is an ESLint plugin that contains a collection of recommended ESLint rule configurations which you can extend from in your own ESLint configs, as well as an Nx-specific lint rule called enforce-module-boundaries.",
   "repository": {
@@ -24,7 +24,7 @@
   },
   "homepage": "https://nx.dev",
   "peerDependencies": {
-    "@typescript-eslint/parser": "^6.13.2 || ^7.0.0",
+    "@typescript-eslint/parser": "^5.60.1",
     "eslint-config-prettier": "^9.0.0"
   },
   "peerDependenciesMeta": {
@@ -33,16 +33,16 @@
     }
   },
   "dependencies": {
-    "@nx/devkit": "17.0.4",
-    "@nx/js": "17.0.4",
-    "@typescript-eslint/type-utils": "^7.3.0",
-    "@typescript-eslint/utils": "^7.3.0",
+    "@nx/devkit": "v17.0.6",
+    "@nx/js": "v17.0.6",
+    "@typescript-eslint/type-utils": "^5.60.1",
+    "@typescript-eslint/utils": "^5.60.1",
     "chalk": "^4.1.0",
     "confusing-browser-globals": "^1.0.9",
     "jsonc-eslint-parser": "^2.1.0",
-    "semver": "^7.5.3",
+    "semver": "7.5.3",
     "tslib": "^2.3.0",
-    "@nrwl/eslint-plugin-nx": "17.0.4"
+    "@nrwl/eslint-plugin-nx": "v17.0.6"
   },
   "publishConfig": {
     "access": "public"

package/src/configs/angular.js

@@ -1,5 +1,10 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+let angularEslintPlugin;
+try {
+    angularEslintPlugin = require('@angular-eslint/eslint-plugin');
+}
+catch { }
 /**
  * This configuration is intended to be applied to ALL .ts files in Angular
  * projects within an Nx workspace.
@@ -18,7 +23,16 @@ exports.default = {
         node: true,
     },
     plugins: ['@angular-eslint'],
-    extends: ['plugin:@angular-eslint/recommended'],
+    extends: [
+        'plugin:@angular-eslint/recommended',
+        /**
+         * TODO: Consider dropping this extends and explicitly carrying over rules we care about
+         * into our typescript preset in v13
+         */
+        ...(angularEslintPlugin?.configs?.['recommended--extra']
+            ? ['plugin:@angular-eslint/recommended--extra']
+            : []),
+    ],
     parserOptions: {
         // Unset the default value for parserOptions.project that is found in earlier versions of @angular-eslint
         project: [],

package/src/configs/javascript.d.ts

@@ -37,26 +37,6 @@ declare const _default: {
          * having to frequently use "eslint-disable-next-line" in their configs.
          */
         '@typescript-eslint/no-var-requires': string;
-        /**
-         * From https://typescript-eslint.io/blog/announcing-typescript-eslint-v6/#updated-configuration-rules
-         *
-         * The following rules were added to preserve the linting rules that were
-         * previously defined v5 of `@typescript-eslint`. v6 of `@typescript-eslint`
-         * changed how configurations are defined.
-         *
-         * TODO(v19): re-evalute these deviations from @typescript-eslint/recommended in v19 of Nx
-         */
-        'no-extra-semi': string;
-        '@typescript-eslint/no-extra-semi': string;
-        '@typescript-eslint/no-non-null-assertion': string;
-        '@typescript-eslint/adjacent-overload-signatures': string;
-        '@typescript-eslint/prefer-namespace-keyword': string;
-        'no-empty-function': string;
-        '@typescript-eslint/no-empty-function': string;
-        '@typescript-eslint/no-inferrable-types': string;
-        '@typescript-eslint/no-unused-vars': string;
-        '@typescript-eslint/no-empty-interface': string;
-        '@typescript-eslint/no-explicit-any': string;
     };
 };
 export default _default;

package/src/configs/javascript.js

@@ -46,25 +46,5 @@ exports.default = {
          * having to frequently use "eslint-disable-next-line" in their configs.
          */
         '@typescript-eslint/no-var-requires': 'off',
-        /**
-         * From https://typescript-eslint.io/blog/announcing-typescript-eslint-v6/#updated-configuration-rules
-         *
-         * The following rules were added to preserve the linting rules that were
-         * previously defined v5 of `@typescript-eslint`. v6 of `@typescript-eslint`
-         * changed how configurations are defined.
-         *
-         * TODO(v19): re-evalute these deviations from @typescript-eslint/recommended in v19 of Nx
-         */
-        'no-extra-semi': 'off',
-        '@typescript-eslint/no-extra-semi': 'error',
-        '@typescript-eslint/no-non-null-assertion': 'warn',
-        '@typescript-eslint/adjacent-overload-signatures': 'error',
-        '@typescript-eslint/prefer-namespace-keyword': 'error',
-        'no-empty-function': 'off',
-        '@typescript-eslint/no-empty-function': 'error',
-        '@typescript-eslint/no-inferrable-types': 'error',
-        '@typescript-eslint/no-unused-vars': 'warn',
-        '@typescript-eslint/no-empty-interface': 'error',
-        '@typescript-eslint/no-explicit-any': 'warn',
     },
 };

package/src/configs/react-base.js

@@ -1,6 +1,5 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-const tslib_1 = require("tslib");
 /**
  * This configuration is intended to be applied to ALL files within a React
  * project in an Nx workspace.
@@ -11,7 +10,7 @@ const tslib_1 = require("tslib");
  * This configuration is intended to be combined with other configs from this
  * package.
  */
-const confusing_browser_globals_1 = tslib_1.__importDefault(require("confusing-browser-globals"));
+const restrictedGlobals = require("confusing-browser-globals");
 /**
  * Rule set originally adapted from:
  * https://github.com/facebook/create-react-app/blob/567f36c9235f1e1fd4a76dc6d1ae00be754ca047/packages/eslint-config-react-app/index.js
@@ -92,7 +91,7 @@ exports.default = {
         'no-template-curly-in-string': 'warn',
         'no-this-before-super': 'warn',
         'no-throw-literal': 'warn',
-        'no-restricted-globals': ['error'].concat(confusing_browser_globals_1.default),
+        'no-restricted-globals': ['error'].concat(restrictedGlobals),
         'no-unexpected-multiline': 'warn',
         'no-unreachable': 'warn',
         'no-unused-expressions': 'off',

package/src/configs/typescript.d.ts

@@ -19,26 +19,6 @@ declare const _default: {
         '@typescript-eslint/explicit-module-boundary-types': string;
         '@typescript-eslint/explicit-function-return-type': string;
         '@typescript-eslint/no-parameter-properties': string;
-        /**
-         * From https://typescript-eslint.io/blog/announcing-typescript-eslint-v6/#updated-configuration-rules
-         *
-         * The following rules were added to preserve the linting rules that were
-         * previously defined v5 of `@typescript-eslint`. v6 of `@typescript-eslint`
-         * changed how configurations are defined.
-         *
-         * TODO(v19): re-evalute these deviations from @typescript-eslint/recommended in v19 of Nx
-         */
-        'no-extra-semi': string;
-        '@typescript-eslint/no-extra-semi': string;
-        '@typescript-eslint/no-non-null-assertion': string;
-        '@typescript-eslint/adjacent-overload-signatures': string;
-        '@typescript-eslint/prefer-namespace-keyword': string;
-        'no-empty-function': string;
-        '@typescript-eslint/no-empty-function': string;
-        '@typescript-eslint/no-inferrable-types': string;
-        '@typescript-eslint/no-unused-vars': string;
-        '@typescript-eslint/no-empty-interface': string;
-        '@typescript-eslint/no-explicit-any': string;
     };
 };
 export default _default;

package/src/configs/typescript.js

@@ -29,25 +29,5 @@ exports.default = {
         '@typescript-eslint/explicit-module-boundary-types': 'off',
         '@typescript-eslint/explicit-function-return-type': 'off',
         '@typescript-eslint/no-parameter-properties': 'off',
-        /**
-         * From https://typescript-eslint.io/blog/announcing-typescript-eslint-v6/#updated-configuration-rules
-         *
-         * The following rules were added to preserve the linting rules that were
-         * previously defined v5 of `@typescript-eslint`. v6 of `@typescript-eslint`
-         * changed how configurations are defined.
-         *
-         * TODO(v19): re-evalute these deviations from @typescript-eslint/recommended in v19 of Nx
-         */
-        'no-extra-semi': 'off',
-        '@typescript-eslint/no-extra-semi': 'error',
-        '@typescript-eslint/no-non-null-assertion': 'warn',
-        '@typescript-eslint/adjacent-overload-signatures': 'error',
-        '@typescript-eslint/prefer-namespace-keyword': 'error',
-        'no-empty-function': 'off',
-        '@typescript-eslint/no-empty-function': 'error',
-        '@typescript-eslint/no-inferrable-types': 'error',
-        '@typescript-eslint/no-unused-vars': 'warn',
-        '@typescript-eslint/no-empty-interface': 'error',
-        '@typescript-eslint/no-explicit-any': 'warn',
     },
 };

package/src/constants.d.ts

@@ -1,4 +1,3 @@
-export declare const WORKSPACE_RULES_PATH = "tools/eslint-rules";
 export declare const WORKSPACE_PLUGIN_DIR: string;
 /**
  * We add a namespace so that we mitigate the risk of rule name collisions as much as
@@ -8,6 +7,6 @@ export declare const WORKSPACE_PLUGIN_DIR: string;
  * E.g. if a user writes a rule called "foo", then they will include it in their ESLint
  * config files as:
  *
- * "@nx/workspace-foo": "error"
+ * "@nx/workspace/foo": "error"
  */
-export declare const WORKSPACE_RULE_PREFIX = "workspace";
+export declare const WORKSPACE_RULE_NAMESPACE = "workspace";

package/src/constants.js

@@ -1,10 +1,9 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.WORKSPACE_RULE_PREFIX = exports.WORKSPACE_PLUGIN_DIR = exports.WORKSPACE_RULES_PATH = void 0;
+exports.WORKSPACE_RULE_NAMESPACE = exports.WORKSPACE_PLUGIN_DIR = void 0;
 const devkit_1 = require("@nx/devkit");
 const path_1 = require("path");
-exports.WORKSPACE_RULES_PATH = 'tools/eslint-rules';
-exports.WORKSPACE_PLUGIN_DIR = (0, path_1.join)(devkit_1.workspaceRoot, exports.WORKSPACE_RULES_PATH);
+exports.WORKSPACE_PLUGIN_DIR = (0, path_1.join)(devkit_1.workspaceRoot, 'tools/eslint-rules');
 /**
  * We add a namespace so that we mitigate the risk of rule name collisions as much as
  * possible between what users might create in their workspaces and what we might want
@@ -13,6 +12,6 @@ exports.WORKSPACE_PLUGIN_DIR = (0, path_1.join)(devkit_1.workspaceRoot, exports.
  * E.g. if a user writes a rule called "foo", then they will include it in their ESLint
  * config files as:
  *
- * "@nx/workspace-foo": "error"
+ * "@nx/workspace/foo": "error"
  */
-exports.WORKSPACE_RULE_PREFIX = 'workspace';
+exports.WORKSPACE_RULE_NAMESPACE = 'workspace';

package/src/index.js

@@ -1,17 +1,16 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-const tslib_1 = require("tslib");
-const typescript_1 = tslib_1.__importDefault(require("./configs/typescript"));
-const javascript_1 = tslib_1.__importDefault(require("./configs/javascript"));
-const react_tmp_1 = tslib_1.__importDefault(require("./configs/react-tmp"));
-const react_base_1 = tslib_1.__importDefault(require("./configs/react-base"));
-const react_jsx_1 = tslib_1.__importDefault(require("./configs/react-jsx"));
-const react_typescript_1 = tslib_1.__importDefault(require("./configs/react-typescript"));
-const angular_1 = tslib_1.__importDefault(require("./configs/angular"));
-const angular_template_1 = tslib_1.__importDefault(require("./configs/angular-template"));
-const enforce_module_boundaries_1 = tslib_1.__importStar(require("./rules/enforce-module-boundaries"));
-const nx_plugin_checks_1 = tslib_1.__importStar(require("./rules/nx-plugin-checks"));
-const dependency_checks_1 = tslib_1.__importStar(require("./rules/dependency-checks"));
+const typescript_1 = require("./configs/typescript");
+const javascript_1 = require("./configs/javascript");
+const react_tmp_1 = require("./configs/react-tmp");
+const react_base_1 = require("./configs/react-base");
+const react_jsx_1 = require("./configs/react-jsx");
+const react_typescript_1 = require("./configs/react-typescript");
+const angular_1 = require("./configs/angular");
+const angular_template_1 = require("./configs/angular-template");
+const enforce_module_boundaries_1 = require("./rules/enforce-module-boundaries");
+const nx_plugin_checks_1 = require("./rules/nx-plugin-checks");
+const dependency_checks_1 = require("./rules/dependency-checks");
 // Resolve any custom rules that might exist in the current workspace
 const resolve_workspace_rules_1 = require("./resolve-workspace-rules");
 module.exports = {

package/src/resolve-workspace-rules.js

@@ -21,9 +21,7 @@ exports.workspaceRules = (() => {
         // Apply the namespace to the resolved rules
         const namespacedRules = {};
         for (const [ruleName, ruleConfig] of Object.entries(rules)) {
-            namespacedRules[`${constants_1.WORKSPACE_RULE_PREFIX}-${ruleName}`] = ruleConfig;
-            // keep the old namespaced rules for backwards compatibility
-            namespacedRules[`${constants_1.WORKSPACE_RULE_PREFIX}/${ruleName}`] = ruleConfig;
+            namespacedRules[`${constants_1.WORKSPACE_RULE_NAMESPACE}/${ruleName}`] = ruleConfig;
         }
         return namespacedRules;
     }

package/src/rules/dependency-checks.d.ts

@@ -1,4 +1,3 @@
-import { ESLintUtils } from '@typescript-eslint/utils';
 export type Options = [
     {
         buildTargets?: string[];
@@ -8,10 +7,9 @@ export type Options = [
         ignoredDependencies?: string[];
         ignoredFiles?: string[];
         includeTransitiveDependencies?: boolean;
-        useLocalPathsForWorkspaceDependencies?: boolean;
     }
 ];
 export type MessageIds = 'missingDependency' | 'obsoleteDependency' | 'versionMismatch' | 'missingDependencySection';
 export declare const RULE_NAME = "dependency-checks";
-declare const _default: ESLintUtils.RuleModule<MessageIds, Options, ESLintUtils.RuleListener>;
+declare const _default: import("@typescript-eslint/utils/dist/ts-eslint/Rule").RuleModule<MessageIds, Options, import("@typescript-eslint/utils/dist/ts-eslint/Rule").RuleListener>;
 export default _default;

package/src/rules/dependency-checks.js

@@ -5,18 +5,18 @@ const path_1 = require("path");
 const semver_1 = require("semver");
 const devkit_1 = require("@nx/devkit");
 const find_npm_dependencies_1 = require("@nx/js/src/utils/find-npm-dependencies");
+const create_eslint_rule_1 = require("../utils/create-eslint-rule");
 const project_graph_utils_1 = require("../utils/project-graph-utils");
 const runtime_lint_utils_1 = require("../utils/runtime-lint-utils");
 const package_json_utils_1 = require("../utils/package-json-utils");
-const utils_1 = require("@typescript-eslint/utils");
 exports.RULE_NAME = 'dependency-checks';
-exports.default = utils_1.ESLintUtils.RuleCreator(() => `https://github.com/nrwl/nx/blob/${devkit_1.NX_VERSION}/docs/generated/packages/eslint-plugin/documents/dependency-checks.md`)({
+exports.default = (0, create_eslint_rule_1.createESLintRule)({
     name: exports.RULE_NAME,
     meta: {
         type: 'suggestion',
         docs: {
             description: `Checks dependencies in project's package.json for version mismatches`,
-            recommended: 'recommended',
+            recommended: 'error',
         },
         fixable: 'code',
         schema: [
@@ -30,7 +30,6 @@ exports.default = utils_1.ESLintUtils.RuleCreator(() => `https://github.com/nrwl
                     checkObsoleteDependencies: { type: 'boolean' },
                     checkVersionMismatches: { type: 'boolean' },
                     includeTransitiveDependencies: { type: 'boolean' },
-                    useLocalPathsForWorkspaceDependencies: { type: 'boolean' },
                 },
                 additionalProperties: false,
             },
@@ -51,10 +50,9 @@ exports.default = utils_1.ESLintUtils.RuleCreator(() => `https://github.com/nrwl
             ignoredDependencies: [],
             ignoredFiles: [],
             includeTransitiveDependencies: false,
-            useLocalPathsForWorkspaceDependencies: false,
         },
     ],
-    create(context, [{ buildTargets, ignoredDependencies, ignoredFiles, checkMissingDependencies, checkObsoleteDependencies, checkVersionMismatches, includeTransitiveDependencies, useLocalPathsForWorkspaceDependencies, },]) {
+    create(context, [{ buildTargets, ignoredDependencies, ignoredFiles, checkMissingDependencies, checkObsoleteDependencies, checkVersionMismatches, includeTransitiveDependencies, },]) {
         if (!context.parserServices.isJSON) {
             return {};
         }
@@ -83,7 +81,6 @@ exports.default = utils_1.ESLintUtils.RuleCreator(() => `https://github.com/nrwl
         {
             includeTransitiveDependencies,
             ignoredFiles,
-            useLocalPathsForWorkspaceDependencies,
         });
         const expectedDependencyNames = Object.keys(npmDependencies);
         const projPackageJsonPath = (0, path_1.join)(devkit_1.workspaceRoot, sourceProject.data.root, 'package.json');
@@ -126,9 +123,7 @@ exports.default = utils_1.ESLintUtils.RuleCreator(() => `https://github.com/nrwl
             if (!checkVersionMismatches) {
                 return;
             }
-            if (npmDependencies[packageName].startsWith('file:') ||
-                packageRange.startsWith('file:') ||
-                npmDependencies[packageName] === '*' ||
+            if (npmDependencies[packageName] === '*' ||
                 packageRange === '*' ||
                 (0, semver_1.satisfies)(npmDependencies[packageName], packageRange, {
                     includePrerelease: true,
@@ -199,7 +194,7 @@ exports.default = utils_1.ESLintUtils.RuleCreator(() => `https://github.com/nrwl
                     },
                     fix: (fixer) => {
                         expectedDependencyNames.sort().reduce((acc, d) => {
-                            acc[d] = rootPackageJsonDeps[d] || npmDependencies[d];
+                            acc[d] = rootPackageJsonDeps[d] || dependencies[d];
                             return acc;
                         }, projPackageJsonDeps);
                         const dependencies = Object.keys(projPackageJsonDeps)

package/src/rules/enforce-module-boundaries.d.ts

@@ -1,5 +1,4 @@
 import { DepConstraint } from '../utils/runtime-lint-utils';
-import { ESLintUtils } from '@typescript-eslint/utils';
 type Options = [
     {
         allow: string[];
@@ -12,7 +11,7 @@ type Options = [
         checkNestedExternalImports: boolean;
     }
 ];
-export type MessageIds = 'noRelativeOrAbsoluteImportsAcrossLibraries' | 'noRelativeOrAbsoluteExternals' | 'noSelfCircularDependencies' | 'noCircularDependencies' | 'noImportsOfApps' | 'noImportsOfE2e' | 'noImportOfNonBuildableLibraries' | 'noImportsOfLazyLoadedLibraries' | 'projectWithoutTagsCannotHaveDependencies' | 'bannedExternalImportsViolation' | 'nestedBannedExternalImportsViolation' | 'noTransitiveDependencies' | 'onlyTagsConstraintViolation' | 'emptyOnlyTagsConstraintViolation' | 'notTagsConstraintViolation';
+export type MessageIds = 'noRelativeOrAbsoluteImportsAcrossLibraries' | 'noSelfCircularDependencies' | 'noCircularDependencies' | 'noImportsOfApps' | 'noImportsOfE2e' | 'noImportOfNonBuildableLibraries' | 'noImportsOfLazyLoadedLibraries' | 'projectWithoutTagsCannotHaveDependencies' | 'bannedExternalImportsViolation' | 'nestedBannedExternalImportsViolation' | 'noTransitiveDependencies' | 'onlyTagsConstraintViolation' | 'emptyOnlyTagsConstraintViolation' | 'notTagsConstraintViolation';
 export declare const RULE_NAME = "enforce-module-boundaries";
-declare const _default: ESLintUtils.RuleModule<MessageIds, Options, ESLintUtils.RuleListener>;
+declare const _default: import("@typescript-eslint/utils/dist/ts-eslint/Rule").RuleModule<MessageIds, Options, import("@typescript-eslint/utils/dist/ts-eslint/Rule").RuleListener>;
 export default _default;

package/src/rules/enforce-module-boundaries.js

@@ -8,16 +8,16 @@ const runtime_lint_utils_1 = require("../utils/runtime-lint-utils");
 const utils_1 = require("@typescript-eslint/utils");
 const path_1 = require("path");
 const ast_utils_1 = require("../utils/ast-utils");
+const create_eslint_rule_1 = require("../utils/create-eslint-rule");
 const project_graph_utils_1 = require("../utils/project-graph-utils");
-const utils_2 = require("@typescript-eslint/utils");
 exports.RULE_NAME = 'enforce-module-boundaries';
-exports.default = utils_2.ESLintUtils.RuleCreator(() => `https://github.com/nrwl/nx/blob/${devkit_1.NX_VERSION}/docs/generated/packages/eslint-plugin/documents/enforce-module-boundaries.md`)({
+exports.default = (0, create_eslint_rule_1.createESLintRule)({
     name: exports.RULE_NAME,
     meta: {
         type: 'suggestion',
         docs: {
             description: `Ensure that module boundaries are respected within the monorepo`,
-            recommended: 'recommended',
+            recommended: 'error',
         },
         fixable: 'code',
         schema: [
@@ -97,7 +97,6 @@ exports.default = utils_2.ESLintUtils.RuleCreator(() => `https://github.com/nrwl
         ],
         messages: {
             noRelativeOrAbsoluteImportsAcrossLibraries: `Projects cannot be imported by a relative or absolute path, and must begin with a npm scope`,
-            noRelativeOrAbsoluteExternals: `External resources cannot be imported using a relative or absolute path`,
             noCircularDependencies: `Circular dependency between "{{sourceProjectName}}" and "{{targetProjectName}}" detected: {{path}}\n\nCircular file chain:\n{{filePaths}}`,
             noSelfCircularDependencies: `Projects should use relative imports to import from other files within the same project. Use "./path/to/file" instead of import from "{{imp}}"`,
             noImportsOfApps: 'Imports of apps are forbidden',
@@ -209,15 +208,8 @@ exports.default = utils_2.ESLintUtils.RuleCreator(() => `https://github.com/nrwl
             targetProject =
                 targetProject ||
                     (0, runtime_lint_utils_1.findProjectUsingImport)(projectGraph, targetProjectLocator, sourceFilePath, imp);
+            // If target is not part of an nx workspace, return.
             if (!targetProject) {
-                // non-project imports cannot use relative or absolute paths
-                if ((0, fileutils_1.isRelativePath)(imp) || imp.startsWith('/')) {
-                    context.report({
-                        node,
-                        messageId: 'noRelativeOrAbsoluteExternals',
-                    });
-                }
-                // If target is not found (including node internals) we bail early
                 return;
             }
             // we only allow relative paths within the same project
@@ -225,7 +217,7 @@ exports.default = utils_2.ESLintUtils.RuleCreator(() => `https://github.com/nrwl
             if (sourceProject === targetProject) {
                 if (!allowCircularSelfDependency &&
                     !(0, fileutils_1.isRelativePath)(imp) &&
-                    !(0, runtime_lint_utils_1.belongsToDifferentNgEntryPoint)(imp, sourceFilePath, sourceProject.data.root)) {
+                    !(0, runtime_lint_utils_1.isAngularSecondaryEntrypoint)(imp, sourceFilePath, sourceProject.data.root)) {
                     context.report({
                         node,
                         messageId: 'noSelfCircularDependencies',
@@ -359,8 +351,10 @@ exports.default = utils_2.ESLintUtils.RuleCreator(() => `https://github.com/nrwl
                 }
             }
             // if we import a library using loadChildren, we should not import it using es6imports
-            if (!checkDynamicDependenciesExceptions.some((a) => (0, runtime_lint_utils_1.matchImportWithWildcard)(a, imp)) &&
-                (0, runtime_lint_utils_1.hasStaticImportOfDynamicResource)(node, projectGraph, sourceProject.name, targetProject.name)) {
+            if (node.type === utils_1.AST_NODE_TYPES.ImportDeclaration &&
+                node.importKind !== 'type' &&
+                !checkDynamicDependenciesExceptions.some((a) => (0, runtime_lint_utils_1.matchImportWithWildcard)(a, imp)) &&
+                (0, runtime_lint_utils_1.onlyLoadChildren)(projectGraph, sourceProject.name, targetProject.name, [])) {
                 const filesWithLazyImports = (0, graph_utils_1.findFilesWithDynamicImports)(projectFileMap, sourceProject.name, targetProject.name);
                 context.report({
                     data: {

package/src/rules/nx-plugin-checks.js

@@ -1,16 +1,15 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.validateVersionJsonExpression = exports.validatePackageGroup = exports.validateImplemenationNode = exports.validateEntry = exports.checkCollectionNode = exports.checkCollectionFileNode = exports.RULE_NAME = void 0;
-const tslib_1 = require("tslib");
-const utils_1 = require("@typescript-eslint/utils");
 const devkit_1 = require("@nx/devkit");
 const runtime_lint_utils_1 = require("../utils/runtime-lint-utils");
 const fs_1 = require("fs");
 const internal_1 = require("@nx/js/src/internal");
-const path = tslib_1.__importStar(require("path"));
+const path = require("path");
+const create_eslint_rule_1 = require("../utils/create-eslint-rule");
 const project_graph_utils_1 = require("../utils/project-graph-utils");
 const semver_1 = require("semver");
-const js_1 = require("@nx/js");
+const path_1 = require("path");
 const DEFAULT_OPTIONS = {
     generatorsJson: 'generators.json',
     executorsJson: 'executors.json',
@@ -19,12 +18,12 @@ const DEFAULT_OPTIONS = {
     allowedVersionStrings: ['*', 'latest', 'next'],
 };
 exports.RULE_NAME = 'nx-plugin-checks';
-exports.default = utils_1.ESLintUtils.RuleCreator(() => ``)({
+exports.default = (0, create_eslint_rule_1.createESLintRule)({
     name: exports.RULE_NAME,
     meta: {
         docs: {
             description: 'Checks common nx-plugin configuration files for validity',
-            recommended: 'recommended',
+            recommended: 'error',
         },
         schema: [
             {
@@ -90,7 +89,7 @@ exports.default = utils_1.ESLintUtils.RuleCreator(() => ``)({
             return {};
         }
         if (!global.tsProjectRegistered) {
-            (0, internal_1.registerTsProject)((0, js_1.getRootTsConfigPath)());
+            (0, internal_1.registerTsProject)((0, path_1.join)(devkit_1.workspaceRoot, 'tsconfig.base.json'));
             global.tsProjectRegistered = true;
         }
         return {

package/src/utils/ast-utils.js

@@ -79,17 +79,7 @@ function hasMemberExport(exportedMember, filePath) {
     return ((0, js_1.findNodes)(sourceFile, ts.SyntaxKind.Identifier).filter((identifier) => identifier.text === exportedMember).length > 0);
 }
 function getRelativeImportPath(exportedMember, filePath, basePath) {
-    const status = (0, fs_1.lstatSync)(filePath, {
-        throwIfNoEntry: false,
-    });
-    if (!status /*not existed, but probably not full file with an extension*/) {
-        // try to find an extension that exists
-        const ext = ['.ts', '.tsx', '.js', '.jsx'].find((ext) => (0, fs_1.lstatSync)(filePath + ext, { throwIfNoEntry: false }));
-        if (ext) {
-            filePath += ext;
-        }
-    }
-    else if (status.isDirectory()) {
+    if ((0, fs_1.lstatSync)(filePath).isDirectory()) {
         const file = (0, fs_1.readdirSync)(filePath).find((file) => /^index\.[jt]sx?$/.exec(file));
         if (file) {
             filePath = (0, devkit_1.joinPathFragments)(filePath, file);
@@ -98,6 +88,15 @@ function getRelativeImportPath(exportedMember, filePath, basePath) {
             return;
         }
     }
+    else if (!(0, fs_1.lstatSync)(filePath, {
+        throwIfNoEntry: false,
+    }) /*not folder, but probably not full file with an extension either*/) {
+        // try to find an extension that exists
+        const ext = ['.ts', '.tsx', '.js', '.jsx'].find((ext) => (0, fs_1.lstatSync)(filePath + ext, { throwIfNoEntry: false }));
+        if (ext) {
+            filePath += ext;
+        }
+    }
     const fileContent = (0, fs_1.readFileSync)(filePath, 'utf8');
     // use the TypeScript AST to find the path to the file where exportedMember is defined
     const sourceFile = ts.createSourceFile(filePath, fileContent, ts.ScriptTarget.Latest, true);

package/src/utils/create-eslint-rule.d.ts

@@ -0,0 +1,2 @@
+import { ESLintUtils } from '@typescript-eslint/utils';
+export declare const createESLintRule: <TOptions extends readonly unknown[], TMessageIds extends string, TRuleListener extends import("@typescript-eslint/utils/dist/ts-eslint/Rule").RuleListener = import("@typescript-eslint/utils/dist/ts-eslint/Rule").RuleListener>({ name, meta, ...rule }: Readonly<ESLintUtils.RuleWithMetaAndName<TOptions, TMessageIds, TRuleListener>>) => import("@typescript-eslint/utils/dist/ts-eslint/Rule").RuleModule<TMessageIds, TOptions, TRuleListener>;

package/src/utils/create-eslint-rule.js

@@ -0,0 +1,5 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.createESLintRule = void 0;
+const utils_1 = require("@typescript-eslint/utils");
+exports.createESLintRule = utils_1.ESLintUtils.RuleCreator(() => ``);

package/src/utils/package-json-utils.js

@@ -14,18 +14,15 @@ function getAllDependencies(packageJson) {
 }
 exports.getAllDependencies = getAllDependencies;
 function getProductionDependencies(packageJsonPath) {
-    if (!globalThis.projPackageJsonDeps ||
-        !globalThis.projPackageJsonDeps[packageJsonPath] ||
-        !(0, runtime_lint_utils_1.isTerminalRun)()) {
+    if (!globalThis.projPackageJsonDeps || !(0, runtime_lint_utils_1.isTerminalRun)()) {
         const packageJson = getPackageJson(packageJsonPath);
-        globalThis.projPackageJsonDeps = globalThis.projPackageJsonDeps || {};
-        globalThis.projPackageJsonDeps[packageJsonPath] = {
+        globalThis.projPackageJsonDeps = {
             ...packageJson.dependencies,
             ...packageJson.peerDependencies,
             ...packageJson.optionalDependencies,
         };
     }
-    return globalThis.projPackageJsonDeps[packageJsonPath];
+    return globalThis.projPackageJsonDeps;
 }
 exports.getProductionDependencies = getProductionDependencies;
 function getPackageJson(path) {

package/src/utils/runtime-lint-utils.d.ts

@@ -1,7 +1,6 @@
 import { ProjectGraph, ProjectGraphDependency, ProjectGraphExternalNode, ProjectGraphProjectNode } from '@nx/devkit';
 import { ProjectRootMappings } from 'nx/src/project-graph/utils/find-project-for-path';
 import { TargetProjectLocator } from '@nx/js/src/internal';
-import { TSESTree } from '@typescript-eslint/utils';
 export type Deps = {
     [projectName: string]: ProjectGraphDependency[];
 };
@@ -40,7 +39,7 @@ export declare function isAbsoluteImportIntoAnotherProject(imp: string, workspac
 }): boolean;
 export declare function findProjectUsingImport(projectGraph: ProjectGraph, targetProjectLocator: TargetProjectLocator, filePath: string, imp: string): ProjectGraphProjectNode | ProjectGraphExternalNode;
 export declare function findConstraintsFor(depConstraints: DepConstraint[], sourceProject: ProjectGraphProjectNode): DepConstraint[];
-export declare function hasStaticImportOfDynamicResource(node: TSESTree.ImportDeclaration | TSESTree.ImportExpression | TSESTree.ExportAllDeclaration | TSESTree.ExportNamedDeclaration, graph: ProjectGraph, sourceProjectName: string, targetProjectName: string): boolean;
+export declare function onlyLoadChildren(graph: ProjectGraph, sourceProjectName: string, targetProjectName: string, visited: string[]): any;
 export declare function getSourceFilePath(sourceFileName: string, projectPath: string): string;
 export declare function hasBannedImport(source: ProjectGraphProjectNode, target: ProjectGraphExternalNode, depConstraints: DepConstraint[], imp: string): DepConstraint | undefined;
 /**
@@ -78,9 +77,12 @@ export declare function groupImports(importsToRemap: {
     importPath: string;
 }[]): string;
 /**
- * Checks if source file belongs to a secondary entry point different than the import one
+ * Checks if import points to a secondary entry point in Angular project
+ * @param targetProjectLocator
+ * @param importExpr
+ * @returns
  */
-export declare function belongsToDifferentNgEntryPoint(importExpr: string, filePath: string, projectRoot: string): boolean;
+export declare function isAngularSecondaryEntrypoint(importExpr: string, filePath: string, projectRoot: string): boolean;
 /**
  * Returns true if the given project contains MFE config with "exposes:" section
  */

package/src/utils/runtime-lint-utils.js

@@ -1,8 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.appIsMFERemote = exports.belongsToDifferentNgEntryPoint = exports.groupImports = exports.isTerminalRun = exports.hasBuildExecutor = exports.isDirectDependency = exports.hasBannedDependencies = exports.findTransitiveExternalDependencies = exports.hasBannedImport = exports.getSourceFilePath = exports.hasStaticImportOfDynamicResource = exports.findConstraintsFor = exports.findProjectUsingImport = exports.isAbsoluteImportIntoAnotherProject = exports.findProject = exports.getTargetProjectBasedOnRelativeImport = exports.isRelative = exports.matchImportWithWildcard = exports.findDependenciesWithTags = exports.isComboDepConstraint = exports.hasNoneOfTheseTags = exports.stringifyTags = void 0;
-const tslib_1 = require("tslib");
-const path = tslib_1.__importStar(require("path"));
+exports.appIsMFERemote = exports.isAngularSecondaryEntrypoint = exports.groupImports = exports.isTerminalRun = exports.hasBuildExecutor = exports.isDirectDependency = exports.hasBannedDependencies = exports.findTransitiveExternalDependencies = exports.hasBannedImport = exports.getSourceFilePath = exports.onlyLoadChildren = exports.findConstraintsFor = exports.findProjectUsingImport = exports.isAbsoluteImportIntoAnotherProject = exports.findProject = exports.getTargetProjectBasedOnRelativeImport = exports.isRelative = exports.matchImportWithWildcard = exports.findDependenciesWithTags = exports.isComboDepConstraint = exports.hasNoneOfTheseTags = exports.stringifyTags = void 0;
+const path = require("path");
 const path_1 = require("path");
 const devkit_1 = require("@nx/devkit");
 const graph_utils_1 = require("./graph-utils");
@@ -10,7 +9,6 @@ const fileutils_1 = require("nx/src/utils/fileutils");
 const find_project_for_path_1 = require("nx/src/project-graph/utils/find-project-for-path");
 const js_1 = require("@nx/js");
 const internal_1 = require("@nx/js/src/internal");
-const utils_1 = require("@typescript-eslint/utils");
 function stringifyTags(tags) {
     return tags.map((t) => `"${t}"`).join(', ');
 }
@@ -125,31 +123,21 @@ function findConstraintsFor(depConstraints, sourceProject) {
     });
 }
 exports.findConstraintsFor = findConstraintsFor;
-function hasStaticImportOfDynamicResource(node, graph, sourceProjectName, targetProjectName) {
-    if (node.type !== utils_1.AST_NODE_TYPES.ImportDeclaration ||
-        node.importKind === 'type') {
-        return false;
-    }
-    return onlyLoadChildren(graph, sourceProjectName, targetProjectName, []);
-}
-exports.hasStaticImportOfDynamicResource = hasStaticImportOfDynamicResource;
 function onlyLoadChildren(graph, sourceProjectName, targetProjectName, visited) {
-    if (visited.indexOf(sourceProjectName) > -1) {
+    if (visited.indexOf(sourceProjectName) > -1)
         return false;
-    }
     return ((graph.dependencies[sourceProjectName] || []).filter((d) => {
-        if (d.type !== devkit_1.DependencyType.dynamic) {
+        if (d.type !== devkit_1.DependencyType.dynamic)
             return false;
-        }
-        if (d.target === targetProjectName) {
+        if (d.target === targetProjectName)
             return true;
-        }
         return onlyLoadChildren(graph, d.target, targetProjectName, [
             ...visited,
             sourceProjectName,
         ]);
     }).length > 0);
 }
+exports.onlyLoadChildren = onlyLoadChildren;
 function getSourceFilePath(sourceFileName, projectPath) {
     const normalizedProjectPath = (0, devkit_1.normalizePath)(projectPath);
     const normalizedSourceFileName = (0, devkit_1.normalizePath)(sourceFileName);
@@ -282,7 +270,7 @@ function hasBuildExecutor(projectGraph, buildTargets = ['build']) {
             projectGraph.data.targets[target].executor !== ''));
 }
 exports.hasBuildExecutor = hasBuildExecutor;
-const ESLINT_REGEX = /node_modules.*[\/\\]eslint(?:\.js)?$/;
+const ESLINT_REGEX = /node_modules.*[\/\\]eslint$/;
 const JEST_REGEX = /node_modules\/.bin\/jest$/; // when we run unit tests in jest
 const NRWL_CLI_REGEX = /nx[\/\\]bin[\/\\]run-executor\.js$/;
 function isTerminalRun() {
@@ -322,21 +310,17 @@ function groupImports(importsToRemap) {
 }
 exports.groupImports = groupImports;
 /**
- * Checks if source file belongs to a secondary entry point different than the import one
+ * Checks if import points to a secondary entry point in Angular project
+ * @param targetProjectLocator
+ * @param importExpr
+ * @returns
  */
-function belongsToDifferentNgEntryPoint(importExpr, filePath, projectRoot) {
-    const resolvedImportFile = (0, internal_1.resolveModuleByImport)(importExpr, filePath, // not strictly necessary, but speeds up resolution
-    (0, path_1.join)(devkit_1.workspaceRoot, (0, js_1.getRootTsConfigFileName)()));
-    if (!resolvedImportFile) {
-        return false;
-    }
-    const importEntryPoint = getAngularEntryPoint(resolvedImportFile, projectRoot);
-    const srcEntryPoint = getAngularEntryPoint(filePath, projectRoot);
-    // check if the entry point of import expression is different than the source file's entry point
-    return importEntryPoint !== srcEntryPoint;
+function isAngularSecondaryEntrypoint(importExpr, filePath, projectRoot) {
+    const resolvedModule = (0, internal_1.resolveModuleByImport)(importExpr, filePath, (0, path_1.join)(devkit_1.workspaceRoot, (0, js_1.getRootTsConfigFileName)()));
+    return (!!resolvedModule && fileIsSecondaryEntryPoint(resolvedModule, projectRoot));
 }
-exports.belongsToDifferentNgEntryPoint = belongsToDifferentNgEntryPoint;
-function getAngularEntryPoint(file, projectRoot) {
+exports.isAngularSecondaryEntrypoint = isAngularSecondaryEntrypoint;
+function fileIsSecondaryEntryPoint(file, projectRoot) {
     let parent = (0, devkit_1.joinPathFragments)(file, '../');
     while (parent !== `${projectRoot}/`) {
         // we need to find closest existing ng-package.json
@@ -345,11 +329,11 @@ function getAngularEntryPoint(file, projectRoot) {
         if (ngPackageContent) {
             // https://github.com/ng-packagr/ng-packagr/blob/23c718d04eea85e015b4c261310b7bd0c39e5311/src/ng-package.schema.json#L54
             const entryFile = (0, devkit_1.parseJson)(ngPackageContent)?.lib?.entryFile;
-            return (0, devkit_1.joinPathFragments)(parent, entryFile);
+            return entryFile && file === (0, devkit_1.joinPathFragments)(parent, entryFile);
         }
         parent = (0, devkit_1.joinPathFragments)(parent, '../');
     }
-    return undefined;
+    return false;
 }
 /**
  * Returns true if the given project contains MFE config with "exposes:" section

package/src/migrations/update-17-2-6-rename-workspace-rules/rename-workspace-rules.d.ts

@@ -1,2 +0,0 @@
-import { Tree } from '@nx/devkit';
-export default function renameWorkspaceRule(tree: Tree): Promise<void>;

package/src/migrations/update-17-2-6-rename-workspace-rules/rename-workspace-rules.js

@@ -1,29 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-const devkit_1 = require("@nx/devkit");
-const binary_extensions_1 = require("@nx/devkit/src/utils/binary-extensions");
-const constants_1 = require("../../constants");
-async function renameWorkspaceRule(tree) {
-    if (!tree.exists(constants_1.WORKSPACE_RULES_PATH)) {
-        return;
-    }
-    let ruleNames = [];
-    try {
-        ruleNames = Object.keys(require(constants_1.WORKSPACE_PLUGIN_DIR).rules);
-    }
-    catch (e) {
-        return;
-    }
-    (0, devkit_1.visitNotIgnoredFiles)(tree, '.', (path) => {
-        if ((0, binary_extensions_1.isBinaryPath)(path)) {
-            return;
-        }
-        let contents = tree.read(path, 'utf-8');
-        ruleNames.forEach((ruleName) => {
-            contents = contents.replace(new RegExp(`@nx/workspace/${ruleName}`, 'g'), `@nx/workspace-${ruleName}`);
-        });
-        tree.write(path, contents);
-    });
-    await (0, devkit_1.formatFiles)(tree);
-}
-exports.default = renameWorkspaceRule;