@nx/eslint-plugin 16.7.2 → 16.7.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/eslint-plugin",
-  "version": "16.7.2",
+  "version": "16.7.4",
   "private": false,
   "description": "The eslint-plugin package is an ESLint plugin that contains a collection of recommended ESLint rule configurations which you can extend from in your own ESLint configs, as well as an Nx-specific lint rule called enforce-module-boundaries.",
   "repository": {
@@ -33,9 +33,9 @@
     }
   },
   "dependencies": {
-    "@nrwl/eslint-plugin-nx": "16.7.2",
-    "@nx/devkit": "16.7.2",
-    "@nx/js": "16.7.2",
+    "@nrwl/eslint-plugin-nx": "16.7.4",
+    "@nx/devkit": "16.7.4",
+    "@nx/js": "16.7.4",
     "@typescript-eslint/type-utils": "^5.60.1",
     "@typescript-eslint/utils": "^5.60.1",
     "chalk": "^4.1.0",
@@ -51,5 +51,5 @@
     "migrations": "./migrations.json"
   },
   "type": "commonjs",
-  "gitHead": "b024f44a1ad4e1773e80f6dc72f9d22766b950f9"
+  "gitHead": "5d73f6e0f2c6d4dfb2e9d45519d591c338bb5c37"
 }

package/src/rules/dependency-checks.js

@@ -34,7 +34,7 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
             },
         ],
         messages: {
-            missingDependency: `The "{{projectName}}" project uses the following packages, but they are missing from the "{{section}}":{{packageNames}}`,
+            missingDependency: `The "{{projectName}}" project uses the following packages, but they are missing from "{{section}}":{{packageNames}}`,
             obsoleteDependency: `The "{{packageName}}" package is not used by "{{projectName}}" project.`,
             versionMismatch: `The version specifier does not contain the installed version of "{{packageName}}" package: {{version}}.`,
             missingDependencySection: `Dependency sections are missing from the "package.json" but following dependencies were detected:{{dependencies}}`,
@@ -82,7 +82,7 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
         });
         const expectedDependencyNames = Object.keys(npmDependencies);
         const projPackageJsonPath = (0, path_1.join)(devkit_1.workspaceRoot, sourceProject.data.root, 'package.json');
-        (_a = globalThis.projPackageJsonDeps) !== null && _a !== void 0 ? _a : (globalThis.projPackageJsonDeps = (0, package_json_utils_1.getAllDependencies)((0, package_json_utils_1.getPackageJson)(projPackageJsonPath)));
+        (_a = globalThis.projPackageJsonDeps) !== null && _a !== void 0 ? _a : (globalThis.projPackageJsonDeps = (0, package_json_utils_1.getProductionDependencies)((0, package_json_utils_1.getPackageJson)(projPackageJsonPath)));
         const projPackageJsonDeps = globalThis.projPackageJsonDeps;
         const rootPackageJsonDeps = (0, package_json_utils_1.getAllDependencies)(rootPackageJson);
         function validateMissingDependencies(node) {
@@ -182,12 +182,7 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
                 return;
             }
             if (!node.properties ||
-                !node.properties.some((p) => [
-                    'dependencies',
-                    'peerDependencies',
-                    'devDependencies',
-                    'optionalDependencies',
-                ].includes(p.key.value))) {
+                !node.properties.some((p) => ['dependencies', 'peerDependencies', 'optionalDependencies'].includes(p.key.value))) {
                 context.report({
                     node: node,
                     messageId: 'missingDependencySection',
@@ -215,7 +210,7 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
             }
         }
         return {
-            ['JSONExpressionStatement > JSONObjectExpression > JSONProperty[key.value=/^(dev|peer|optional)?dependencies$/i]'](node) {
+            ['JSONExpressionStatement > JSONObjectExpression > JSONProperty[key.value=/^(peer|optional)?dependencies$/i]'](node) {
                 validateMissingDependencies(node);
             },
             ['JSONExpressionStatement > JSONObjectExpression > JSONProperty[key.value=/^(peer|optional)?dependencies$/i] > JSONObjectExpression > JSONProperty'](node) {

package/src/utils/package-json-utils.d.ts

@@ -1,3 +1,4 @@
 import { PackageJson } from 'nx/src/utils/package-json';
 export declare function getAllDependencies(packageJson: PackageJson): Record<string, string>;
+export declare function getProductionDependencies(packageJson: PackageJson): Record<string, string>;
 export declare function getPackageJson(path: string): PackageJson;

package/src/utils/package-json-utils.js

@@ -1,12 +1,16 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.getPackageJson = exports.getAllDependencies = void 0;
+exports.getPackageJson = exports.getProductionDependencies = exports.getAllDependencies = void 0;
 const devkit_1 = require("@nx/devkit");
 const fs_1 = require("fs");
 function getAllDependencies(packageJson) {
     return Object.assign(Object.assign(Object.assign(Object.assign({}, packageJson.dependencies), packageJson.devDependencies), packageJson.peerDependencies), packageJson.optionalDependencies);
 }
 exports.getAllDependencies = getAllDependencies;
+function getProductionDependencies(packageJson) {
+    return Object.assign(Object.assign(Object.assign({}, packageJson.dependencies), packageJson.peerDependencies), packageJson.optionalDependencies);
+}
+exports.getProductionDependencies = getProductionDependencies;
 function getPackageJson(path) {
     if ((0, fs_1.existsSync)(path)) {
         return (0, devkit_1.readJsonFile)(path);