@nx/eslint-plugin 16.4.1 → 16.4.3
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/package.json +5 -5
- package/src/rules/dependency-checks.js +29 -29
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "@nx/eslint-plugin",
|
|
3
|
-
"version": "16.4.
|
|
3
|
+
"version": "16.4.3",
|
|
4
4
|
"private": false,
|
|
5
5
|
"description": "The eslint-plugin package is an ESLint plugin that contains a collection of recommended ESLint rule configurations which you can extend from in your own ESLint configs, as well as an Nx-specific lint rule called enforce-module-boundaries.",
|
|
6
6
|
"repository": {
|
|
@@ -33,9 +33,9 @@
|
|
|
33
33
|
}
|
|
34
34
|
},
|
|
35
35
|
"dependencies": {
|
|
36
|
-
"@nrwl/eslint-plugin-nx": "16.4.
|
|
37
|
-
"@nx/devkit": "16.4.
|
|
38
|
-
"@nx/js": "16.4.
|
|
36
|
+
"@nrwl/eslint-plugin-nx": "16.4.3",
|
|
37
|
+
"@nx/devkit": "16.4.3",
|
|
38
|
+
"@nx/js": "16.4.3",
|
|
39
39
|
"@typescript-eslint/type-utils": "^5.58.0",
|
|
40
40
|
"@typescript-eslint/utils": "^5.58.0",
|
|
41
41
|
"chalk": "^4.1.0",
|
|
@@ -50,5 +50,5 @@
|
|
|
50
50
|
"migrations": "./migrations.json"
|
|
51
51
|
},
|
|
52
52
|
"types": "./src/index.d.ts",
|
|
53
|
-
"gitHead": "
|
|
53
|
+
"gitHead": "30ea694c017a9e9956e007d009df18cf5347e6a5"
|
|
54
54
|
}
|
|
@@ -25,7 +25,7 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
|
|
|
25
25
|
type: 'object',
|
|
26
26
|
properties: {
|
|
27
27
|
buildTargets: [{ type: 'string' }],
|
|
28
|
-
|
|
28
|
+
ignoredDependencies: [{ type: 'string' }],
|
|
29
29
|
checkMissingDependencies: { type: 'boolean' },
|
|
30
30
|
checkObsoleteDependencies: { type: 'boolean' },
|
|
31
31
|
checkVersionMismatches: { type: 'boolean' },
|
|
@@ -34,7 +34,7 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
|
|
|
34
34
|
},
|
|
35
35
|
],
|
|
36
36
|
messages: {
|
|
37
|
-
missingDependency: `The "{{projectName}}" uses the
|
|
37
|
+
missingDependency: `The "{{projectName}}" uses the following packages, but they are missing from the "{{section}}":{{packageNames}}`,
|
|
38
38
|
obsoleteDependency: `The "{{packageName}}" package is not used by "{{projectName}}".`,
|
|
39
39
|
versionMismatch: `The version specifier does not contain the installed version of "{{packageName}}" package: {{version}}.`,
|
|
40
40
|
missingDependencySection: `Dependency sections are missing from the "package.json" but following dependencies were detected:{{dependencies}}`,
|
|
@@ -91,27 +91,34 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
|
|
|
91
91
|
if (!checkMissingDependencies) {
|
|
92
92
|
return;
|
|
93
93
|
}
|
|
94
|
-
const missingDeps = expectedDependencyNames.filter((d) => !projPackageJsonDeps[d]);
|
|
95
|
-
missingDeps.
|
|
96
|
-
|
|
97
|
-
|
|
98
|
-
|
|
99
|
-
|
|
100
|
-
|
|
101
|
-
|
|
94
|
+
const missingDeps = expectedDependencyNames.filter((d) => !projPackageJsonDeps[d] && !ignoredDependencies.includes(d));
|
|
95
|
+
if (missingDeps.length) {
|
|
96
|
+
context.report({
|
|
97
|
+
node: node,
|
|
98
|
+
messageId: 'missingDependency',
|
|
99
|
+
data: {
|
|
100
|
+
packageNames: missingDeps.map((d) => `\n - ${d}`).join(''),
|
|
101
|
+
section: node.key.value,
|
|
102
|
+
projectName: sourceProject.name,
|
|
103
|
+
},
|
|
104
|
+
fix(fixer) {
|
|
105
|
+
missingDeps.forEach((d) => {
|
|
102
106
|
projPackageJsonDeps[d] =
|
|
103
107
|
rootPackageJsonDeps[d] || projDependencies[d];
|
|
104
|
-
|
|
105
|
-
|
|
106
|
-
|
|
107
|
-
}
|
|
108
|
-
|
|
109
|
-
|
|
110
|
-
}
|
|
111
|
-
}
|
|
112
|
-
|
|
113
|
-
|
|
114
|
-
|
|
108
|
+
});
|
|
109
|
+
const deps = node.value.properties;
|
|
110
|
+
const mappedDeps = missingDeps
|
|
111
|
+
.map((d) => `\n "${d}": "${projPackageJsonDeps[d]}"`)
|
|
112
|
+
.join(',');
|
|
113
|
+
if (deps.length) {
|
|
114
|
+
return fixer.insertTextAfter(deps[deps.length - 1], `,${mappedDeps}`);
|
|
115
|
+
}
|
|
116
|
+
else {
|
|
117
|
+
return fixer.insertTextAfterRange([node.value.range[0] + 1, node.value.range[1] - 1], `${mappedDeps}\n `);
|
|
118
|
+
}
|
|
119
|
+
},
|
|
120
|
+
});
|
|
121
|
+
}
|
|
115
122
|
}
|
|
116
123
|
function validateVersionMatchesInstalled(node, packageName, packageRange) {
|
|
117
124
|
if (!checkVersionMismatches) {
|
|
@@ -145,7 +152,7 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
|
|
|
145
152
|
if (index > 0) {
|
|
146
153
|
const previousNode = node.parent.properties[index - 1];
|
|
147
154
|
return fixer.removeRange([
|
|
148
|
-
previousNode.range[1] + 1,
|
|
155
|
+
previousNode.range[1] + (isLastProperty ? 0 : 1),
|
|
149
156
|
node.range[1] + (isLastProperty ? 0 : 1),
|
|
150
157
|
]);
|
|
151
158
|
}
|
|
@@ -165,13 +172,6 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
|
|
|
165
172
|
]);
|
|
166
173
|
}
|
|
167
174
|
}
|
|
168
|
-
// remove 4 spaces, new line and potential comma from previous line
|
|
169
|
-
const shouldRemoveSiblingComma = isLastProperty && node.parent.properties.length > 1;
|
|
170
|
-
const leadingChars = 5 + (shouldRemoveSiblingComma ? 1 : 0);
|
|
171
|
-
return fixer.removeRange([
|
|
172
|
-
node.range[0] - leadingChars,
|
|
173
|
-
node.range[1] + (isLastProperty ? 0 : 1),
|
|
174
|
-
]);
|
|
175
175
|
},
|
|
176
176
|
});
|
|
177
177
|
}
|