@nx/eslint-plugin 16.4.0-beta.10 → 16.4.0-beta.13

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/eslint-plugin",
-  "version": "16.4.0-beta.10",
+  "version": "16.4.0-beta.13",
   "private": false,
   "description": "The eslint-plugin package is an ESLint plugin that contains a collection of recommended ESLint rule configurations which you can extend from in your own ESLint configs, as well as an Nx-specific lint rule called enforce-module-boundaries.",
   "repository": {
@@ -33,9 +33,9 @@
     }
   },
   "dependencies": {
-    "@nrwl/eslint-plugin-nx": "16.4.0-beta.10",
-    "@nx/devkit": "16.4.0-beta.10",
-    "@nx/js": "16.4.0-beta.10",
+    "@nrwl/eslint-plugin-nx": "16.4.0-beta.13",
+    "@nx/devkit": "16.4.0-beta.13",
+    "@nx/js": "16.4.0-beta.13",
     "@typescript-eslint/type-utils": "^5.58.0",
     "@typescript-eslint/utils": "^5.58.0",
     "chalk": "^4.1.0",
@@ -49,5 +49,5 @@
     "migrations": "./migrations.json"
   },
   "types": "./src/index.d.ts",
-  "gitHead": "d2bde0605c692a023bc9c28686f3a3037bbd56d3"
+  "gitHead": "d81afedfcc8d07db8cdb9b0e9286de0321ee184e"
 }

package/src/rules/enforce-module-boundaries.js

@@ -64,7 +64,7 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
             noImportsOfApps: 'Imports of apps are forbidden',
             noImportsOfE2e: 'Imports of e2e projects are forbidden',
             noImportOfNonBuildableLibraries: 'Buildable libraries cannot import or export from non-buildable libraries',
-            noImportsOfLazyLoadedLibraries: `Imports of lazy-loaded libraries are forbidden`,
+            noImportsOfLazyLoadedLibraries: `Static imports of lazy-loaded libraries are forbidden.\n\nLibrary "{{targetProjectName}}" is lazy-loaded in these files:\n{{filePaths}}`,
             projectWithoutTagsCannotHaveDependencies: `A project without tags matching at least one constraint cannot depend on any libraries`,
             bannedExternalImportsViolation: `A project tagged with "{{sourceTag}}" is not allowed to import the "{{package}}" package`,
             nestedBannedExternalImportsViolation: `A project tagged with "{{sourceTag}}" is not allowed to import the "{{package}}" package. Nested import found at {{childProjectName}}`,
@@ -312,7 +312,14 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
                 node.importKind !== 'type' &&
                 !checkDynamicDependenciesExceptions.some((a) => (0, runtime_lint_utils_1.matchImportWithWildcard)(a, imp)) &&
                 (0, runtime_lint_utils_1.onlyLoadChildren)(projectGraph, sourceProject.name, targetProject.name, [])) {
+                const filesWithLazyImports = (0, graph_utils_1.findFilesWithDynamicImports)(projectFileMap, sourceProject.name, targetProject.name);
                 context.report({
+                    data: {
+                        filePaths: filesWithLazyImports
+                            .map(({ file }) => `- ${file}`)
+                            .join('\n'),
+                        targetProjectName: targetProject.name,
+                    },
                     node,
                     messageId: 'noImportsOfLazyLoadedLibraries',
                 });

package/src/utils/graph-utils.d.ts

@@ -1,5 +1,6 @@
-import type { ProjectFileMap, ProjectGraph, ProjectGraphProjectNode } from '@nx/devkit';
+import type { FileData, ProjectFileMap, ProjectGraph, ProjectGraphProjectNode } from '@nx/devkit';
 export declare function getPath(graph: ProjectGraph, sourceProjectName: string, targetProjectName: string): Array<ProjectGraphProjectNode>;
 export declare function pathExists(graph: ProjectGraph, sourceProjectName: string, targetProjectName: string): boolean;
 export declare function checkCircularPath(graph: ProjectGraph, sourceProject: ProjectGraphProjectNode, targetProject: ProjectGraphProjectNode): ProjectGraphProjectNode[];
 export declare function findFilesInCircularPath(projectFileMap: ProjectFileMap, circularPath: ProjectGraphProjectNode[]): Array<string[]>;
+export declare function findFilesWithDynamicImports(projectFileMap: ProjectFileMap, sourceProjectName: string, targetProjectName: string): FileData[];

package/src/utils/graph-utils.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.findFilesInCircularPath = exports.checkCircularPath = exports.pathExists = exports.getPath = void 0;
+exports.findFilesWithDynamicImports = exports.findFilesInCircularPath = exports.checkCircularPath = exports.pathExists = exports.getPath = void 0;
 const project_graph_1 = require("nx/src/config/project-graph");
 const reach = {
     graph: null,
@@ -114,3 +114,16 @@ function findFilesInCircularPath(projectFileMap, circularPath) {
     return filePathChain;
 }
 exports.findFilesInCircularPath = findFilesInCircularPath;
+function findFilesWithDynamicImports(projectFileMap, sourceProjectName, targetProjectName) {
+    const files = [];
+    projectFileMap[sourceProjectName].forEach((file) => {
+        if (!file.deps)
+            return;
+        if (file.deps.some((d) => (0, project_graph_1.fileDataDepTarget)(d) === targetProjectName &&
+            (0, project_graph_1.fileDataDepType)(d) === project_graph_1.DependencyType.dynamic)) {
+            files.push(file);
+        }
+    });
+    return files;
+}
+exports.findFilesWithDynamicImports = findFilesWithDynamicImports;