@nx/esbuild 23.2.0-beta.10 → 23.2.0-beta.12

package/README.md

@@ -7,9 +7,9 @@
 
 <div style="text-align: center;">
 
-[![License](https://img.shields.io/npm/l/@nx/workspace.svg?style=flat-square)]()
+[![License](https://img.shields.io/npm/l/@nx/workspace.svg?style=flat-square)](<>)
 [![NPM Version](https://badge.fury.io/js/nx.svg)](https://www.npmjs.com/package/nx)
-[![Semantic Release](https://img.shields.io/badge/%20%20%F0%9F%93%A6%F0%9F%9A%80-semantic--release-e10079.svg?style=flat-square)]()
+[![Semantic Release](https://img.shields.io/badge/%20%20%F0%9F%93%A6%F0%9F%9A%80-semantic--release-e10079.svg?style=flat-square)](<>)
 [![Commitizen friendly](https://img.shields.io/badge/commitizen-friendly-brightgreen.svg)](http://commitizen.github.io/cz-cli/)
 [![Join us on the Official Nx Discord Server](https://img.shields.io/discord/1143497901675401286?label=discord)](https://go.nx.dev/community)
 [![Nx Sandboxing](https://staging.nx.app/workspaces/62d013ea0852fe0a2df74438/sandbox-badge.svg)](https://nx.dev/docs/features/ci-features/sandboxing)

package/dist/src/executors/esbuild/esbuild.impl.js

@@ -10,7 +10,7 @@ const esbuild = tslib_1.__importStar(require("esbuild"));
 const normalize_1 = require("./lib/normalize");
 const build_esbuild_options_1 = require("./lib/build-esbuild-options");
 const get_extra_dependencies_1 = require("./lib/get-extra-dependencies");
-const node_fs_1 = require("node:fs");
+const fs_1 = require("../../utils/fs");
 const path_1 = require("path");
 const BUILD_WATCH_FAILED = `[ ${pc.red('watch')} ] build finished with errors (see above), watching for changes...`;
 const BUILD_WATCH_SUCCEEDED = `[ ${pc.green('watch')} ] build succeeded, watching for changes...`;
@@ -18,7 +18,7 @@ async function* esbuildExecutor(_options, context) {
     process.env.NODE_ENV ??= context.configurationName ?? 'production';
     const options = await (0, normalize_1.normalizeOptions)(_options, context);
     if (options.deleteOutputPath)
-        (0, node_fs_1.rmSync)(options.outputPath, { recursive: true, force: true });
+        (0, fs_1.deleteOutputDir)(context.root, options.outputPath);
     const assetsResult = await (0, js_1.copyAssets)(options, context);
     const externalDependencies = options.external.reduce((acc, name) => {
         const externalNode = context.projectGraph.externalNodes[`npm:${name}`];
@@ -140,7 +140,7 @@ async function* esbuildExecutor(_options, context) {
                 const filename = options.format.length === 1
                     ? 'meta.json'
                     : `meta.${options.format[i]}.json`;
-                (0, devkit_1.writeJsonFile)((0, devkit_1.joinPathFragments)(options.outputPath, filename), buildResult.metafile);
+                (0, devkit_1.writeJsonFile)((0, path_1.join)(context.root, options.outputPath, filename), buildResult.metafile);
             }
             yield {
                 success: buildResult.errors.length === 0,

package/dist/src/executors/esbuild/lib/build-esbuild-options.js

@@ -24,6 +24,8 @@ function buildEsbuildOptions(format, options, context) {
         : undefined;
     const esbuildOptions = {
         ...options.userDefinedBuildOptions,
+        // Nx-computed paths are workspace-root-relative, not cwd-relative.
+        absWorkingDir: context.root,
         entryNames: options.outputHashing === 'all' ? '[dir]/[name].[hash]' : '[dir]/[name]',
         bundle: options.bundle,
         // Cannot use external with bundle option
@@ -32,7 +34,7 @@ function buildEsbuildOptions(format, options, context) {
         platform: options.platform,
         target: options.target,
         metafile: options.metafile,
-        tsconfig: (0, path_1.relative)(process.cwd(), (0, path_1.join)(context.root, options.tsConfig)),
+        tsconfig: (0, path_1.join)(context.root, options.tsConfig),
         sourcemap: (options.sourcemap ?? options.userDefinedBuildOptions?.sourcemap) ||
             false,
         format,

package/dist/src/executors/esbuild/schema.d.ts

@@ -31,8 +31,10 @@ export interface EsBuildExecutorOptions {
   watch?: boolean;
 }
 
-export interface NormalizedEsBuildExecutorOptions
-  extends Omit<EsBuildExecutorOptions, 'esbuildOptions' | 'esbuildConfig'> {
+export interface NormalizedEsBuildExecutorOptions extends Omit<
+  EsBuildExecutorOptions,
+  'esbuildOptions' | 'esbuildConfig'
+> {
   assets: (AssetGlob | string)[];
   singleEntry: boolean;
   external: string[];

package/dist/src/utils/get-entry-points.js

@@ -18,6 +18,8 @@ function getEntryPoints(projectName, context, options = {}) {
         const project = context.projectGraph?.nodes[projectName];
         if (!project)
             return;
+        // Anchor to the workspace root so results do not depend on the invoking cwd.
+        const absProjectRoot = path.join(context.root, project.data.root);
         // Known files we generate from our generators. Only one of these should be used to build the project.
         const tsconfigCandidates = [
             'tsconfig.app.json',
@@ -28,7 +30,7 @@ function getEntryPoints(projectName, context, options = {}) {
             tsconfigCandidates.unshift(tsConfigFileName);
         const foundTsConfig = tsconfigCandidates.find((f) => {
             try {
-                return fs.statSync(path.join(project.data.root, f)).isFile();
+                return fs.statSync(path.join(absProjectRoot, f)).isFile();
             }
             catch {
                 return false;
@@ -36,9 +38,9 @@ function getEntryPoints(projectName, context, options = {}) {
         });
         // Workspace projects may not be a TS project, so skip reading source files if tsconfig is not found.
         if (foundTsConfig) {
-            const tsconfig = (0, devkit_1.readJsonFile)(path.join(project.data.root, foundTsConfig));
+            const tsconfig = (0, devkit_1.readJsonFile)(path.join(absProjectRoot, foundTsConfig));
             const projectFiles = (0, tinyglobby_1.globSync)(tsconfig.include ?? [], {
-                cwd: project.data.root,
+                cwd: absProjectRoot,
                 ignore: tsconfig.exclude ?? [],
                 expandDirectories: false,
             }).map((f) => path.join(project.data.root, f));

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/esbuild",
-  "version": "23.2.0-beta.10",
+  "version": "23.2.0-beta.12",
   "private": false,
   "description": "The Nx Plugin for esbuild contains executors and generators that support building applications using esbuild",
   "repository": {
@@ -44,11 +44,11 @@
     "picocolors": "^1.1.0",
     "tsconfig-paths": "^4.1.2",
     "tslib": "^2.3.0",
-    "@nx/devkit": "23.2.0-beta.10",
-    "@nx/js": "23.2.0-beta.10"
+    "@nx/devkit": "23.2.0-beta.12",
+    "@nx/js": "23.2.0-beta.12"
   },
   "devDependencies": {
-    "nx": "23.2.0-beta.10"
+    "nx": "23.2.0-beta.12"
   },
   "peerDependencies": {
     "esbuild": ">=0.19.2 <1.0.0"