@nx/esbuild 22.5.2 → 22.5.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/esbuild",
-  "version": "22.5.2",
+  "version": "22.5.3",
   "private": false,
   "description": "The Nx Plugin for esbuild contains executors and generators that support building applications using esbuild",
   "repository": {
@@ -31,15 +31,15 @@
     "migrations": "./migrations.json"
   },
   "dependencies": {
-    "@nx/devkit": "22.5.2",
-    "@nx/js": "22.5.2",
+    "@nx/devkit": "22.5.3",
+    "@nx/js": "22.5.3",
     "tinyglobby": "^0.2.12",
     "picocolors": "^1.1.0",
     "tsconfig-paths": "^4.1.2",
     "tslib": "^2.3.0"
   },
   "devDependencies": {
-    "nx": "22.5.2"
+    "nx": "22.5.3"
   },
   "peerDependencies": {
     "esbuild": ">=0.19.2 <1.0.0"

package/src/executors/esbuild/esbuild.impl.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"esbuild.impl.d.ts","sourceRoot":"","sources":["../../../../../../packages/esbuild/src/executors/esbuild/esbuild.impl.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EAAE,eAAe,EAAE,MAAM,YAAY,CAAC;AAmBlD,OAAO,EACL,sBAAsB,EAEvB,MAAM,UAAU,CAAC;AAwBlB,wBAAuB,eAAe,CACpC,QAAQ,EAAE,sBAAsB,EAChC,OAAO,EAAE,eAAe;aAqEuB,OAAO;cAAY,MAAM;aA6GzE;AAkED,eAAe,eAAe,CAAC"}
+{"version":3,"file":"esbuild.impl.d.ts","sourceRoot":"","sources":["../../../../../../packages/esbuild/src/executors/esbuild/esbuild.impl.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EAAE,eAAe,EAAE,MAAM,YAAY,CAAC;AAmBlD,OAAO,EACL,sBAAsB,EAEvB,MAAM,UAAU,CAAC;AAwBlB,wBAAuB,eAAe,CACpC,QAAQ,EAAE,sBAAsB,EAChC,OAAO,EAAE,eAAe;aAqEuB,OAAO;cAAY,MAAM;aAgHzE;AAkED,eAAe,eAAe,CAAC"}

package/src/executors/esbuild/esbuild.impl.js

@@ -81,7 +81,7 @@ async function* esbuildExecutor(_options, context) {
                                 setup(build) {
                                     build.onEnd(async (result) => {
                                         if (!options.skipTypeCheck ||
-                                            options.isTsSolutionSetup) {
+                                            (options.isTsSolutionSetup && options.declaration)) {
                                             const { errors } = await runTypeCheck(options, context);
                                             hasTypeErrors = errors.length > 0;
                                         }
@@ -122,7 +122,8 @@ async function* esbuildExecutor(_options, context) {
     }
     else {
         // Run type-checks first and bail if they don't pass.
-        if (!options.skipTypeCheck || options.isTsSolutionSetup) {
+        if (!options.skipTypeCheck ||
+            (options.isTsSolutionSetup && options.declaration)) {
             const { errors } = await runTypeCheck(options, context);
             if (errors.length > 0) {
                 yield { success: false };

package/src/executors/esbuild/lib/normalize.js

@@ -10,7 +10,7 @@ const pc = require("picocolors");
 function normalizeOptions(options, context) {
     const isTsSolutionSetup = (0, ts_solution_setup_1.isUsingTsSolutionSetup)();
     if (isTsSolutionSetup && options.generatePackageJson) {
-        throw new Error(`Setting 'generatePackageJson: true' is not supported with the current TypeScript setup. Update the 'package.json' file at the project root as needed and unset the 'generatePackageJson' option.`);
+        throw new Error(`Setting 'generatePackageJson: true' is not supported with the current TypeScript setup. Update the 'package.json' file at the project root as needed and unset the 'generatePackageJson' option. See https://nx.dev/docs/technologies/node/guides/deploying-node-projects for the recommended pruned package.json workflow.`);
     }
     const tsConfig = (0, js_1.readTsConfig)(options.tsConfig);
     // If we're not generating package.json file, then copy it as-is as an asset when not using ts solution setup.