@nx/docker 0.0.0-pr-32117-ebf1c19 → 0.0.0-pr-32111-2ec6a92

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@nx/docker",
   "description": "The Nx Plugin for Docker to aid in containerizing projects.",
-  "version": "0.0.0-pr-32117-ebf1c19",
+  "version": "0.0.0-pr-32111-2ec6a92",
   "type": "commonjs",
   "publishConfig": {
     "access": "public"
@@ -32,10 +32,6 @@
       "types": "./src/release/version-utils.d.ts",
       "default": "./src/release/version-utils.js"
     },
-    "./generators": {
-      "types": "./generators.d.ts",
-      "default": "./generators.js"
-    },
     "./package.json": "./package.json",
     "./generators.json": "./generators.json",
     "./executors.json": "./executors.json",
@@ -47,12 +43,12 @@
   "executors": "./executors.json",
   "generators": "./generators.json",
   "dependencies": {
-    "@nx/devkit": "0.0.0-pr-32117-ebf1c19",
+    "@nx/devkit": "0.0.0-pr-32111-2ec6a92",
     "enquirer": "~2.3.6",
     "tslib": "^2.3.0"
   },
   "devDependencies": {
-    "nx": "0.0.0-pr-32117-ebf1c19"
+    "nx": "0.0.0-pr-32111-2ec6a92"
   },
   "types": "./src/index.d.ts"
 }

package/src/executors/release-publish/release-publish.impl.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"release-publish.impl.d.ts","sourceRoot":"","sources":["../../../../../../packages/docker/src/executors/release-publish/release-publish.impl.ts"],"names":[],"mappings":"AAAA,OAAO,EACL,KAAK,eAAe,EAIrB,MAAM,YAAY,CAAC;AAEpB,OAAO,KAAK,EAAE,0BAA0B,EAAE,MAAM,UAAU,CAAC;AAI3D,MAAM,WAAW,oCAAoC;IACnD,KAAK,EAAE,OAAO,CAAC;IACf,cAAc,EAAE,MAAM,CAAC;IACvB,MAAM,EAAE,OAAO,CAAC;CACjB;AAED,eAAO,MAAM,YAAY,QAAiB,CAAC;AAE3C,wBAA8B,oBAAoB,CAChD,MAAM,EAAE,0BAA0B,EAClC,OAAO,EAAE,eAAe;;GAmBzB"}
+{"version":3,"file":"release-publish.impl.d.ts","sourceRoot":"","sources":["../../../../../../packages/docker/src/executors/release-publish/release-publish.impl.ts"],"names":[],"mappings":"AAAA,OAAO,EACL,KAAK,eAAe,EAIrB,MAAM,YAAY,CAAC;AAEpB,OAAO,KAAK,EAAE,0BAA0B,EAAE,MAAM,UAAU,CAAC;AAI3D,MAAM,WAAW,oCAAoC;IACnD,KAAK,EAAE,OAAO,CAAC;IACf,cAAc,EAAE,MAAM,CAAC;IACvB,MAAM,EAAE,OAAO,CAAC;CACjB;AAED,eAAO,MAAM,YAAY,QAAiB,CAAC;AAE3C,wBAA8B,oBAAoB,CAChD,MAAM,EAAE,0BAA0B,EAClC,OAAO,EAAE,eAAe;;GAiBzB"}

package/src/executors/release-publish/release-publish.impl.js

@@ -9,10 +9,10 @@ const version_utils_1 = require("../../release/version-utils");
 exports.LARGE_BUFFER = 1024 * 1000000;
 async function dockerReleasePublish(schema, context) {
     const projectConfig = context.projectGraph.nodes[context.projectName];
-    const options = await normalizeOptions(projectConfig, schema);
+    const options = normalizeOptions(projectConfig, schema);
     if (!options.dryRun) {
-        const digest = await dockerPush(options.imageReference, options.quiet);
-        devkit_1.logger.log(`Successfully pushed ${options.imageReference}${options.quiet ? `. Digest: ${digest}` : ''}`);
+        const digest = dockerPush(options.imageReference, options.quiet);
+        devkit_1.logger.log(`Successfully pushed ${options.imageReference}. Digest: ${digest}`);
     }
     else {
         devkit_1.logger.log(`Docker Image ${options.imageReference} was not pushed as --dry-run is enabled.`);
@@ -21,17 +21,17 @@ async function dockerReleasePublish(schema, context) {
         success: true,
     };
 }
-async function normalizeOptions(projectConfig, schema) {
+function normalizeOptions(projectConfig, schema) {
     return {
         quiet: schema.quiet ?? false,
-        imageReference: await findImageReference(projectConfig, schema),
+        imageReference: findImageReference(projectConfig, schema),
         dryRun: process.env.NX_DRY_RUN === 'true' || schema.dryRun || false,
     };
 }
-async function findImageReference(projectConfig, schema) {
+function findImageReference(projectConfig, schema) {
     let imageRef = readVersionFromFile(projectConfig.data.root);
     if (imageRef) {
-        if (await checkDockerImageExistsLocally(imageRef)) {
+        if (checkDockerImageExistsLocally(imageRef)) {
             return imageRef;
         }
         throw new Error(`Could not find Docker Image ${imageRef}. Did you run 'nx release version'?`);
@@ -45,63 +45,21 @@ function readVersionFromFile(projectRoot) {
     const version = (0, fs_1.readFileSync)(versionFilePath, { encoding: 'utf8' });
     return version.trim();
 }
-async function checkDockerImageExistsLocally(imageRef) {
+function checkDockerImageExistsLocally(imageRef) {
     try {
-        return await new Promise((res) => {
-            // If the ref starts with 'docker.io/', then we need to strip it since it is the default value and Docker CLI will not find it.
-            const normalizedImageRef = imageRef.startsWith('docker.io/')
-                ? imageRef.split('docker.io/')[1]
-                : imageRef;
-            const childProcess = (0, child_process_1.exec)(`docker images --filter "reference=${normalizedImageRef}" --quiet`, { encoding: 'utf8' });
-            let result = '';
-            childProcess.stdout?.on('data', (data) => {
-                result += data;
-            });
-            childProcess.stderr?.on('data', (data) => {
-                console.error(data);
-            });
-            childProcess.on('error', (error) => {
-                console.error('Docker command failed:', error);
-                res(false);
-            });
-            childProcess.on('exit', () => {
-                res(result.trim().length > 0);
-            });
-        });
+        const result = (0, child_process_1.execSync)(`docker images --filter "reference=${imageRef}" --quiet`, { encoding: 'utf8', stdio: 'inherit', maxBuffer: exports.LARGE_BUFFER });
+        return result.trim().length > 0;
     }
     catch {
         return false;
     }
 }
-async function dockerPush(imageReference, quiet) {
+function dockerPush(imageReference, quiet) {
     try {
-        return await new Promise((res, rej) => {
-            const childProcess = (0, child_process_1.exec)(`docker push ${imageReference}${quiet ? ' --quiet' : ''}`, {
-                encoding: 'utf8',
-                maxBuffer: exports.LARGE_BUFFER,
-            });
-            let result = '';
-            childProcess.stdout?.on('data', (data) => {
-                result += data;
-                if (!quiet) {
-                    console.log(data);
-                }
-            });
-            childProcess.stderr?.on('data', (data) => {
-                console.error(data);
-            });
-            childProcess.on('error', (error) => {
-                rej(error);
-            });
-            childProcess.on('exit', (code) => {
-                if (code === 0) {
-                    res(result.trim());
-                }
-                else {
-                    rej(new Error(`Docker push failed with exit code ${code}`));
-                }
-            });
+        const result = (0, child_process_1.execSync)(`docker push ${imageReference}${quiet ? ' --quiet' : ''}`, {
+            encoding: 'utf8',
         });
+        return result.trim();
     }
     catch (e) {
         devkit_1.logger.error(`Failed to push ${imageReference}`);

package/src/generators/init/schema.d.ts

@@ -4,4 +4,5 @@ export interface InitGeneratorSchema {
   updatePackageScripts?: boolean;
   skipFormat?: boolean;
   skipPackageJson?: boolean;
+  addPlugin?: boolean;
 }

package/src/generators/init/schema.json

@@ -30,6 +30,11 @@
       "description": "Do not add dependencies to `package.json`.",
       "type": "boolean",
       "default": false
+    },
+    "addPlugin": {
+      "type": "boolean",
+      "description": "Add the plugin to the nx.json file.",
+      "default": true
     }
   },
   "required": []

package/README.md

@@ -1,70 +0,0 @@
-<p style="text-align: center;">
-  <picture>
-    <source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/nrwl/nx/master/images/nx-dark.svg">
-    <img alt="Nx - Smart Repos · Fast Builds" src="https://raw.githubusercontent.com/nrwl/nx/master/images/nx-light.svg" width="100%">
-  </picture>
-</p>
-
-<div style="text-align: center;">
-
-[![CircleCI](https://circleci.com/gh/nrwl/nx.svg?style=svg)](https://circleci.com/gh/nrwl/nx)
-[![License](https://img.shields.io/npm/l/@nx/workspace.svg?style=flat-square)]()
-[![NPM Version](https://badge.fury.io/js/nx.svg)](https://www.npmjs.com/package/nx)
-[![Semantic Release](https://img.shields.io/badge/%20%20%F0%9F%93%A6%F0%9F%9A%80-semantic--release-e10079.svg?style=flat-square)]()
-[![Commitizen friendly](https://img.shields.io/badge/commitizen-friendly-brightgreen.svg)](http://commitizen.github.io/cz-cli/)
-[![Join the chat at https://gitter.im/nrwl-nx/community](https://badges.gitter.im/nrwl-nx/community.svg)](https://gitter.im/nrwl-nx/community?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
-[![Join us on the Official Nx Discord Server](https://img.shields.io/discord/1143497901675401286?label=discord)](https://go.nx.dev/community)
-
-</div>
-
-
-<hr>
-
-# Nx: Smart Repos · Fast Builds
-
-An AI-first build platform that connects everything from your editor to CI. Helping you deliver fast, without breaking things.
-
-This package is a [Docker plugin for Nx](https://nx.dev/nx-api/docker).
-
-**Experimental**: Support for Docker is currently experimental. Breaking changes may occur and not adhere to semver versioning.
-
-## Getting Started
-
-### Creating an Nx Workspace
-
-**Using `npx`**
-
-```bash
-npx create-nx-workspace
-```
-
-**Using `npm init`**
-
-```bash
-npm init nx-workspace
-```
-
-**Using `yarn create`**
-
-```bash
-yarn create nx-workspace
-```
-
-### Adding Nx to an Existing Repository
-
-Run:
-
-```bash
-npx nx@latest init
-```
-
-## Documentation & Resources
-
-- [Nx.Dev: Documentation, Guides, Tutorials](https://nx.dev)
-- [Intro to Nx](https://nx.dev/getting-started/intro)
-- [Official Nx YouTube Channel](https://www.youtube.com/@NxDevtools)
-- [Blog Posts About Nx](https://nx.dev/blog)
-
-<p style="text-align: center;"><a href="https://nx.dev/#learning-materials" target="_blank" rel="noreferrer"><img src="https://raw.githubusercontent.com/nrwl/nx/master/images/nx-courses-and-videos.svg" 
-width="100%" alt="Nx - Smart Repos · Fast Builds"></a></p>
-

package/generators.d.ts

@@ -1,2 +0,0 @@
-export * from './src/generators/init/init';
-//# sourceMappingURL=generators.d.ts.map

package/generators.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"generators.d.ts","sourceRoot":"","sources":["../../../packages/docker/generators.ts"],"names":[],"mappings":"AAAA,cAAc,4BAA4B,CAAC"}

package/generators.js

@@ -1,4 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-const tslib_1 = require("tslib");
-tslib_1.__exportStar(require("./src/generators/init/init"), exports);