@nx/devkit 16.9.0-beta.3 → 16.9.0-rc.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/devkit",
-  "version": "16.9.0-beta.3",
+  "version": "16.9.0-rc.0",
   "private": false,
   "description": "The Nx Devkit is used to customize Nx for different technologies and use cases. It contains many utility functions for reading and writing files, updating configuration, working with Abstract Syntax Trees(ASTs), and more.",
   "repository": {
@@ -28,13 +28,13 @@
   },
   "homepage": "https://nx.dev",
   "dependencies": {
-    "@nrwl/devkit": "16.9.0-beta.3",
     "ejs": "^3.1.7",
     "enquirer": "~2.3.6",
     "ignore": "^5.0.4",
-    "semver": "7.5.3",
     "tmp": "~0.2.1",
-    "tslib": "^2.3.0"
+    "tslib": "^2.3.0",
+    "semver": "7.5.3",
+    "@nrwl/devkit": "*"
   },
   "peerDependencies": {
     "nx": ">= 15 <= 17"
@@ -45,6 +45,5 @@
   "nx-migrations": {
     "migrations": "./migrations.json"
   },
-  "type": "commonjs",
-  "gitHead": "d5692528c089a75c76b21d2d1235d8cc5dbb1d26"
+  "type": "commonjs"
 }

package/src/generators/project-name-and-root-utils.js

@@ -2,22 +2,18 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.determineProjectNameAndRootOptions = void 0;
 const enquirer_1 = require("enquirer");
+const path_1 = require("path");
 const nx_1 = require("../../nx");
 const get_workspace_layout_1 = require("../utils/get-workspace-layout");
 const names_1 = require("../utils/names");
-const { joinPathFragments, normalizePath, logger, readJson, readNxJson, updateNxJson, stripIndents, } = (0, nx_1.requireNx)();
+const { joinPathFragments, normalizePath, logger, readJson, readNxJson, updateNxJson, stripIndents, workspaceRoot, } = (0, nx_1.requireNx)();
 const deprecationWarning = stripIndents `
     In Nx 18, generating projects will no longer derive the name and root.
     Please provide the exact project name and root in the future.`;
 async function determineProjectNameAndRootOptions(tree, options) {
     validateName(options.name, options.projectNameAndRootFormat);
     const formats = getProjectNameAndRootFormats(tree, options);
-    const configuredDefault = getDefaultProjectNameAndRootFormat(tree);
-    if (configuredDefault === 'derived') {
-        logger.warn(deprecationWarning + '\n' + getExample(options.callingGenerator, formats));
-    }
     const format = options.projectNameAndRootFormat ??
-        configuredDefault ??
         (await determineFormat(tree, formats, options.callingGenerator));
     return {
         ...formats[format],
@@ -82,47 +78,40 @@ async function determineFormat(tree, formats, callingGenerator) {
         ],
         initial: 'as-provided',
     }).then(({ format }) => format === asProvidedSelectedValue ? 'as-provided' : 'derived');
-    if (result === 'as-provided' && callingGenerator) {
-        const { saveDefault } = await (0, enquirer_1.prompt)({
-            type: 'confirm',
-            message: `Would you like to configure Nx to always take project name and root as provided for ${callingGenerator}?`,
-            name: 'saveDefault',
-            initial: true,
-        });
-        if (saveDefault) {
-            setProjectNameAndRootFormatDefault(tree);
-        }
-        else {
-            logger.warn(deprecationWarning);
-        }
-    }
-    else {
+    if (result === 'derived' && callingGenerator) {
         const example = getExample(callingGenerator, formats);
         logger.warn(deprecationWarning + '\n' + example);
     }
     return result;
 }
-function setProjectNameAndRootFormatDefault(tree) {
-    const nxJson = readNxJson(tree);
-    nxJson.workspaceLayout ??= {};
-    nxJson.workspaceLayout.projectNameAndRootFormat = 'as-provided';
-    updateNxJson(tree, nxJson);
-}
-function getDefaultProjectNameAndRootFormat(tree) {
-    const nxJson = readNxJson(tree);
-    return nxJson.workspaceLayout?.projectNameAndRootFormat;
-}
 function getProjectNameAndRootFormats(tree, options) {
     const name = (0, names_1.names)(options.name).fileName;
     const directory = options.directory
         ? normalizePath(options.directory.replace(/^\.?\//, ''))
         : undefined;
     const asProvidedProjectName = name;
-    const asProvidedProjectDirectory = directory
-        ? (0, names_1.names)(directory).fileName
-        : options.rootProject
-            ? '.'
-            : asProvidedProjectName;
+    let asProvidedProjectDirectory;
+    const relativeCwd = normalizePath((0, path_1.relative)(workspaceRoot, getCwd())).replace(/\/$/, '');
+    if (directory) {
+        // append the directory to the current working directory if it doesn't start with it
+        if (directory === relativeCwd || directory.startsWith(`${relativeCwd}/`)) {
+            asProvidedProjectDirectory = (0, names_1.names)(directory).fileName;
+        }
+        else {
+            asProvidedProjectDirectory = joinPathFragments(relativeCwd, (0, names_1.names)(directory).fileName);
+        }
+    }
+    else if (options.rootProject) {
+        asProvidedProjectDirectory = '.';
+    }
+    else {
+        asProvidedProjectDirectory = relativeCwd;
+        // append the project name to the current working directory if it doesn't end with it
+        if (!relativeCwd.endsWith(asProvidedProjectName) &&
+            !relativeCwd.endsWith(options.name)) {
+            asProvidedProjectDirectory = joinPathFragments(relativeCwd, asProvidedProjectName);
+        }
+    }
     if (name.startsWith('@')) {
         const nameWithoutScope = asProvidedProjectName.split('/')[1];
         return {
@@ -223,3 +212,14 @@ function getNpmScope(tree) {
 function isTTY() {
     return !!process.stdout.isTTY && process.env['CI'] !== 'true';
 }
+/**
+ * When running a script with the package manager (e.g. `npm run`), the package manager will
+ * traverse the directory tree upwards until it finds a `package.json` and will set `process.cwd()`
+ * to the folder where it found it. The actual working directory is stored in the INIT_CWD
+ * environment variable (see here: https://docs.npmjs.com/cli/v9/commands/npm-run-script#description).
+ */
+function getCwd() {
+    return process.env.INIT_CWD?.startsWith(workspaceRoot)
+        ? process.env.INIT_CWD
+        : process.cwd();
+}

package/CHANGELOG.md

@@ -1,8 +0,0 @@
-# Change Log
-
-All notable changes to this project will be documented in this file.
-See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
-
-
-
-**Note:** Version bump only for package @nx/devkit