@nx/cypress 23.1.0 → 23.1.2

package/dist/src/generators/configuration/configuration.d.ts

@@ -6,6 +6,10 @@ export interface CypressE2EConfigSchema {
     directory?: string;
     js?: boolean;
     skipFormat?: boolean;
+    enableTypedLinting?: boolean;
+    /**
+     * @deprecated Use `enableTypedLinting` instead. This option will be removed in Nx v24.
+     */
     setParserOptionsProject?: boolean;
     skipPackageJson?: boolean;
     bundler?: 'webpack' | 'vite' | 'none';

package/dist/src/generators/configuration/schema.json

@@ -60,11 +60,17 @@
       "default": false,
       "x-priority": "internal"
     },
-    "setParserOptionsProject": {
+    "enableTypedLinting": {
       "type": "boolean",
-      "description": "Whether or not to configure the ESLint `parserOptions.project` option. We do not do this by default for lint performance reasons.",
+      "description": "Whether to enable typed linting. For flat configs, this configures the recommended `parserOptions.projectService` and `tsconfigRootDir`. For legacy `.eslintrc` configs, this configures `parserOptions.project`. We do not enable this by default for lint performance reasons.",
       "default": false
     },
+    "setParserOptionsProject": {
+      "type": "boolean",
+      "description": "Deprecated alias for `enableTypedLinting`.",
+      "default": false,
+      "x-deprecated": "Use `enableTypedLinting` instead. This option will be removed in Nx v24."
+    },
     "skipPackageJson": {
       "type": "boolean",
       "default": false,

package/dist/src/generators/init/init.js

@@ -50,6 +50,12 @@ function updateDependencies(tree, options) {
     };
     if (!(0, versions_1.getInstalledCypressVersion)(tree)) {
         devDependencies.cypress = versions_1.cypressVersion;
+        // The user explicitly asked for cypress, and its postinstall downloads
+        // the binary it needs to run at all, so enable it — npm and yarn run it
+        // unconditionally. Transitive deps stay denied.
+        (0, internal_1.acknowledgeBuildScripts)(tree, (0, devkit_1.detectPackageManager)(tree.root), {
+            cypress: true,
+        });
     }
     tasks.push((0, devkit_1.addDependenciesToPackageJson)(tree, {}, devDependencies, undefined, options.keepExistingVersions ?? true));
     return (0, devkit_1.runTasksInSerial)(...tasks);

package/dist/src/plugins/plugin.js

@@ -5,10 +5,6 @@ const internal_1 = require("@nx/devkit/internal");
 const devkit_1 = require("@nx/devkit");
 const js_1 = require("@nx/js");
 const fs_1 = require("fs");
-const devkit_internals_1 = require("nx/src/devkit-internals");
-const cache_directory_1 = require("nx/src/utils/cache-directory");
-const plugin_cache_utils_1 = require("nx/src/utils/plugin-cache-utils");
-const workspace_context_1 = require("nx/src/utils/workspace-context");
 const path_1 = require("path");
 const constants_1 = require("../utils/constants");
 const cypressConfigGlob = '**/cypress.config.{js,ts,mjs,cjs}';
@@ -25,9 +21,9 @@ const defaultPatterns = {
 exports.createNodes = [
     cypressConfigGlob,
     async (configFiles, options, context) => {
-        const optionsHash = (0, devkit_internals_1.hashObject)(options);
-        const cachePath = (0, path_1.join)(cache_directory_1.workspaceDataDirectory, `cypress-${optionsHash}.hash`);
-        const pluginCache = new plugin_cache_utils_1.PluginCache(cachePath);
+        const optionsHash = (0, internal_1.hashObject)(options);
+        const cachePath = (0, path_1.join)(internal_1.workspaceDataDirectory, `cypress-${optionsHash}.hash`);
+        const pluginCache = new internal_1.PluginCache(cachePath);
         const packageManager = (0, devkit_1.detectPackageManager)(context.workspaceRoot);
         const pmc = (0, devkit_1.getPackageManagerCommand)(packageManager);
         const lockFileName = (0, js_1.getLockFileName)(packageManager);
@@ -490,7 +486,7 @@ async function getSpecFilesAndPatternsForTestType(cypressConfig, testType, works
     const excludeSpecPatterns = Array.isArray(excludeSpecPattern)
         ? excludeSpecPattern.map((p) => (0, path_1.join)(projectRoot, p))
         : [(0, path_1.join)(projectRoot, excludeSpecPattern)];
-    const specFiles = await (0, workspace_context_1.globWithWorkspaceContext)(workspaceRoot, specPatterns, excludeSpecPatterns);
+    const specFiles = await (0, internal_1.globWithWorkspaceContext)(workspaceRoot, specPatterns, excludeSpecPatterns);
     return { specFiles, specPatterns, excludeSpecPatterns };
 }
 async function filterCypressConfigs(configFiles, context) {

package/dist/src/utils/add-linter.d.ts

@@ -3,6 +3,10 @@ import { Linter, LinterType } from '@nx/eslint';
 export interface CyLinterOptions {
     project: string;
     linter: Linter | LinterType;
+    enableTypedLinting?: boolean;
+    /**
+     * @deprecated Use `enableTypedLinting` instead. This option will be removed in Nx v24.
+     */
     setParserOptionsProject?: boolean;
     skipPackageJson?: boolean;
     rootProject?: boolean;

package/dist/src/utils/add-linter.js

@@ -12,13 +12,14 @@ async function addLinterToCyProject(tree, options) {
     const tasks = [];
     const projectConfig = (0, devkit_1.readProjectConfiguration)(tree, options.project);
     const eslintFile = (0, internal_1.findEslintFile)(tree, projectConfig.root);
+    const enableTypedLinting = (0, internal_1.isTypedLintingEnabled)(options);
     if (!eslintFile) {
         tasks.push(await (0, eslint_1.lintProjectGenerator)(tree, {
             project: options.project,
             linter: options.linter,
             skipFormat: true,
             tsConfigPaths: [(0, devkit_1.joinPathFragments)(projectConfig.root, 'tsconfig.json')],
-            setParserOptionsProject: options.setParserOptionsProject,
+            enableTypedLinting,
             skipPackageJson: options.skipPackageJson,
             rootProject: options.rootProject,
             addPlugin: options.addPlugin,
@@ -35,7 +36,8 @@ async function addLinterToCyProject(tree, options) {
     if ((0, internal_1.isEslintConfigSupported)(tree, projectConfig.root) ||
         (0, internal_1.isEslintConfigSupported)(tree)) {
         const overrides = [];
-        if ((0, internal_1.useFlatConfig)(tree)) {
+        const isFlatConfig = (0, internal_1.useFlatConfig)(tree);
+        if (isFlatConfig) {
             (0, internal_1.addPredefinedConfigToFlatLintConfig)(tree, projectConfig.root, 'recommended', {
                 moduleName: 'cypress',
                 moduleImportPath: 'eslint-plugin-cypress/flat',
@@ -67,39 +69,44 @@ async function addLinterToCyProject(tree, options) {
                 'no-undef': 'off',
             },
         };
+        // For flat configs typed linting is handled by `lintProjectGenerator` via
+        // `parserOptions.projectService`, so we don't emit `parserOptions.project`
+        // here. Legacy `.eslintrc` configs are JSON, which can't express the
+        // `__dirname` that `tsconfigRootDir` needs, so they keep `project`.
+        const legacyParserOptions = !isFlatConfig && enableTypedLinting
+            ? { project: `${projectConfig.root}/tsconfig.*?.json` }
+            : undefined;
         if (options.overwriteExisting) {
             overrides.unshift({
-                files: (0, internal_1.useFlatConfig)(tree)
+                files: isFlatConfig
                     ? // For flat configs we don't need to specify the files
                         undefined
                     : ['*.ts', '*.tsx', '*.js', '*.jsx'],
-                parserOptions: !options.setParserOptionsProject
-                    ? undefined
-                    : {
-                        project: `${projectConfig.root}/tsconfig.*?.json`,
-                    },
+                parserOptions: legacyParserOptions,
                 rules: {},
             });
             (0, internal_1.replaceOverridesInLintConfig)(tree, projectConfig.root, overrides);
         }
         else {
             overrides.unshift({
-                files: (0, internal_1.useFlatConfig)(tree)
+                files: isFlatConfig
                     ? // For flat configs we don't need to specify the files
                         undefined
                     : [
                         '*.cy.{ts,js,tsx,jsx}',
                         `${options.cypressDir}/**/*.{ts,js,tsx,jsx}`,
                     ],
-                parserOptions: !options.setParserOptionsProject
-                    ? undefined
-                    : {
-                        project: `${projectConfig.root}/tsconfig.*?.json`,
-                    },
+                parserOptions: legacyParserOptions,
                 rules: {},
             });
             overrides.forEach((override) => (0, internal_1.addOverrideToLintConfig)(tree, projectConfig.root, override));
         }
+        // `lintProjectGenerator` only sets up the projectService block when it
+        // creates the config, and `replaceOverridesInLintConfig` strips it. For a
+        // flat config, re-add it here when typed linting is enabled.
+        if (isFlatConfig && enableTypedLinting) {
+            (0, internal_1.addTypedLintingToFlatConfig)(tree, projectConfig.root);
+        }
     }
     return (0, devkit_1.runTasksInSerial)(...tasks);
 }

package/dist/src/utils/config.js

@@ -131,7 +131,10 @@ ${jitComment}
 }`;
         });
     }
-    if (presetImportPath) {
+    // Re-running the generator must not prepend a second declaration - Cypress
+    // loads TS configs through esbuild, which rejects duplicate bindings.
+    const isPresetAlreadyDeclared = tsquery.query(updatedConfigContents, ':matches(ImportSpecifier, BindingElement) Identifier[name="nxComponentTestingPreset"]').length > 0;
+    if (presetImportPath && !isPresetAlreadyDeclared) {
         // Use the path verbatim - callers pass the public exported subpath. Don't
         // append `.js`: @nx/react and @nx/angular's package exports only declare
         // the bare `./plugins/component-testing` subpath, so a `.js` suffix

package/dist/src/utils/ct-helpers.js

@@ -8,9 +8,7 @@ exports.createExecutorContext = createExecutorContext;
 const devkit_1 = require("@nx/devkit");
 const path_1 = require("path");
 const fs_1 = require("fs");
-const find_project_for_path_1 = require("nx/src/project-graph/utils/find-project-for-path");
-const project_graph_1 = require("nx/src/project-graph/project-graph");
-const configuration_1 = require("nx/src/config/configuration");
+const internal_1 = require("@nx/devkit/internal");
 exports.CY_FILE_MATCHER = new RegExp(/\.cy\.[tj]sx?$/);
 /**
  * return a path to a temp css file
@@ -55,8 +53,8 @@ function getProjectConfigByPath(graph, configPath) {
     const normalizedPathFromWorkspaceRoot = (0, devkit_1.normalizePath)((0, fs_1.lstatSync)(configPath).isFile()
         ? configFileFromWorkspaceRoot.replace((0, path_1.extname)(configPath), '')
         : configFileFromWorkspaceRoot);
-    const projectRootMappings = (0, find_project_for_path_1.createProjectRootMappings)(graph.nodes);
-    const componentTestingProjectName = (0, find_project_for_path_1.findProjectForPath)(normalizedPathFromWorkspaceRoot, projectRootMappings);
+    const projectRootMappings = (0, internal_1.createProjectRootMappings)(graph.nodes);
+    const componentTestingProjectName = (0, internal_1.findProjectForPath)(normalizedPathFromWorkspaceRoot, projectRootMappings);
     if (!componentTestingProjectName ||
         !graph.nodes[componentTestingProjectName]?.data) {
         throw new Error((0, devkit_1.stripIndents) `Unable to find the project configuration that includes ${normalizedPathFromWorkspaceRoot}. 
@@ -69,8 +67,8 @@ function getProjectConfigByPath(graph, configPath) {
     return graph.nodes[componentTestingProjectName].data;
 }
 function createExecutorContext(graph, targets, projectName, targetName, configurationName) {
-    const projectsConfigurations = (0, project_graph_1.readProjectsConfigurationFromProjectGraph)(graph);
-    const nxJsonConfiguration = (0, configuration_1.readNxJson)();
+    const projectsConfigurations = (0, devkit_1.readProjectsConfigurationFromProjectGraph)(graph);
+    const nxJsonConfiguration = (0, internal_1.readNxJsonFromDisk)();
     return {
         cwd: process.cwd(),
         projectGraph: graph,

package/dist/src/utils/find-target-options.js

@@ -2,8 +2,7 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.findBuildConfig = findBuildConfig;
 const devkit_1 = require("@nx/devkit");
-const configuration_1 = require("nx/src/config/configuration");
-const project_graph_1 = require("nx/src/project-graph/project-graph");
+const internal_1 = require("@nx/devkit/internal");
 async function findBuildConfig(tree, options) {
     try {
         // attempt to use the provided target
@@ -118,8 +117,8 @@ function findTargetOptionsInProject(tree, graph, projectName, options) {
     }
 }
 function createExecutorContext(graph, targets, projectName, targetName, configurationName) {
-    const nxJsonConfiguration = (0, configuration_1.readNxJson)();
-    const projectsConfigurations = (0, project_graph_1.readProjectsConfigurationFromProjectGraph)(graph);
+    const nxJsonConfiguration = (0, internal_1.readNxJsonFromDisk)();
+    const projectsConfigurations = (0, devkit_1.readProjectsConfigurationFromProjectGraph)(graph);
     return {
         cwd: process.cwd(),
         projectGraph: graph,

package/dist/src/utils/start-dev-server.js

@@ -5,9 +5,9 @@ const tslib_1 = require("tslib");
 const devkit_1 = require("@nx/devkit");
 const path_1 = require("path");
 const detect_port_1 = tslib_1.__importDefault(require("detect-port"));
-const executor_utils_1 = require("nx/src/command-line/run/executor-utils");
 const fs_1 = require("fs");
 const os_1 = require("os");
+const internal_1 = require("@nx/devkit/internal");
 const PORT_LOCK_DIR = (0, path_1.join)((0, os_1.tmpdir)(), 'nx-cypress-port-locks');
 async function* startDevServer(opts, context) {
     // no dev server, return the provisioned base url
@@ -136,8 +136,8 @@ ${e.message || e}`);
         // so we double check the schema if readTargetOptions didn't return a value for the property
         const projectConfig = context.projectsConfigurations?.projects?.[target.project];
         const targetConfig = projectConfig.targets[target.target];
-        const [collection, executor] = (0, executor_utils_1.parseExecutor)(targetConfig.executor);
-        const { schema } = (0, executor_utils_1.getExecutorInformation)(collection, executor, context.root, context.projectsConfigurations.projects);
+        const [collection, executor] = (0, internal_1.parseExecutor)(targetConfig.executor);
+        const { schema } = (0, internal_1.getExecutorInformation)(collection, executor, context.root, context.projectsConfigurations.projects);
         // NOTE: schema won't have a default since readTargetOptions would have
         // already set that and this check wouldn't need to be made
         targetHasOpt = Object.keys(schema.properties).includes(property);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/cypress",
-  "version": "23.1.0",
+  "version": "23.1.2",
   "private": false,
   "type": "commonjs",
   "files": [
@@ -89,12 +89,12 @@
     "semver": "^7.6.3",
     "tree-kill": "^1.2.2",
     "tslib": "^2.3.0",
-    "@nx/devkit": "23.1.0",
-    "@nx/eslint": "23.1.0",
-    "@nx/js": "23.1.0"
+    "@nx/devkit": "23.1.2",
+    "@nx/eslint": "23.1.2",
+    "@nx/js": "23.1.2"
   },
   "devDependencies": {
-    "nx": "23.1.0"
+    "nx": "23.1.2"
   },
   "peerDependencies": {
     "cypress": ">= 13 < 16"