@nx/cypress 17.2.6 → 17.3.0-beta.1

package/README.md

@@ -1,4 +1,9 @@
-<p style="text-align: center;"><img src="https://raw.githubusercontent.com/nrwl/nx/master/images/nx.png" width="600" alt="Nx - Smart, Fast and Extensible Build System"></p>
+<p style="text-align: center;">
+  <picture>
+    <source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/nrwl/nx/master/images/nx-dark.svg">
+    <img alt="Nx - Smart Monorepos · Fast CI" src="https://raw.githubusercontent.com/nrwl/nx/master/images/nx-light.svg" width="100%">
+  </picture>
+</p>
 
 <div style="text-align: center;">
 
@@ -15,9 +20,9 @@
 
 <hr>
 
-# Nx: Smart, Fast and Extensible Build System
+# Nx: Smart Monorepos · Fast CI
 
-Nx is a next generation build system with first class monorepo support and powerful integrations.
+Nx is a build system with built-in tooling and advanced CI capabilities. It helps you maintain and scale monorepos, both locally and on CI.
 
 This package is a [Cypress plugin for Nx](https://nx.dev/cypress/overview).
 
@@ -59,5 +64,5 @@ npx nx@latest init
 - [Blog Posts About Nx](https://blog.nrwl.io/nx/home)
 
 <p style="text-align: center;"><a href="https://nx.dev/#learning-materials" target="_blank" rel="noreferrer"><img src="https://raw.githubusercontent.com/nrwl/nx/master/images/nx-courses-and-videos.svg" 
-width="100%" alt="Nx - Smart, Fast and Extensible Build System"></a></p>
+width="100%" alt="Nx - Smart Monorepos · Fast CI"></a></p>
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/cypress",
-  "version": "17.2.6",
+  "version": "17.3.0-beta.1",
   "private": false,
   "description": "The Nx Plugin for Cypress contains executors and generators allowing your workspace to use the powerful Cypress integration testing capabilities.",
   "repository": {
@@ -34,14 +34,14 @@
     "migrations": "./migrations.json"
   },
   "dependencies": {
-    "@nx/devkit": "17.2.6",
-    "@nx/eslint": "17.2.6",
-    "@nx/js": "17.2.6",
+    "@nx/devkit": "17.3.0-beta.1",
+    "@nx/eslint": "17.3.0-beta.1",
+    "@nx/js": "17.3.0-beta.1",
     "@phenomnomnominal/tsquery": "~5.0.1",
     "detect-port": "^1.5.1",
     "semver": "7.5.3",
     "tslib": "^2.3.0",
-    "@nrwl/cypress": "17.2.6"
+    "@nrwl/cypress": "17.3.0-beta.1"
   },
   "peerDependencies": {
     "cypress": ">= 3 < 14"

package/src/generators/component-configuration/component-configuration.d.ts

@@ -1,5 +1,5 @@
 import { ProjectConfiguration, Tree } from '@nx/devkit';
 import { CypressComponentConfigurationSchema } from './schema';
-export declare function componentConfigurationGenerator(tree: Tree, options: CypressComponentConfigurationSchema): Promise<() => void>;
+export declare function componentConfigurationGenerator(tree: Tree, options: CypressComponentConfigurationSchema): Promise<import("@nx/devkit").GeneratorCallback>;
 export declare function updateTsConfigForComponentTesting(tree: Tree, projectConfig: ProjectConfiguration): void;
 export default componentConfigurationGenerator;

package/src/generators/component-configuration/component-configuration.js

@@ -22,9 +22,7 @@ async function componentConfigurationGenerator(tree, options) {
     if (!opts.skipFormat) {
         await (0, devkit_1.formatFiles)(tree);
     }
-    return () => {
-        installDepsTask();
-    };
+    return installDepsTask;
 }
 exports.componentConfigurationGenerator = componentConfigurationGenerator;
 function normalizeOptions(options) {

package/src/plugins/plugin.js

@@ -220,11 +220,18 @@ function getInputs(namedInputs) {
 /**
  * Load the module after ensuring that the require cache is cleared.
  */
+const packageInstallationDirectories = ['node_modules', '.yarn'];
 function load(path) {
     // Clear cache if the path is in the cache
     if (require.cache[path]) {
         for (const k of Object.keys(require.cache)) {
-            delete require.cache[k];
+            // We don't want to clear the require cache of installed packages.
+            // Clearing them can cause some issues when running Nx without the daemon
+            // and may cause issues for other packages that use the module state
+            // in some to store cached information.
+            if (!packageInstallationDirectories.some((dir) => k.includes(dir))) {
+                delete require.cache[k];
+            }
         }
     }
     // Then require

package/src/utils/ct-helpers.d.ts

@@ -11,6 +11,6 @@ export declare function getTempTailwindPath(context: ExecutorContext): string;
  * Checks if the childProjectName is a descendent of the parentProjectName
  * in the project graph
  **/
-export declare function isCtProjectUsingBuildProject(graph: ProjectGraph, parentProjectName: string, childProjectName: string): boolean;
+export declare function isCtProjectUsingBuildProject(graph: ProjectGraph, parentProjectName: string, childProjectName: string, seen?: Set<string>): boolean;
 export declare function getProjectConfigByPath(graph: ProjectGraph, configPath: string): ProjectConfiguration;
 export declare function createExecutorContext(graph: ProjectGraph, targets: Record<string, TargetConfiguration>, projectName: string, targetName: string, configurationName: string): ExecutorContext;

package/src/utils/ct-helpers.js

@@ -30,14 +30,18 @@ exports.getTempTailwindPath = getTempTailwindPath;
  * Checks if the childProjectName is a descendent of the parentProjectName
  * in the project graph
  **/
-function isCtProjectUsingBuildProject(graph, parentProjectName, childProjectName) {
+function isCtProjectUsingBuildProject(graph, parentProjectName, childProjectName, seen = new Set()) {
+    if (seen.has(parentProjectName)) {
+        return false;
+    }
+    seen.add(parentProjectName);
     const isProjectDirectDep = graph.dependencies[parentProjectName].some((p) => p.target === childProjectName);
     if (isProjectDirectDep) {
         return true;
     }
     const maybeIntermediateProjects = graph.dependencies[parentProjectName].filter((p) => !graph.externalNodes[p.target]);
     for (const maybeIntermediateProject of maybeIntermediateProjects) {
-        if (isCtProjectUsingBuildProject(graph, maybeIntermediateProject.target, childProjectName)) {
+        if (isCtProjectUsingBuildProject(graph, maybeIntermediateProject.target, childProjectName, seen)) {
             return true;
         }
     }