@nx/cypress 17.2.0-beta.1 → 17.2.0-beta.11

package/migrations.json

@@ -47,16 +47,6 @@
       "version": "16.8.0-beta.4",
       "description": "Update to Cypress v13. Most noteable change is video recording is off by default. This migration will only update if the workspace is already on Cypress v12. https://docs.cypress.io/guides/references/migration-guide#Migrating-to-Cypress-130",
       "implementation": "./src/migrations/update-16-8-0/cypress-13"
-    },
-    "add-nx-metadata": {
-      "version": "17.2.0-beta.0",
-      "description": "Add devServerTargets into cypress.config.ts files for @nx/cypress/plugin",
-      "implementation": "./src/migrations/update-17-2-0/add-dev-server-targets-to-cypress-configs"
-    },
-    "add-nx-cypress-plugin": {
-      "version": "17.2.0-beta.0",
-      "description": "Add the @nx/cypress/plugin to nx.json plugins",
-      "implementation": "./src/migrations/update-17-2-0/add-nx-cypress-plugin"
     }
   },
   "packageJsonUpdates": {
@@ -92,6 +82,15 @@
           "alwaysAddToPackageJson": false
         }
       }
+    },
+    "17.2.0-beta.2": {
+      "version": "17.2.0-beta.2",
+      "packages": {
+        "vite": {
+          "version": "^5.0.0",
+          "alwaysAddToPackageJson": false
+        }
+      }
     }
   }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/cypress",
-  "version": "17.2.0-beta.1",
+  "version": "17.2.0-beta.11",
   "private": false,
   "description": "The Nx Plugin for Cypress contains executors and generators allowing your workspace to use the powerful Cypress integration testing capabilities.",
   "repository": {
@@ -34,14 +34,14 @@
     "migrations": "./migrations.json"
   },
   "dependencies": {
-    "@nx/devkit": "17.2.0-beta.1",
-    "@nx/eslint": "17.2.0-beta.1",
-    "@nx/js": "17.2.0-beta.1",
+    "@nx/devkit": "17.2.0-beta.11",
+    "@nx/eslint": "17.2.0-beta.11",
+    "@nx/js": "17.2.0-beta.11",
     "@phenomnomnominal/tsquery": "~5.0.1",
     "detect-port": "^1.5.1",
     "semver": "7.5.3",
     "tslib": "^2.3.0",
-    "@nrwl/cypress": "17.2.0-beta.1"
+    "@nrwl/cypress": "17.2.0-beta.11"
   },
   "peerDependencies": {
     "cypress": ">= 3 < 14"

package/plugins/cypress-preset.d.ts

@@ -32,6 +32,17 @@ export declare function nxBaseCypressPreset(pathToConfig: string, options?: {
  *
  */
 export declare function nxE2EPreset(pathToConfig: string, options?: NxCypressE2EPresetOptions): any;
+export interface WebServerConfig {
+    /**
+     * Timeout to wait for the webserver to start listening
+     */
+    timeout?: number;
+    /**
+     * Reuse an existing web server if it exists
+     * If this is false, an error will be thrown if the server is already running
+     */
+    reuseExistingServer?: boolean;
+}
 export type NxCypressE2EPresetOptions = {
     bundler?: string;
     /**
@@ -40,7 +51,8 @@ export type NxCypressE2EPresetOptions = {
      * default is 'src'
      **/
     cypressDir?: string;
-    devServerTargets?: Record<string, string>;
-    ciDevServerTarget?: string;
+    webServerCommands?: Record<string, string>;
+    ciWebServerCommand?: string;
+    webServerConfig?: WebServerConfig;
 };
 export {};

package/plugins/cypress-preset.js

@@ -5,8 +5,9 @@ const devkit_1 = require("@nx/devkit");
 const path_1 = require("path");
 const fs_1 = require("fs");
 const preprocessor_vite_1 = require("../src/plugins/preprocessor-vite");
-const ct_helpers_1 = require("../src/utils/ct-helpers");
-const start_dev_server_1 = require("../src/utils/start-dev-server");
+const child_process_1 = require("child_process");
+const http_1 = require("http");
+const https_1 = require("https");
 function nxBaseCypressPreset(pathToConfig, options) {
     // used to set babel settings for react CT.
     process.env.NX_CYPRESS_COMPONENT_TEST =
@@ -27,6 +28,16 @@ function nxBaseCypressPreset(pathToConfig, options) {
     };
 }
 exports.nxBaseCypressPreset = nxBaseCypressPreset;
+function startWebServer(webServerCommand) {
+    const serverProcess = (0, child_process_1.exec)(webServerCommand, {
+        cwd: devkit_1.workspaceRoot,
+    });
+    serverProcess.stdout.pipe(process.stdout);
+    serverProcess.stderr.pipe(process.stderr);
+    return () => {
+        serverProcess.kill();
+    };
+}
 /**
  * nx E2E Preset for Cypress
  * @description
@@ -51,40 +62,79 @@ function nxE2EPreset(pathToConfig, options) {
         specPattern: `${basePath}/**/*.cy.{js,jsx,ts,tsx}`,
         fixturesFolder: `${basePath}/fixtures`,
         env: {
-            devServerTargets: options?.devServerTargets,
-            devServerTargetOptions: {},
-            ciDevServerTarget: options?.ciDevServerTarget,
+            webServerCommand: options?.webServerCommands?.default,
+            webServerCommands: options?.webServerCommands,
+            ciWebServerCommand: options?.ciWebServerCommand,
         },
         async setupNodeEvents(on, config) {
             if (options?.bundler === 'vite') {
                 on('file:preprocessor', (0, preprocessor_vite_1.default)());
             }
-            if (!config.env.devServerTargets) {
+            if (!config.env.webServerCommands) {
                 return;
             }
-            const devServerTarget = config.env.devServerTarget ?? config.env.devServerTargets['default'];
-            if (!devServerTarget) {
+            const webServerCommand = config.env.webServerCommand;
+            if (!webServerCommand) {
                 return;
             }
-            if (!config.baseUrl && devServerTarget) {
-                const graph = await (0, devkit_1.createProjectGraphAsync)();
-                const target = (0, devkit_1.parseTargetString)(devServerTarget, graph);
-                const context = (0, ct_helpers_1.createExecutorContext)(graph, graph.nodes[target.project].data?.targets, target.project, target.target, target.configuration);
-                const devServer = (0, start_dev_server_1.startDevServer)({
-                    devServerTarget,
-                    ...config.env.devServerTargetOptions,
-                }, context);
+            if (config.baseUrl && webServerCommand) {
+                if (await isServerUp(config.baseUrl)) {
+                    if (options?.webServerConfig?.reuseExistingServer === undefined
+                        ? true
+                        : options.webServerConfig.reuseExistingServer) {
+                        console.log(`Reusing the server already running on ${config.baseUrl}`);
+                        return;
+                    }
+                    else {
+                        throw new Error(`Web server is already running at ${config.baseUrl}`);
+                    }
+                }
+                const killWebServer = startWebServer(webServerCommand);
                 on('after:run', () => {
-                    devServer.return();
+                    killWebServer();
                 });
-                const devServerValue = (await devServer.next()).value;
-                if (!devServerValue) {
-                    return;
-                }
-                return { ...config, baseUrl: devServerValue.baseUrl };
+                await waitForServer(config.baseUrl, options.webServerConfig);
             }
         },
     };
     return baseConfig;
 }
 exports.nxE2EPreset = nxE2EPreset;
+function waitForServer(url, webServerConfig) {
+    return new Promise((resolve, reject) => {
+        let pollTimeout;
+        const { protocol } = new URL(url);
+        const timeoutDuration = webServerConfig?.timeout ?? 5 * 1000;
+        const timeout = setTimeout(() => {
+            clearTimeout(pollTimeout);
+            reject(new Error(`Web server failed to start in ${timeoutDuration}ms. This can be configured in cypress.config.ts.`));
+        }, timeoutDuration);
+        const makeRequest = protocol === 'https:' ? https_1.request : http_1.request;
+        function pollForServer() {
+            const request = makeRequest(url, () => {
+                clearTimeout(timeout);
+                resolve();
+            });
+            request.on('error', () => {
+                pollTimeout = setTimeout(pollForServer, 100);
+            });
+            // Don't forget to end the request
+            request.end();
+        }
+        pollForServer();
+    });
+}
+function isServerUp(url) {
+    const { protocol } = new URL(url);
+    const makeRequest = protocol === 'https:' ? https_1.request : http_1.request;
+    return new Promise((resolve) => {
+        const request = makeRequest(url, () => {
+            resolve(true);
+        });
+        request.on('error', () => {
+            resolve(false);
+        });
+        // Don't forget to end the request
+        request.end();
+    });
+}

package/src/executors/cypress/cypress.impl.js

@@ -109,9 +109,6 @@ async function runCypress(baseUrl, opts) {
     if (opts.browser) {
         options.browser = opts.browser;
     }
-    options.env = {
-        devServerTarget: opts.devServerTarget,
-    };
     if (opts.env) {
         options.env = {
             ...options.env,

package/src/generators/configuration/configuration.js

@@ -95,28 +95,28 @@ async function addFiles(tree, options, projectGraph, hasPlugin) {
             jsx: options.jsx,
         });
         const cyFile = (0, devkit_1.joinPathFragments)(projectConfig.root, 'cypress.config.ts');
-        let devServerTargets;
+        let webServerCommands;
         let ciDevServerTarget;
-        if (hasPlugin && !options.baseUrl && options.devServerTarget) {
-            devServerTargets = {};
-            devServerTargets.default = options.devServerTarget;
+        if (hasPlugin && options.devServerTarget) {
+            webServerCommands = {};
+            webServerCommands.default = 'nx run ' + options.devServerTarget;
             const parsedTarget = (0, devkit_1.parseTargetString)(options.devServerTarget, projectGraph);
             const devServerProjectConfig = (0, devkit_1.readProjectConfiguration)(tree, parsedTarget.project);
             // Add production e2e target if serve target is found
             if (parsedTarget.configuration !== 'production' &&
                 devServerProjectConfig.targets[parsedTarget.target]?.configurations?.['production']) {
-                devServerTargets.production = `${parsedTarget.project}:${parsedTarget.target}:production`;
+                webServerCommands.production = `nx run ${parsedTarget.project}:${parsedTarget.target}:production`;
             }
             // Add ci/static e2e target if serve target is found
             if (devServerProjectConfig.targets?.['serve-static']) {
-                ciDevServerTarget = `${parsedTarget.project}:serve-static`;
+                ciDevServerTarget = `nx run ${parsedTarget.project}:serve-static`;
             }
         }
         const updatedCyConfig = await (0, config_1.addDefaultE2EConfig)(tree.read(cyFile, 'utf-8'), {
             cypressDir: options.directory,
             bundler: options.bundler === 'vite' ? 'vite' : undefined,
-            devServerTargets,
-            ciDevServerTarget: ciDevServerTarget,
+            webServerCommands,
+            ciWebServerCommand: ciDevServerTarget,
         }, options.baseUrl);
         tree.write(cyFile, updatedCyConfig);
     }
@@ -148,13 +148,7 @@ function addTarget(tree, opts) {
             testingType: 'e2e',
         },
     };
-    if (opts.baseUrl) {
-        projectConfig.targets.e2e.options = {
-            ...projectConfig.targets.e2e.options,
-            baseUrl: opts.baseUrl,
-        };
-    }
-    else if (opts.devServerTarget) {
+    if (opts.devServerTarget) {
         const parsedTarget = (0, devkit_1.parseTargetString)(opts.devServerTarget);
         projectConfig.targets.e2e.options = {
             ...projectConfig.targets.e2e.options,
@@ -178,6 +172,12 @@ function addTarget(tree, opts) {
             };
         }
     }
+    else if (opts.baseUrl) {
+        projectConfig.targets.e2e.options = {
+            ...projectConfig.targets.e2e.options,
+            baseUrl: opts.baseUrl,
+        };
+    }
     (0, devkit_1.updateProjectConfiguration)(tree, opts.project, projectConfig);
 }
 exports.default = configurationGenerator;

package/src/plugins/plugin.js

@@ -36,7 +36,9 @@ exports.createNodes = [
             !siblingFiles.includes('project.json')) {
             return {};
         }
-        const hash = (0, calculate_hash_for_create_nodes_1.calculateHashForCreateNodes)(projectRoot, options, context);
+        const hash = (0, calculate_hash_for_create_nodes_1.calculateHashForCreateNodes)(projectRoot, options, context, [
+            (0, js_1.getLockFileName)((0, devkit_1.detectPackageManager)(context.workspaceRoot)),
+        ]);
         const targets = targetsCache[hash]
             ? targetsCache[hash]
             : buildCypressTargets(configFilePath, projectRoot, options, context);
@@ -61,7 +63,7 @@ function getOutputs(projectRoot, cypressConfig, testingType) {
         }
     }
     const { screenshotsFolder, videosFolder, e2e, component } = cypressConfig;
-    const outputs = ['{options.videosFolder}', '{options.screenshotsFolder}'];
+    const outputs = [];
     if (videosFolder) {
         outputs.push(getOutput(videosFolder));
     }
@@ -92,55 +94,44 @@ function getOutputs(projectRoot, cypressConfig, testingType) {
 }
 function buildCypressTargets(configFilePath, projectRoot, options, context) {
     const cypressConfig = getCypressConfig(configFilePath, context);
-    const namedInputs = (0, get_named_inputs_1.getNamedInputs)(projectRoot, context);
-    const baseTargetConfig = {
-        executor: '@nx/cypress:cypress',
-        options: {
-            cypressConfig: configFilePath,
-        },
+    const cypressEnv = {
+        ...cypressConfig.env,
+        ...cypressConfig.e2e?.env,
     };
+    const webServerCommands = cypressEnv?.webServerCommands;
+    const relativeConfigPath = (0, path_1.relative)(projectRoot, configFilePath);
+    const namedInputs = (0, get_named_inputs_1.getNamedInputs)(projectRoot, context);
     const targets = {};
     if ('e2e' in cypressConfig) {
-        const e2eTargetDefaults = (0, project_configuration_utils_1.readTargetDefaultsForTarget)(options.targetName, context.nxJsonConfiguration.targetDefaults, '@nx/cypress:cypress');
         targets[options.targetName] = {
-            ...baseTargetConfig,
+            command: `cypress run --config-file ${relativeConfigPath} --e2e`,
             options: {
-                ...baseTargetConfig.options,
-                testingType: 'e2e',
+                cwd: projectRoot,
             },
         };
+        const e2eTargetDefaults = (0, project_configuration_utils_1.readTargetDefaultsForTarget)(options.targetName, context.nxJsonConfiguration.targetDefaults, 'run-commands');
         if (e2eTargetDefaults?.cache === undefined) {
             targets[options.targetName].cache = true;
         }
         if (e2eTargetDefaults?.inputs === undefined) {
-            targets[options.targetName].inputs =
-                'production' in namedInputs
-                    ? ['default', '^production']
-                    : ['default', '^default'];
+            targets[options.targetName].inputs = getInputs(namedInputs);
         }
         if (e2eTargetDefaults?.outputs === undefined) {
             targets[options.targetName].outputs = getOutputs(projectRoot, cypressConfig, 'e2e');
         }
-        const cypressEnv = {
-            ...cypressConfig.env,
-            ...cypressConfig.e2e?.env,
-        };
-        const devServerTargets = cypressEnv?.devServerTargets;
-        if (devServerTargets?.default) {
-            targets[options.targetName].options.devServerTarget =
-                devServerTargets.default;
-            delete devServerTargets.default;
+        if (webServerCommands?.default) {
+            delete webServerCommands.default;
         }
-        if (Object.keys(devServerTargets ?? {}).length > 0) {
+        if (Object.keys(webServerCommands ?? {}).length > 0) {
             targets[options.targetName].configurations ??= {};
-            for (const [configuration, devServerTarget] of Object.entries(devServerTargets ?? {})) {
+            for (const [configuration, webServerCommand] of Object.entries(webServerCommands ?? {})) {
                 targets[options.targetName].configurations[configuration] = {
-                    devServerTarget,
+                    command: `cypress run --config-file ${relativeConfigPath} --e2e --env webServerCommand="${webServerCommand}"`,
                 };
             }
         }
-        const ciDevServerTarget = cypressEnv?.ciDevServerTarget;
-        if (ciDevServerTarget) {
+        const ciWebServerCommand = cypressEnv?.ciWebServerCommand;
+        if (ciWebServerCommand) {
             const specPatterns = Array.isArray(cypressConfig.e2e.specPattern)
                 ? cypressConfig.e2e.specPattern.map((p) => (0, path_1.join)(projectRoot, p))
                 : [(0, path_1.join)(projectRoot, cypressConfig.e2e.specPattern)];
@@ -153,21 +144,17 @@ function buildCypressTargets(configFilePath, projectRoot, options, context) {
             const specFiles = (0, workspace_context_1.globWithWorkspaceContext)(context.workspaceRoot, specPatterns, excludeSpecPatterns);
             const dependsOn = [];
             const outputs = getOutputs(projectRoot, cypressConfig, 'e2e');
-            const inputs = 'production' in namedInputs
-                ? ['default', '^production']
-                : ['default', '^default'];
+            const inputs = getInputs(namedInputs);
             for (const file of specFiles) {
-                const targetName = options.ciTargetName + '--' + file;
+                const relativeSpecFilePath = (0, path_1.relative)(projectRoot, file);
+                const targetName = options.ciTargetName + '--' + relativeSpecFilePath;
                 targets[targetName] = {
-                    ...targets[options.targetName],
                     outputs,
                     inputs,
                     cache: true,
-                    configurations: undefined,
+                    command: `cypress run --config-file ${relativeConfigPath} --e2e --env webServerCommand="${ciWebServerCommand}" --spec ${relativeSpecFilePath}`,
                     options: {
-                        ...targets[options.targetName].options,
-                        devServerTarget: ciDevServerTarget,
-                        spec: file,
+                        cwd: projectRoot,
                     },
                 };
                 dependsOn.push({
@@ -187,13 +174,12 @@ function buildCypressTargets(configFilePath, projectRoot, options, context) {
         }
     }
     if ('component' in cypressConfig) {
-        const componentTestingTargetDefaults = (0, project_configuration_utils_1.readTargetDefaultsForTarget)(options.componentTestingTargetName, context.nxJsonConfiguration.targetDefaults, '@nx/cypress:cypress');
+        const componentTestingTargetDefaults = (0, project_configuration_utils_1.readTargetDefaultsForTarget)(options.componentTestingTargetName, context.nxJsonConfiguration.targetDefaults, 'nx:run-commands');
         // This will not override the e2e target if it is the same
         targets[options.componentTestingTargetName] ??= {
-            ...baseTargetConfig,
+            command: `cypress open --config-file ${relativeConfigPath} --component`,
             options: {
-                ...baseTargetConfig.options,
-                testingType: 'component',
+                cwd: projectRoot,
             },
         };
         if (componentTestingTargetDefaults?.cache === undefined) {
@@ -201,9 +187,7 @@ function buildCypressTargets(configFilePath, projectRoot, options, context) {
         }
         if (componentTestingTargetDefaults?.inputs === undefined) {
             targets[options.componentTestingTargetName].inputs =
-                'production' in namedInputs
-                    ? ['default', '^production']
-                    : ['default', '^default'];
+                getInputs(namedInputs);
         }
         if (componentTestingTargetDefaults?.outputs === undefined) {
             targets[options.componentTestingTargetName].outputs = getOutputs(projectRoot, cypressConfig, 'component');
@@ -241,3 +225,13 @@ function normalizeOptions(options) {
     options.ciTargetName ??= 'e2e-ci';
     return options;
 }
+function getInputs(namedInputs) {
+    return [
+        ...('production' in namedInputs
+            ? ['default', '^production']
+            : ['default', '^default']),
+        {
+            externalDependencies: ['cypress'],
+        },
+    ];
+}

package/src/utils/add-linter.js

@@ -20,9 +20,6 @@ async function addLinterToCyProject(tree, options) {
             linter: options.linter,
             skipFormat: true,
             tsConfigPaths: [(0, devkit_1.joinPathFragments)(projectConfig.root, 'tsconfig.json')],
-            eslintFilePatterns: [
-                `${projectConfig.root}/**/*.${options.js ? 'js' : '{js,ts}'}`,
-            ],
             setParserOptionsProject: options.setParserOptionsProject,
             skipPackageJson: options.skipPackageJson,
             rootProject: options.rootProject,

package/src/utils/versions.d.ts

@@ -5,5 +5,5 @@ export declare const cypressViteDevServerVersion = "^2.2.1";
 export declare const cypressVersion = "^13.0.0";
 export declare const cypressWebpackVersion = "^2.0.0";
 export declare const webpackHttpPluginVersion = "^5.5.0";
-export declare const viteVersion = "~4.3.9";
+export declare const viteVersion = "^5.0.0";
 export declare const htmlWebpackPluginVersion = "^5.5.0";

package/src/utils/versions.js

@@ -8,5 +8,5 @@ exports.cypressViteDevServerVersion = '^2.2.1';
 exports.cypressVersion = '^13.0.0';
 exports.cypressWebpackVersion = '^2.0.0';
 exports.webpackHttpPluginVersion = '^5.5.0';
-exports.viteVersion = '~4.3.9';
+exports.viteVersion = '^5.0.0';
 exports.htmlWebpackPluginVersion = '^5.5.0';

package/src/migrations/update-17-2-0/add-dev-server-targets-to-cypress-configs.d.ts

@@ -1,2 +0,0 @@
-import { Tree } from '@nx/devkit';
-export default function update(tree: Tree): Promise<void>;

package/src/migrations/update-17-2-0/add-dev-server-targets-to-cypress-configs.js

@@ -1,125 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-const devkit_1 = require("@nx/devkit");
-const executor_options_utils_1 = require("@nx/devkit/src/generators/executor-options-utils");
-const typescript_1 = require("typescript");
-function addDevServerTargets(tree, cypressConfig, devServerTargets) {
-    const contents = tree.read(cypressConfig, 'utf-8');
-    const sourceFile = (0, typescript_1.createSourceFile)(cypressConfig, contents, typescript_1.ScriptTarget.ESNext);
-    const ciDevServerTarget = devServerTargets.ci;
-    delete devServerTargets.ci;
-    const changes = [];
-    const visit = (node) => {
-        if ((0, typescript_1.isCallExpression)(node) &&
-            (0, typescript_1.isIdentifier)(node.expression) &&
-            node.expression.text === 'nxE2EPreset') {
-            const argumentContents = ', ' +
-                JSON.stringify({
-                    devServerTargets,
-                    ciDevServerTarget,
-                });
-            if (node.arguments.length === 1) {
-                changes.push({
-                    type: devkit_1.ChangeType.Insert,
-                    index: node.arguments[0].getEnd(),
-                    text: argumentContents,
-                });
-            }
-            else {
-                const lastArgument = node.arguments[node.arguments.length - 1];
-                if ((0, typescript_1.isObjectLiteralExpression)(lastArgument)) {
-                    const lastProperty = lastArgument.properties[lastArgument.properties.length - 1];
-                    const trailingComma = lastArgument.properties.hasTrailingComma;
-                    changes.push({
-                        type: devkit_1.ChangeType.Insert,
-                        index: lastProperty.getEnd(),
-                        text: (trailingComma ? '' : ', ') +
-                            'devServerTargets: ' +
-                            JSON.stringify(devServerTargets) +
-                            (ciDevServerTarget
-                                ? `, ciDevServerTarget: '${ciDevServerTarget}'`
-                                : ''),
-                    });
-                }
-            }
-        }
-        else {
-            (0, typescript_1.forEachChild)(node, visit);
-        }
-    };
-    (0, typescript_1.forEachChild)(sourceFile, visit);
-    tree.write(cypressConfig, (0, devkit_1.applyChangesToString)(contents, changes));
-}
-async function update(tree) {
-    const projects = (0, devkit_1.getProjects)(tree);
-    const graph = await (0, devkit_1.createProjectGraphAsync)();
-    const devServerTargetsMap = new Map();
-    (0, executor_options_utils_1.forEachExecutorOptionsInGraph)(graph, '@nx/cypress:cypress', (options, project, target, configuration) => {
-        const targetConfig = projects.get(project).targets?.[target];
-        if (!targetConfig) {
-            return;
-        }
-        const cypressConfig = options.cypressConfig ?? targetConfig.options?.cypressConfig;
-        if (!cypressConfig) {
-            return;
-        }
-        const devServerTargets = {};
-        devServerTargets.default = targetConfig.options?.devServerTarget;
-        for (const [configuration, configurationOptions] of Object.entries(targetConfig.configurations ?? {})) {
-            devServerTargets[configuration] = configurationOptions.devServerTarget;
-        }
-        devServerTargetsMap.set(cypressConfig, devServerTargets);
-    });
-    for (const [cypressConfig, devServerTargets] of devServerTargetsMap) {
-        addDevServerTargets(tree, cypressConfig, devServerTargets);
-    }
-    // const configFiles = glob(tree, [createNodes[0]]);
-    //
-    // const proj = Object.fromEntries(getProjects(tree).entries());
-    //
-    // const rootMappings = createProjectRootMappingsFromProjectConfigurations(proj);
-    //
-    // for (const configFile of configFiles) {
-    //   const siblings = tree.children(dirname(configFile));
-    //   if (!siblings.includes('project.json')) {
-    //     continue;
-    //   }
-    //
-    //   const projectName = findProjectForPath(configFile, rootMappings);
-    //   const projectConfig = readProjectConfiguration(tree, projectName);
-    //   const e2eTarget: TargetConfiguration<CypressExecutorOptions> =
-    //     projectConfig.targets?.e2e;
-    //
-    //   if (!e2eTarget || e2eTarget.executor !== '@nx/cypress:cypress') {
-    //     continue;
-    //   }
-    //
-    //   nxMetadata.devServerTarget = e2eTarget.options?.devServerTarget;
-    //   nxMetadata.productionDevServerTarget =
-    //     e2eTarget.configurations?.production?.devServerTarget;
-    //   nxMetadata.ciDevServerTarget =
-    //     e2eTarget.configurations?.ci?.devServerTarget;
-    //
-    //   if (Object.values(nxMetadata).filter((v) => !!v).length > 0) {
-    //     let contents = tree.read(configFile, 'utf-8');
-    //
-    //     contents =
-    //       `import type { NxCypressMetadata } from '@nx/cypress/plugin';\n` +
-    //       contents +
-    //       `
-    //
-    //     /**
-    //      * This is metadata for the @nx/cypress/plugin
-    //      */
-    //     export const nx: NxCypressMetadata = ${JSON.stringify(
-    //       nxMetadata,
-    //       null,
-    //       2
-    //     )};`;
-    //
-    //     tree.write(configFile, contents);
-    //   }
-    // }
-    await (0, devkit_1.formatFiles)(tree);
-}
-exports.default = update;

package/src/migrations/update-17-2-0/add-nx-cypress-plugin.d.ts

@@ -1,2 +0,0 @@
-import { Tree } from '@nx/devkit';
-export default function update(tree: Tree): Promise<void>;

package/src/migrations/update-17-2-0/add-nx-cypress-plugin.js

@@ -1,16 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-const devkit_1 = require("@nx/devkit");
-const plugin_1 = require("../../plugins/plugin");
-const find_project_for_path_1 = require("nx/src/project-graph/utils/find-project-for-path");
-const replace_project_configuration_with_plugin_1 = require("@nx/devkit/src/utils/replace-project-configuration-with-plugin");
-async function update(tree) {
-    const proj = Object.fromEntries((0, devkit_1.getProjects)(tree).entries());
-    const rootMappings = (0, find_project_for_path_1.createProjectRootMappingsFromProjectConfigurations)(proj);
-    await (0, replace_project_configuration_with_plugin_1.replaceProjectConfigurationsWithPlugin)(tree, rootMappings, '@nx/cypress/plugin', plugin_1.createNodes, {
-        targetName: 'e2e',
-        componentTestingTargetName: 'component-test',
-    });
-    await (0, devkit_1.formatFiles)(tree);
-}
-exports.default = update;