@nx/cypress 17.0.3 → 17.0.4

package/LICENSE

@@ -1,6 +1,6 @@
 (The MIT License)
 
-Copyright (c) 2017-2023 Narwhal Technologies Inc.
+Copyright (c) 2017-2024 Narwhal Technologies Inc.
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

package/README.md

@@ -1,4 +1,9 @@
-<p style="text-align: center;"><img src="https://raw.githubusercontent.com/nrwl/nx/master/images/nx.png" width="600" alt="Nx - Smart, Fast and Extensible Build System"></p>
+<p style="text-align: center;">
+  <picture>
+    <source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/nrwl/nx/master/images/nx-dark.svg">
+    <img alt="Nx - Smart Monorepos · Fast CI" src="https://raw.githubusercontent.com/nrwl/nx/master/images/nx-light.svg" width="100%">
+  </picture>
+</p>
 
 <div style="text-align: center;">
 
@@ -15,9 +20,9 @@
 
 <hr>
 
-# Nx: Smart, Fast and Extensible Build System
+# Nx: Smart Monorepos · Fast CI
 
-Nx is a next generation build system with first class monorepo support and powerful integrations.
+Nx is a build system with built-in tooling and advanced CI capabilities. It helps you maintain and scale monorepos, both locally and on CI.
 
 This package is a [Cypress plugin for Nx](https://nx.dev/cypress/overview).
 
@@ -59,5 +64,5 @@ npx nx@latest init
 - [Blog Posts About Nx](https://blog.nrwl.io/nx/home)
 
 <p style="text-align: center;"><a href="https://nx.dev/#learning-materials" target="_blank" rel="noreferrer"><img src="https://raw.githubusercontent.com/nrwl/nx/master/images/nx-courses-and-videos.svg" 
-width="100%" alt="Nx - Smart, Fast and Extensible Build System"></a></p>
+width="100%" alt="Nx - Smart Monorepos · Fast CI"></a></p>
 

package/generators.json

@@ -3,7 +3,7 @@
   "version": "0.1",
   "generators": {
     "init": {
-      "factory": "./src/generators/init/init#cypressInitGenerator",
+      "factory": "./src/generators/init/init#cypressInitGeneratorInternal",
       "schema": "./src/generators/init/schema.json",
       "description": "Initialize the `@nrwl/cypress` plugin.",
       "aliases": ["ng-add"],
@@ -17,13 +17,13 @@
     },
     "configuration": {
       "aliases": ["cypress-e2e-configuration", "e2e", "e2e-config"],
-      "factory": "./src/generators/configuration/configuration",
+      "factory": "./src/generators/configuration/configuration#configurationGeneratorInternal",
       "schema": "./src/generators/configuration/schema.json",
       "description": "Add a Cypress E2E Configuration to an existing project."
     },
     "component-configuration": {
       "aliases": ["cypress-component-configuration"],
-      "factory": "./src/generators/component-configuration/component-configuration",
+      "factory": "./src/generators/component-configuration/component-configuration#componentConfigurationGeneratorInternal",
       "schema": "./src/generators/component-configuration/schema.json",
       "description": "Set up Cypress Component Test for a project",
       "hidden": true

package/index.d.ts

@@ -2,10 +2,10 @@ import { configurationGenerator } from './src/generators/configuration/configura
 import { componentConfigurationGenerator } from './src/generators/component-configuration/component-configuration';
 import { cypressProjectGenerator as _cypressProjectGenerator } from './src/generators/cypress-project/cypress-project';
 export { configurationGenerator, componentConfigurationGenerator };
-/** @deprecated Use `configurationGenerator` instead. It will be removed in Nx 18. */
+/** @deprecated Use `configurationGenerator` instead. It will be removed in Nx 19. */
 export declare const cypressComponentConfiguration: typeof componentConfigurationGenerator;
 export { configurationGenerator as cypressE2EConfigurationGenerator };
-/** @deprecated Add a new project and call `configurationGenerator` instead. It will be removed in Nx 18. */
+/** @deprecated Add a new project and call `configurationGenerator` instead. It will be removed in Nx 19. */
 export declare const cypressProjectGenerator: typeof _cypressProjectGenerator;
 export { cypressInitGenerator } from './src/generators/init/init';
 export { migrateCypressProject } from './src/generators/migrate-to-cypress-11/migrate-to-cypress-11';

package/index.js

@@ -8,11 +8,11 @@ const component_configuration_1 = require("./src/generators/component-configurat
 Object.defineProperty(exports, "componentConfigurationGenerator", { enumerable: true, get: function () { return component_configuration_1.componentConfigurationGenerator; } });
 const cypress_project_1 = require("./src/generators/cypress-project/cypress-project");
 // Maintain backwards compatibility with the old names in case community plugins used them.
-// TODO(v18): Remove old name
-/** @deprecated Use `configurationGenerator` instead. It will be removed in Nx 18. */
+// TODO(v19): Remove old name
+/** @deprecated Use `configurationGenerator` instead. It will be removed in Nx 19. */
 exports.cypressComponentConfiguration = component_configuration_1.componentConfigurationGenerator;
-// TODO(v18): Remove project generator
-/** @deprecated Add a new project and call `configurationGenerator` instead. It will be removed in Nx 18. */
+// TODO(v19): Remove project generator
+/** @deprecated Add a new project and call `configurationGenerator` instead. It will be removed in Nx 19. */
 exports.cypressProjectGenerator = cypress_project_1.cypressProjectGenerator;
 var init_1 = require("./src/generators/init/init");
 Object.defineProperty(exports, "cypressInitGenerator", { enumerable: true, get: function () { return init_1.cypressInitGenerator; } });

package/migrations.json

@@ -47,6 +47,12 @@
       "version": "16.8.0-beta.4",
       "description": "Update to Cypress v13. Most noteable change is video recording is off by default. This migration will only update if the workspace is already on Cypress v12. https://docs.cypress.io/guides/references/migration-guide#Migrating-to-Cypress-130",
       "implementation": "./src/migrations/update-16-8-0/cypress-13"
+    },
+    "update-cypress-version-13-6-6": {
+      "cli": "nx",
+      "version": "18.1.0-beta.3",
+      "description": "Update to Cypress ^13.6.6 if the workspace is using Cypress v13 to ensure workspaces don't use v13.6.5 which has an issue when verifying Cypress.",
+      "implementation": "./src/migrations/update-18-1-0/update-cypress-version-13-6-6"
     }
   },
   "packageJsonUpdates": {
@@ -82,6 +88,24 @@
           "alwaysAddToPackageJson": false
         }
       }
+    },
+    "17.2.0-beta.2": {
+      "version": "17.2.0-beta.2",
+      "packages": {
+        "vite": {
+          "version": "^5.0.0",
+          "alwaysAddToPackageJson": false
+        }
+      }
+    },
+    "17.3.0": {
+      "version": "17.3.0-beta.3",
+      "packages": {
+        "@types/node": {
+          "version": "18.16.9",
+          "alwaysAddToPackageJson": false
+        }
+      }
     }
   }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/cypress",
-  "version": "17.0.3",
+  "version": "17.0.4",
   "private": false,
   "description": "The Nx Plugin for Cypress contains executors and generators allowing your workspace to use the powerful Cypress integration testing capabilities.",
   "repository": {
@@ -34,14 +34,14 @@
     "migrations": "./migrations.json"
   },
   "dependencies": {
+    "@nx/devkit": "17.0.4",
+    "@nx/eslint": "17.0.4",
+    "@nx/js": "17.0.4",
     "@phenomnomnominal/tsquery": "~5.0.1",
     "detect-port": "^1.5.1",
-    "semver": "7.5.3",
+    "semver": "^7.5.3",
     "tslib": "^2.3.0",
-    "@nx/devkit": "17.0.3",
-    "@nx/js": "17.0.3",
-    "@nx/eslint": "17.0.3",
-    "@nrwl/cypress": "17.0.3"
+    "@nrwl/cypress": "17.0.4"
   },
   "peerDependencies": {
     "cypress": ">= 3 < 14"

package/plugin.d.ts

@@ -0,0 +1 @@
+export { createNodes, createDependencies } from './src/plugins/plugin';

package/plugin.js

@@ -0,0 +1,6 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.createDependencies = exports.createNodes = void 0;
+var plugin_1 = require("./src/plugins/plugin");
+Object.defineProperty(exports, "createNodes", { enumerable: true, get: function () { return plugin_1.createNodes; } });
+Object.defineProperty(exports, "createDependencies", { enumerable: true, get: function () { return plugin_1.createDependencies; } });

package/plugins/cypress-preset.d.ts

@@ -10,7 +10,9 @@ export interface NxComponentTestingOptions {
      * @example 'component-test'
      */
     ctTargetName?: string;
+    buildTarget?: string;
     bundler?: 'vite' | 'webpack';
+    compiler?: 'swc' | 'babel';
 }
 export declare function nxBaseCypressPreset(pathToConfig: string, options?: {
     testingType: 'component' | 'e2e';
@@ -29,26 +31,19 @@ export declare function nxBaseCypressPreset(pathToConfig: string, options?: {
  *   }
  * })
  *
- * @param pathToConfig will be used to construct the output paths for videos and screenshots
  */
-export declare function nxE2EPreset(pathToConfig: string, options?: NxCypressE2EPresetOptions): {
-    fileServerFolder: string;
-    supportFile: string;
-    specPattern: string;
-    fixturesFolder: string;
-    videosFolder: string;
-    screenshotsFolder: string;
-    chromeWebSecurity: boolean;
-} | {
-    setupNodeEvents(on: any): void;
-    fileServerFolder: string;
-    supportFile: string;
-    specPattern: string;
-    fixturesFolder: string;
-    videosFolder: string;
-    screenshotsFolder: string;
-    chromeWebSecurity: boolean;
-};
+export declare function nxE2EPreset(pathToConfig: string, options?: NxCypressE2EPresetOptions): any;
+export interface WebServerConfig {
+    /**
+     * Timeout to wait for the webserver to start listening
+     */
+    timeout?: number;
+    /**
+     * Reuse an existing web server if it exists
+     * If this is false, an error will be thrown if the server is already running
+     */
+    reuseExistingServer?: boolean;
+}
 export type NxCypressE2EPresetOptions = {
     bundler?: string;
     /**
@@ -57,5 +52,18 @@ export type NxCypressE2EPresetOptions = {
      * default is 'src'
      **/
     cypressDir?: string;
+    /**
+     * A map of commandName -> command to start the web server for testing.
+     * Currently only default is read.
+     */
+    webServerCommands?: Record<string, string>;
+    /**
+     * A command to start the web server - used for e2e tests distributed by Nx.
+     */
+    ciWebServerCommand?: string;
+    /**
+     * Configures how the web server command is started and monitored.
+     */
+    webServerConfig?: WebServerConfig;
 };
 export {};

package/plugins/cypress-preset.js

@@ -5,6 +5,10 @@ const devkit_1 = require("@nx/devkit");
 const path_1 = require("path");
 const fs_1 = require("fs");
 const preprocessor_vite_1 = require("../src/plugins/preprocessor-vite");
+const constants_1 = require("../src/utils/constants");
+const child_process_1 = require("child_process");
+const http_1 = require("http");
+const https_1 = require("https");
 function nxBaseCypressPreset(pathToConfig, options) {
     // used to set babel settings for react CT.
     process.env.NX_CYPRESS_COMPONENT_TEST =
@@ -25,6 +29,26 @@ function nxBaseCypressPreset(pathToConfig, options) {
     };
 }
 exports.nxBaseCypressPreset = nxBaseCypressPreset;
+function startWebServer(webServerCommand) {
+    const serverProcess = (0, child_process_1.spawn)(webServerCommand, {
+        cwd: devkit_1.workspaceRoot,
+        shell: true,
+        // Detaching the process on unix will create a process group, allowing us to kill it later
+        // Windows is fine so we leave it attached to this process
+        detached: process.platform !== 'win32',
+        stdio: 'inherit',
+    });
+    return () => {
+        if (process.platform === 'win32') {
+            serverProcess.kill();
+        }
+        else {
+            // child.kill() does not work on linux
+            // process.kill will kill the whole process group on unix
+            process.kill(-serverProcess.pid, 'SIGKILL');
+        }
+    };
+}
 /**
  * nx E2E Preset for Cypress
  * @description
@@ -39,25 +63,92 @@ exports.nxBaseCypressPreset = nxBaseCypressPreset;
  *   }
  * })
  *
- * @param pathToConfig will be used to construct the output paths for videos and screenshots
  */
 function nxE2EPreset(pathToConfig, options) {
     const basePath = options?.cypressDir || 'src';
-    const baseConfig = {
+    const baseConfig /*Cypress.EndToEndConfigOptions & {
+      [NX_PLUGIN_OPTIONS]: unknown;
+    }*/ = {
         ...nxBaseCypressPreset(pathToConfig),
         fileServerFolder: '.',
-        supportFile: `${basePath}/support/e2e.ts`,
+        supportFile: `${basePath}/support/e2e.{js,ts}`,
         specPattern: `${basePath}/**/*.cy.{js,jsx,ts,tsx}`,
         fixturesFolder: `${basePath}/fixtures`,
-    };
-    if (options?.bundler === 'vite') {
-        return {
-            ...baseConfig,
-            setupNodeEvents(on) {
+        [constants_1.NX_PLUGIN_OPTIONS]: {
+            webServerCommand: options?.webServerCommands?.default,
+            webServerCommands: options?.webServerCommands,
+            ciWebServerCommand: options?.ciWebServerCommand,
+        },
+        async setupNodeEvents(on, config) {
+            const webServerCommands = config.env?.webServerCommands ?? options?.webServerCommands;
+            const webServerCommand = config.env?.webServerCommand ?? webServerCommands?.default;
+            if (options?.bundler === 'vite') {
                 on('file:preprocessor', (0, preprocessor_vite_1.default)());
-            },
-        };
-    }
+            }
+            if (!options?.webServerCommands) {
+                return;
+            }
+            if (!webServerCommand) {
+                return;
+            }
+            if (config.baseUrl && webServerCommand) {
+                if (await isServerUp(config.baseUrl)) {
+                    if (options?.webServerConfig?.reuseExistingServer === undefined
+                        ? true
+                        : options.webServerConfig.reuseExistingServer) {
+                        console.log(`Reusing the server already running on ${config.baseUrl}`);
+                        return;
+                    }
+                    else {
+                        throw new Error(`Web server is already running at ${config.baseUrl}`);
+                    }
+                }
+                const killWebServer = startWebServer(webServerCommand);
+                on('after:run', () => {
+                    killWebServer();
+                });
+                await waitForServer(config.baseUrl, options.webServerConfig);
+            }
+        },
+    };
     return baseConfig;
 }
 exports.nxE2EPreset = nxE2EPreset;
+function waitForServer(url, webServerConfig) {
+    return new Promise((resolve, reject) => {
+        let pollTimeout;
+        const { protocol } = new URL(url);
+        const timeoutDuration = webServerConfig?.timeout ?? 60 * 1000;
+        const timeout = setTimeout(() => {
+            clearTimeout(pollTimeout);
+            reject(new Error(`Web server failed to start in ${timeoutDuration}ms. This can be configured in cypress.config.ts.`));
+        }, timeoutDuration);
+        const makeRequest = protocol === 'https:' ? https_1.request : http_1.request;
+        function pollForServer() {
+            const request = makeRequest(url, () => {
+                clearTimeout(timeout);
+                resolve();
+            });
+            request.on('error', () => {
+                pollTimeout = setTimeout(pollForServer, 100);
+            });
+            // Don't forget to end the request
+            request.end();
+        }
+        pollForServer();
+    });
+}
+function isServerUp(url) {
+    const { protocol } = new URL(url);
+    const makeRequest = protocol === 'https:' ? https_1.request : http_1.request;
+    return new Promise((resolve) => {
+        const request = makeRequest(url, () => {
+            resolve(true);
+        });
+        request.on('error', () => {
+            resolve(false);
+        });
+        // Don't forget to end the request
+        request.end();
+    });
+}

package/src/executors/cypress/cypress.impl.d.ts

@@ -25,7 +25,7 @@ export interface CypressExecutorOptions extends Json {
     copyFiles?: string;
     ciBuildId?: string | number;
     group?: string;
-    ignoreTestFiles?: string;
+    ignoreTestFiles?: string | string[];
     reporter?: string;
     reporterOptions?: string | Json;
     skipServe?: boolean;

package/src/executors/cypress/cypress.impl.js

@@ -1,19 +1,18 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 const devkit_1 = require("@nx/devkit");
-const executor_utils_1 = require("nx/src/command-line/run/executor-utils");
 const fs_1 = require("fs");
 const path_1 = require("path");
 const ct_helpers_1 = require("../../utils/ct-helpers");
 const cypress_version_1 = require("../../utils/cypress-version");
-const detectPort = require("detect-port");
+const start_dev_server_1 = require("../../utils/start-dev-server");
 const Cypress = require('cypress'); // @NOTE: Importing via ES6 messes the whole test dependencies.
 async function cypressExecutor(options, context) {
     options = normalizeOptions(options, context);
     // this is used by cypress component testing presets to build the executor contexts with the correct configuration options.
     process.env.NX_CYPRESS_TARGET_CONFIGURATION = context.configurationName;
     let success;
-    for await (const devServerValues of startDevServer(options, context)) {
+    for await (const devServerValues of (0, start_dev_server_1.startDevServer)(options, context)) {
         try {
             success = await runCypress(devServerValues.baseUrl, {
                 ...options,
@@ -90,50 +89,6 @@ A generator to migrate from v8 to v10 is provided. See https://nx.dev/cypress/v1
 `);
     }
 }
-async function* startDevServer(opts, context) {
-    // no dev server, return the provisioned base url
-    if (!opts.devServerTarget || opts.skipServe) {
-        yield { baseUrl: opts.baseUrl };
-        return;
-    }
-    const parsedDevServerTarget = (0, devkit_1.parseTargetString)(opts.devServerTarget, context);
-    const [targetSupportsWatchOpt] = getValueFromSchema(context, parsedDevServerTarget, 'watch');
-    const overrides = {
-        // @NOTE: Do not forward watch option if not supported by the target dev server,
-        //  this is relevant for running Cypress against dev server target that does not support this option,
-        //  for instance @nguniversal/builders:ssr-dev-server.
-        ...(targetSupportsWatchOpt ? { watch: opts.watch } : {}),
-    };
-    if (opts.port === 'cypress-auto') {
-        const freePort = await getPortForProject(context, parsedDevServerTarget);
-        overrides['port'] = freePort;
-    }
-    else if (opts.port !== undefined) {
-        overrides['port'] = opts.port;
-        // zero is a special case that means any valid port so there is no reason to try to 'lock it'
-        if (opts.port !== 0) {
-            const didLock = attemptToLockPort(opts.port);
-            if (!didLock) {
-                devkit_1.logger.warn((0, devkit_1.stripIndents) `${opts.port} is potentially already in use by another cypress run.
-If the port is in use, try using a different port value or passing --port='cypress-auto' to find a free port.`);
-            }
-        }
-    }
-    for await (const output of await (0, devkit_1.runExecutor)(parsedDevServerTarget, overrides, context)) {
-        if (!output.success && !opts.watch)
-            throw new Error('Could not compile application files');
-        if (!opts.baseUrl &&
-            !output.baseUrl &&
-            !output.info?.baseUrl &&
-            output.info?.port) {
-            output.baseUrl = `http://localhost:${output.info.port}`;
-        }
-        yield {
-            baseUrl: opts.baseUrl || output.baseUrl || output.info?.baseUrl,
-            portLockFilePath: overrides.port && (0, path_1.join)(__dirname, `${overrides.port}.txt`),
-        };
-    }
-}
 /**
  * @whatItDoes Initialize the Cypress test runner with the provided project configuration.
  * By default, Cypress will run tests from the CLI without the GUI and provide directly the results in the console output.
@@ -155,7 +110,10 @@ async function runCypress(baseUrl, opts) {
         options.browser = opts.browser;
     }
     if (opts.env) {
-        options.env = opts.env;
+        options.env = {
+            ...options.env,
+            ...opts.env,
+        };
     }
     if (opts.spec) {
         options.spec = opts.spec;
@@ -211,110 +169,6 @@ async function runCypress(baseUrl, opts) {
      */
     return !result.totalFailed && !result.failures;
 }
-/**
- * try to find a free port for the project to run on
- * will return undefined if no port is found or the project doesn't have a port option
- **/
-async function getPortForProject(context, target, defaultPort = 4200) {
-    const fmtTarget = (0, devkit_1.targetToTargetString)(target);
-    const [hasPortOpt, schemaPortValue] = getValueFromSchema(context, target, 'port');
-    let freePort;
-    if (hasPortOpt) {
-        let normalizedPortValue;
-        if (!schemaPortValue) {
-            devkit_1.logger.info(`NX ${fmtTarget} did not have a defined port value, checking for free port with the default value of ${defaultPort}`);
-            normalizedPortValue = defaultPort;
-        }
-        else {
-            normalizedPortValue = Number(schemaPortValue);
-        }
-        if (isNaN(normalizedPortValue)) {
-            devkit_1.output.warn({
-                title: `Port Not a Number`,
-                bodyLines: [
-                    `The port value found was not a number or can't be parsed to a number`,
-                    `When reading the devServerTarget (${fmtTarget}) schema, expected ${schemaPortValue} to be a number but got NaN.`,
-                    `Nx will use the default value of ${defaultPort} instead.`,
-                    `You can manually specify a port by setting the 'port' option`,
-                ],
-            });
-            normalizedPortValue = defaultPort;
-        }
-        try {
-            let attempts = 0;
-            // make sure when this check happens in parallel,
-            // we don't let the same port be used by multiple projects
-            do {
-                freePort = await detectPort(freePort || normalizedPortValue);
-                if (attemptToLockPort(freePort)) {
-                    break;
-                }
-                attempts++;
-                // increment port in case the lock file isn't cleaned up
-                freePort++;
-            } while (attempts < 20);
-            devkit_1.logger.info(`NX Using port ${freePort} for ${fmtTarget}`);
-        }
-        catch (err) {
-            throw new Error((0, devkit_1.stripIndents) `Unable to find a free port for the dev server, ${fmtTarget}.
-You can disable auto port detection by specifing a port or not passing a value to --port`);
-        }
-    }
-    else {
-        devkit_1.output.warn({
-            title: `No Port Option Found`,
-            bodyLines: [
-                `The 'port' option is set to 'cypress-auto', but the devServerTarget (${fmtTarget}) does not have a port option.`,
-                `Because of this, Nx is unable to verify the port is free before starting the dev server.`,
-                `This might cause issues if the devServerTarget is trying to use a port that is already in use.`,
-            ],
-        });
-    }
-    return freePort;
-}
-/**
- * Check if the given target has the given property in it's options.
- * if the property is does not have a default value or is not in the actual executor options,
- * the value will be undefined even if it's in the executor schema.
- **/
-function getValueFromSchema(context, target, property) {
-    let targetOpts;
-    try {
-        targetOpts = (0, devkit_1.readTargetOptions)(target, context);
-    }
-    catch (e) {
-        throw new Error(`Unable to read the target options for  ${(0, devkit_1.targetToTargetString)(target)}.
-Are you sure this is a valid target?
-Was trying to read the target for the property: '${property}', but got the following error: 
-${e.message || e}`);
-    }
-    let targetHasOpt = Object.keys(targetOpts).includes(property);
-    if (!targetHasOpt) {
-        // NOTE: readTargetOptions doesn't apply non defaulted values, i.e. @nx/vite has a port options but is optional
-        // so we double check the schema if readTargetOptions didn't return a value for the property
-        const projectConfig = context.projectsConfigurations?.projects?.[target.project];
-        const targetConfig = projectConfig.targets[target.target];
-        const [collection, executor] = targetConfig.executor.split(':');
-        const { schema } = (0, executor_utils_1.getExecutorInformation)(collection, executor, context.root);
-        // NOTE: schema won't have a default since readTargetOptions would have
-        // already set that and this check wouldn't need to be made
-        targetHasOpt = Object.keys(schema.properties).includes(property);
-    }
-    return [targetHasOpt, targetOpts[property]];
-}
-function attemptToLockPort(port) {
-    const portLockFilePath = (0, path_1.join)(__dirname, `${port}.txt`);
-    try {
-        if ((0, fs_1.existsSync)(portLockFilePath)) {
-            return false;
-        }
-        (0, fs_1.writeFileSync)(portLockFilePath, 'locked');
-        return true;
-    }
-    catch (err) {
-        return false;
-    }
-}
 function cleanupTmpFile(path) {
     try {
         if (path && (0, fs_1.existsSync)(path)) {

package/src/executors/cypress/schema.json

@@ -113,7 +113,17 @@
     },
     "ignoreTestFiles": {
       "aliases": ["excludeSpecPattern"],
-      "type": "string",
+      "oneOf": [
+        {
+          "type": "string"
+        },
+        {
+          "type": "array",
+          "items": {
+            "type": "string"
+          }
+        }
+      ],
       "description": "A String or Array of glob patterns used to ignore test files that would otherwise be shown in your list of tests. Cypress uses minimatch with the options: `{dot: true, matchBase: true}`. We suggest using https://globster.xyz to test what files would match."
     },
     "reporter": {

package/src/generators/base-setup/base-setup.d.ts

@@ -6,6 +6,7 @@ export interface CypressBaseSetupSchema {
      * default is `cypress`
      * */
     directory?: string;
+    js?: boolean;
     jsx?: boolean;
 }
 export declare function addBaseCypressSetup(tree: Tree, options: CypressBaseSetupSchema): void;