@nx/angular 23.0.0-beta.16 → 23.0.0-beta.17
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/package.json +8 -8
- package/src/generators/add-linting/add-linting.d.ts.map +1 -1
- package/src/generators/add-linting/add-linting.js +10 -12
- package/src/generators/add-linting/lib/add-angular-eslint-dependencies.d.ts.map +1 -1
- package/src/generators/add-linting/lib/add-angular-eslint-dependencies.js +3 -4
- package/src/generators/ng-add/utilities/workspace.js +4 -4
- package/src/migrations/update-20-2-0/disable-angular-eslint-prefer-standalone.js +8 -8
- package/src/migrations/update-20-2-0/remove-angular-eslint-rules.js +6 -6
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "@nx/angular",
|
|
3
|
-
"version": "23.0.0-beta.
|
|
3
|
+
"version": "23.0.0-beta.17",
|
|
4
4
|
"private": false,
|
|
5
5
|
"description": "The Nx Plugin for Angular contains executors, generators, and utilities for managing Angular applications and libraries within an Nx workspace. It provides: \n\n- Integration with libraries such as Storybook, Jest, ESLint, Playwright and Cypress. \n\n- Generators to help scaffold code quickly (like: Micro Frontends, Libraries, both internal to your codebase and publishable to npm) \n\n- Single Component Application Modules (SCAMs) \n\n- NgRx helpers. \n\n- Utilities for automatic workspace refactoring.",
|
|
6
6
|
"repository": {
|
|
@@ -61,13 +61,13 @@
|
|
|
61
61
|
"migrations": "./migrations.json"
|
|
62
62
|
},
|
|
63
63
|
"dependencies": {
|
|
64
|
-
"@nx/devkit": "23.0.0-beta.
|
|
65
|
-
"@nx/eslint": "23.0.0-beta.
|
|
66
|
-
"@nx/js": "23.0.0-beta.
|
|
67
|
-
"@nx/module-federation": "23.0.0-beta.
|
|
68
|
-
"@nx/rspack": "23.0.0-beta.
|
|
69
|
-
"@nx/web": "23.0.0-beta.
|
|
70
|
-
"@nx/webpack": "23.0.0-beta.
|
|
64
|
+
"@nx/devkit": "23.0.0-beta.17",
|
|
65
|
+
"@nx/eslint": "23.0.0-beta.17",
|
|
66
|
+
"@nx/js": "23.0.0-beta.17",
|
|
67
|
+
"@nx/module-federation": "23.0.0-beta.17",
|
|
68
|
+
"@nx/rspack": "23.0.0-beta.17",
|
|
69
|
+
"@nx/web": "23.0.0-beta.17",
|
|
70
|
+
"@nx/webpack": "23.0.0-beta.17",
|
|
71
71
|
"@phenomnomnominal/tsquery": "~6.2.0",
|
|
72
72
|
"@typescript-eslint/type-utils": "^8.0.0",
|
|
73
73
|
"enquirer": "~2.3.6",
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"add-linting.d.ts","sourceRoot":"","sources":["../../../../../../packages/angular/src/generators/add-linting/add-linting.ts"],"names":[],"mappings":"AACA,OAAO,EAIL,KAAK,iBAAiB,EACtB,KAAK,IAAI,EACV,MAAM,YAAY,CAAC;
|
|
1
|
+
{"version":3,"file":"add-linting.d.ts","sourceRoot":"","sources":["../../../../../../packages/angular/src/generators/add-linting/add-linting.ts"],"names":[],"mappings":"AACA,OAAO,EAIL,KAAK,iBAAiB,EACtB,KAAK,IAAI,EACV,MAAM,YAAY,CAAC;AAepB,OAAO,KAAK,EAAE,yBAAyB,EAAE,MAAM,UAAU,CAAC;AAE1D,wBAAsB,mBAAmB,CACvC,IAAI,EAAE,IAAI,EACV,OAAO,EAAE,yBAAyB,GACjC,OAAO,CAAC,iBAAiB,CAAC,CA8I5B;AAED,eAAe,mBAAmB,CAAC"}
|
|
@@ -5,11 +5,9 @@ const internal_1 = require("@nx/devkit/internal");
|
|
|
5
5
|
const devkit_1 = require("@nx/devkit");
|
|
6
6
|
const eslint_1 = require("@nx/eslint");
|
|
7
7
|
const assert_supported_angular_version_1 = require("../../utils/assert-supported-angular-version");
|
|
8
|
-
const
|
|
9
|
-
const eslint_file_1 = require("@nx/eslint/src/generators/utils/eslint-file");
|
|
8
|
+
const internal_2 = require("@nx/eslint/internal");
|
|
10
9
|
const add_angular_eslint_dependencies_1 = require("./lib/add-angular-eslint-dependencies");
|
|
11
10
|
const buildable_project_1 = require("./lib/buildable-project");
|
|
12
|
-
const flat_config_1 = require("@nx/eslint/src/utils/flat-config");
|
|
13
11
|
async function addLintingGenerator(tree, options) {
|
|
14
12
|
(0, assert_supported_angular_version_1.assertSupportedAngularVersion)(tree);
|
|
15
13
|
const tasks = [];
|
|
@@ -29,16 +27,16 @@ async function addLintingGenerator(tree, options) {
|
|
|
29
27
|
skipPackageJson: options.skipPackageJson,
|
|
30
28
|
});
|
|
31
29
|
tasks.push(lintTask);
|
|
32
|
-
if ((0,
|
|
33
|
-
const eslintFile = (0,
|
|
30
|
+
if ((0, internal_2.isEslintConfigSupported)(tree)) {
|
|
31
|
+
const eslintFile = (0, internal_2.findEslintFile)(tree, options.projectRoot);
|
|
34
32
|
// keep parser options if they exist
|
|
35
33
|
const hasParserOptions = tree
|
|
36
34
|
.read((0, devkit_1.joinPathFragments)(options.projectRoot, eslintFile), 'utf8')
|
|
37
35
|
.includes(`${options.projectRoot}/tsconfig.*?.json`);
|
|
38
|
-
if ((0,
|
|
39
|
-
(0,
|
|
40
|
-
(0,
|
|
41
|
-
(0,
|
|
36
|
+
if ((0, internal_2.useFlatConfig)(tree)) {
|
|
37
|
+
(0, internal_2.addPredefinedConfigToFlatLintConfig)(tree, options.projectRoot, 'flat/angular', { checkBaseConfig: true });
|
|
38
|
+
(0, internal_2.addPredefinedConfigToFlatLintConfig)(tree, options.projectRoot, 'flat/angular-template', { checkBaseConfig: true });
|
|
39
|
+
(0, internal_2.addOverrideToLintConfig)(tree, options.projectRoot, {
|
|
42
40
|
files: ['*.ts'],
|
|
43
41
|
rules: {
|
|
44
42
|
'@angular-eslint/directive-selector': [
|
|
@@ -59,14 +57,14 @@ async function addLintingGenerator(tree, options) {
|
|
|
59
57
|
],
|
|
60
58
|
},
|
|
61
59
|
});
|
|
62
|
-
(0,
|
|
60
|
+
(0, internal_2.addOverrideToLintConfig)(tree, options.projectRoot, {
|
|
63
61
|
files: ['*.html'],
|
|
64
62
|
rules: {},
|
|
65
63
|
});
|
|
66
64
|
}
|
|
67
65
|
else {
|
|
68
|
-
(0,
|
|
69
|
-
...(rootProject ? [
|
|
66
|
+
(0, internal_2.replaceOverridesInLintConfig)(tree, options.projectRoot, [
|
|
67
|
+
...(rootProject ? [internal_2.typeScriptOverride, internal_2.javaScriptOverride] : []),
|
|
70
68
|
{
|
|
71
69
|
files: ['*.ts'],
|
|
72
70
|
...(hasParserOptions
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"add-angular-eslint-dependencies.d.ts","sourceRoot":"","sources":["../../../../../../../packages/angular/src/generators/add-linting/lib/add-angular-eslint-dependencies.ts"],"names":[],"mappings":"AAAA,OAAO,EAEL,KAAK,iBAAiB,EACtB,KAAK,IAAI,EACV,MAAM,YAAY,CAAC;
|
|
1
|
+
{"version":3,"file":"add-angular-eslint-dependencies.d.ts","sourceRoot":"","sources":["../../../../../../../packages/angular/src/generators/add-linting/lib/add-angular-eslint-dependencies.ts"],"names":[],"mappings":"AAAA,OAAO,EAEL,KAAK,iBAAiB,EACtB,KAAK,IAAI,EACV,MAAM,YAAY,CAAC;AAQpB,wBAAgB,4BAA4B,CAC1C,IAAI,EAAE,IAAI,EACV,WAAW,EAAE,MAAM,GAClB,iBAAiB,CAiCnB"}
|
|
@@ -2,14 +2,13 @@
|
|
|
2
2
|
Object.defineProperty(exports, "__esModule", { value: true });
|
|
3
3
|
exports.addAngularEsLintDependencies = addAngularEsLintDependencies;
|
|
4
4
|
const devkit_1 = require("@nx/devkit");
|
|
5
|
-
const
|
|
6
|
-
const versions_1 = require("@nx/eslint/src/utils/versions");
|
|
5
|
+
const internal_1 = require("@nx/eslint/internal");
|
|
7
6
|
const version_utils_1 = require("../../utils/version-utils");
|
|
8
7
|
const buildable_project_1 = require("./buildable-project");
|
|
9
8
|
function addAngularEsLintDependencies(tree, projectName) {
|
|
10
9
|
const compatVersions = (0, version_utils_1.versions)(tree);
|
|
11
10
|
const angularEslintVersionToInstall = compatVersions.angularEslintVersion;
|
|
12
|
-
const usesEslintFlatConfig = (0,
|
|
11
|
+
const usesEslintFlatConfig = (0, internal_1.useFlatConfig)(tree);
|
|
13
12
|
const devDependencies = usesEslintFlatConfig
|
|
14
13
|
? {
|
|
15
14
|
'angular-eslint': angularEslintVersionToInstall,
|
|
@@ -21,7 +20,7 @@ function addAngularEsLintDependencies(tree, projectName) {
|
|
|
21
20
|
};
|
|
22
21
|
if ('typescriptEslintVersion' in compatVersions) {
|
|
23
22
|
devDependencies['@typescript-eslint/utils'] = usesEslintFlatConfig
|
|
24
|
-
?
|
|
23
|
+
? internal_1.eslint9__typescriptESLintVersion
|
|
25
24
|
: compatVersions.typescriptEslintVersion;
|
|
26
25
|
}
|
|
27
26
|
if ((0, buildable_project_1.isBuildableLibraryProject)(tree, projectName)) {
|
|
@@ -15,10 +15,10 @@ exports.deleteAngularJson = deleteAngularJson;
|
|
|
15
15
|
exports.deleteGitKeepFilesIfNotNeeded = deleteGitKeepFilesIfNotNeeded;
|
|
16
16
|
const devkit_1 = require("@nx/devkit");
|
|
17
17
|
const eslint_1 = require("@nx/eslint");
|
|
18
|
-
const
|
|
18
|
+
const internal_1 = require("@nx/eslint/internal");
|
|
19
19
|
const js_1 = require("@nx/js");
|
|
20
20
|
const default_base_1 = require("nx/src/utils/default-base");
|
|
21
|
-
const
|
|
21
|
+
const internal_2 = require("@nx/js/internal");
|
|
22
22
|
const angular_json_1 = require("nx/src/adapter/angular-json");
|
|
23
23
|
const versions_1 = require("../../../utils/versions");
|
|
24
24
|
const path_1 = require("path");
|
|
@@ -151,7 +151,7 @@ function updatePackageJson(tree) {
|
|
|
151
151
|
packageJson.devDependencies['nx'] = versions_1.nxVersion;
|
|
152
152
|
}
|
|
153
153
|
if (!packageJson.devDependencies['prettier']) {
|
|
154
|
-
packageJson.devDependencies['prettier'] =
|
|
154
|
+
packageJson.devDependencies['prettier'] = internal_2.prettierVersion;
|
|
155
155
|
}
|
|
156
156
|
return packageJson;
|
|
157
157
|
});
|
|
@@ -162,7 +162,7 @@ async function updateRootEsLintConfig(tree, existingEsLintConfig, unitTestRunner
|
|
|
162
162
|
});
|
|
163
163
|
if (!existingEsLintConfig) {
|
|
164
164
|
// There was no eslint config in the root, so we set it up and use it as-is
|
|
165
|
-
(0,
|
|
165
|
+
(0, internal_1.setupRootEsLint)(tree, { unitTestRunner });
|
|
166
166
|
return;
|
|
167
167
|
}
|
|
168
168
|
existingEsLintConfig.ignorePatterns = ['**/*'];
|
|
@@ -2,7 +2,7 @@
|
|
|
2
2
|
Object.defineProperty(exports, "__esModule", { value: true });
|
|
3
3
|
exports.default = default_1;
|
|
4
4
|
const devkit_1 = require("@nx/devkit");
|
|
5
|
-
const
|
|
5
|
+
const internal_1 = require("@nx/eslint/internal");
|
|
6
6
|
const projects_1 = require("../utils/projects");
|
|
7
7
|
const preferStandaloneRule = '@angular-eslint/prefer-standalone';
|
|
8
8
|
async function default_1(tree) {
|
|
@@ -11,20 +11,20 @@ async function default_1(tree) {
|
|
|
11
11
|
]);
|
|
12
12
|
for (const graphNode of projects) {
|
|
13
13
|
const root = graphNode.data.root;
|
|
14
|
-
if (!(0,
|
|
14
|
+
if (!(0, internal_1.isEslintConfigSupported)(tree, root)) {
|
|
15
15
|
// ESLint config is not supported, skip
|
|
16
16
|
continue;
|
|
17
17
|
}
|
|
18
|
-
if ((0,
|
|
18
|
+
if ((0, internal_1.lintConfigHasOverride)(tree, root, (o) => !!o.rules?.[preferStandaloneRule], true)) {
|
|
19
19
|
// the @angular-eslint/prefer-standalone rule is set in an override, skip
|
|
20
20
|
continue;
|
|
21
21
|
}
|
|
22
22
|
const ngEslintOverrideLookup = (o) => o.files?.includes('*.ts') &&
|
|
23
23
|
Object.keys(o.rules ?? {}).some((r) => r.startsWith('@angular-eslint/'));
|
|
24
24
|
const tsFilesOverrideLookup = (o) => o.files?.length === 1 && o.files[0] === '*.ts';
|
|
25
|
-
if ((0,
|
|
25
|
+
if ((0, internal_1.lintConfigHasOverride)(tree, root, ngEslintOverrideLookup, false)) {
|
|
26
26
|
// there is an override containing an Angular ESLint rule
|
|
27
|
-
(0,
|
|
27
|
+
(0, internal_1.updateOverrideInLintConfig)(tree, root, ngEslintOverrideLookup, (o) => {
|
|
28
28
|
o.rules = {
|
|
29
29
|
...o.rules,
|
|
30
30
|
[preferStandaloneRule]: 'off',
|
|
@@ -32,9 +32,9 @@ async function default_1(tree) {
|
|
|
32
32
|
return o;
|
|
33
33
|
});
|
|
34
34
|
}
|
|
35
|
-
else if ((0,
|
|
35
|
+
else if ((0, internal_1.lintConfigHasOverride)(tree, root, tsFilesOverrideLookup, false)) {
|
|
36
36
|
// there is an override for just *.ts files
|
|
37
|
-
(0,
|
|
37
|
+
(0, internal_1.updateOverrideInLintConfig)(tree, root, tsFilesOverrideLookup, (o) => {
|
|
38
38
|
o.rules = {
|
|
39
39
|
...o.rules,
|
|
40
40
|
[preferStandaloneRule]: 'off',
|
|
@@ -44,7 +44,7 @@ async function default_1(tree) {
|
|
|
44
44
|
}
|
|
45
45
|
else {
|
|
46
46
|
// there are no overrides for any Angular ESLint rule or just *.ts files, add a new override
|
|
47
|
-
(0,
|
|
47
|
+
(0, internal_1.addOverrideToLintConfig)(tree, root, {
|
|
48
48
|
files: ['*.ts'],
|
|
49
49
|
rules: {
|
|
50
50
|
[preferStandaloneRule]: 'off',
|
|
@@ -3,7 +3,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
|
|
|
3
3
|
exports.rulesToRemove = void 0;
|
|
4
4
|
exports.default = default_1;
|
|
5
5
|
const devkit_1 = require("@nx/devkit");
|
|
6
|
-
const
|
|
6
|
+
const internal_1 = require("@nx/eslint/internal");
|
|
7
7
|
const projects_1 = require("../utils/projects");
|
|
8
8
|
exports.rulesToRemove = [
|
|
9
9
|
'@angular-eslint/no-host-metadata-property',
|
|
@@ -17,7 +17,7 @@ async function default_1(tree) {
|
|
|
17
17
|
let hasRootProject = false;
|
|
18
18
|
for (const graphNode of projects) {
|
|
19
19
|
const root = graphNode.data.root;
|
|
20
|
-
if (!(0,
|
|
20
|
+
if (!(0, internal_1.isEslintConfigSupported)(tree, root)) {
|
|
21
21
|
// ESLint config is not supported, skip
|
|
22
22
|
continue;
|
|
23
23
|
}
|
|
@@ -36,12 +36,12 @@ async function default_1(tree) {
|
|
|
36
36
|
// check root config, provide a root so it doesn't try to lookup a base config
|
|
37
37
|
if (!hasRootProject) {
|
|
38
38
|
// if there is no root project the root eslint config has not been processed
|
|
39
|
-
if ((0,
|
|
39
|
+
if ((0, internal_1.isEslintConfigSupported)(tree, '')) {
|
|
40
40
|
removeRules(tree, '');
|
|
41
41
|
}
|
|
42
42
|
}
|
|
43
43
|
// handle root base config, not providing a root will prioritize a base config
|
|
44
|
-
const baseEslintConfig = (0,
|
|
44
|
+
const baseEslintConfig = (0, internal_1.findEslintFile)(tree);
|
|
45
45
|
if (baseEslintConfig && baseEslintConfig.includes('.base.')) {
|
|
46
46
|
removeRules(tree, baseEslintConfig);
|
|
47
47
|
}
|
|
@@ -50,12 +50,12 @@ async function default_1(tree) {
|
|
|
50
50
|
function removeRules(tree, root) {
|
|
51
51
|
for (const rule of exports.rulesToRemove) {
|
|
52
52
|
const lookup = (o) => !!o.rules?.[rule];
|
|
53
|
-
if (!(0,
|
|
53
|
+
if (!(0, internal_1.lintConfigHasOverride)(tree, root, lookup)) {
|
|
54
54
|
// it's not using the rule, skip
|
|
55
55
|
continue;
|
|
56
56
|
}
|
|
57
57
|
// there is an override containing the rule, remove the rule
|
|
58
|
-
(0,
|
|
58
|
+
(0, internal_1.updateOverrideInLintConfig)(tree, root, lookup, (o) => {
|
|
59
59
|
delete o.rules[rule];
|
|
60
60
|
return o;
|
|
61
61
|
});
|