@nx/angular 18.1.0-beta.2 → 18.1.0-beta.3

package/migrations.json

@@ -1641,7 +1641,7 @@
       }
     },
     "18.1.0-jest": {
-      "version": "18.1.0-beta.1",
+      "version": "18.1.0-beta.2",
       "requires": {
         "@angular-devkit/build-angular": ">=15.0.0 <18.0.0",
         "@angular/compiler-cli": ">=15.0.0 <18.0.0",
@@ -1651,13 +1651,17 @@
       },
       "packages": {
         "jest-preset-angular": {
-          "version": "~14.0.2",
+          "version": "~14.0.3",
           "alwaysAddToPackageJson": false
         }
       }
     },
     "18.1.0": {
       "version": "18.1.0-beta.1",
+      "x-prompt": "Do you want to update the Angular version to v17.2?",
+      "requires": {
+        "@angular/core": ">=17.1.0 <17.2.0"
+      },
       "packages": {
         "@angular-devkit/build-angular": {
           "version": "~17.2.0",

package/package.json

@@ -1,8 +1,8 @@
 {
   "name": "@nx/angular",
-  "version": "18.1.0-beta.2",
+  "version": "18.1.0-beta.3",
   "private": false,
-  "description": "The Nx Plugin for Angular contains executors, generators, and utilities for managing Angular applications and libraries within an Nx workspace. It provides: \n\n- Integration with libraries such as Storybook, Jest, ESLint, Tailwind CSS, and Cypress. \n\n- Generators to help scaffold code quickly (like: Micro Frontends, Libraries, both internal to your codebase and publishable to npm) \n\n- Upgrading AngularJS applications \n\n- Single Component Application Modules (SCAMs) \n\n- NgRx helpers. \n\n- Utilities for automatic workspace refactoring.",
+  "description": "The Nx Plugin for Angular contains executors, generators, and utilities for managing Angular applications and libraries within an Nx workspace. It provides: \n\n- Integration with libraries such as Storybook, Jest, ESLint, Tailwind CSS, and Cypress. \n\n- Generators to help scaffold code quickly (like: Micro Frontends, Libraries, both internal to your codebase and publishable to npm) \n\n- Single Component Application Modules (SCAMs) \n\n- NgRx helpers. \n\n- Utilities for automatic workspace refactoring.",
   "repository": {
     "type": "git",
     "url": "https://github.com/nrwl/nx.git",
@@ -78,16 +78,16 @@
     "tslib": "^2.3.0",
     "webpack": "^5.80.0",
     "webpack-merge": "^5.8.0",
-    "@nx/devkit": "18.1.0-beta.2",
-    "@nx/cypress": "18.1.0-beta.2",
-    "@nx/jest": "18.1.0-beta.2",
-    "@nx/js": "18.1.0-beta.2",
-    "@nx/eslint": "18.1.0-beta.2",
-    "@nx/webpack": "18.1.0-beta.2",
-    "@nx/web": "18.1.0-beta.2",
-    "@nx/workspace": "18.1.0-beta.2",
+    "@nx/devkit": "18.1.0-beta.3",
+    "@nx/cypress": "18.1.0-beta.3",
+    "@nx/jest": "18.1.0-beta.3",
+    "@nx/js": "18.1.0-beta.3",
+    "@nx/eslint": "18.1.0-beta.3",
+    "@nx/webpack": "18.1.0-beta.3",
+    "@nx/web": "18.1.0-beta.3",
+    "@nx/workspace": "18.1.0-beta.3",
     "piscina": "^4.2.1",
-    "@nrwl/angular": "18.1.0-beta.2"
+    "@nrwl/angular": "18.1.0-beta.3"
   },
   "peerDependencies": {
     "@angular-devkit/build-angular": ">= 15.0.0 < 18.0.0",

package/src/executors/module-federation-dev-server/module-federation-dev-server.impl.js

@@ -101,8 +101,10 @@ async function* moduleFederationDevServerExecutor(schema, context) {
             devkit_1.logger.info(`NX All remotes started, server ready at http://localhost:${options.port}`);
             next({ success: true, baseUrl: `http://localhost:${options.port}` });
         }
-        catch {
-            throw new Error(`Timed out waiting for remote to start. Check above for any errors.`);
+        catch (err) {
+            throw new Error(`Failed to start remotes. Check above for any errors.`, {
+                cause: err,
+            });
         }
         finally {
             done();

package/src/generators/application/files/base/tsconfig.json__tpl__

@@ -7,6 +7,9 @@
   "files": [],
   "include": [],
   "references": [
+    {
+      "path": "./tsconfig.editor.json"
+    },
     {
       "path": "./tsconfig.app.json"
     }

package/src/generators/application/lib/add-e2e.js

@@ -7,7 +7,9 @@ const versions_1 = require("../../../utils/versions");
 const version_utils_1 = require("../../utils/version-utils");
 async function addE2e(tree, options) {
     // since e2e are separate projects, default to adding plugins
-    const addPlugin = process.env.NX_ADD_PLUGINS !== 'false';
+    const nxJson = (0, devkit_1.readNxJson)(tree);
+    const addPlugin = process.env.NX_ADD_PLUGINS !== 'false' &&
+        nxJson.useInferencePlugins !== false;
     if (options.e2eTestRunner === 'cypress') {
         // TODO: This can call `@nx/web:static-config` generator when ready
         addFileServerTarget(tree, options, 'serve-static');

package/src/generators/application/lib/create-files.js

@@ -3,14 +3,19 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.createFiles = void 0;
 const devkit_1 = require("@nx/devkit");
 const js_1 = require("@nx/js");
-const create_ts_config_1 = require("../../utils/create-ts-config");
+const update_project_root_tsconfig_1 = require("../../utils/update-project-root-tsconfig");
 const test_runners_1 = require("../../../utils/test-runners");
 const version_utils_1 = require("../../utils/version-utils");
+const selector_1 = require("../../utils/selector");
 async function createFiles(tree, options, rootOffset) {
     const { major: angularMajorVersion } = (0, version_utils_1.getInstalledAngularVersionInfo)(tree);
     const isUsingApplicationBuilder = angularMajorVersion >= 17 && options.bundler === 'esbuild';
+    const rootSelector = `${options.prefix}-root`;
+    (0, selector_1.validateHtmlSelector)(rootSelector);
+    const nxWelcomeSelector = `${options.prefix}-nx-welcome`;
+    (0, selector_1.validateHtmlSelector)(nxWelcomeSelector);
     const substitutions = {
-        rootSelector: `${options.prefix}-root`,
+        rootSelector,
         appName: options.name,
         inlineStyle: options.inlineStyle,
         inlineTemplate: options.inlineTemplate,
@@ -19,7 +24,7 @@ async function createFiles(tree, options, rootOffset) {
         unitTesting: options.unitTestRunner !== test_runners_1.UnitTestRunner.None,
         routing: options.routing,
         minimal: options.minimal,
-        nxWelcomeSelector: `${options.prefix}-nx-welcome`,
+        nxWelcomeSelector,
         rootTsConfig: (0, devkit_1.joinPathFragments)(rootOffset, (0, js_1.getRootTsConfigFileName)(tree)),
         angularMajorVersion,
         rootOffset,
@@ -33,13 +38,7 @@ async function createFiles(tree, options, rootOffset) {
     else {
         (0, devkit_1.generateFiles)(tree, (0, devkit_1.joinPathFragments)(__dirname, '../files/ng-module'), options.appProjectRoot, substitutions);
     }
-    (0, create_ts_config_1.createTsConfig)(tree, options.appProjectRoot, 'app', {
-        bundler: options.bundler,
-        rootProject: options.rootProject,
-        strict: options.strict,
-        style: options.style,
-        esModuleInterop: isUsingApplicationBuilder,
-    }, (0, js_1.getRelativePathToRootTsConfig)(tree, options.appProjectRoot));
+    (0, update_project_root_tsconfig_1.updateProjectRootTsConfig)(tree, options.appProjectRoot, (0, js_1.getRelativePathToRootTsConfig)(tree, options.appProjectRoot), options.rootProject);
     if (!options.routing) {
         tree.delete((0, devkit_1.joinPathFragments)(options.appProjectRoot, '/src/app/app.routes.ts'));
     }

package/src/generators/application/lib/normalize-options.js

@@ -4,9 +4,7 @@ exports.normalizeOptions = void 0;
 const devkit_1 = require("@nx/devkit");
 const project_name_and_root_utils_1 = require("@nx/devkit/src/generators/project-name-and-root-utils");
 const eslint_1 = require("@nx/eslint");
-const get_npm_scope_1 = require("@nx/js/src/utils/package-json/get-npm-scope");
 const test_runners_1 = require("../../../utils/test-runners");
-const project_1 = require("../../utils/project");
 const version_utils_1 = require("../../utils/version-utils");
 async function normalizeOptions(host, options) {
     const { projectName: appProjectName, projectRoot: appProjectRoot, projectNameAndRootFormat, } = await (0, project_name_and_root_utils_1.determineProjectNameAndRootOptions)(host, {
@@ -24,7 +22,6 @@ async function normalizeOptions(host, options) {
     const parsedTags = options.tags
         ? options.tags.split(',').map((s) => s.trim())
         : [];
-    const prefix = (0, project_1.normalizeNewProjectPrefix)(options.prefix, (0, get_npm_scope_1.getNpmScope)(host), 'app');
     let bundler = options.bundler;
     if (!bundler) {
         const { major: angularMajorVersion } = (0, version_utils_1.getInstalledAngularVersionInfo)(host);
@@ -44,7 +41,7 @@ async function normalizeOptions(host, options) {
         strict: true,
         standalone: true,
         ...options,
-        prefix,
+        prefix: options.prefix || 'app',
         name: appProjectName,
         appProjectRoot,
         appProjectSourceRoot: `${appProjectRoot}/src`,

package/src/generators/application/lib/update-editor-tsconfig.d.ts

@@ -1,3 +1,3 @@
-import type { Tree } from '@nx/devkit';
+import { type Tree } from '@nx/devkit';
 import type { NormalizedSchema } from './normalized-schema';
 export declare function updateEditorTsConfig(tree: Tree, options: NormalizedSchema): void;

package/src/generators/application/lib/update-editor-tsconfig.js

@@ -2,24 +2,21 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.updateEditorTsConfig = void 0;
 const devkit_1 = require("@nx/devkit");
+const update_app_editor_tsconfig_excluded_files_1 = require("../../utils/update-app-editor-tsconfig-excluded-files");
 function getCompilerOptionsTypes(tsConfig) {
     return tsConfig?.compilerOptions?.types ?? [];
 }
 function updateEditorTsConfig(tree, options) {
-    const types = getCompilerOptionsTypes((0, devkit_1.readJson)(tree, (0, devkit_1.joinPathFragments)(options.appProjectRoot, 'tsconfig.app.json')));
-    if (options.unitTestRunner !== 'none') {
-        types.push(...getCompilerOptionsTypes((0, devkit_1.readJson)(tree, (0, devkit_1.joinPathFragments)(options.appProjectRoot, 'tsconfig.spec.json'))));
-    }
-    (0, devkit_1.updateJson)(tree, (0, devkit_1.joinPathFragments)(options.appProjectRoot, 'tsconfig.editor.json'), (json) => {
-        json.compilerOptions.types = types;
-        return json;
-    });
-    // This should be the last tsconfig references so it's not in the template
-    (0, devkit_1.updateJson)(tree, (0, devkit_1.joinPathFragments)(options.appProjectRoot, 'tsconfig.json'), (json) => {
-        json.references.push({
-            path: './tsconfig.editor.json',
+    const appTsConfig = (0, devkit_1.readJson)(tree, (0, devkit_1.joinPathFragments)(options.appProjectRoot, 'tsconfig.app.json'));
+    const types = getCompilerOptionsTypes(appTsConfig);
+    if (types?.length) {
+        (0, devkit_1.updateJson)(tree, (0, devkit_1.joinPathFragments)(options.appProjectRoot, 'tsconfig.editor.json'), (json) => {
+            json.compilerOptions ??= {};
+            json.compilerOptions.types = Array.from(new Set(types));
+            return json;
         });
-        return json;
-    });
+    }
+    const project = (0, devkit_1.readProjectConfiguration)(tree, options.name);
+    (0, update_app_editor_tsconfig_excluded_files_1.updateAppEditorTsConfigExcludedFiles)(tree, project);
 }
 exports.updateEditorTsConfig = updateEditorTsConfig;

package/src/generators/application/schema.json

@@ -81,6 +81,7 @@
       "type": "string",
       "format": "html-selector",
       "description": "The prefix to apply to generated selectors.",
+      "default": "app",
       "alias": "p"
     },
     "skipTests": {

package/src/generators/component/lib/normalize-options.js

@@ -20,8 +20,8 @@ async function normalizeOptions(tree, options) {
     const { className: suffixClassName } = (0, devkit_1.names)(options.type);
     const symbolName = `${className}${suffixClassName}`;
     const { prefix, root, sourceRoot } = (0, devkit_1.readProjectConfiguration)(tree, projectName);
-    const selector = options.selector ??
-        (0, selector_1.buildSelector)(tree, name, options.prefix, prefix, 'fileName');
+    const selector = options.selector ?? (0, selector_1.buildSelector)(name, options.prefix, prefix, 'fileName');
+    (0, selector_1.validateHtmlSelector)(selector);
     return {
         ...options,
         name,

package/src/generators/cypress-component-configuration/cypress-component-configuration.js

@@ -10,6 +10,7 @@ const component_test_1 = require("../component-test/component-test");
 const component_info_1 = require("../utils/storybook-ast/component-info");
 const entry_point_1 = require("../utils/storybook-ast/entry-point");
 const module_info_1 = require("../utils/storybook-ast/module-info");
+const update_app_editor_tsconfig_excluded_files_1 = require("../utils/update-app-editor-tsconfig-excluded-files");
 function cypressComponentConfiguration(tree, options) {
     return cypressComponentConfigurationInternal(tree, {
         ...options,
@@ -30,6 +31,9 @@ async function cypressComponentConfigurationInternal(tree, options) {
     });
     await configureCypressCT(tree, options);
     await addFiles(tree, projectConfig, options);
+    if (projectConfig.projectType === 'application') {
+        (0, update_app_editor_tsconfig_excluded_files_1.updateAppEditorTsConfigExcludedFiles)(tree, projectConfig);
+    }
     if (!options.skipFormat) {
         await (0, devkit_1.formatFiles)(tree);
     }

package/src/generators/directive/lib/normalize-options.js

@@ -20,7 +20,8 @@ async function normalizeOptions(tree, options) {
     const symbolName = `${className}${suffixClassName}`;
     const { prefix } = (0, devkit_1.readProjectConfiguration)(tree, projectName);
     const selector = options.selector ??
-        (0, selector_1.buildSelector)(tree, name, options.prefix, prefix, 'propertyName');
+        (0, selector_1.buildSelector)(name, options.prefix, prefix, 'propertyName');
+    (0, selector_1.validateHtmlSelector)(selector);
     return {
         ...options,
         projectName,

package/src/generators/library/lib/add-project.js

@@ -4,10 +4,6 @@ exports.addProject = void 0;
 const devkit_1 = require("@nx/devkit");
 const add_build_target_defaults_1 = require("@nx/devkit/src/generators/add-build-target-defaults");
 function addProject(tree, libraryOptions) {
-    const executor = libraryOptions.publishable
-        ? '@nx/angular:package'
-        : '@nx/angular:ng-packagr-lite';
-    (0, add_build_target_defaults_1.addBuildTargetDefaults)(tree, executor);
     const project = {
         name: libraryOptions.name,
         root: libraryOptions.projectRoot,
@@ -15,27 +11,30 @@ function addProject(tree, libraryOptions) {
         prefix: libraryOptions.prefix,
         tags: libraryOptions.parsedTags,
         projectType: 'library',
-        targets: {
-            build: libraryOptions.buildable || libraryOptions.publishable
-                ? {
-                    executor,
-                    outputs: ['{workspaceRoot}/dist/{projectRoot}'],
-                    options: {
-                        project: `${libraryOptions.projectRoot}/ng-package.json`,
-                    },
-                    configurations: {
-                        production: {
-                            tsConfig: `${libraryOptions.projectRoot}/tsconfig.lib.prod.json`,
-                        },
-                        development: {
-                            tsConfig: `${libraryOptions.projectRoot}/tsconfig.lib.json`,
-                        },
-                    },
-                    defaultConfiguration: 'production',
-                }
-                : undefined,
-        },
+        targets: {},
     };
+    if (libraryOptions.buildable || libraryOptions.publishable) {
+        const executor = libraryOptions.publishable
+            ? '@nx/angular:package'
+            : '@nx/angular:ng-packagr-lite';
+        (0, add_build_target_defaults_1.addBuildTargetDefaults)(tree, executor);
+        project.targets.build = {
+            executor,
+            outputs: ['{workspaceRoot}/dist/{projectRoot}'],
+            options: {
+                project: `${libraryOptions.projectRoot}/ng-package.json`,
+            },
+            configurations: {
+                production: {
+                    tsConfig: `${libraryOptions.projectRoot}/tsconfig.lib.prod.json`,
+                },
+                development: {
+                    tsConfig: `${libraryOptions.projectRoot}/tsconfig.lib.json`,
+                },
+            },
+            defaultConfiguration: 'production',
+        };
+    }
     (0, devkit_1.addProjectConfiguration)(tree, libraryOptions.name, project);
     return project;
 }

package/src/generators/library/lib/normalize-options.js

@@ -3,10 +3,8 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.normalizeOptions = void 0;
 const devkit_1 = require("@nx/devkit");
 const project_name_and_root_utils_1 = require("@nx/devkit/src/generators/project-name-and-root-utils");
-const get_npm_scope_1 = require("@nx/js/src/utils/package-json/get-npm-scope");
 const eslint_1 = require("@nx/eslint");
 const test_runners_1 = require("../../../utils/test-runners");
-const project_1 = require("../../utils/project");
 async function normalizeOptions(host, schema) {
     schema.standalone = schema.standalone ?? true;
     // Create a schema with populated default values
@@ -40,14 +38,12 @@ async function normalizeOptions(host, schema) {
         ? options.tags.split(',').map((s) => s.trim())
         : [];
     const modulePath = `${projectRoot}/src/lib/${fileName}.module.ts`;
-    const npmScope = (0, get_npm_scope_1.getNpmScope)(host);
-    const prefix = (0, project_1.normalizeNewProjectPrefix)(options.prefix, npmScope, 'lib');
     const ngCliSchematicLibRoot = projectName;
     const allNormalizedOptions = {
         ...options,
         linter: options.linter ?? eslint_1.Linter.EsLint,
         unitTestRunner: options.unitTestRunner ?? test_runners_1.UnitTestRunner.Jest,
-        prefix,
+        prefix: options.prefix ?? 'lib',
         name: projectName,
         projectRoot,
         entryFile: 'index',

package/src/generators/library/lib/update-tsconfig.js

@@ -3,7 +3,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.updateTsConfig = void 0;
 const devkit_1 = require("@nx/devkit");
 const js_1 = require("@nx/js");
-const create_ts_config_1 = require("../../utils/create-ts-config");
+const update_project_root_tsconfig_1 = require("../../utils/update-project-root-tsconfig");
 function updateProjectConfig(host, options) {
     (0, devkit_1.updateJson)(host, `${options.projectRoot}/tsconfig.lib.json`, (json) => {
         json.include = ['src/**/*.ts'];
@@ -18,7 +18,7 @@ function updateProjectConfig(host, options) {
         return json;
     });
     // tsconfig.json
-    (0, create_ts_config_1.createTsConfig)(host, options.projectRoot, 'lib', options, (0, js_1.getRelativePathToRootTsConfig)(host, options.projectRoot));
+    (0, update_project_root_tsconfig_1.updateProjectRootTsConfig)(host, options.projectRoot, (0, js_1.getRelativePathToRootTsConfig)(host, options.projectRoot));
 }
 function updateProjectIvyConfig(host, options) {
     if (options.buildable || options.publishable) {
@@ -30,7 +30,7 @@ function updateProjectIvyConfig(host, options) {
     }
 }
 function updateTsConfig(host, options) {
-    (0, create_ts_config_1.extractTsConfigBase)(host);
+    (0, update_project_root_tsconfig_1.extractTsConfigBase)(host);
     updateProjectConfig(host, options);
     updateProjectIvyConfig(host, options);
 }

package/src/generators/ng-add/migrators/projects/e2e.migrator.js

@@ -235,6 +235,9 @@ class E2eMigrator extends project_migrator_1.ProjectMigrator {
             tags: [],
             implicitDependencies: [this.appName],
         });
+        const nxJson = (0, devkit_1.readNxJson)(this.tree) ?? {};
+        const addPlugin = process.env.NX_ADD_PLUGINS !== 'false' &&
+            nxJson.useInferencePlugins !== false;
         await (0, cypress_1.configurationGenerator)(this.tree, {
             project: this.project.name,
             linter: this.isProjectUsingEsLint ? eslint_1.Linter.EsLint : eslint_1.Linter.None,
@@ -242,7 +245,7 @@ class E2eMigrator extends project_migrator_1.ProjectMigrator {
             // any target would do, we replace it later with the target existing in the project being migrated
             devServerTarget: `${this.appName}:serve`,
             baseUrl: 'http://localhost:4200',
-            addPlugin: process.env.NX_ADD_PLUGINS !== 'false',
+            addPlugin,
         });
         const cypressConfigFilePath = this.updateOrCreateCypressConfigFile(oldCypressConfigFilePath);
         this.updateCypressProjectConfiguration(cypressConfigFilePath);

package/src/generators/ng-add/utilities/workspace.js

@@ -29,9 +29,7 @@ exports.validateWorkspace = validateWorkspace;
 function createNxJson(tree, options, defaultProject) {
     const targets = getWorkspaceCommonTargets(tree);
     (0, devkit_1.writeJson)(tree, 'nx.json', {
-        affected: {
-            defaultBase: options.defaultBase ?? (0, default_base_1.deduceDefaultBase)(),
-        },
+        defaultBase: options.defaultBase ?? (0, default_base_1.deduceDefaultBase)(),
         namedInputs: {
             sharedGlobals: [],
             default: ['{projectRoot}/**/*', 'sharedGlobals'],

package/src/generators/setup-mf/lib/normalize-options.js

@@ -7,7 +7,7 @@ function normalizeOptions(tree, options) {
         ...options,
         typescriptConfiguration: options.typescriptConfiguration ?? true,
         federationType: options.federationType ?? 'static',
-        prefix: options.prefix ?? (0, project_1.getProjectPrefix)(tree, options.appName),
+        prefix: options.prefix ?? (0, project_1.getProjectPrefix)(tree, options.appName) ?? 'app',
         standalone: options.standalone ?? true,
     };
 }

package/src/generators/storybook-configuration/storybook-configuration.js

@@ -2,6 +2,7 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.storybookConfigurationGenerator = void 0;
 const devkit_1 = require("@nx/devkit");
+const update_app_editor_tsconfig_excluded_files_1 = require("../utils/update-app-editor-tsconfig-excluded-files");
 const assert_compatible_storybook_version_1 = require("./lib/assert-compatible-storybook-version");
 const generate_stories_1 = require("./lib/generate-stories");
 const generate_storybook_configuration_1 = require("./lib/generate-storybook-configuration");
@@ -22,6 +23,10 @@ async function storybookConfigurationGenerator(tree, options) {
             skipFormat: true,
         });
     }
+    const project = (0, devkit_1.readProjectConfiguration)(tree, options.project);
+    if (project.projectType === 'application') {
+        (0, update_app_editor_tsconfig_excluded_files_1.updateAppEditorTsConfigExcludedFiles)(tree, project);
+    }
     if (!options.skipFormat) {
         await (0, devkit_1.formatFiles)(tree);
     }

package/src/generators/utils/project.d.ts

@@ -1,3 +1,2 @@
 import type { Tree } from '@nx/devkit';
-export declare function normalizeNewProjectPrefix(prefix: string | undefined, npmScope: string | undefined, fallbackPrefix: string): string;
 export declare function getProjectPrefix(tree: Tree, project: string): string | undefined;

package/src/generators/utils/project.js

@@ -1,35 +1,8 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.getProjectPrefix = exports.normalizeNewProjectPrefix = void 0;
+exports.getProjectPrefix = void 0;
 const devkit_1 = require("@nx/devkit");
-const get_npm_scope_1 = require("@nx/js/src/utils/package-json/get-npm-scope");
-function normalizeNewProjectPrefix(prefix, npmScope, fallbackPrefix) {
-    // Prefix needs to be a valid html selector, if npmScope it's not valid, we don't default
-    // to it and let it fall through to the Angular schematic to handle it
-    // https://github.com/angular/angular-cli/blob/aa9f0528f174e856a4923cb24861fdf6e6f96b48/packages/schematics/angular/component/index.ts#L64
-    const htmlSelectorRegex = /^[a-zA-Z][.0-9a-zA-Z]*((:?-[0-9]+)*|(:?-[a-zA-Z][.0-9a-zA-Z]*(:?-[0-9]+)*)*)$/;
-    if (prefix) {
-        if (!htmlSelectorRegex.test(prefix)) {
-            throw new Error('The provided "prefix" is invalid. The prefix must start with a letter, and must contain only alphanumeric characters or dashes.');
-        }
-        return prefix;
-    }
-    if (npmScope && !htmlSelectorRegex.test(npmScope)) {
-        throw new Error(`The "--prefix" option was not provided, therefore attempted to use the "npmScope" defined in "nx.json" to set the application's selector prefix, but it is invalid.
-
-There are two options that can be followed to resolve this issue:
-  - Pass a valid "--prefix" option.
-  - Update the "npmScope" in "nx.json" (Note: this can be an involved process, as other libraries and applications may need to be updated to match the new scope).
-
-If you encountered this error when creating a new Nx Workspace, the workspace name or "npmScope" is invalid to use as the selector prefix for the application being generated.
-
-Valid selector prefixes must start with a letter, and must contain only alphanumeric characters or dashes.`);
-    }
-    return npmScope || fallbackPrefix;
-}
-exports.normalizeNewProjectPrefix = normalizeNewProjectPrefix;
 function getProjectPrefix(tree, project) {
-    return ((0, devkit_1.readProjectConfiguration)(tree, project)
-        .prefix ?? (0, get_npm_scope_1.getNpmScope)(tree));
+    return (0, devkit_1.readProjectConfiguration)(tree, project).prefix;
 }
 exports.getProjectPrefix = getProjectPrefix;

package/src/generators/utils/selector.d.ts

@@ -1,3 +1,3 @@
-import type { Tree } from '@nx/devkit';
 import { names } from '@nx/devkit';
-export declare function buildSelector(tree: Tree, name: string, prefix: string | undefined, projectPrefix: string | undefined, casing: keyof Pick<ReturnType<typeof names>, 'fileName' | 'propertyName'>): string;
+export declare function buildSelector(name: string, prefix: string | undefined, projectPrefix: string | undefined, casing: keyof Pick<ReturnType<typeof names>, 'fileName' | 'propertyName'>): string;
+export declare function validateHtmlSelector(selector: string): void;

package/src/generators/utils/selector.js

@@ -1,14 +1,21 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.buildSelector = void 0;
+exports.validateHtmlSelector = exports.buildSelector = void 0;
 const devkit_1 = require("@nx/devkit");
-const get_npm_scope_1 = require("@nx/js/src/utils/package-json/get-npm-scope");
-function buildSelector(tree, name, prefix, projectPrefix, casing) {
+function buildSelector(name, prefix, projectPrefix, casing) {
     let selector = name;
-    prefix ??= projectPrefix ?? (0, get_npm_scope_1.getNpmScope)(tree);
+    prefix ??= projectPrefix;
     if (prefix) {
         selector = `${prefix}-${selector}`;
     }
     return (0, devkit_1.names)(selector)[casing];
 }
 exports.buildSelector = buildSelector;
+// https://github.com/angular/angular-cli/blob/main/packages/schematics/angular/utility/validation.ts#L11-L14
+const htmlSelectorRegex = /^[a-zA-Z][.0-9a-zA-Z]*((:?-[0-9]+)*|(:?-[a-zA-Z][.0-9a-zA-Z]*(:?-[0-9]+)*)*)$/;
+function validateHtmlSelector(selector) {
+    if (selector && !htmlSelectorRegex.test(selector)) {
+        throw new Error(`The selector "${selector}" is invalid.`);
+    }
+}
+exports.validateHtmlSelector = validateHtmlSelector;

package/src/generators/utils/update-app-editor-tsconfig-excluded-files.d.ts

@@ -0,0 +1,2 @@
+import { type ProjectConfiguration, type Tree } from '@nx/devkit';
+export declare function updateAppEditorTsConfigExcludedFiles(tree: Tree, projectConfig: ProjectConfiguration): void;

package/src/generators/utils/update-app-editor-tsconfig-excluded-files.js

@@ -0,0 +1,23 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.updateAppEditorTsConfigExcludedFiles = void 0;
+const devkit_1 = require("@nx/devkit");
+function updateAppEditorTsConfigExcludedFiles(tree, projectConfig) {
+    if (projectConfig.projectType !== 'application') {
+        return;
+    }
+    const editorTsConfigPath = (0, devkit_1.joinPathFragments)(projectConfig.root, 'tsconfig.editor.json');
+    const appTsConfigPath = (0, devkit_1.joinPathFragments)(projectConfig.root, 'tsconfig.app.json');
+    if (!tree.exists(editorTsConfigPath) || !tree.exists(appTsConfigPath)) {
+        return;
+    }
+    const appTsConfig = (0, devkit_1.readJson)(tree, appTsConfigPath);
+    (0, devkit_1.updateJson)(tree, editorTsConfigPath, (json) => {
+        const exclude = [...(json.exclude ?? []), ...(appTsConfig.exclude ?? [])];
+        if (exclude.length) {
+            json.exclude = Array.from(new Set(exclude));
+        }
+        return json;
+    });
+}
+exports.updateAppEditorTsConfigExcludedFiles = updateAppEditorTsConfigExcludedFiles;

package/src/generators/utils/update-project-root-tsconfig.d.ts

@@ -0,0 +1,3 @@
+import { type Tree } from '@nx/devkit';
+export { extractTsConfigBase } from '@nx/js';
+export declare function updateProjectRootTsConfig(host: Tree, projectRoot: string, relativePathToRootTsConfig: string, isRootProject?: boolean): void;

package/src/generators/utils/update-project-root-tsconfig.js

@@ -0,0 +1,26 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.updateProjectRootTsConfig = exports.extractTsConfigBase = void 0;
+const devkit_1 = require("@nx/devkit");
+const js_1 = require("@nx/js");
+var js_2 = require("@nx/js");
+Object.defineProperty(exports, "extractTsConfigBase", { enumerable: true, get: function () { return js_2.extractTsConfigBase; } });
+function updateProjectRootTsConfig(host, projectRoot, relativePathToRootTsConfig, isRootProject) {
+    (0, devkit_1.updateJson)(host, `${projectRoot}/tsconfig.json`, (json) => {
+        if (isRootProject) {
+            // inline tsconfig.base.json into the project
+            json.compileOnSave = false;
+            json.compilerOptions = {
+                ...js_1.tsConfigBaseOptions,
+                ...json.compilerOptions,
+            };
+            json.exclude = ['node_modules', 'tmp'];
+            delete json.extends;
+        }
+        else {
+            json.extends = relativePathToRootTsConfig;
+        }
+        return json;
+    });
+}
+exports.updateProjectRootTsConfig = updateProjectRootTsConfig;

package/src/utils/versions.d.ts

@@ -19,7 +19,7 @@ export declare const postcssVersion = "^8.4.5";
 export declare const postcssUrlVersion = "~10.1.3";
 export declare const autoprefixerVersion = "^10.4.0";
 export declare const tsNodeVersion = "10.9.1";
-export declare const jestPresetAngularVersion = "~14.0.2";
+export declare const jestPresetAngularVersion = "~14.0.3";
 export declare const typesNodeVersion = "18.16.9";
 export declare const jasmineMarblesVersion = "^0.9.2";
 export declare const jsoncEslintParserVersion = "^2.1.0";

package/src/utils/versions.js

@@ -22,7 +22,7 @@ exports.postcssVersion = '^8.4.5';
 exports.postcssUrlVersion = '~10.1.3';
 exports.autoprefixerVersion = '^10.4.0';
 exports.tsNodeVersion = '10.9.1';
-exports.jestPresetAngularVersion = '~14.0.2';
+exports.jestPresetAngularVersion = '~14.0.3';
 exports.typesNodeVersion = '18.16.9';
 exports.jasmineMarblesVersion = '^0.9.2';
 exports.jsoncEslintParserVersion = '^2.1.0';

package/src/generators/utils/create-ts-config.d.ts

@@ -1,9 +0,0 @@
-import type { Tree } from '@nx/devkit';
-export { extractTsConfigBase } from '@nx/js';
-export declare function createTsConfig(host: Tree, projectRoot: string, type: 'app' | 'lib', options: {
-    strict?: boolean;
-    style?: string;
-    bundler?: string;
-    rootProject?: boolean;
-    esModuleInterop?: boolean;
-}, relativePathToRootTsConfig: string): void;

package/src/generators/utils/create-ts-config.js

@@ -1,34 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.createTsConfig = exports.extractTsConfigBase = void 0;
-const devkit_1 = require("@nx/devkit");
-const js_1 = require("@nx/js");
-var js_2 = require("@nx/js");
-Object.defineProperty(exports, "extractTsConfigBase", { enumerable: true, get: function () { return js_2.extractTsConfigBase; } });
-function createTsConfig(host, projectRoot, type, options, relativePathToRootTsConfig) {
-    const json = {
-        compilerOptions: {
-            target: 'es2022',
-            useDefineForClassFields: false,
-            esModuleInterop: options.esModuleInterop ? true : undefined,
-        },
-        files: [],
-        include: [],
-        references: [
-            {
-                path: type === 'app' ? './tsconfig.app.json' : './tsconfig.lib.json',
-            },
-        ],
-    };
-    // inline tsconfig.base.json into the project
-    if (options.rootProject) {
-        json.compileOnSave = false;
-        json.compilerOptions = { ...js_1.tsConfigBaseOptions, ...json.compilerOptions };
-        json.exclude = ['node_modules', 'tmp'];
-    }
-    else {
-        json.extends = relativePathToRootTsConfig;
-    }
-    (0, devkit_1.writeJson)(host, `${projectRoot}/tsconfig.json`, json);
-}
-exports.createTsConfig = createTsConfig;