@nx/angular 16.6.0-beta.0 → 16.6.0-beta.2

package/ng-package.json

@@ -25,7 +25,8 @@
     "webpack",
     "http-server",
     "magic-string",
-    "enquirer"
+    "enquirer",
+    "find-cache-dir"
   ],
   "keepLifecycleScripts": true
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/angular",
-  "version": "16.6.0-beta.0",
+  "version": "16.6.0-beta.2",
   "private": false,
   "description": "The Nx Plugin for Angular contains executors, generators, and utilities for managing Angular applications and libraries within an Nx workspace. It provides: \n\n- Integration with libraries such as Storybook, Jest, ESLint, Tailwind CSS, and Cypress. \n\n- Generators to help scaffold code quickly (like: Micro Frontends, Libraries, both internal to your codebase and publishable to npm) \n\n- Upgrading AngularJS applications \n\n- Single Component Application Modules (SCAMs) \n\n- NgRx helpers. \n\n- Utilities for automatic workspace refactoring.",
   "repository": {
@@ -66,26 +66,25 @@
     "migrations": "./migrations.json"
   },
   "dependencies": {
-    "@nrwl/angular": "16.6.0-beta.0",
-    "@nx/cypress": "16.6.0-beta.0",
-    "@nx/devkit": "16.6.0-beta.0",
-    "@nx/jest": "16.6.0-beta.0",
-    "@nx/js": "16.6.0-beta.0",
-    "@nx/linter": "16.6.0-beta.0",
-    "@nx/webpack": "16.6.0-beta.0",
-    "@nx/workspace": "16.6.0-beta.0",
+    "@nrwl/angular": "16.6.0-beta.2",
+    "@nx/cypress": "16.6.0-beta.2",
+    "@nx/devkit": "16.6.0-beta.2",
+    "@nx/jest": "16.6.0-beta.2",
+    "@nx/js": "16.6.0-beta.2",
+    "@nx/linter": "16.6.0-beta.2",
+    "@nx/webpack": "16.6.0-beta.2",
+    "@nx/workspace": "16.6.0-beta.2",
     "@phenomnomnominal/tsquery": "~5.0.1",
     "@typescript-eslint/type-utils": "^5.36.1",
     "chalk": "^4.1.0",
     "chokidar": "^3.5.1",
     "enquirer": "^2.3.6",
+    "find-cache-dir": "^3.3.2",
     "http-server": "^14.1.0",
     "ignore": "^5.0.4",
     "magic-string": "~0.26.2",
     "minimatch": "3.0.5",
     "semver": "7.5.3",
-    "ts-node": "10.9.1",
-    "tsconfig-paths": "^4.1.2",
     "tslib": "^2.3.0",
     "webpack": "^5.80.0",
     "webpack-merge": "5.7.3"
@@ -109,5 +108,5 @@
   "module": "fesm2022/nx-angular.mjs",
   "typings": "index.d.ts",
   "sideEffects": false,
-  "gitHead": "5a7ffb93c9e84bffbf52f6ae9c6c1e3b8edb9d35"
+  "gitHead": "c3d31711b71d648cedeff688fce9334d393b586b"
 }

package/src/builders/utilities/module-federation.js

@@ -4,6 +4,7 @@ exports.validateDevRemotes = exports.getStaticRemotes = exports.getDynamicRemote
 const path_1 = require("path");
 const fs_1 = require("fs");
 const devkit_1 = require("@nx/devkit");
+const tsnode_register_1 = require("@nx/js/src/utils/typescript/tsnode-register");
 function getDynamicRemotes(project, context, workspaceProjects, remotesToSkip, pathToManifestFile = (0, path_1.join)(context.workspaceRoot, project.sourceRoot, 'assets/module-federation.manifest.json')) {
     // check for dynamic remotes
     // we should only check for dynamic based on what we generate
@@ -40,15 +41,27 @@ function getDynamicRemotes(project, context, workspaceProjects, remotesToSkip, p
     return dynamicRemotes;
 }
 exports.getDynamicRemotes = getDynamicRemotes;
-function getStaticRemotes(project, context, workspaceProjects, remotesToSkip) {
-    const mfConfigPath = (0, path_1.join)(context.workspaceRoot, project.root, 'module-federation.config.js');
-    let mfeConfig;
+function getModuleFederationConfig(tsconfigPath, workspaceRoot, projectRoot) {
+    const moduleFederationConfigPathJS = (0, path_1.join)(workspaceRoot, projectRoot, 'module-federation.config.js');
+    const moduleFederationConfigPathTS = (0, path_1.join)(workspaceRoot, projectRoot, 'module-federation.config.ts');
+    let moduleFederationConfigPath = moduleFederationConfigPathJS;
+    if ((0, fs_1.existsSync)(moduleFederationConfigPathTS)) {
+        (0, tsnode_register_1.tsNodeRegister)(moduleFederationConfigPathTS, tsconfigPath);
+        moduleFederationConfigPath = moduleFederationConfigPathTS;
+    }
     try {
-        mfeConfig = require(mfConfigPath);
+        const config = require(moduleFederationConfigPath);
+        return {
+            mfeConfig: config.default || config,
+            mfConfigPath: moduleFederationConfigPath,
+        };
     }
     catch (_a) {
-        throw new Error(`Could not load ${mfConfigPath}. Was this project generated with "@nx/angular:host"?`);
+        throw new Error(`Could not load ${moduleFederationConfigPath}. Was this project generated with "@nx/angular:host"?`);
     }
+}
+function getStaticRemotes(project, context, workspaceProjects, remotesToSkip) {
+    const { mfeConfig, mfConfigPath } = getModuleFederationConfig(project.targets.build.options.tsConfig, context.workspaceRoot, project.root);
     const remotesConfig = Array.isArray(mfeConfig.remotes) && mfeConfig.remotes.length > 0
         ? mfeConfig.remotes
         : [];

package/src/builders/utilities/webpack.js

@@ -3,6 +3,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.resolveIndexHtmlTransformer = exports.resolveCustomWebpackConfig = exports.mergeCustomWebpackConfig = void 0;
 const tslib_1 = require("tslib");
 const webpack_merge_1 = require("webpack-merge");
+const tsnode_register_1 = require("@nx/js/src/utils/typescript/tsnode-register");
 function mergeCustomWebpackConfig(baseWebpackConfig, pathToWebpackConfig, options, target) {
     return tslib_1.__awaiter(this, void 0, void 0, function* () {
         const customWebpackConfiguration = resolveCustomWebpackConfig(pathToWebpackConfig, options.tsConfig);
@@ -23,7 +24,7 @@ function mergeCustomWebpackConfig(baseWebpackConfig, pathToWebpackConfig, option
 exports.mergeCustomWebpackConfig = mergeCustomWebpackConfig;
 function resolveCustomWebpackConfig(path, tsConfig) {
     var _a;
-    tsNodeRegister(path, tsConfig);
+    (0, tsnode_register_1.tsNodeRegister)(path, tsConfig);
     const customWebpackConfig = require(path);
     // If the user provides a configuration in TS file
     // then there are 2 cases for exporting an object. The first one is:
@@ -35,29 +36,9 @@ function resolveCustomWebpackConfig(path, tsConfig) {
 exports.resolveCustomWebpackConfig = resolveCustomWebpackConfig;
 function resolveIndexHtmlTransformer(path, tsConfig, target) {
     var _a;
-    tsNodeRegister(path, tsConfig);
+    (0, tsnode_register_1.tsNodeRegister)(path, tsConfig);
     const indexTransformer = require(path);
     const transform = (_a = indexTransformer.default) !== null && _a !== void 0 ? _a : indexTransformer;
     return (indexHtml) => transform(target, indexHtml);
 }
 exports.resolveIndexHtmlTransformer = resolveIndexHtmlTransformer;
-function tsNodeRegister(file, tsConfig) {
-    if (!(file === null || file === void 0 ? void 0 : file.endsWith('.ts')))
-        return;
-    // Register TS compiler lazily
-    require('ts-node').register({
-        project: tsConfig,
-        compilerOptions: {
-            module: 'CommonJS',
-            types: ['node'],
-        },
-    });
-    if (!tsConfig)
-        return;
-    // Register paths in tsConfig
-    const tsconfigPaths = require('tsconfig-paths');
-    const { absoluteBaseUrl: baseUrl, paths } = tsconfigPaths.loadConfig(tsConfig);
-    if (baseUrl && paths) {
-        tsconfigPaths.register({ baseUrl, paths });
-    }
-}

package/src/executors/ng-packagr-lite/schema.json

@@ -13,11 +13,7 @@
     },
     {
       "name": "Updating Project Dependencies for Buildable Library",
-      "keys": [
-        "project",
-        "updateBuildableProjectDepsInPackageJson",
-        "buildableProjectDepsInPackageJsonType"
-      ]
+      "keys": ["project"]
     }
   ],
   "properties": {
@@ -40,13 +36,15 @@
     "updateBuildableProjectDepsInPackageJson": {
       "type": "boolean",
       "description": "Whether to update the buildable project dependencies in the build output package.json.",
-      "default": false
+      "default": false,
+      "x-deprecated": "Configure the project to use the '@nx/dependency-checks' ESLint rule instead (https://nx.dev/packages/eslint-plugin/documents/dependency-checks). It will be removed in v17."
     },
     "buildableProjectDepsInPackageJsonType": {
       "type": "string",
       "description": "When `updateBuildableProjectDepsInPackageJson` is `true`, this adds dependencies to either `peerDependencies` or `dependencies`.",
       "enum": ["dependencies", "peerDependencies"],
-      "default": "peerDependencies"
+      "default": "peerDependencies",
+      "x-deprecated": "Configure the '@nx/dependency-checks' ESLint rule instead (https://nx.dev/packages/eslint-plugin/documents/dependency-checks). It will be removed in v17."
     },
     "tailwindConfig": {
       "type": "string",

package/src/executors/package/schema.d.ts

@@ -1,8 +1,18 @@
 export interface BuildAngularLibraryExecutorOptions {
   project: string;
+  /**
+   * @deprecated Configure the project to use the `@nx/dependency-checks` ESLint
+   * rule instead (https://nx.dev/packages/eslint-plugin/documents/dependency-checks).
+   * It will be removed in v17.
+   */
   buildableProjectDepsInPackageJsonType?: 'dependencies' | 'peerDependencies';
   tailwindConfig?: string;
   tsConfig?: string;
+  /**
+   * @deprecated Configure the project to use the `@nx/dependency-checks` ESLint
+   * rule instead (https://nx.dev/packages/eslint-plugin/documents/dependency-checks).
+   * It will be removed in v17.
+   */
   updateBuildableProjectDepsInPackageJson?: boolean;
   watch?: boolean;
 }

package/src/executors/package/schema.json

@@ -13,11 +13,7 @@
     },
     {
       "name": "Updating Project Dependencies for Publishable Library",
-      "keys": [
-        "project",
-        "updateBuildableProjectDepsInPackageJson",
-        "buildableProjectDepsInPackageJsonType"
-      ]
+      "keys": ["project"]
     }
   ],
   "properties": {
@@ -40,13 +36,15 @@
     "updateBuildableProjectDepsInPackageJson": {
       "type": "boolean",
       "description": "Whether to update the buildable project dependencies in the build output package.json.",
-      "default": false
+      "default": false,
+      "x-deprecated": "Configure the project to use the '@nx/dependency-checks' ESLint rule instead (https://nx.dev/packages/eslint-plugin/documents/dependency-checks). It will be removed in v17."
     },
     "buildableProjectDepsInPackageJsonType": {
       "type": "string",
       "description": "When `updateBuildableProjectDepsInPackageJson` is `true`, this adds dependencies to either `peerDependencies` or `dependencies`.",
       "enum": ["dependencies", "peerDependencies"],
-      "default": "peerDependencies"
+      "default": "peerDependencies",
+      "x-deprecated": "Configure the project to use the '@nx/dependency-checks' ESLint rule instead (https://nx.dev/packages/eslint-plugin/documents/dependency-checks). It will be removed in v17."
     },
     "tailwindConfig": {
       "type": "string",

package/src/generators/application/lib/add-unit-test-runner.js

@@ -8,7 +8,7 @@ const test_runners_1 = require("../../../utils/test-runners");
 function addUnitTestRunner(host, options) {
     return tslib_1.__awaiter(this, void 0, void 0, function* () {
         if (options.unitTestRunner === test_runners_1.UnitTestRunner.Jest) {
-            yield (0, jest_1.jestProjectGenerator)(host, {
+            yield (0, jest_1.configurationGenerator)(host, {
                 project: options.name,
                 setupFile: 'angular',
                 supportTsx: false,

package/src/generators/library/library.js

@@ -81,7 +81,7 @@ exports.libraryGenerator = libraryGenerator;
 function addUnitTestRunner(host, options) {
     return tslib_1.__awaiter(this, void 0, void 0, function* () {
         if (options.unitTestRunner === 'jest') {
-            yield (0, jest_1.jestProjectGenerator)(host, {
+            yield (0, jest_1.configurationGenerator)(host, {
                 project: options.name,
                 setupFile: 'angular',
                 supportTsx: false,

package/src/generators/storybook-configuration/lib/generate-storybook-configuration.js

@@ -14,7 +14,7 @@ function generateStorybookConfiguration(tree, options) {
             linter: options.linter,
             cypressDirectory: options.cypressDirectory,
             tsConfiguration: options.tsConfiguration,
-            configureTestRunner: options.configureTestRunner,
+            interactionTests: options.interactionTests,
             configureStaticServe: options.configureStaticServe,
             skipFormat: true,
         });

package/src/generators/storybook-configuration/schema.d.ts

@@ -11,5 +11,5 @@ export interface StorybookConfigurationOptions {
   tsConfiguration?: boolean;
   skipFormat?: boolean;
   ignorePaths?: string[];
-  configureTestRunner?: boolean;
+  interactionTests?: boolean;
 }

package/src/generators/storybook-configuration/schema.json

@@ -18,12 +18,18 @@
       "x-dropdown": "projects",
       "x-priority": "important"
     },
+    "interactionTests": {
+      "type": "boolean",
+      "description": "Set up Storybook interaction tests.",
+      "x-prompt": "Do you want to set up Storybook interaction tests?",
+      "alias": ["configureTestRunner"],
+      "x-priority": "important",
+      "default": true
+    },
     "configureCypress": {
       "type": "boolean",
       "description": "Specifies whether to configure Cypress or not.",
-      "x-prompt": "Configure a Cypress e2e app to run against the storybook instance?",
-      "default": true,
-      "x-priority": "important"
+      "x-deprecated": "Please use Storybook interaction tests instead."
     },
     "generateStories": {
       "type": "boolean",
@@ -35,9 +41,7 @@
     "generateCypressSpecs": {
       "type": "boolean",
       "description": "Specifies whether to automatically generate test files in the generated Cypress e2e app.",
-      "x-prompt": "Automatically generate test files in the generated Cypress e2e app?",
-      "default": true,
-      "x-priority": "important"
+      "x-deprecated": "Please use Storybook interaction tests instead."
     },
     "configureStaticServe": {
       "type": "boolean",
@@ -48,7 +52,8 @@
     },
     "cypressDirectory": {
       "type": "string",
-      "description": "A directory where the Cypress project will be placed. Placed at the root by default."
+      "description": "A directory where the Cypress project will be placed. Placed at the root by default.",
+      "x-deprecated": "Please use Storybook interaction tests instead."
     },
     "linter": {
       "description": "The tool to use for running lint checks.",
@@ -59,7 +64,7 @@
     "tsConfiguration": {
       "type": "boolean",
       "description": "Configure your project with TypeScript. Generate main.ts and preview.ts files, instead of main.js and preview.js.",
-      "default": false,
+      "default": true,
       "x-priority": "important"
     },
     "skipFormat": {
@@ -82,10 +87,6 @@
         "**/**/src/**/*.other.*",
         "libs/my-lib/src/not-stories/**,**/**/src/**/*.other.*,apps/my-app/**/*.something.ts"
       ]
-    },
-    "configureTestRunner": {
-      "type": "boolean",
-      "description": "Add a Storybook Test-Runner target."
     }
   },
   "additionalProperties": false,

package/src/migrations/update-16-6-0/explicitly-set-projects-to-update-buildable-deps.js

@@ -9,26 +9,29 @@ const executors = new Set([
     '@nrwl/angular:package',
 ]);
 function default_1(tree) {
+    var _a;
+    var _b;
     return tslib_1.__awaiter(this, void 0, void 0, function* () {
-        const projects = (0, devkit_1.getProjects)(tree);
-        for (const [projectName, project] of projects) {
-            if (project.projectType !== 'library') {
+        // use project graph to get the expanded target configurations
+        const projectGraph = yield (0, devkit_1.createProjectGraphAsync)();
+        for (const [projectName, { data: projectData }] of Object.entries(projectGraph.nodes)) {
+            if (projectData.projectType !== 'library') {
                 continue;
             }
-            let updated = false;
-            for (const [, target] of Object.entries(project.targets || {})) {
+            for (const [targetName, target] of Object.entries(projectData.targets || {})) {
                 if (!executors.has(target.executor)) {
                     continue;
                 }
-                if (target.options &&
+                if (!target.options ||
                     target.options.updateBuildableProjectDepsInPackageJson === undefined) {
-                    target.options.updateBuildableProjectDepsInPackageJson = true;
-                    updated = true;
+                    // read the project configuration to write the explicit project configuration
+                    // and avoid writing the expanded target configuration
+                    const project = (0, devkit_1.readProjectConfiguration)(tree, projectName);
+                    (_a = (_b = project.targets[targetName]).options) !== null && _a !== void 0 ? _a : (_b.options = {});
+                    project.targets[targetName].options.updateBuildableProjectDepsInPackageJson = true;
+                    (0, devkit_1.updateProjectConfiguration)(tree, projectName, project);
                 }
             }
-            if (updated) {
-                (0, devkit_1.updateProjectConfiguration)(tree, projectName, project);
-            }
         }
         yield (0, devkit_1.formatFiles)(tree);
     });