@nx/angular 16.5.0-beta.3 → 16.6.0-beta.0

package/migrations.json

@@ -263,6 +263,12 @@
       },
       "description": "Update the @angular/cli package version to ~16.1.0.",
       "factory": "./src/migrations/update-16-4-0/update-angular-cli"
+    },
+    "explicitly-set-projects-to-update-buildable-deps": {
+      "cli": "nx",
+      "version": "16.6.0-beta.0",
+      "description": "Explicitly set 'updateBuildableProjectDepsInPackageJson' to 'true' in targets that rely on that value as the default.",
+      "factory": "./src/migrations/update-16-6-0/explicitly-set-projects-to-update-buildable-deps"
     }
   },
   "packageJsonUpdates": {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/angular",
-  "version": "16.5.0-beta.3",
+  "version": "16.6.0-beta.0",
   "private": false,
   "description": "The Nx Plugin for Angular contains executors, generators, and utilities for managing Angular applications and libraries within an Nx workspace. It provides: \n\n- Integration with libraries such as Storybook, Jest, ESLint, Tailwind CSS, and Cypress. \n\n- Generators to help scaffold code quickly (like: Micro Frontends, Libraries, both internal to your codebase and publishable to npm) \n\n- Upgrading AngularJS applications \n\n- Single Component Application Modules (SCAMs) \n\n- NgRx helpers. \n\n- Utilities for automatic workspace refactoring.",
   "repository": {
@@ -66,14 +66,14 @@
     "migrations": "./migrations.json"
   },
   "dependencies": {
-    "@nrwl/angular": "16.5.0-beta.3",
-    "@nx/cypress": "16.5.0-beta.3",
-    "@nx/devkit": "16.5.0-beta.3",
-    "@nx/jest": "16.5.0-beta.3",
-    "@nx/js": "16.5.0-beta.3",
-    "@nx/linter": "16.5.0-beta.3",
-    "@nx/webpack": "16.5.0-beta.3",
-    "@nx/workspace": "16.5.0-beta.3",
+    "@nrwl/angular": "16.6.0-beta.0",
+    "@nx/cypress": "16.6.0-beta.0",
+    "@nx/devkit": "16.6.0-beta.0",
+    "@nx/jest": "16.6.0-beta.0",
+    "@nx/js": "16.6.0-beta.0",
+    "@nx/linter": "16.6.0-beta.0",
+    "@nx/webpack": "16.6.0-beta.0",
+    "@nx/workspace": "16.6.0-beta.0",
     "@phenomnomnominal/tsquery": "~5.0.1",
     "@typescript-eslint/type-utils": "^5.36.1",
     "chalk": "^4.1.0",
@@ -109,5 +109,5 @@
   "module": "fesm2022/nx-angular.mjs",
   "typings": "index.d.ts",
   "sideEffects": false,
-  "gitHead": "b9d30fa0f44051be102f67e8555efc05e3de87e5"
+  "gitHead": "5a7ffb93c9e84bffbf52f6ae9c6c1e3b8edb9d35"
 }

package/src/builders/module-federation-dev-server/module-federation-dev-server.impl.js

@@ -30,6 +30,9 @@ function executeModuleFederationDevServerBuilder(schema, context) {
     }
     (0, module_federation_1.validateDevRemotes)(options, workspaceProjects);
     const remotesToSkip = new Set((_a = (0, find_matching_projects_1.findMatchingProjects)(options.skipRemotes, projectGraph.nodes)) !== null && _a !== void 0 ? _a : []);
+    if (remotesToSkip.size > 0) {
+        devkit_1.logger.info(`Remotes not served automatically: ${[...remotesToSkip].join(', ')}`);
+    }
     const staticRemotes = (0, module_federation_1.getStaticRemotes)(project, context, workspaceProjects, remotesToSkip);
     const dynamicRemotes = (0, module_federation_1.getDynamicRemotes)(project, context, workspaceProjects, remotesToSkip, pathToManifestFile);
     const remotes = [...staticRemotes, ...dynamicRemotes];

package/src/builders/module-federation-dev-server/schema.json

@@ -117,7 +117,7 @@
       "items": {
         "type": "string"
       },
-      "description": "List of remote applications to not automatically serve, either statically or in development mode. This can be useful for multi-repository module federation setups where the host application uses a remote application from an external repository."
+      "description": "List of remote applications to not automatically serve, either statically or in development mode."
     },
     "pathToManifestFile": {
       "type": "string",

package/src/builders/module-federation-dev-ssr/schema.json

@@ -73,7 +73,7 @@
       "items": {
         "type": "string"
       },
-      "description": "List of remote applications to not automatically serve, either statically or in development mode. This can be useful for multi-repository module federation setups where the host application uses a remote application from an external repository."
+      "description": "List of remote applications to not automatically serve, either statically or in development mode."
     },
     "verbose": {
       "type": "boolean",

package/src/builders/utilities/module-federation.js

@@ -3,6 +3,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.validateDevRemotes = exports.getStaticRemotes = exports.getDynamicRemotes = void 0;
 const path_1 = require("path");
 const fs_1 = require("fs");
+const devkit_1 = require("@nx/devkit");
 function getDynamicRemotes(project, context, workspaceProjects, remotesToSkip, pathToManifestFile = (0, path_1.join)(context.workspaceRoot, project.sourceRoot, 'assets/module-federation.manifest.json')) {
     // check for dynamic remotes
     // we should only check for dynamic based on what we generate
@@ -22,14 +23,19 @@ function getDynamicRemotes(project, context, workspaceProjects, remotesToSkip, p
     if (!Object.keys(parsedManifest).every((key) => typeof key === 'string' && typeof parsedManifest[key] === 'string')) {
         return [];
     }
-    const dynamicRemotes = Object.entries(parsedManifest)
+    const allDynamicRemotes = Object.entries(parsedManifest)
         .map(([remoteName]) => remoteName)
         .filter((r) => !remotesToSkip.has(r));
-    const invalidDynamicRemotes = dynamicRemotes.filter((remote) => !workspaceProjects[remote]);
-    if (invalidDynamicRemotes.length) {
-        throw new Error(invalidDynamicRemotes.length === 1
-            ? `Invalid dynamic remote configured in "${pathToManifestFile}": ${invalidDynamicRemotes[0]}.`
-            : `Invalid dynamic remotes configured in "${pathToManifestFile}": ${invalidDynamicRemotes.join(', ')}.`);
+    const remotesNotInWorkspace = [];
+    const dynamicRemotes = allDynamicRemotes.filter((remote) => {
+        if (!workspaceProjects[remote]) {
+            remotesNotInWorkspace.push(remote);
+            return false;
+        }
+        return true;
+    });
+    if (remotesNotInWorkspace.length > 0) {
+        devkit_1.logger.warn(`Skipping serving ${remotesNotInWorkspace.join(', ')} as they could not be found in the workspace. Ensure they are served correctly.`);
     }
     return dynamicRemotes;
 }
@@ -46,14 +52,19 @@ function getStaticRemotes(project, context, workspaceProjects, remotesToSkip) {
     const remotesConfig = Array.isArray(mfeConfig.remotes) && mfeConfig.remotes.length > 0
         ? mfeConfig.remotes
         : [];
-    const staticRemotes = remotesConfig
+    const allStaticRemotes = remotesConfig
         .map((remoteDefinition) => Array.isArray(remoteDefinition) ? remoteDefinition[0] : remoteDefinition)
         .filter((r) => !remotesToSkip.has(r));
-    const invalidStaticRemotes = staticRemotes.filter((remote) => !workspaceProjects[remote]);
-    if (invalidStaticRemotes.length) {
-        throw new Error(invalidStaticRemotes.length === 1
-            ? `Invalid static remote configured in "${mfConfigPath}": ${invalidStaticRemotes[0]}.`
-            : `Invalid static remotes configured in "${mfConfigPath}": ${invalidStaticRemotes.join(', ')}.`);
+    const remotesNotInWorkspace = [];
+    const staticRemotes = allStaticRemotes.filter((remote) => {
+        if (!workspaceProjects[remote]) {
+            remotesNotInWorkspace.push(remote);
+            return false;
+        }
+        return true;
+    });
+    if (remotesNotInWorkspace.length > 0) {
+        devkit_1.logger.warn(`Skipping serving ${remotesNotInWorkspace.join(', ')} as they could not be found in the workspace. Ensure they are served correctly.`);
     }
     return staticRemotes;
 }

package/src/executors/ng-packagr-lite/schema.json

@@ -40,7 +40,7 @@
     "updateBuildableProjectDepsInPackageJson": {
       "type": "boolean",
       "description": "Whether to update the buildable project dependencies in the build output package.json.",
-      "default": true
+      "default": false
     },
     "buildableProjectDepsInPackageJsonType": {
       "type": "string",

package/src/executors/package/schema.json

@@ -40,7 +40,7 @@
     "updateBuildableProjectDepsInPackageJson": {
       "type": "boolean",
       "description": "Whether to update the buildable project dependencies in the build output package.json.",
-      "default": true
+      "default": false
     },
     "buildableProjectDepsInPackageJsonType": {
       "type": "string",

package/src/generators/cypress-component-configuration/cypress-component-configuration.js

@@ -18,7 +18,7 @@ const module_info_1 = require("../utils/storybook-ast/module-info");
 function cypressComponentConfiguration(tree, options) {
     return tslib_1.__awaiter(this, void 0, void 0, function* () {
         const projectConfig = (0, devkit_1.readProjectConfiguration)(tree, options.project);
-        const installTask = yield (0, cypress_1.cypressComponentConfiguration)(tree, {
+        const installTask = yield (0, cypress_1.componentConfigurationGenerator)(tree, {
             project: options.project,
             skipFormat: true,
         });

package/src/migrations/update-16-6-0/explicitly-set-projects-to-update-buildable-deps.d.ts

@@ -0,0 +1,2 @@
+import { Tree } from '@nx/devkit';
+export default function (tree: Tree): Promise<void>;

package/src/migrations/update-16-6-0/explicitly-set-projects-to-update-buildable-deps.js

@@ -0,0 +1,36 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+const tslib_1 = require("tslib");
+const devkit_1 = require("@nx/devkit");
+const executors = new Set([
+    '@nx/angular:ng-packagr-lite',
+    '@nrwl/angular:ng-packagr-lite',
+    '@nx/angular:package',
+    '@nrwl/angular:package',
+]);
+function default_1(tree) {
+    return tslib_1.__awaiter(this, void 0, void 0, function* () {
+        const projects = (0, devkit_1.getProjects)(tree);
+        for (const [projectName, project] of projects) {
+            if (project.projectType !== 'library') {
+                continue;
+            }
+            let updated = false;
+            for (const [, target] of Object.entries(project.targets || {})) {
+                if (!executors.has(target.executor)) {
+                    continue;
+                }
+                if (target.options &&
+                    target.options.updateBuildableProjectDepsInPackageJson === undefined) {
+                    target.options.updateBuildableProjectDepsInPackageJson = true;
+                    updated = true;
+                }
+            }
+            if (updated) {
+                (0, devkit_1.updateProjectConfiguration)(tree, projectName, project);
+            }
+        }
+        yield (0, devkit_1.formatFiles)(tree);
+    });
+}
+exports.default = default_1;