@nuskin/ns-product-lib 1.4.4 → 1.4.5-cx12-4643.1

package/CHANGELOG.md

@@ -1,3 +1,11 @@
+## [1.4.5-cx12-4643.1](https://code.tls.nuskin.io/ns-am/product/js-libs/ns-product-lib/compare/v1.4.4...v1.4.5-cx12-4643.1) (2022-07-27)
+
+
+### Fix
+
+* Check for valid productStatusV2Response before reading items (#CX12-4643) ([40cb2a7](https://code.tls.nuskin.io/ns-am/product/js-libs/ns-product-lib/commit/40cb2a770e76c68da33d7322d2947323696d3781)), closes [#CX12-4643](https://code.tls.nuskin.io/ns-am/product/js-libs/ns-product-lib/issues/CX12-4643)
+* sonarQube issue ([82deb06](https://code.tls.nuskin.io/ns-am/product/js-libs/ns-product-lib/commit/82deb06c84af639829394da786184031a07f4da5))
+
 ## [1.4.4](https://code.tls.nuskin.io/ns-am/product/js-libs/ns-product-lib/compare/v1.4.3...v1.4.4) (2022-06-10)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nuskin/ns-product-lib",
-  "version": "1.4.4",
+  "version": "1.4.5-cx12-4643.1",
   "description": "This project contains shared Product models and code between the backend and frontend.",
   "main": "src/index.js",
   "scripts": {

package/src/product.js

@@ -308,7 +308,7 @@ const Product = function(productData) {
       }
       if (productStatus.csv) {
         Object.keys(productStatus.csv).map((csvKey) => {
-          this.addCvWithType(csvKey, productStatus.csv[csvKey]);
+          return this.addCvWithType(csvKey, productStatus.csv[csvKey]);
         }, this);
       }
       this.orderTypes = ProductUtils.mergeOrderTypes(this.orderTypes, productStatus.orderType);

package/src/productStatusMapper.js

@@ -13,7 +13,7 @@ const ProductStatusMapper = {
    */
   createProductStatusesFromV2: function(productStatusV2Response) {
     const productStatuses = [];
-    if (productStatusV2Response.items) {
+    if (productStatusV2Response && productStatusV2Response.items) {
       for (const productStatusSku of Object.keys(productStatusV2Response.items)) {
         const productStatusV2 = productStatusV2Response.items[productStatusSku];
         productStatusV2.sku = productStatusSku;
@@ -55,11 +55,12 @@ const ProductStatusMapper = {
 * @return {String}
 */
 function getStatusPartFromV2(productStatusV2) {
-  const retailStatusIsReleased = productStatusV2.status.retail === 'RELEASED_FOR_SALE';
+  const status = productStatusV2.status || {};
+  const retailStatusIsReleased = status.retail === 'RELEASED_FOR_SALE';
   const wholesaleStatusIsReleased =
-  productStatusV2.status.wholesale === 'RELEASED_FOR_SALE';
-  const retailNotSet = productStatusV2.status.retail === 'NOT_SET_FOR_DIST_TYPE';
-  const wholesaleNotSet = productStatusV2.status.wholesale === 'NOT_SET_FOR_DIST_TYPE';
+  status.wholesale === 'RELEASED_FOR_SALE';
+  const retailNotSet = status.retail === 'NOT_SET_FOR_DIST_TYPE';
+  const wholesaleNotSet = status.wholesale === 'NOT_SET_FOR_DIST_TYPE';
   if (retailStatusIsReleased || wholesaleStatusIsReleased) {
     return 'RELEASED_FOR_SALE';
   }
@@ -69,14 +70,14 @@ function getStatusPartFromV2(productStatusV2) {
       return 'NOT_RELEASED_FOR_SALE';
     }
     if (retailNotSet) {
-      return productStatusV2.status.wholesale;
+      return status.wholesale;
     }
     if (wholesaleNotSet) {
-      return productStatusV2.status.retail;
+      return status.retail;
     }
   }
 
-  return productStatusV2.status.retail;
+  return status.retail;
 }
 
 /**