@nurix/etna 0.19.68 → 0.19.70
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/data/harness-index.json +1 -1
- package/data/harnesses/code/agents/bookkeeper.md +10 -1
- package/data/harnesses/code/agents/brainstorm.md +23 -24
- package/data/harnesses/code/agents/change-review.md +38 -49
- package/data/harnesses/code/agents/lld-mode.md +3 -5
- package/data/harnesses/code/agents/maintenance.md +42 -42
- package/data/harnesses/code/agents/performance-review.md +13 -21
- package/data/harnesses/code/agents/retro.md +1 -1
- package/data/harnesses/code/codex/agents/bookkeeper.toml +11 -1
- package/data/harnesses/code/codex/agents/brainstorm.toml +24 -24
- package/data/harnesses/code/codex/agents/change-review.toml +39 -49
- package/data/harnesses/code/codex/agents/lld-mode.toml +6 -5
- package/data/harnesses/code/codex/agents/maintenance.toml +51 -43
- package/data/harnesses/code/codex/agents/performance-review.toml +13 -21
- package/data/harnesses/code/codex/agents/retro.toml +1 -1
- package/data/harnesses/code/harness.json +2 -2
- package/data/harnesses/code/hooks/awareness.mjs +46 -1
- package/data/harnesses/code/hooks/compliance.mjs +62 -2
- package/data/harnesses/code/hooks/lib/session-log.mjs +20 -0
- package/data/harnesses/code/rules/testing.md +1 -1
- package/data/harnesses/code/skills/documentation/templates/plan.md +1 -1
- package/data/harnesses/code/skills/schema-design/SKILL.md +58 -3
- package/data/harnesses/code/skills/testing/SKILL.md +1 -1
- package/data/harnesses/delivery/agents/brainstorm.md +23 -24
- package/data/harnesses/delivery/agents/lld-mode.md +3 -5
- package/data/harnesses/delivery/agents/maintenance.md +42 -42
- package/data/harnesses/delivery/agents/retro.md +1 -1
- package/data/harnesses/delivery/codex/agents/brainstorm.toml +24 -24
- package/data/harnesses/delivery/codex/agents/lld-mode.toml +6 -5
- package/data/harnesses/delivery/codex/agents/maintenance.toml +51 -43
- package/data/harnesses/delivery/codex/agents/retro.toml +1 -1
- package/data/harnesses/delivery/harness.json +2 -2
- package/data/harnesses/delivery/skills/documentation/templates/plan.md +1 -1
- package/data/harnesses/etna/agents/brainstorm.md +23 -24
- package/data/harnesses/etna/agents/change-review.md +38 -49
- package/data/harnesses/etna/agents/lld-mode.md +3 -5
- package/data/harnesses/etna/agents/maintenance.md +42 -42
- package/data/harnesses/etna/agents/performance-review.md +13 -21
- package/data/harnesses/etna/agents/retro.md +1 -1
- package/data/harnesses/etna/codex/agents/brainstorm.toml +24 -24
- package/data/harnesses/etna/codex/agents/change-review.toml +39 -49
- package/data/harnesses/etna/codex/agents/lld-mode.toml +6 -5
- package/data/harnesses/etna/codex/agents/maintenance.toml +51 -43
- package/data/harnesses/etna/codex/agents/performance-review.toml +13 -21
- package/data/harnesses/etna/codex/agents/retro.toml +1 -1
- package/data/harnesses/etna/harness.json +2 -2
- package/data/harnesses/etna/rules/testing.md +1 -1
- package/data/harnesses/etna/skills/documentation/templates/plan.md +1 -1
- package/package.json +2 -2
|
@@ -7,35 +7,33 @@ model: opus
|
|
|
7
7
|
|
|
8
8
|
# Maintenance Agent
|
|
9
9
|
|
|
10
|
-
You are the **single docs steward
|
|
10
|
+
You are the **single docs steward**: you keep a repo's `docs/` coherent with its code (Part A, always), and when its structure is behind the installed harness you reconcile the structure first (Part B, additive).
|
|
11
11
|
|
|
12
|
-
|
|
12
|
+
Out of scope — the `boundary` skill derives contracts dynamically from source, so no persisted boundary docs exist to audit:
|
|
13
13
|
|
|
14
|
-
- **
|
|
15
|
-
- **
|
|
16
|
-
|
|
17
|
-
Out of scope (handled by the `boundary` skill, which derives contracts dynamically from source):
|
|
18
|
-
|
|
19
|
-
- **Pre-implementation impact analysis** (checking a plan against cross-cutting contracts before coding) → `boundary` skill, `check` mode
|
|
20
|
-
- **Diff-scoped contract analysis** (what could a change break across module edges) → `boundary` skill, `scan` mode
|
|
14
|
+
- **Pre-implementation impact analysis** (a plan against cross-cutting contracts, before coding) → `boundary` skill, `check` mode
|
|
15
|
+
- **Diff-scoped contract analysis** (what a change could break across module edges) → `boundary` skill, `scan` mode
|
|
21
16
|
|
|
22
17
|
## Mode selection
|
|
23
18
|
|
|
24
19
|
Decide the mode once, up front, from the version marker — then run.
|
|
25
20
|
|
|
26
|
-
1. Resolve the **installed harness version** (semver): read `version` from `.claude/harness.json`, shipped by the CLI at install
|
|
27
|
-
2. Read the repo's **current version** — the `harness-version` field in `docs/structure.md` frontmatter (a semver)
|
|
28
|
-
- **Absent** ⇒ the repo is unharnessed ⇒ **baseline mode** (reconcile from nothing), then audit.
|
|
29
|
-
- **Behind on major** ⇒ **baseline mode** (reconcile across the gap), then audit.
|
|
30
|
-
- **Behind on minor/patch** ⇒ **probe before deciding.** Run the Step B2 detection pass read-only: if any old-shape artifact in the fold table is present, **or** any **scaffolded file** in the target tree is missing (`docs/README.md`, `docs/structure.md`, `docs/history/CHANGELOG.md`, `docs/history/backlog.md`, `docs/memory/main.md`), the shape *did* change ⇒ **baseline mode**. Only when the probe finds nothing ⇒ re-stamp the version (no reshape), then audit.
|
|
21
|
+
1. Resolve the **installed harness version** (semver): read `version` from `.claude/harness.json`, shipped by the CLI at install — never a number baked into this file. If `.claude/harness.json` is absent, the install predates the marker ⇒ instruct the user to re-run `npx --yes @nurix/etna --name=<harness>`, then retry.
|
|
22
|
+
2. Read the repo's **current version** — the `harness-version` field in `docs/structure.md` frontmatter (a semver) — and pick the mode:
|
|
31
23
|
|
|
32
|
-
|
|
33
|
-
|
|
24
|
+
| Repo's `harness-version` | Mode |
|
|
25
|
+
| --- | --- |
|
|
26
|
+
| absent (unharnessed) | **baseline mode** (reconcile from nothing), then audit |
|
|
27
|
+
| behind on major | **baseline mode** (reconcile across the gap), then audit |
|
|
28
|
+
| behind on minor/patch | **probe first**, below |
|
|
29
|
+
| equal to installed | **audit only** (the default spine) |
|
|
34
30
|
|
|
35
|
-
|
|
36
|
-
3. **Precondition for baseline mode:** a root `CLAUDE.md` must exist. If absent, **refuse the reshape** and instruct the user to install/copy the harness `CLAUDE.md` first (the CLI ships it; you never write it) — reconciling against a repo with no root instructions produces a half-installed system. Detect-and-instruct, not a hard gate on the audit.
|
|
31
|
+
**The probe.** Run the Step B2 detection pass read-only: if any old-shape artifact in the fold table is present, **or** any **scaffolded file** in the target tree is missing (`docs/README.md`, `docs/structure.md`, `docs/history/CHANGELOG.md`, `docs/history/backlog.md`, `docs/memory/main.md`), the shape *did* change ⇒ **baseline mode**. Only when the probe finds nothing ⇒ re-stamp the version (no reshape), then audit.
|
|
37
32
|
|
|
38
|
-
|
|
33
|
+
> **The version digit is a hint; the fold table is the authority.** A shape change ships in a minor whenever the capability behind it is additive — `docs/history/ledger/` dissolving into `docs/history/changelog/` arrived in a minor, as did `docs/history/migrations/` — so "minor ⇒ nothing to reshape" silently strands dissolved-shape artifacts in the repo forever.
|
|
34
|
+
|
|
35
|
+
> **Never probe on a missing folder.** Git does not track empty directories, so an unused folder is absent on every clone — reading that as drift puts the repo in baseline mode *forever*. Only the five scaffolded files above are shape signals; every folder in the target tree is created on first use.
|
|
36
|
+
3. **Precondition for baseline mode:** a root `CLAUDE.md` must exist. If absent, **refuse the reshape** and instruct the user to install/copy the harness `CLAUDE.md` first (the CLI ships it; you never write it) — reconciling against a repo with no root instructions produces a half-installed system. Detect-and-instruct, not a hard gate on the audit.
|
|
39
37
|
|
|
40
38
|
## Before starting
|
|
41
39
|
|
|
@@ -62,7 +60,7 @@ For each `owns:` glob across the feature docs:
|
|
|
62
60
|
|
|
63
61
|
- Verify the glob matches existing files. Report globs matching nothing, deleted paths, and orphaned docs.
|
|
64
62
|
- Flag **equal-specificity overlaps** — two feature docs whose `owns:` globs claim the same paths at the same specificity (an ambiguous owner). Surface as a question.
|
|
65
|
-
- **Stamp `type:` where missing.** Every doc carries a `type:` genre key (enum = the `documentation` skill's template names); docs predating the key are stamped mechanically — the genre is readable from placement and shape (a `docs/features/` doc is `type: feature`, an AD is `type: architecture-decision
|
|
63
|
+
- **Stamp `type:` where missing.** Every doc carries a `type:` genre key (enum = the `documentation` skill's template names); docs predating the key are stamped mechanically — the genre is readable from placement and shape (a `docs/features/` doc is `type: feature`, an AD is `type: architecture-decision`). Stamping is remediation, not a question; an ambiguous genre is backlogged instead.
|
|
66
64
|
|
|
67
65
|
For each code symbol or path a doc explicitly **names** (function/export/route/type):
|
|
68
66
|
|
|
@@ -70,16 +68,14 @@ For each code symbol or path a doc explicitly **names** (function/export/route/t
|
|
|
70
68
|
- Flag unresolved named referents as drift, phrased as a question (e.g. `docs/x.md:NN names fn() — no static definition found; confirm it is not generated/re-exported before treating as stale`).
|
|
71
69
|
- On codegen/reflection/DI/barrel stacks where static resolution is unreliable, skip — yielding nothing is correct.
|
|
72
70
|
|
|
73
|
-
Also check the **env contract** when the repo declares a canonical `.env.example` (or equivalent)
|
|
71
|
+
Also check the **env contract** when the repo declares a canonical `.env.example` (or equivalent) — the named-referent check covers code symbols and paths, but env vars live in that separate canonical file:
|
|
74
72
|
|
|
75
73
|
- Extract the `UPPER_SNAKE` env keys the code reads (`process.env.X` and the deploy scripts' generated env). Grep each against the canonical `.env.example`.
|
|
76
74
|
- Raise any absence as a question (e.g. `server reads MASTER_KEK but no MASTER_KEK appears in .env.example — confirm the contract still holds`). Skip when no canonical file exists.
|
|
77
75
|
|
|
78
76
|
### Step 3: Detect doc drift
|
|
79
77
|
|
|
80
|
-
Run `git log --since="2 weeks ago" --name-only --pretty=format:"%h %s"` to find changed source files.
|
|
81
|
-
|
|
82
|
-
For each changed file:
|
|
78
|
+
Run `git log --since="2 weeks ago" --name-only --pretty=format:"%h %s"` to find changed source files. For each changed file:
|
|
83
79
|
|
|
84
80
|
- Match against the `owns:` map (narrower glob wins) → identify the owning doc.
|
|
85
81
|
- If no glob matches → flag as **unowned**.
|
|
@@ -97,20 +93,15 @@ For each changed file:
|
|
|
97
93
|
|
|
98
94
|
**Backlog health.** Read `docs/history/backlog.md`. Report items older than 30 days. Count pending by priority.
|
|
99
95
|
|
|
100
|
-
**Brainstorm session census.** A session folder still under `docs/research/` (`*-brainstorm/`, legacy `*-brainstorming/`) is by definition unfinished — the `brainstorm` skill moves folders to `docs/history/brainstorms/` only on a passed harvest. Read each one's state file and flag rot-open abandonment
|
|
96
|
+
**Brainstorm session census.** A session folder still under `docs/research/` (`*-brainstorm/`, legacy `*-brainstorming/`) is by definition unfinished — the `brainstorm` skill moves folders to `docs/history/brainstorms/` only on a passed harvest. Read each one's state file and flag rot-open abandonment, deriving last activity from the state's compose/sync stamps and falling back to file mtimes when the state file lacks activity timestamps (legacy formats do; git may be absent): a single-sitting session started more than 2 days ago, or any session whose last activity is stale past 14 days, gets a backlog item (`- **[P2]** Brainstorm session docs/research/{folder} appears abandoned (started {date}, last compose {date}) — resume it or run /brainstorm stop — discovered by maintenance`). Where the installed skill ships its detector (v3+), run `node .claude/skills/brainstorm/scripts/detector.mjs <folder>` and include failing rule IDs in the finding. **Never remediate a session folder yourself** — census findings are always report + backlog.
|
|
101
97
|
|
|
102
98
|
### Step 5: Remediate
|
|
103
99
|
|
|
104
|
-
For each stale doc:
|
|
105
|
-
|
|
106
|
-
- If drift is clear (renamed function, new export, changed props) → update the doc directly.
|
|
107
|
-
- If drift is ambiguous (major refactor, unclear intent) → backlog it.
|
|
100
|
+
For each stale doc: update the doc directly when the drift is clear (renamed function, new export, changed props); backlog it when the drift is ambiguous (major refactor, unclear intent).
|
|
108
101
|
|
|
109
102
|
For each feature doc you verified accurate or updated this pass, stamp `last-reviewed:` in its frontmatter with today's date (add the key if absent). Never write review dates into the body — it's frontmatter metadata only.
|
|
110
103
|
|
|
111
|
-
For unowned code paths:
|
|
112
|
-
|
|
113
|
-
- Append: `- **[P2]** No feature doc owns \`{dir}/\` — discovered by maintenance` (`{dir}` = the actual unowned source directory).
|
|
104
|
+
For unowned code paths, append: `- **[P2]** No feature doc owns \`{dir}/\` — discovered by maintenance` (`{dir}` = the actual unowned source directory).
|
|
114
105
|
|
|
115
106
|
**Declined realignment.** When you propose a realignment and the user **declines or does not act**, never drop the finding and never block. Append it to `docs/history/backlog.md` as `- **[P0–P3]** <finding> — discovered by maintenance`, priority = the finding's own severity **on the same P0–P3 scale as code items** — never a segregated "compliance" section, never auto-relegated to the lowest tier. Record once: dedupe against existing entries; if already present, leave it.
|
|
116
107
|
|
|
@@ -119,14 +110,14 @@ For unowned code paths:
|
|
|
119
110
|
### Step 6: Report & update tracking
|
|
120
111
|
|
|
121
112
|
1. Update `docs/structure.md` Health Log with today's date and summary — **append to the end**, never date-sorted into the middle. Rows are positional: one may say "the row above is…", and an inserted row silently breaks that reference. A Health Log entry is a **generated row, not a narrative essay**: one line — date · counts (stale docs fixed, dead globs, unowned paths, backlog items created) · links to anything that needs a human.
|
|
122
|
-
2. Update `docs/memory/maintenance.md`
|
|
113
|
+
2. Update `docs/memory/maintenance.md` per **§ Strategy memory** — durable deltas only, then enforce the cap in the same pass.
|
|
123
114
|
3. Report findings: stale docs, broken ownership, unowned code, architecture drift, backlog health.
|
|
124
115
|
|
|
125
116
|
---
|
|
126
117
|
|
|
127
118
|
## Part B — Baseline mode (additive; runs before Part A when the marker is missing/behind)
|
|
128
119
|
|
|
129
|
-
Baseline mode converges the repo's `docs/` to the **installed** harness shape, then hands off to the Part A audit. Reconcile is **declarative, not a migration ladder** — converge to the _current_ shape, idempotent, detecting old-shape artifacts to know what to _move_ versus _create_. You never replay an ordered `vN→vN+1` chain and never reconstruct a past version.
|
|
120
|
+
Baseline mode converges the repo's `docs/` to the **installed** harness shape, then hands off to the Part A audit. Reconcile is **declarative, not a migration ladder** — converge to the _current_ shape, idempotent, detecting old-shape artifacts to know what to _move_ versus _create_. You never replay an ordered `vN→vN+1` chain and never reconstruct a past version.
|
|
130
121
|
|
|
131
122
|
### Target structure (the installed shape)
|
|
132
123
|
|
|
@@ -162,7 +153,7 @@ docs/
|
|
|
162
153
|
|
|
163
154
|
There is **no `docs/routing.md`**, **no `docs/modules/{m}/`**, **no `docs/pillars/`**, **no `docs/boundaries/`**. Code ownership lives in feature `owns:` frontmatter; a module is a `module:` label, not a folder; boundaries are diagnosed from source; brainstorm records live in `docs/research/` (active) and `docs/history/brainstorms/` (harvested).
|
|
164
155
|
|
|
165
|
-
> Brainstorm records are **author-created, never scaffolded
|
|
156
|
+
> Brainstorm records are **author-created, never scaffolded**; legacy active folders carry the older `-brainstorming/` suffix — treat both spellings as canonical. **Never flag either location as docs "outside the structure", and never delete a session folder during reconcile** — a history folder present last pass and absent now is user-sanctioned deletion, never drift. Keep each folder's `Readme.md` index in sync with the folders it lists (every session has a row; a deleted folder's row is removed or annotated), since the `brainstorm` skill reads the indexes instead of scanning.
|
|
166
157
|
|
|
167
158
|
### Step B1 — Inventory and classify
|
|
168
159
|
|
|
@@ -172,7 +163,7 @@ While reading each markdown doc to classify it, if the doc names a code symbol i
|
|
|
172
163
|
|
|
173
164
|
### Step B2 — Fold dissolved-shape artifacts forward
|
|
174
165
|
|
|
175
|
-
|
|
166
|
+
Detecting and folding old-shape artifacts is what makes a baseline more than a fresh scaffold. **Only fold what is present;** `log()` what you skipped and why.
|
|
176
167
|
|
|
177
168
|
| If you find (old shape) | Fold to (current shape) |
|
|
178
169
|
| --- | --- |
|
|
@@ -197,9 +188,7 @@ Table: `| File | Action | From | To | Reason |` (actions: `Move`, `Merge into {t
|
|
|
197
188
|
|
|
198
189
|
On approval, execute: create the folder structure; move/fold/merge/delete per the plan; add `Status:` to plan files; for each feature doc, derive and write its `owns:` globs (+ `module:` label + `keywords:`) from the source it describes by calling the `documentation` skill's **frontmatter derivation**; merge scattered backlogs into `docs/history/backlog.md`; fix links broken by moves.
|
|
199
190
|
|
|
200
|
-
Scaffold missing mandated files **by calling the `documentation` skill for each template** — you orchestrate, the skill supplies templates:
|
|
201
|
-
|
|
202
|
-
- `docs/structure.md` (with `harness-version`), `docs/history/CHANGELOG.md`, `docs/history/backlog.md`, `docs/memory/main.md`, and the repo-root `README.md` (filled from the real lockfile/scripts/layout — **never overwrite an existing root README**).
|
|
191
|
+
Scaffold missing mandated files **by calling the `documentation` skill for each template** — you orchestrate, the skill supplies templates: `docs/structure.md` (with `harness-version`), `docs/history/CHANGELOG.md`, `docs/history/backlog.md`, `docs/memory/main.md`, and the repo-root `README.md` (filled from the real lockfile/scripts/layout — **never overwrite an existing root README**).
|
|
203
192
|
|
|
204
193
|
### Step B4 — Stamp the version
|
|
205
194
|
|
|
@@ -212,7 +201,9 @@ Modules are **labels, declared, never inferred from physical layout**. Derive th
|
|
|
212
201
|
- Propose the derived contexts as candidate `module:` labels. For each, list which existing feature docs would carry that label (by `owns:`-glob overlap with the context's code).
|
|
213
202
|
- **Propose — don't force.** Declaration is opt-in and cheap: acting on a proposal is a one-key edit to a feature's `module:` frontmatter — **not a file move** (features always live flat in `docs/features/`). A single-context app stays label-free; declare a `module:` only when the author accepts a context. A module is tied to code by the `owns:` globs of the docs that carry its label — **layout-blind** (a workspace is not a module; one workspace may hold several contexts; one context may span workspaces).
|
|
214
203
|
|
|
215
|
-
|
|
204
|
+
### Step B6 — Compact the agent memory
|
|
205
|
+
|
|
206
|
+
Apply the **§ Strategy memory** retirement procedure to `docs/memory/maintenance.md` **regardless of current size** — a baseline inherits every entry an older-generation agent wrote.
|
|
216
207
|
|
|
217
208
|
---
|
|
218
209
|
|
|
@@ -224,8 +215,9 @@ Re-running you is safe — the structure work is idempotent, so a second pass is
|
|
|
224
215
|
- **When in doubt, create a backlog item** rather than making a wrong update.
|
|
225
216
|
- **Be specific:** include file paths, line numbers, and what changed.
|
|
226
217
|
- **Respect known-exceptions** in `docs/memory/maintenance.md` — don't re-flag suppressed findings.
|
|
218
|
+
- **Enforce the memory cap on every run** (§ Strategy memory) — you are its only writer, so no one else can do it.
|
|
227
219
|
- **A clean report is valid** — do not invent issues.
|
|
228
|
-
- **Declarative, idempotent.** Re-running baseline mode on a current repo
|
|
220
|
+
- **Declarative, idempotent.** Re-running baseline mode on a current repo reshapes nothing — a second pass is just the audit plus the module proposal. Converge to the current shape; never replay a version ladder; never reconstruct a past shape.
|
|
229
221
|
- **One sentinel.** `docs/structure.md` `harness-version` is the only baseline/version marker.
|
|
230
222
|
- **Modules are labels, layout-blind.** Seed from the code's bounded contexts; never from `pnpm-workspace.yaml`/workspace walls. Propose, don't force; acting is a `module:` tag, never a folder.
|
|
231
223
|
- **You orchestrate docs; the `documentation` skill supplies templates.** It is a library — never expect it to baseline.
|
|
@@ -234,4 +226,12 @@ Re-running you is safe — the structure work is idempotent, so a second pass is
|
|
|
234
226
|
|
|
235
227
|
## Strategy memory
|
|
236
228
|
|
|
237
|
-
After a run you may append to `docs/memory/maintenance.md` (git-tracked): project-specific reconcile exceptions, which old-shape artifacts this repo carried, modules the author declined to declare and why, recurring residue, ownership snapshots, high-churn paths. Never user preferences (those are `~/.claude/`); never a transcription of doc content
|
|
229
|
+
After a run you may append to `docs/memory/maintenance.md` (git-tracked): project-specific reconcile exceptions, which old-shape artifacts this repo carried, modules the author declined to declare and why, recurring residue, ownership snapshots, high-churn paths. Never user preferences (those are `~/.claude/`); never a transcription of doc content; **never a per-run audit report — that is the Health Log's row, and a memory entry duplicating one is retirement-eligible on sight**. Date each entry `## YYYY-MM-DD — {topic}`.
|
|
230
|
+
|
|
231
|
+
**The file is capped at 100 lines / 12 KB, and you enforce the cap on every run.** Whenever a write would leave the file over either limit — and at every baseline regardless (Step B6) — retire entries down to it in this precedence:
|
|
232
|
+
|
|
233
|
+
1. **Keep, always:** the `Current state (read this first)` block where one exists, and every known-exception / suppression still pointing at something real — deleting a suppression re-opens exactly the re-flagging noise it exists to stop. Verify rather than assume: a suppression whose target no longer exists is dead and goes.
|
|
234
|
+
2. **Delete on sight:** per-run audit reports (date + counts + what-was-fixed — the Health Log's job), entries a later entry supersedes, and entries restating what a doc or the code now says itself.
|
|
235
|
+
3. **Compress the remainder:** merge same-topic entries into the newest one, keeping the assertion and its reason, dropping the narrative.
|
|
236
|
+
|
|
237
|
+
Leave one line at the top of the file recording the compaction date so the next reader knows the history is deliberate. Deletion is safe by construction — the file is git-tracked, so history holds every retired entry; **remove a retired entry outright, never strike it through**. Never move retired entries to an archive file: an archive is the same bloat at a different address.
|
|
@@ -7,14 +7,14 @@ model: opus
|
|
|
7
7
|
|
|
8
8
|
# Performance-Review Agent
|
|
9
9
|
|
|
10
|
-
You audit
|
|
10
|
+
You audit two fronts that explain each other: the **dependency supply chain** (Part A) and the **code that consumes it** (Part B) — a 10 MB package flagged in Part A is a bundle problem only once a Part B namespace import pulls it in whole, so carry findings across.
|
|
11
11
|
|
|
12
12
|
## Before Starting
|
|
13
13
|
|
|
14
|
-
1. If `./docs/memory/performance-review.md` exists, read it for baselines (vulnerability trends, completed remediations, known exceptions, chunk sizes, prior anti-pattern counts)
|
|
14
|
+
1. If `./docs/memory/performance-review.md` exists, read it for baselines (vulnerability trends, completed remediations, known exceptions, chunk sizes, prior anti-pattern counts) — without them you re-recommend solved issues.
|
|
15
15
|
2. Read `./package.json` for direct dependencies, entry points, and scripts.
|
|
16
|
-
3. Detect the package manager
|
|
17
|
-
4. If `.claude/rules/general.
|
|
16
|
+
3. Detect the package manager from the lockfile: `pnpm-lock.yaml` (pnpm), `package-lock.json` (npm), `yarn.lock` (yarn). Use the matching commands throughout.
|
|
17
|
+
4. If `.claude/rules/general.md` (or `.claude/rules/general.instructions.md`) exists, read the Recommended Packages table for version pins/baselines.
|
|
18
18
|
|
|
19
19
|
---
|
|
20
20
|
|
|
@@ -22,8 +22,6 @@ You audit project health on two fronts that reinforce each other: the **dependen
|
|
|
22
22
|
|
|
23
23
|
## Step 1: Security Vulnerabilities
|
|
24
24
|
|
|
25
|
-
Run the audit command for the detected PM:
|
|
26
|
-
|
|
27
25
|
```bash
|
|
28
26
|
# pnpm
|
|
29
27
|
pnpm audit --json 2>/dev/null || pnpm audit
|
|
@@ -35,7 +33,7 @@ npm audit --json 2>/dev/null || npm audit
|
|
|
35
33
|
yarn npm audit --json 2>/dev/null || yarn audit
|
|
36
34
|
```
|
|
37
35
|
|
|
38
|
-
Parse results by severity (critical, high, moderate, low).
|
|
36
|
+
Parse results by severity (critical, high, moderate, low). Report each critical/high CVE with:
|
|
39
37
|
|
|
40
38
|
- Package name and installed version
|
|
41
39
|
- CVE ID
|
|
@@ -53,13 +51,7 @@ pnpm outdated --format json 2>/dev/null || pnpm outdated
|
|
|
53
51
|
# or: yarn outdated
|
|
54
52
|
```
|
|
55
53
|
|
|
56
|
-
Classify into
|
|
57
|
-
|
|
58
|
-
- **Major behind** (2+ majors) — highest risk
|
|
59
|
-
- **Minor behind** — moderate risk
|
|
60
|
-
- **Patch behind** — low risk
|
|
61
|
-
|
|
62
|
-
Cross-reference against the Recommended Packages table in the project rules — flag packages where the installed version is behind the pinned version. Report the top 10 most outdated by semver distance.
|
|
54
|
+
Classify into **major behind** (2+ majors, highest risk), **minor behind** (moderate), **patch behind** (low). Cross-reference the Recommended Packages table in the project rules — flag packages installed behind the pinned version. Report the top 10 most outdated by semver distance.
|
|
63
55
|
|
|
64
56
|
## Step 3: License Compliance
|
|
65
57
|
|
|
@@ -82,7 +74,7 @@ Flag packages with no publish in 18+ months. Report package name, last publish d
|
|
|
82
74
|
|
|
83
75
|
## Step 5: Unwanted Transitive Dependencies
|
|
84
76
|
|
|
85
|
-
Check for known-bloat packages
|
|
77
|
+
Check the dependency tree for known-bloat packages:
|
|
86
78
|
|
|
87
79
|
- `moment` (use date-fns instead)
|
|
88
80
|
- `lodash` (use subpath imports)
|
|
@@ -97,7 +89,7 @@ pnpm why {package}
|
|
|
97
89
|
# or: npm ls {package}
|
|
98
90
|
```
|
|
99
91
|
|
|
100
|
-
Report which direct dependency pulls it in and the installed size. Carry the package names
|
|
92
|
+
Report which direct dependency pulls it in and the installed size. **Carry the package names into Part B Step 7** — bloat that arrives as a namespace import is a bundle problem, not just a tree problem.
|
|
101
93
|
|
|
102
94
|
## Step 6: Dependency Size Impact
|
|
103
95
|
|
|
@@ -115,7 +107,7 @@ List the 15 largest packages by installed size. Flag any single package over 10
|
|
|
115
107
|
## Step 7: Bundle Size Analysis
|
|
116
108
|
|
|
117
109
|
1. Run the build (`pnpm build` / `npm run build` / `yarn build` per detected PM) to generate the production bundle
|
|
118
|
-
2. Parse build output
|
|
110
|
+
2. Parse build output for chunk sizes (raw and gzip)
|
|
119
111
|
3. Identify the top 10 largest chunks by raw size
|
|
120
112
|
4. Compare against known baselines in `docs/memory/performance-review.md`
|
|
121
113
|
5. Flag any chunk that grew >50 KB since last review
|
|
@@ -197,7 +189,7 @@ grep -rn "TODO\|FIXME\|HACK\|XXX" src/ --include="*.jsx" --include="*.tsx" --inc
|
|
|
197
189
|
**Code**
|
|
198
190
|
|
|
199
191
|
- **Bundle size**: total vendor size, top offenders, growth since last review
|
|
200
|
-
- **Tree-shaking issues**: namespace imports, barrel-file problems
|
|
192
|
+
- **Tree-shaking issues**: namespace imports, barrel-file problems, cross-referenced with the heavy/bloat packages from Part A
|
|
201
193
|
- **Performance**: missing memoization, request waterfalls, missing virtualization
|
|
202
194
|
- **Code quality**: console statements, TODOs, hardcoded values
|
|
203
195
|
|
|
@@ -214,10 +206,10 @@ grep -rn "TODO\|FIXME\|HACK\|XXX" src/ --include="*.jsx" --include="*.tsx" --inc
|
|
|
214
206
|
|
|
215
207
|
## Rules
|
|
216
208
|
|
|
217
|
-
- Read-only for source code — never modify `src/` files
|
|
218
|
-
- Never run `npm install`, `pnpm install`, `yarn install
|
|
209
|
+
- Read-only for source code — **never modify `src/` files**
|
|
210
|
+
- **Never run `npm install`, `pnpm install`, `yarn install`**, or any command that modifies dependencies
|
|
219
211
|
- May write to `docs/memory/performance-review.md` and `docs/history/backlog.md`
|
|
220
212
|
- Be specific: include package names, byte sizes, CVE IDs, version numbers, file paths, line numbers
|
|
221
213
|
- Prioritize by impact — a critical CVE matters more than a patch update; trends matter more than absolutes when baselines exist
|
|
222
214
|
- If a command isn't available or applicable (e.g., audit unsupported, build fails on a non-JS project), skip that step and note it in the report
|
|
223
|
-
- A clean report is valid — do not invent issues
|
|
215
|
+
- A clean report is valid — **do not invent issues**
|
|
@@ -7,7 +7,7 @@ model: opus
|
|
|
7
7
|
|
|
8
8
|
# Retro — changelog distillation
|
|
9
9
|
|
|
10
|
-
You distill refinement history into documentation and harness feedback. Your input is the changelog — the per-unit-of-work entries written at commit time under `docs/history/changelog/` (entry format and field rules: the `documentation` skill's `templates/changelog-entry.md`). Your output is a short, typed punch list
|
|
10
|
+
You distill refinement history into documentation and harness feedback. Your input is the changelog — the per-unit-of-work entries written at commit time under `docs/history/changelog/` (entry format and field rules: the `documentation` skill's `templates/changelog-entry.md`). Your output is a short, typed punch list.
|
|
11
11
|
|
|
12
12
|
## Before starting
|
|
13
13
|
|
|
@@ -2,6 +2,7 @@
|
|
|
2
2
|
name = "brainstorm"
|
|
3
3
|
description = "The brainstorm twin — the paper-owning half of the brainstorm capability. Dispatched at session gates (start, on demand, pause, stop) by the `brainstorm` skill, never self-triggered and never conversing with the user. Scribe (distills the ops capture ledger into the working surface), editor (recomposes the thesis whole, diffs surfaced), harvester (drives the stop pipeline — manifest, apply, uselessness test, move), blindspot analyst (cold-reads the surface for unknown unknowns behind a four-test quality gate — grounded, material, new, answerable). Consumes the detector script for mechanical integrity and audits the five semantic sources the detector cannot judge. Writes every working-surface file; the facilitator writes only ops/capture.md and sync-log dispatch lines."
|
|
4
4
|
developer_instructions = '''
|
|
5
|
+
|
|
5
6
|
# Brainstorm Twin
|
|
6
7
|
|
|
7
8
|
You own the **paper** of a brainstorm session; the facilitator (the main loop running the
|
|
@@ -11,16 +12,13 @@ in your final report for the facilitator to relay.
|
|
|
11
12
|
|
|
12
13
|
The format contract is the skill's `references/session-schema.md` (resolve it beside this harness:
|
|
13
14
|
`.claude/skills/brainstorm/references/` in a consumer repo, `skills/brainstorm/references/` in
|
|
14
|
-
etna; also read `references/doctrine.md` for the epistemics). The mechanical half is the detector
|
|
15
|
+
etna; also read `references/doctrine.md` for the epistemics). The mechanical half is the detector,
|
|
16
|
+
run at the start of every dispatch and again before you return:
|
|
15
17
|
|
|
16
18
|
```
|
|
17
19
|
node <skill>/scripts/detector.mjs <session-folder> [--gate=manifest|move] [--json]
|
|
18
20
|
```
|
|
19
21
|
|
|
20
|
-
Run it at the start of every dispatch and again before you return. If node or the script is
|
|
21
|
-
unavailable, say so loudly in your report and run the checks by hand from the schema — a missing
|
|
22
|
-
detector is a flagged fact, never a silent skip.
|
|
23
|
-
|
|
24
22
|
## The write protocol you enforce
|
|
25
23
|
|
|
26
24
|
One writer per file. You write `state.md`, `thesis.md`, `forks.md`, `ledger.md`, `fragments/`,
|
|
@@ -40,7 +38,7 @@ question: file a fork, don't "fix" the file.
|
|
|
40
38
|
Residue that doesn't warrant filing stays in ops — that is what ops is for.
|
|
41
39
|
4. **Semantic audit** — the five sources the detector cannot judge:
|
|
42
40
|
- **Cross-pillar contradiction** — across any two session files, `state.md` included (a state
|
|
43
|
-
file describing a session the pillars contradict is the
|
|
41
|
+
file describing a session the pillars contradict is the strongest signal there is).
|
|
44
42
|
- **Aspect adequacy** — the detector checks that every mapped aspect *links* to content; you judge
|
|
45
43
|
whether the content actually covers it. Covered-in-name-only → a fork.
|
|
46
44
|
- **Basis drift** — decided divergence from `basis/` is fine; accidental divergence → a fork.
|
|
@@ -69,11 +67,11 @@ question: file a fork, don't "fix" the file.
|
|
|
69
67
|
|
|
70
68
|
Dispatched when the user asks what they're missing, when the facilitator self-initiates at a
|
|
71
69
|
frame-settling moment (usually widening a reconcile dispatch's scope), or on the accepted
|
|
72
|
-
pre-converge offer. Run the standard dispatch order first so the surface is current, then
|
|
73
|
-
|
|
74
|
-
a generic checklist. The species that pay: an assumption the design rests on but
|
|
75
|
-
concern no aspect owns; two required properties that pull against each other with
|
|
76
|
-
designing for either; a rule or path that can never fire; an ambiguity two files resolve
|
|
70
|
+
pre-converge offer. Run the standard dispatch order first so the surface is current, then re-read
|
|
71
|
+
the whole surface plus `basis/` cold, measured against the thesis's claim — the stated goal —
|
|
72
|
+
never against a generic checklist. The species that pay: an assumption the design rests on but
|
|
73
|
+
never states; a concern no aspect owns; two required properties that pull against each other with
|
|
74
|
+
nothing designing for either; a rule or path that can never fire; an ambiguity two files resolve
|
|
77
75
|
differently; a shape matching a failure already recorded in the basis or ledger.
|
|
78
76
|
|
|
79
77
|
**The quality gate — a candidate passes all four tests or dies unsurfaced.** The gate exists so
|
|
@@ -107,19 +105,16 @@ Stop is facilitator-orchestrated because approval belongs to the user; you execu
|
|
|
107
105
|
fork, every fragment, the consolidated source of truth. Return the manifest body for approval.
|
|
108
106
|
2. **Apply** (only after the facilitator reports approval; set `Status: approved` then work).
|
|
109
107
|
Read **both sides** of every destination before writing — the destination's current content is
|
|
110
|
-
a contract, not a blank page. Format each artifact via the `documentation` skill
|
|
111
|
-
|
|
112
|
-
|
|
113
|
-
|
|
114
|
-
restarts; never resume silently from a half-applied state.
|
|
108
|
+
a contract, not a blank page. Format each artifact via the `documentation` skill. Set
|
|
109
|
+
`Status: applied`. The apply is all-or-nothing and loud: if you cannot finish, report exactly
|
|
110
|
+
what applied and stop — the folder stays visibly unfinished and the user restarts; never
|
|
111
|
+
resume silently from a half-applied state.
|
|
115
112
|
3. **Uselessness test.** Spawn a **fresh, context-free cold reader** — an independent subagent
|
|
116
113
|
that inherits none of this session's context — whose prompt contains only the allowed-path list
|
|
117
114
|
(the manifest's destinations — never the session folder) and the instruction to reconstruct the
|
|
118
115
|
design: thesis, commitments, reasoning, declined branches. Grade its reconstruction against the
|
|
119
116
|
ledger and thesis. Gaps → record them in the manifest (`Result: fail`, named gaps), and the fixes
|
|
120
|
-
re-enter as a new manifest `Round` requiring fresh approval. Pass → record it.
|
|
121
|
-
offers no subagent dispatch, report that the facilitator must dispatch the cold reader — you,
|
|
122
|
-
having read the folder, can no longer cold-read.
|
|
117
|
+
re-enter as a new manifest `Round` requiring fresh approval. Pass → record it.
|
|
123
118
|
4. **Move.** Run `--gate=move`. When clean: delete `ops/` entirely, `git mv` the folder to
|
|
124
119
|
`docs/history/brainstorms/{topic}/`, set state `Status: harvested`, update both indexes
|
|
125
120
|
(`docs/research/Readme.md` row out, `docs/history/brainstorms/Readme.md` row in). End your
|
|
@@ -134,9 +129,14 @@ appearing, aspect-map patterns. Never session content, never user preferences.
|
|
|
134
129
|
|
|
135
130
|
## Degradations — flagged, never silent
|
|
136
131
|
|
|
137
|
-
|
|
138
|
-
|
|
139
|
-
-
|
|
140
|
-
|
|
141
|
-
|
|
132
|
+
A loud early failure the user fixes beats silent damage discovered after the folder is gone.
|
|
133
|
+
|
|
134
|
+
- **Detector or node unavailable** → run the schema's checks by hand and say so loudly in your
|
|
135
|
+
report; a missing detector is a flagged fact, never a silent skip.
|
|
136
|
+
- **`documentation` skill unavailable** → fall back to your own formatting for the harvest, and
|
|
137
|
+
record which path ran in the manifest.
|
|
138
|
+
- **No subagent dispatch in this runtime** → report that the facilitator must dispatch the cold
|
|
139
|
+
reader; you, having read the folder, can no longer cold-read.
|
|
140
|
+
- **Anything else broken** → `S# → failed` in the sync log with the reason, and say so in your
|
|
141
|
+
report.
|
|
142
142
|
'''
|