@numio/bigmath 2.4.0 → 2.4.1

package/CHANGELOG.md

@@ -1,3 +1,6 @@
+### 2.4.1
+Modulo - fix calculation
+
 ### 2.4.0
 Add Mod - Modulo operation, which finds the remainder when one number is divided by another
 

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@numio/bigmath",
   "description": "@numio/bigmath is an arbitrary-precision arithmetic library. It can be used for basic operations with decimal numbers (integers and float)",
-  "version": "2.4.0",
+  "version": "2.4.1",
   "keywords": [
     "precision",
     "arithmetic",

package/src/mod/mod.js

@@ -1,6 +1,11 @@
 import { bi2s, s2bi } from "../shared/utils.js";
 import { modInner } from "./utils.js";
-export const mod = (left, right, options = { precision: 20 }) => {
-    const bi = modInner(s2bi(left), s2bi(right), options);
-    return bi2s(bi);
+export const mod = (left, right) => {
+    const bil = s2bi(left);
+    const bir = s2bi(right);
+    if (bil[1] > 0)
+        throw new Error(`${left} is no valid. It should be integer`);
+    if (bir[1] > 0)
+        throw new Error(`${right} is no valid. It should be integer`);
+    return bi2s(modInner(bil, bir));
 };

package/src/mod/types.d.ts

@@ -1,6 +1,3 @@
 import type { BI } from "../shared/types.d.ts";
-export type ModOptions = {
-    precision: number;
-};
-export type Mod = (left: string, right: string, options?: ModOptions) => string;
-export type ModInner = (left: BI, right: BI, options: ModOptions) => BI;
+export type Mod = (left: string, right: string) => string;
+export type ModInner = (left: BI, right: BI) => BI;

package/src/mod/utils.js

@@ -1,6 +1,3 @@
-import { divInner } from "../operations/div/utils.js";
-import { tryBigInt } from "../shared/utils.js";
-export const modInner = (left, right, { precision }) => {
-    const bi = divInner([left, right], precision);
-    return bi[1] === 0 ? [0n, 0] : [bi[0] % (10n ** tryBigInt(bi[1])), 0];
+export const modInner = (left, right) => {
+    return [((left[0] % right[0]) + right[0]) % right[0], 0];
 };

package/src/pipe/pipe.d.ts

@@ -1,5 +1,4 @@
 import type { BI2S } from "../shared/types.d.ts";
-import type { ModOptions } from "../mod/types.d.ts";
 /** Using this function you can chain operations (add, sub, div, mul). */
 export declare class Pipe {
     #private;
@@ -9,7 +8,7 @@ export declare class Pipe {
     div(array: string[], precision?: number): Pipe;
     mul(array: string[]): Pipe;
     abs(): Pipe;
-    mod(value: string, options?: ModOptions): Pipe;
+    mod(value: string): Pipe;
     calc(): ReturnType<BI2S>;
     resultToBase(radix: number): string;
 }

package/src/pipe/pipe.js

@@ -47,11 +47,11 @@ export class Pipe {
         __classPrivateFieldSet(this, _Pipe_result, absInner(__classPrivateFieldGet(this, _Pipe_result, "f")), "f");
         return this;
     }
-    mod(value, options = { precision: 20 }) {
+    mod(value) {
         if (!__classPrivateFieldGet(this, _Pipe_result, "f")) {
             throw new Error("Value is undefined.");
         }
-        __classPrivateFieldSet(this, _Pipe_result, modInner(__classPrivateFieldGet(this, _Pipe_result, "f"), s2bi(value), options), "f");
+        __classPrivateFieldSet(this, _Pipe_result, modInner(__classPrivateFieldGet(this, _Pipe_result, "f"), s2bi(value)), "f");
         return this;
     }
     calc() {