@nuasite/cli 0.52.0 → 0.54.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nuasite/cli",
-  "version": "0.52.0",
+  "version": "0.54.0",
   "license": "Apache-2.0",
   "type": "module",
   "files": [
@@ -23,8 +23,10 @@
     "prepack": "bun run ../../scripts/workspace-deps/resolve-deps.ts"
   },
   "dependencies": {
-    "@nuasite/cms": "0.52.0",
-    "@nuasite/cms-core": "0.52.0"
+    "@astrojs/compiler": "^3.0.1",
+    "@jridgewell/trace-mapping": "^0.3.31",
+    "@nuasite/cms": "0.54.0",
+    "@nuasite/cms-core": "0.54.0"
   },
   "devDependencies": {
     "@types/bun": "1.3.11"

package/src/check-code.ts

@@ -0,0 +1,133 @@
+/**
+ * Syntax check for the project's own code.
+ *
+ * A full build catches these, but it renders every page to get there. What actually fails is the
+ * parse: Astro compiles a `.astro` file to TypeScript and the bundler parses that, so compiling
+ * and parsing — without rendering anything — reproduces the same class of error in about a second.
+ *
+ * This is a *syntax* check, not a type check. A wrong prop type or a missing export still needs
+ * `astro check` or a build. What it does catch is the error that stops a build dead before a single
+ * page renders — an unescaped quote inside a Czech string being the one that prompted it.
+ */
+
+import { transform } from '@astrojs/compiler'
+import { originalPositionFor, TraceMap } from '@jridgewell/trace-mapping'
+import type { CheckFinding } from '@nuasite/cms-core'
+import { Glob } from 'bun'
+import path from 'node:path'
+
+/** Directories that are never the project's own source. */
+const IGNORED = ['node_modules', 'dist', '.astro', '.git', '.output', '.vercel', '.netlify']
+
+const isIgnored = (relative: string): boolean =>
+	// Declaration files are types only — nothing compiles them, and the TS loader rejects them.
+	/\.d\.[mc]?ts$/.test(relative) || relative.split(path.sep).some(segment => IGNORED.includes(segment))
+
+/** Bun's parser reports a `BuildMessage` carrying the offending position in the code it was given. */
+interface BuildPosition {
+	line?: number
+	column?: number
+	lineText?: string
+}
+
+function buildPosition(error: unknown): BuildPosition | null {
+	if (typeof error !== 'object' || error === null || !('position' in error)) return null
+	const position = (error as { position: unknown }).position
+	return typeof position === 'object' && position !== null ? position as BuildPosition : null
+}
+
+/** Bun's `BuildMessage` is not an `Error`, so `String(error)` would prefix the class name. */
+function messageOf(error: unknown): string {
+	const message = typeof error === 'object' && error !== null && 'message' in error ? (error as { message: unknown }).message : undefined
+	return String(typeof message === 'string' ? message : error).split('\n')[0]!
+}
+
+/**
+ * Map a position in the emitted TypeScript back to the `.astro` source.
+ *
+ * Without this the position points into generated `$$render` code, which is worse than no position
+ * at all — it looks like a real line number and is not one.
+ */
+function toSource(map: string | undefined, position: BuildPosition | null): { line?: number; column?: number } {
+	if (!map || position?.line === undefined) return {}
+	try {
+		const traced = originalPositionFor(new TraceMap(JSON.parse(map)), {
+			line: position.line,
+			column: position.column ?? 0,
+		})
+		if (traced.line === null) return {}
+		// trace-mapping columns are 0-based; editors and build output are not.
+		return { line: traced.line, column: traced.column + 1 }
+	} catch {
+		return {}
+	}
+}
+
+async function checkAstroFile(absolute: string, relative: string, source: string): Promise<CheckFinding | null> {
+	let emitted: { code: string; map: string }
+	try {
+		emitted = await transform(source, { filename: absolute, sourcemap: 'both' })
+	} catch (error) {
+		return { severity: 'error', code: 'code/astro-parse', file: relative, message: messageOf(error) }
+	}
+
+	try {
+		new Bun.Transpiler({ loader: 'ts' }).transformSync(emitted.code)
+		return null
+	} catch (error) {
+		const position = buildPosition(error)
+		return {
+			severity: 'error',
+			code: 'code/syntax',
+			file: relative,
+			...toSource(emitted.map, position),
+			message: messageOf(error),
+		}
+	}
+}
+
+function checkScriptFile(relative: string, source: string, loader: 'ts' | 'tsx'): CheckFinding | null {
+	try {
+		new Bun.Transpiler({ loader }).transformSync(source)
+		return null
+	} catch (error) {
+		const position = buildPosition(error)
+		return {
+			severity: 'error',
+			code: 'code/syntax',
+			file: relative,
+			line: position?.line,
+			column: position?.column === undefined ? undefined : position.column + 1,
+			message: messageOf(error),
+		}
+	}
+}
+
+export interface CodeCheckResult {
+	findings: CheckFinding[]
+	files: number
+}
+
+/** Parse every `.astro`/`.ts`/`.tsx` under `root`, newest failure first is not meaningful here — order is by path. */
+export async function checkCode(root: string): Promise<CodeCheckResult> {
+	const findings: CheckFinding[] = []
+	let files = 0
+
+	const paths: string[] = []
+	for await (const relative of new Glob('**/*.{astro,ts,tsx,mts,cts}').scan({ cwd: root })) {
+		if (!isIgnored(relative)) paths.push(relative)
+	}
+	paths.sort()
+
+	for (const relative of paths) {
+		files++
+		const absolute = path.join(root, relative)
+		const source = await Bun.file(absolute).text()
+		const finding = relative.endsWith('.astro')
+			? await checkAstroFile(absolute, relative, source)
+			: checkScriptFile(relative, source, relative.endsWith('.tsx') ? 'tsx' : 'ts')
+		if (finding) findings.push(finding)
+	}
+
+	return { findings, files }
+}

package/src/check.ts

@@ -1,12 +1,36 @@
-import { checkContent, type CheckReport, createNodeFs, formatCheckReport } from '@nuasite/cms-core'
+import { checkContent, type CheckReport, createNodeFs, formatCheckReport, type LiveSchemas } from '@nuasite/cms-core'
 import { existsSync, readdirSync } from 'node:fs'
 import path from 'node:path'
+import { checkCode } from './check-code'
+import { loadLiveSchemas } from './live-schema'
 
 export interface CheckOptions {
 	cwd: string
 	json: boolean
 	/** Treat warnings as failures too. Off by default: a dangling reference builds fine. */
 	strict: boolean
+	/** Skip the code syntax pass — content only. */
+	contentOnly: boolean
+	/** Validate against the project's real schemas, which means importing and running its content config. */
+	live: boolean
+}
+
+/**
+ * `nua check`'s argv, as options.
+ *
+ * Pure and exported so the flag combinations are testable: `index.ts` is a top-level-await
+ * script that reads `process.argv` and calls `process.exit`, so a test cannot import it.
+ */
+export function parseCheckArgs(args: string[], cwd: string): CheckOptions {
+	const contentOnly = args.includes('--content-only')
+	return {
+		cwd,
+		json: args.includes('--json'),
+		strict: args.includes('--strict'),
+		contentOnly,
+		// Loading the real schemas executes the project's content config — the least content-only thing this command does.
+		live: !contentOnly && !args.includes('--no-live'),
+	}
 }
 
 const ASTRO_CONFIG_NAMES = ['astro.config.ts', 'astro.config.mts', 'astro.config.mjs', 'astro.config.js']
@@ -44,6 +68,25 @@ function prefixed(report: CheckReport, root: string): CheckReport {
 	}
 }
 
+/** The project's real schemas, or the sentence saying why the rules needing them did not run. */
+type LiveResult = { schemas: LiveSchemas } | { skipped: string }
+
+async function liveSchemasFor(options: CheckOptions, roots: string[]): Promise<LiveResult> {
+	if (options.contentOnly) {
+		return { skipped: "--content-only was passed, and reading the real schemas means executing the project's content config." }
+	}
+	if (!options.live) return { skipped: '--no-live was passed.' }
+
+	const first = roots[0]
+	// The `astro:content` stub is process-global and re-exports one project's zod, so a second
+	// project would be judged by the first project's schemas — quietly wrong is worse than skipped.
+	if (roots.length !== 1 || first === undefined) {
+		const where = roots.join(', ')
+		return { skipped: `They need exactly one Astro project; this run covers ${roots.length} (${where}). Check each one from its own directory.` }
+	}
+	return loadLiveSchemas(path.join(options.cwd, first))
+}
+
 /** Validate the content collections and return the process exit code. */
 export async function check(options: CheckOptions): Promise<number> {
 	const roots = astroRoots(options.cwd)
@@ -53,27 +96,43 @@ export async function check(options: CheckOptions): Promise<number> {
 		return 1
 	}
 
-	const reports = await Promise.all(
-		roots.map(async root => prefixed(await checkContent(createNodeFs(path.join(options.cwd, root))), root)),
-	)
+	const live = await liveSchemasFor(options, roots)
+	const schemas = 'schemas' in live ? live.schemas : undefined
+
+	const reports = await Promise.all(roots.map(async root => {
+		const absolute = path.join(options.cwd, root)
+		const content = prefixed(await checkContent(createNodeFs(absolute), schemas ? { schemas } : {}), root)
+		if (options.contentOnly) return { ...content, files: 0 }
+		const code = await checkCode(absolute)
+		return {
+			...content,
+			findings: [...content.findings, ...code.findings.map(finding => ({ ...finding, file: path.join(root, finding.file) }))],
+			files: code.files,
+		}
+	}))
 
 	const report: CheckReport = {
 		findings: reports.flatMap(one => one.findings),
 		collections: reports.reduce((total, one) => total + one.collections, 0),
 		entries: reports.reduce((total, one) => total + one.entries, 0),
 	}
+	const sourceFiles = reports.reduce((total, one) => total + one.files, 0)
 
 	const errors = report.findings.filter(finding => finding.severity === 'error').length
 	const warnings = report.findings.length - errors
 
 	if (options.json) {
-		console.log(JSON.stringify({ ...report, roots }, null, 2))
+		// The reason belongs inside the payload: a stray line would break anything parsing this.
+		console.log(JSON.stringify({ ...report, roots, liveSchemas: 'schemas' in live ? 'ran' : live.skipped }, null, 2))
 	} else {
 		const formatted = formatCheckReport(report)
 		if (formatted) console.log(formatted + '\n')
 		const where = roots.length === 1 && roots[0] === '.' ? '' : ` in ${roots.join(', ')}`
-		const counts = `${report.collections} collection(s), ${report.entries} entries${where}`
+		const code = options.contentOnly ? '' : `, ${sourceFiles} source file(s)`
+		const counts = `${report.collections} collection(s), ${report.entries} entries${code}${where}`
 		console.log(errors === 0 && warnings === 0 ? `${counts} — no problems found` : `${counts} — ${errors} error(s), ${warnings} warning(s)`)
+		// A check that did not run must not read as a pass.
+		if ('skipped' in live) console.log(`Live schema rules did not run: ${live.skipped}`)
 	}
 
 	return errors > 0 || (options.strict && warnings > 0) ? 1 : 0

package/src/index.ts

@@ -25,7 +25,7 @@ function printUsage() {
 	console.log('  build              Run astro build with the Nua defaults')
 	console.log('  dev                Run astro dev with the Nua defaults')
 	console.log('  preview            Run astro preview with the Nua defaults')
-	console.log('  check              Validate the content collections (no build). --json, --strict')
+	console.log('  check              Validate collections and parse the source (no build). --json, --strict, --content-only, --no-live')
 	console.log('  init               Convert a standard Astro project to use Nua')
 	console.log('  clean              Eject to a standard Astro project (remove @nuasite/* deps)')
 	console.log('  migrate <target>   Run a content migration. Targets: astro-image')
@@ -38,14 +38,8 @@ if (command && ['build', 'dev', 'preview'].includes(command)) {
 } else {
 	switch (command) {
 		case 'check': {
-			const { check } = await import('./check')
-			process.exit(
-				await check({
-					cwd: process.cwd(),
-					json: args.includes('--json'),
-					strict: args.includes('--strict'),
-				}),
-			)
+			const { check, parseCheckArgs } = await import('./check')
+			process.exit(await check(parseCheckArgs(args, process.cwd())))
 			break
 		}
 		case 'init': {