@nt-ai-lab/deterministic-agent-workflow-cli 0.3.6 → 0.4.0

package/dist/features/workflow-runner/entrypoint/review-routes.d.ts

@@ -3,4 +3,4 @@ import type { RunnerResult } from '../../../platform/domain/workflow-runner-type
 /** @riviere-role cli-entrypoint */
 export declare function handleRecordReviewRoute<TWorkflow extends RehydratableWorkflow<TState>, TState extends BaseWorkflowState<TStateName>, TDeps, TStateName extends string, TOperation extends string>(engine: {
     readonly hasSessionStarted: (sessionId: string) => boolean;
-}, engineDeps: WorkflowEngineDeps, workflowDefinition: WorkflowDefinition<TWorkflow, TState, TDeps, TStateName, TOperation>, args: readonly string[], readStdin: (() => string) | undefined, getSessionId: (() => string) | undefined): RunnerResult;
+}, engineDeps: WorkflowEngineDeps, workflowDefinition: WorkflowDefinition<TWorkflow, TState, TDeps, TStateName, TOperation>, args: readonly string[], getSessionId: (() => string) | undefined): RunnerResult;

package/dist/features/workflow-runner/entrypoint/review-routes.js

@@ -18,70 +18,44 @@ function blockedResult(output) {
         exitCode: EXIT_BLOCK,
     };
 }
-function parseFlagArgs(args) {
-    const flags = new Map();
-    for (const [index, key] of args.entries()) {
-        if (index % 2 === 1)
-            continue;
-        const value = args[index + 1];
-        if (!key.startsWith('--')) {
-            return {
-                ok: false,
-                message: `Invalid flag: ${String(key)}`,
-            };
-        }
-        if (typeof value !== 'string' || value.length === 0) {
-            return {
-                ok: false,
-                message: `Missing value for flag: ${key}`,
-            };
-        }
-        flags.set(key, value);
+function parseReviewArguments(args) {
+    const reviewType = args[1];
+    const reviewJson = args[2];
+    if (args.length !== 3 || typeof reviewType !== 'string' || typeof reviewJson !== 'string') {
+        return {
+            ok: false,
+            message: 'record-review requires <review-type> and <review-json> arguments',
+        };
+    }
+    if (reviewType.length === 0) {
+        return {
+            ok: false,
+            message: 'record-review requires a non-empty review type',
+        };
     }
     return {
         ok: true,
-        flags,
+        reviewType,
+        reviewJson,
     };
 }
-function validateReviewFlags(flags) {
-    for (const key of flags.keys()) {
-        if (key !== '--type') {
-            return `Unknown flag: ${key}`;
-        }
-    }
-    if (!flags.has('--type')) {
-        return 'record-review requires --type';
-    }
-    return null;
-}
 function isReviewAllowed(allowedWorkflowOperations) {
     return allowedWorkflowOperations.some((allowedWorkflowOperation) => allowedWorkflowOperation === 'record-review');
 }
 /** @riviere-role cli-entrypoint */
-export function handleRecordReviewRoute(engine, engineDeps, workflowDefinition, args, readStdin, getSessionId) {
+export function handleRecordReviewRoute(engine, engineDeps, workflowDefinition, args, getSessionId) {
     if (getSessionId === undefined) {
         return errorResult('record-review requires an active workflow session');
     }
-    if (readStdin === undefined) {
-        return errorResult('record-review requires JSON on stdin');
-    }
-    const parsedFlags = parseFlagArgs(args.slice(1));
-    if (!parsedFlags.ok) {
-        return errorResult(parsedFlags.message);
-    }
-    const flagError = validateReviewFlags(parsedFlags.flags);
-    if (flagError !== null) {
-        return errorResult(flagError);
-    }
-    const reviewType = parsedFlags.flags.get('--type');
-    if (reviewType === undefined) {
-        return errorResult('record-review requires a non-empty --type value');
+    const parsedArguments = parseReviewArguments(args);
+    if (!parsedArguments.ok) {
+        return errorResult(parsedArguments.message);
     }
     const sessionId = getSessionId();
     if (!engine.hasSessionStarted(sessionId)) {
         return errorResult(`Session ${sessionId} has not been started`);
     }
-    const reviewPayloadResult = parseReviewPayload(readStdin);
+    const reviewPayloadResult = parseReviewPayload(parsedArguments.reviewJson);
     if (!reviewPayloadResult.ok) {
         return errorResult(reviewPayloadResult.message);
     }
@@ -99,7 +73,7 @@ export function handleRecordReviewRoute(engine, engineDeps, workflowDefinition,
     }
     const createdAt = engineDeps.now();
     const stored = engineDeps.store.recordReviewWithEvent(sessionId, createdAt, {
-        reviewType,
+        reviewType: parsedArguments.reviewType,
         sourceState: currentStateName,
         ...parsedReview.data,
     }, currentStateName);
@@ -108,7 +82,7 @@ export function handleRecordReviewRoute(engine, engineDeps, workflowDefinition,
         id: stored.id,
         sessionId,
         createdAt: stored.createdAt,
-        reviewType,
+        reviewType: parsedArguments.reviewType,
         verdict: parsedReview.data.verdict,
     });
 }
@@ -116,11 +90,11 @@ function computeCurrentState(workflowDefinition, storedEvents) {
     const state = reduceWorkflowStateFromStoredEvents(workflowDefinition, storedEvents);
     return state.currentStateMachineState;
 }
-function parseReviewPayload(readStdin) {
+function parseReviewPayload(reviewJson) {
     try {
         return {
             ok: true,
-            payload: JSON.parse(readStdin()),
+            payload: JSON.parse(reviewJson),
         };
     }
     catch (error) {

package/dist/features/workflow-runner/entrypoint/review-routes.spec.js

@@ -170,20 +170,20 @@ function createEngineDeps(store) {
         transcriptReader: { readMessages: () => [] },
     };
 }
-function recordReview(store, readStdin, sessionId = 'test-session') {
-    return handleRecordReviewRoute({ hasSessionStarted: (candidateSessionId) => store.hasSessionStarted(candidateSessionId) }, createEngineDeps(store), workflowDefinition, ['record-review', '--type', 'custom-review'], readStdin, () => sessionId);
+function recordReview(store, reviewJson, sessionId = 'test-session') {
+    return handleRecordReviewRoute({ hasSessionStarted: (candidateSessionId) => store.hasSessionStarted(candidateSessionId) }, createEngineDeps(store), workflowDefinition, ['record-review', 'custom-review', reviewJson], () => sessionId);
 }
 describe('handleRecordReviewRoute', () => {
-    it('returns error when stdin is invalid JSON', () => {
+    it('returns error when review JSON argument is invalid JSON', () => {
         const store = new ReviewRouteStore();
-        const result = recordReview(store, () => '{');
+        const result = recordReview(store, '{');
         expect(result.exitCode).toBe(EXIT_ERROR);
         expect(result.output).toContain('Invalid review JSON');
         expect(store.storedReviews).toStrictEqual([]);
     });
     it('returns error when verdict is unknown', () => {
         const store = new ReviewRouteStore();
-        const result = recordReview(store, () => JSON.stringify({
+        const result = recordReview(store, JSON.stringify({
             verdict: 'MAYBE',
             findings: []
         }));
@@ -193,7 +193,7 @@ describe('handleRecordReviewRoute', () => {
     });
     it('returns error when session has not started', () => {
         const store = new ReviewRouteStore();
-        const result = recordReview(store, () => JSON.stringify({
+        const result = recordReview(store, JSON.stringify({
             verdict: 'PASS',
             findings: []
         }), 'missing-session');
@@ -204,7 +204,7 @@ describe('handleRecordReviewRoute', () => {
     });
     it('records review row and review event when payload is valid', () => {
         const store = new ReviewRouteStore();
-        const result = recordReview(store, () => JSON.stringify({
+        const result = recordReview(store, JSON.stringify({
             verdict: 'FAIL',
             findings: [{ title: 'Missing command tests' }],
         }));
@@ -234,11 +234,11 @@ describe('handleRecordReviewRoute', () => {
     });
     it('preserves repeated review attempts', () => {
         const store = new ReviewRouteStore();
-        recordReview(store, () => JSON.stringify({
+        recordReview(store, JSON.stringify({
             verdict: 'FAIL',
             findings: [{ title: 'First failure' }]
         }));
-        recordReview(store, () => JSON.stringify({
+        recordReview(store, JSON.stringify({
             verdict: 'PASS',
             findings: []
         }));
@@ -259,7 +259,7 @@ describe('handleRecordReviewRoute', () => {
     });
     it('returns blocked when current state disallows record-review', () => {
         const store = new ReviewRouteStore('PLANNING');
-        const result = recordReview(store, () => JSON.stringify({
+        const result = recordReview(store, JSON.stringify({
             verdict: 'PASS',
             findings: []
         }));

package/dist/features/workflow-runner/entrypoint/workflow-runner.js

@@ -166,7 +166,7 @@ function resolveBuiltinRoute(engine, engineDeps, config, args, routeName, readSt
         case 'record-reflection':
             return handleRecordReflectionRoute(engine, engineDeps, args, readStdin, getSessionId);
         case 'record-review':
-            return handleRecordReviewRoute(engine, engineDeps, config.workflowDefinition, args, readStdin, getSessionId);
+            return handleRecordReviewRoute(engine, engineDeps, config.workflowDefinition, args, getSessionId);
         case 'write-journal':
             return handleWriteJournalRoute(engine, args, getSessionId);
         default:

package/package.json

@@ -1,8 +1,13 @@
 {
   "name": "@nt-ai-lab/deterministic-agent-workflow-cli",
-  "version": "0.3.6",
+  "version": "0.4.0",
   "private": false,
   "type": "module",
+  "repository": {
+    "type": "git",
+    "url": "git+https://github.com/NTCoding/deterministic-agent-workflows.git",
+    "directory": "packages/deterministic-agent-workflows-cli"
+  },
   "exports": {
     ".": "./dist/index.js"
   },
@@ -12,9 +17,9 @@
   ],
   "dependencies": {
     "zod": "^3.25.76",
-    "@nt-ai-lab/deterministic-agent-workflow-engine": "0.3.6",
-    "@nt-ai-lab/deterministic-agent-workflow-dsl": "0.3.6",
-    "@nt-ai-lab/deterministic-agent-workflow-event-store": "0.3.6"
+    "@nt-ai-lab/deterministic-agent-workflow-engine": "0.4.0",
+    "@nt-ai-lab/deterministic-agent-workflow-dsl": "0.4.0",
+    "@nt-ai-lab/deterministic-agent-workflow-event-store": "0.4.0"
   },
   "devDependencies": {
     "vitest": "^2.1.9"