@npmcli/arborist 7.4.1 → 7.5.0

package/bin/index.js

@@ -2,6 +2,7 @@
 
 const fs = require('fs')
 const path = require('path')
+const { time } = require('proc-log')
 
 const { bin, arb: options } = require('./lib/options')
 const version = require('../package.json').version
@@ -72,11 +73,11 @@ for (const file of commandFiles) {
 
     log.info(name, options)
 
-    process.emit('time', totalTime)
-    process.emit('time', scriptTime)
+    const timeEnd = time.start(totalTime)
+    const scriptEnd = time.start(scriptTime)
 
     return command(options, (result) => {
-      process.emit('timeEnd', scriptTime)
+      scriptEnd()
       return {
         result,
         timing: {
@@ -95,7 +96,7 @@ for (const file of commandFiles) {
         return err
       })
       .then((r) => {
-        process.emit('timeEnd', totalTime)
+        timeEnd()
         if (bin.loglevel !== 'silent') {
           console[process.exitCode ? 'error' : 'log'](r)
         }

package/bin/lib/logging.js

@@ -1,4 +1,4 @@
-const log = require('proc-log')
+const { log } = require('proc-log')
 const fs = require('fs')
 const { dirname } = require('path')
 const os = require('os')

package/bin/lib/timers.js

@@ -4,22 +4,22 @@ const log = require('./logging.js')
 const timers = new Map()
 const finished = new Map()
 
-process.on('time', name => {
-  if (timers.has(name)) {
-    throw new Error('conflicting timer! ' + name)
-  }
-  timers.set(name, process.hrtime.bigint())
-})
-
-process.on('timeEnd', name => {
-  if (!timers.has(name)) {
-    throw new Error('timer not started! ' + name)
-  }
-  const elapsed = Number(process.hrtime.bigint() - timers.get(name))
-  timers.delete(name)
-  finished.set(name, elapsed)
-  if (options.timing) {
-    log.info('timeEnd', `${name} ${elapsed / 1e9}s`, log.meta({ force: options.timing === 'always' }))
+process.on('time', (level, name) => {
+  if (level === 'start') {
+    if (timers.has(name)) {
+      throw new Error('conflicting timer! ' + name)
+    }
+    timers.set(name, process.hrtime.bigint())
+  } else if (level === 'end') {
+    if (!timers.has(name)) {
+      throw new Error('timer not started! ' + name)
+    }
+    const elapsed = Number(process.hrtime.bigint() - timers.get(name))
+    timers.delete(name)
+    finished.set(name, elapsed)
+    if (options.timing) {
+      log.info('timeEnd', `${name} ${elapsed / 1e9}s`, log.meta({ force: options.timing === 'always' }))
+    }
   }
 })
 

package/lib/add-rm-pkg-deps.js

@@ -1,6 +1,6 @@
 // add and remove dependency specs to/from pkg manifest
 
-const log = require('proc-log')
+const { log } = require('proc-log')
 const localeCompare = require('@isaacs/string-locale-compare')('en')
 
 const add = ({ pkg, add, saveBundle, saveType }) => {

package/lib/arborist/build-ideal-tree.js

@@ -11,8 +11,8 @@ const treeCheck = require('../tree-check.js')
 const { readdirScoped } = require('@npmcli/fs')
 const { lstat, readlink } = require('fs/promises')
 const { depth } = require('treeverse')
-const log = require('proc-log')
-const { cleanUrl } = require('npm-registry-fetch')
+const { log, time } = require('proc-log')
+const { redact } = require('@npmcli/redact')
 
 const {
   OK,
@@ -179,7 +179,7 @@ module.exports = cls => class IdealTreeBuilder extends cls {
       options.rm = null
     }
 
-    process.emit('time', 'idealTree')
+    const timeEnd = time.start('idealTree')
 
     if (!options.add && !options.rm && !options.update && this.options.global) {
       throw new Error('global requires add, rm, or update option')
@@ -205,7 +205,7 @@ module.exports = cls => class IdealTreeBuilder extends cls {
       await this.#pruneFailedOptional()
       await this.#checkEngineAndPlatform()
     } finally {
-      process.emit('timeEnd', 'idealTree')
+      timeEnd()
       this.finishTracker('idealTree')
     }
 
@@ -278,7 +278,7 @@ module.exports = cls => class IdealTreeBuilder extends cls {
   // load the initial tree, either the virtualTree from a shrinkwrap,
   // or just the root node from a package.json
   async #initTree () {
-    process.emit('time', 'idealTree:init')
+    const timeEnd = time.start('idealTree:init')
     let root
     if (this.options.global) {
       root = await this.#globalRootNode()
@@ -356,7 +356,7 @@ module.exports = cls => class IdealTreeBuilder extends cls {
         // if you want another one, load another copy.
         this.idealTree = tree
         this.virtualTree = null
-        process.emit('timeEnd', 'idealTree:init')
+        timeEnd()
         return tree
       })
   }
@@ -420,7 +420,7 @@ module.exports = cls => class IdealTreeBuilder extends cls {
   // process the add/rm requests by modifying the root node, and the
   // update.names request by queueing nodes dependent on those named.
   async #applyUserRequests (options) {
-    process.emit('time', 'idealTree:userRequests')
+    const timeEnd = time.start('idealTree:userRequests')
     const tree = this.idealTree.target
 
     if (!this.options.workspaces.length) {
@@ -436,7 +436,7 @@ module.exports = cls => class IdealTreeBuilder extends cls {
       await Promise.all(appliedRequests)
     }
 
-    process.emit('timeEnd', 'idealTree:userRequests')
+    timeEnd()
   }
 
   async #applyUserRequestsToNode (tree, options) {
@@ -691,7 +691,7 @@ module.exports = cls => class IdealTreeBuilder extends cls {
     // if the lockfile is from node v5 or earlier, then we'll have to reload
     // all the manifests of everything we encounter.  this is costly, but at
     // least it's just a one-time hit.
-    process.emit('time', 'idealTree:inflate')
+    const timeEnd = time.start('idealTree:inflate')
 
     // don't warn if we're not gonna actually write it back anyway.
     const heading = ancient ? 'ancient lockfile' : 'old lockfile'
@@ -758,14 +758,14 @@ This is a one-time fix-up, please be patient...
       meta.originalLockfileVersion = defaultLockfileVersion
     }
     this.finishTracker('idealTree:inflate')
-    process.emit('timeEnd', 'idealTree:inflate')
+    timeEnd()
   }
 
   // at this point we have a virtual tree with the actual root node's
   // package deps, which may be partly or entirely incomplete, invalid
   // or extraneous.
   #buildDeps () {
-    process.emit('time', 'idealTree:buildDeps')
+    const timeEnd = time.start('idealTree:buildDeps')
     const tree = this.idealTree.target
     tree.assertRootOverrides()
     this.#depsQueue.push(tree)
@@ -773,15 +773,14 @@ This is a one-time fix-up, please be patient...
     // in the override list
     log.silly('idealTree', 'buildDeps')
     this.addTracker('idealTree', tree.name, '')
-    return this.#buildDepStep()
-      .then(() => process.emit('timeEnd', 'idealTree:buildDeps'))
+    return this.#buildDepStep().then(timeEnd)
   }
 
   async #buildDepStep () {
     // removes tracker of previous dependency in the queue
     if (this.#currentDep) {
       const { location, name } = this.#currentDep
-      process.emit('timeEnd', `idealTree:${location || '#root'}`)
+      time.end(`idealTree:${location || '#root'}`)
       this.finishTracker('idealTree', name, location)
       this.#currentDep = null
     }
@@ -807,7 +806,7 @@ This is a one-time fix-up, please be patient...
 
     this.#depsSeen.add(node)
     this.#currentDep = node
-    process.emit('time', `idealTree:${node.location || '#root'}`)
+    time.start(`idealTree:${node.location || '#root'}`)
 
     // if we're loading a _complete_ ideal tree, for a --package-lock-only
     // installation for example, we have to crack open the tarball and
@@ -1213,7 +1212,7 @@ This is a one-time fix-up, please be patient...
     if (this.#manifests.has(spec.raw)) {
       return this.#manifests.get(spec.raw)
     } else {
-      const cleanRawSpec = cleanUrl(spec.rawSpec)
+      const cleanRawSpec = redact(spec.rawSpec)
       log.silly('fetch manifest', spec.raw.replace(spec.rawSpec, cleanRawSpec))
       const o = {
         ...options,
@@ -1449,7 +1448,7 @@ This is a one-time fix-up, please be patient...
   }
 
   #fixDepFlags () {
-    process.emit('time', 'idealTree:fixDepFlags')
+    const timeEnd = time.start('idealTree:fixDepFlags')
     const metaFromDisk = this.idealTree.meta.loadedFromDisk
     const flagsSuspect = this[_flagsSuspect]
     const mutateTree = this.#mutateTree
@@ -1496,7 +1495,7 @@ This is a one-time fix-up, please be patient...
       }
     }
 
-    process.emit('timeEnd', 'idealTree:fixDepFlags')
+    timeEnd()
   }
 
   #idealTreePrune () {

package/lib/arborist/index.js

@@ -30,7 +30,7 @@ const { resolve } = require('path')
 const { homedir } = require('os')
 const { depth } = require('treeverse')
 const mapWorkspaces = require('@npmcli/map-workspaces')
-const log = require('proc-log')
+const { log, time } = require('proc-log')
 
 const { saveTypeMap } = require('../add-rm-pkg-deps.js')
 const AuditReport = require('../audit-report.js')
@@ -66,7 +66,7 @@ const lockfileVersion = lfv => {
 
 class Arborist extends Base {
   constructor (options = {}) {
-    process.emit('time', 'arborist:ctor')
+    const timeEnd = time.start('arborist:ctor')
     super(options)
     this.options = {
       nodeVersion: process.version,
@@ -97,7 +97,7 @@ class Arborist extends Base {
     }
     this.cache = resolve(this.options.cache)
     this.path = resolve(this.options.path)
-    process.emit('timeEnd', 'arborist:ctor')
+    timeEnd()
   }
 
   // TODO: We should change these to static functions instead
@@ -223,7 +223,7 @@ class Arborist extends Base {
     // XXX: deprecate separate method options objects.
     options = { ...this.options, ...options }
 
-    process.emit('time', 'audit')
+    const timeEnd = time.start('audit')
     let tree
     if (options.packageLock === false) {
       // build ideal tree
@@ -246,7 +246,7 @@ class Arborist extends Base {
     }
     this.auditReport = await AuditReport.load(tree, options)
     const ret = options.fix ? this.reify(options) : this.auditReport
-    process.emit('timeEnd', 'audit')
+    timeEnd()
     this.finishTracker('audit')
     return ret
   }

package/lib/arborist/isolated-reifier.js

@@ -1,7 +1,7 @@
 const _makeIdealGraph = Symbol('makeIdealGraph')
 const _createIsolatedTree = Symbol.for('createIsolatedTree')
 const _createBundledTree = Symbol('createBundledTree')
-const fs = require('fs')
+const { mkdirSync } = require('fs')
 const pacote = require('pacote')
 const { join } = require('path')
 const { depth } = require('treeverse')
@@ -108,7 +108,7 @@ module.exports = cls => class IsolatedReifier extends cls {
         '.store',
         `${node.name}@${node.version}`
       )
-      fs.mkdirSync(dir, { recursive: true })
+      mkdirSync(dir, { recursive: true })
       // TODO this approach feels wrong
       // and shouldn't be necessary for shrinkwraps
       await pacote.extract(node.resolved, dir, {

package/lib/arborist/rebuild.js

@@ -9,11 +9,8 @@ const binLinks = require('bin-links')
 const runScript = require('@npmcli/run-script')
 const { callLimit: promiseCallLimit } = require('promise-call-limit')
 const { resolve } = require('path')
-const {
-  isNodeGypPackage,
-  defaultGypInstallScript,
-} = require('@npmcli/node-gyp')
-const log = require('proc-log')
+const { isNodeGypPackage, defaultGypInstallScript } = require('@npmcli/node-gyp')
+const { log, time } = require('proc-log')
 
 const boolEnv = b => b ? '1' : ''
 const sortNodes = (a, b) =>
@@ -54,7 +51,7 @@ module.exports = cls => class Builder extends cls {
 
     // separates links nodes so that it can run
     // prepare scripts and link bins in the expected order
-    process.emit('time', 'build')
+    const timeEnd = time.start('build')
 
     const {
       depNodes,
@@ -70,7 +67,7 @@ module.exports = cls => class Builder extends cls {
       await this.#build(linkNodes, { type: 'links' })
     }
 
-    process.emit('timeEnd', 'build')
+    timeEnd()
   }
 
   // if we don't have a set of nodes, then just rebuild
@@ -147,7 +144,7 @@ module.exports = cls => class Builder extends cls {
   }
 
   async #build (nodes, { type = 'deps' }) {
-    process.emit('time', `build:${type}`)
+    const timeEnd = time.start(`build:${type}`)
 
     await this.#buildQueues(nodes)
 
@@ -168,11 +165,11 @@ module.exports = cls => class Builder extends cls {
       await this.#runScripts('postinstall')
     }
 
-    process.emit('timeEnd', `build:${type}`)
+    timeEnd()
   }
 
   async #buildQueues (nodes) {
-    process.emit('time', 'build:queue')
+    const timeEnd = time.start('build:queue')
     const set = new Set()
 
     const promises = []
@@ -210,7 +207,7 @@ module.exports = cls => class Builder extends cls {
         }
       }
     }
-    process.emit('timeEnd', 'build:queue')
+    timeEnd()
   }
 
   async [_checkBins] (node) {
@@ -286,7 +283,7 @@ module.exports = cls => class Builder extends cls {
       return
     }
 
-    process.emit('time', `build:run:${event}`)
+    const timeEnd = time.start(`build:run:${event}`)
     const stdio = this.options.foregroundScripts ? 'inherit' : 'pipe'
     const limit = this.options.foregroundScripts ? 1 : undefined
     await promiseCallLimit(queue.map(node => async () => {
@@ -309,8 +306,7 @@ module.exports = cls => class Builder extends cls {
         return
       }
 
-      const timer = `build:run:${event}:${location}`
-      process.emit('time', timer)
+      const timeEndLocation = time.start(`build:run:${event}:${location}`)
       log.info('run', pkg._id, event, location, pkg.scripts[event])
       const env = {
         npm_package_resolved: resolved,
@@ -356,9 +352,9 @@ module.exports = cls => class Builder extends cls {
         ? this[_handleOptionalFailure](node, p)
         : p)
 
-      process.emit('timeEnd', timer)
+      timeEndLocation()
     }), { limit })
-    process.emit('timeEnd', `build:run:${event}`)
+    timeEnd()
   }
 
   async #linkAllBins () {
@@ -367,7 +363,7 @@ module.exports = cls => class Builder extends cls {
       return
     }
 
-    process.emit('time', 'build:link')
+    const timeEnd = time.start('build:link')
     const promises = []
     // sort the queue by node path, so that the module-local collision
     // detector in bin-links will always resolve the same way.
@@ -377,7 +373,7 @@ module.exports = cls => class Builder extends cls {
     }
 
     await promiseAllRejectLate(promises)
-    process.emit('timeEnd', 'build:link')
+    timeEnd()
   }
 
   async #createBinLinks (node) {
@@ -385,7 +381,7 @@ module.exports = cls => class Builder extends cls {
       return
     }
 
-    process.emit('time', `build:link:${node.location}`)
+    const timeEnd = time.start(`build:link:${node.location}`)
 
     const p = binLinks({
       pkg: node.package,
@@ -399,6 +395,6 @@ module.exports = cls => class Builder extends cls {
       ? this[_handleOptionalFailure](node, p)
       : p)
 
-    process.emit('timeEnd', `build:link:${node.location}`)
+    timeEnd()
   }
 }

package/lib/arborist/reify.js

@@ -7,7 +7,7 @@ const npa = require('npm-package-arg')
 const semver = require('semver')
 const debug = require('../debug.js')
 const { walkUp } = require('walk-up-path')
-const log = require('proc-log')
+const { log, time } = require('proc-log')
 const hgi = require('hosted-git-info')
 const rpj = require('read-package-json-fast')
 
@@ -149,7 +149,7 @@ module.exports = cls => class Reifier extends cls {
 
     // start tracker block
     this.addTracker('reify')
-    process.emit('time', 'reify')
+    const timeEnd = time.start('reify')
     await this[_validatePath]()
     await this[_loadTrees](options)
 
@@ -174,7 +174,7 @@ module.exports = cls => class Reifier extends cls {
     this.auditReport = await this.auditReport
 
     this.finishTracker('reify')
-    process.emit('timeEnd', 'reify')
+    timeEnd()
     return treeCheck(this.actualTree)
   }
 
@@ -269,7 +269,7 @@ module.exports = cls => class Reifier extends cls {
   // when doing a local install, we load everything and figure it all out.
   // when doing a global install, we *only* care about the explicit requests.
   [_loadTrees] (options) {
-    process.emit('time', 'reify:loadTrees')
+    const timeEnd = time.start('reify:loadTrees')
     const bitOpt = {
       ...options,
       complete: this[_packageLockOnly] || this[_dryRun],
@@ -277,8 +277,7 @@ module.exports = cls => class Reifier extends cls {
 
     // if we're only writing a package lock, then it doesn't matter what's here
     if (this[_packageLockOnly]) {
-      return this.buildIdealTree(bitOpt)
-        .then(() => process.emit('timeEnd', 'reify:loadTrees'))
+      return this.buildIdealTree(bitOpt).then(timeEnd)
     }
 
     const actualOpt = this.options.global ? {
@@ -312,7 +311,7 @@ module.exports = cls => class Reifier extends cls {
       return Promise.all([
         this.loadActual(actualOpt),
         this.buildIdealTree(bitOpt),
-      ]).then(() => process.emit('timeEnd', 'reify:loadTrees'))
+      ]).then(timeEnd)
     }
 
     // the global install space tends to have a lot of stuff in it.  don't
@@ -322,7 +321,7 @@ module.exports = cls => class Reifier extends cls {
     // explicitRequests which is set during buildIdealTree
     return this.buildIdealTree(bitOpt)
       .then(() => this.loadActual(actualOpt))
-      .then(() => process.emit('timeEnd', 'reify:loadTrees'))
+      .then(timeEnd)
   }
 
   [_diffTrees] () {
@@ -330,7 +329,7 @@ module.exports = cls => class Reifier extends cls {
       return
     }
 
-    process.emit('time', 'reify:diffTrees')
+    const timeEnd = time.start('reify:diffTrees')
     // XXX if we have an existing diff already, there should be a way
     // to just invalidate the parts that changed, but avoid walking the
     // whole tree again.
@@ -397,7 +396,7 @@ module.exports = cls => class Reifier extends cls {
     // because if we remove node_modules/FOO on case-insensitive systems,
     // it will remove the dep that we *want* at node_modules/foo.
 
-    process.emit('timeEnd', 'reify:diffTrees')
+    timeEnd()
   }
 
   // add the node and all its bins to the list of things to be
@@ -422,7 +421,7 @@ module.exports = cls => class Reifier extends cls {
   // move aside the shallowest nodes in the tree that have to be
   // changed or removed, so that we can rollback if necessary.
   [_retireShallowNodes] () {
-    process.emit('time', 'reify:retireShallow')
+    const timeEnd = time.start('reify:retireShallow')
     const moves = this[_retiredPaths] = {}
     for (const diff of this.diff.children) {
       if (diff.action === 'CHANGE' || diff.action === 'REMOVE') {
@@ -433,8 +432,7 @@ module.exports = cls => class Reifier extends cls {
     log.silly('reify', 'moves', moves)
     const movePromises = Object.entries(moves)
       .map(([from, to]) => this[_renamePath](from, to))
-    return promiseAllRejectLate(movePromises)
-      .then(() => process.emit('timeEnd', 'reify:retireShallow'))
+    return promiseAllRejectLate(movePromises).then(timeEnd)
   }
 
   [_renamePath] (from, to, didMkdirp = false) {
@@ -456,14 +454,14 @@ module.exports = cls => class Reifier extends cls {
   }
 
   [_rollbackRetireShallowNodes] (er) {
-    process.emit('time', 'reify:rollback:retireShallow')
+    const timeEnd = time.start('reify:rollback:retireShallow')
     const moves = this[_retiredPaths]
     const movePromises = Object.entries(moves)
       .map(([from, to]) => this[_renamePath](to, from))
     return promiseAllRejectLate(movePromises)
       // ignore subsequent rollback errors
       .catch(er => {})
-      .then(() => process.emit('timeEnd', 'reify:rollback:retireShallow'))
+      .then(timeEnd)
       .then(() => {
         throw er
       })
@@ -476,7 +474,7 @@ module.exports = cls => class Reifier extends cls {
       return
     }
 
-    process.emit('time', 'reify:trashOmits')
+    const timeEnd = time.start('reify:trashOmits')
 
     for (const node of this.idealTree.inventory.values()) {
       const { top } = node
@@ -503,11 +501,11 @@ module.exports = cls => class Reifier extends cls {
       }
     }
 
-    process.emit('timeEnd', 'reify:trashOmits')
+    timeEnd()
   }
 
   [_createSparseTree] () {
-    process.emit('time', 'reify:createSparse')
+    const timeEnd = time.start('reify:createSparse')
     // if we call this fn again, we look for the previous list
     // so that we can avoid making the same directory multiple times
     const leaves = this.diff.leaves
@@ -550,12 +548,11 @@ module.exports = cls => class Reifier extends cls {
       if (made) {
         this[_sparseTreeRoots].add(made)
       }
-    }))
-      .then(() => process.emit('timeEnd', 'reify:createSparse'))
+    })).then(timeEnd)
   }
 
   [_rollbackCreateSparseTree] (er) {
-    process.emit('time', 'reify:rollback:createSparse')
+    const timeEnd = time.start('reify:rollback:createSparse')
     // cut the roots of the sparse tree that were created, not the leaves
     const roots = this[_sparseTreeRoots]
     // also delete the moves that we retired, so that we can move them back
@@ -569,7 +566,7 @@ module.exports = cls => class Reifier extends cls {
         log.warn('cleanup', 'Failed to remove some directories', failures)
       }
     })
-      .then(() => process.emit('timeEnd', 'reify:rollback:createSparse'))
+      .then(timeEnd)
       .then(() => this[_rollbackRetireShallowNodes](er))
   }
 
@@ -587,7 +584,7 @@ module.exports = cls => class Reifier extends cls {
       return
     }
 
-    process.emit('time', 'reify:loadShrinkwraps')
+    const timeEnd = time.start('reify:loadShrinkwraps')
 
     const Arborist = this.constructor
     return promiseAllRejectLate(shrinkwraps.map(diff => {
@@ -604,7 +601,7 @@ module.exports = cls => class Reifier extends cls {
       .then(() => this[_createSparseTree]())
       .then(() => this[_addOmitsToTrashList]())
       .then(() => this[_loadShrinkwrapsAndUpdateTrees]())
-      .then(() => process.emit('timeEnd', 'reify:loadShrinkwraps'))
+      .then(timeEnd)
   }
 
   // create a symlink for Links, extract for Nodes
@@ -619,8 +616,7 @@ module.exports = cls => class Reifier extends cls {
       return node
     }
 
-    const timer = `reifyNode:${node.location}`
-    process.emit('time', timer)
+    const timeEnd = time.start(`reifyNode:${node.location}`)
     this.addTracker('reify', node.name, node.location)
 
     const { npmVersion, nodeVersion, cpu, os, libc } = this.options
@@ -643,7 +639,7 @@ module.exports = cls => class Reifier extends cls {
     return this[_handleOptionalFailure](node, p)
       .then(() => {
         this.finishTracker('reify', node.name, node.location)
-        process.emit('timeEnd', timer)
+        timeEnd()
         return node
       })
   }
@@ -786,7 +782,7 @@ module.exports = cls => class Reifier extends cls {
     depth = 0, bundlesByDepth = this[_getBundlesByDepth]()
   ) {
     if (depth === 0) {
-      process.emit('time', 'reify:loadBundles')
+      time.start('reify:loadBundles')
     }
 
     const maxBundleDepth = bundlesByDepth.get('maxBundleDepth')
@@ -796,7 +792,7 @@ module.exports = cls => class Reifier extends cls {
         this[_pruneBundledMetadeps](bundlesByDepth)
         this[_diffTrees]()
       }
-      process.emit('timeEnd', 'reify:loadBundles')
+      time.end('reify:loadBundles')
       return
     }
 
@@ -981,7 +977,7 @@ module.exports = cls => class Reifier extends cls {
     // before finishing the reify() and returning the tree.  Thus, we do
     // NOT return the promise, as the intent is for this to run in parallel
     // with the reification, and be resolved at a later time.
-    process.emit('time', 'reify:audit')
+    const timeEnd = time.start('reify:audit')
     const options = { ...this.options }
     const tree = this.idealTree
 
@@ -995,7 +991,7 @@ module.exports = cls => class Reifier extends cls {
     }
 
     this.auditReport = AuditReport.load(tree, options).then(res => {
-      process.emit('timeEnd', 'reify:audit')
+      timeEnd()
       return res
     })
   }
@@ -1005,7 +1001,7 @@ module.exports = cls => class Reifier extends cls {
   // kicking off each unpack job.  If any fail, we rm the sparse
   // tree entirely and try to put everything back where it was.
   [_unpackNewModules] () {
-    process.emit('time', 'reify:unpack')
+    const timeEnd = time.start('reify:unpack')
     const unpacks = []
     dfwalk({
       tree: this.diff,
@@ -1038,8 +1034,7 @@ module.exports = cls => class Reifier extends cls {
       },
       getChildren: diff => diff.children,
     })
-    return promiseAllRejectLate(unpacks)
-      .then(() => process.emit('timeEnd', 'reify:unpack'))
+    return promiseAllRejectLate(unpacks).then(timeEnd)
   }
 
   // This is the part where we move back the unchanging nodes that were
@@ -1054,7 +1049,7 @@ module.exports = cls => class Reifier extends cls {
     // This is sort of an inverse diff tree, of all the nodes where
     // the actualTree and idealTree _don't_ differ, starting from the
     // shallowest nodes that we moved aside in the first place.
-    process.emit('time', 'reify:unretire')
+    const timeEnd = time.start('reify:unretire')
     const moves = this[_retiredPaths]
     this[_retiredUnchanged] = {}
     return promiseAllRejectLate(this.diff.children.map(diff => {
@@ -1102,8 +1097,7 @@ module.exports = cls => class Reifier extends cls {
         const dir = bd && bd.length ? node.path + '/node_modules' : node.path
         return mkdir(dir, { recursive: true }).then(() => this[_moveContents](node, fromPath))
       }))
-    }))
-      .then(() => process.emit('timeEnd', 'reify:unretire'))
+    })).then(timeEnd)
   }
 
   // move the contents from the fromPath to the node.path
@@ -1135,7 +1129,7 @@ module.exports = cls => class Reifier extends cls {
   }
 
   [_build] () {
-    process.emit('time', 'reify:build')
+    const timeEnd = time.start('reify:build')
 
     // for all the things being installed, run their appropriate scripts
     // run in tip->root order, so as to be more likely to build a node's
@@ -1167,8 +1161,7 @@ module.exports = cls => class Reifier extends cls {
       }
     }
 
-    return this.rebuild({ nodes, handleOptionalFailure: true })
-      .then(() => process.emit('timeEnd', 'reify:build'))
+    return this.rebuild({ nodes, handleOptionalFailure: true }).then(timeEnd)
   }
 
   // the tree is pretty much built now, so it's cleanup time.
@@ -1176,7 +1169,7 @@ module.exports = cls => class Reifier extends cls {
   // If this fails, there isn't much we can do but tell the user about it.
   // Thankfully, it's pretty unlikely that it'll fail, since rm is a node builtin.
   async [_removeTrash] () {
-    process.emit('time', 'reify:trash')
+    const timeEnd = time.start('reify:trash')
     const promises = []
     const failures = []
     const _rm = path => rm(path, { recursive: true, force: true }).catch(er => failures.push([path, er]))
@@ -1189,7 +1182,8 @@ module.exports = cls => class Reifier extends cls {
     if (failures.length) {
       log.warn('cleanup', 'Failed to remove some directories', failures)
     }
-    process.emit('timeEnd', 'reify:trash')
+
+    timeEnd()
   }
 
   // last but not least, we save the ideal tree metadata to the package-lock
@@ -1222,7 +1216,7 @@ module.exports = cls => class Reifier extends cls {
       return false
     }
 
-    process.emit('time', 'reify:save')
+    const timeEnd = time.start('reify:save')
 
     const updatedTrees = new Set()
     const updateNodes = nodes => {
@@ -1460,7 +1454,7 @@ module.exports = cls => class Reifier extends cls {
       })
     }
 
-    process.emit('timeEnd', 'reify:save')
+    timeEnd()
     return true
   }
 
@@ -1571,17 +1565,14 @@ module.exports = cls => class Reifier extends cls {
         const { scripts = {} } = pkg
         for (const event of ['predependencies', 'dependencies', 'postdependencies']) {
           if (Object.prototype.hasOwnProperty.call(scripts, event)) {
-            const timer = `reify:run:${event}`
-            process.emit('time', timer)
             log.info('run', pkg._id, event, scripts[event])
-            await runScript({
+            await time.start(`reify:run:${event}`, () => runScript({
               event,
               path,
               pkg,
               stdio,
               scriptShell: this.options.scriptShell,
-            })
-            process.emit('timeEnd', timer)
+            }))
           }
         }
       }

package/lib/audit-report.js

@@ -13,7 +13,7 @@ const _fixAvailable = Symbol('fixAvailable')
 const _checkTopNode = Symbol('checkTopNode')
 const _init = Symbol('init')
 const _omit = Symbol('omit')
-const log = require('proc-log')
+const { log, time } = require('proc-log')
 
 const fetch = require('npm-registry-fetch')
 
@@ -117,7 +117,7 @@ class AuditReport extends Map {
   }
 
   async [_init] () {
-    process.emit('time', 'auditReport:init')
+    const timeEnd = time.start('auditReport:init')
 
     const promises = []
     for (const [name, advisories] of Object.entries(this.report)) {
@@ -210,7 +210,8 @@ class AuditReport extends Map {
         }
       }
     }
-    process.emit('timeEnd', 'auditReport:init')
+
+    timeEnd()
   }
 
   [_checkTopNode] (topNode, vuln, spec) {
@@ -306,7 +307,7 @@ class AuditReport extends Map {
       return null
     }
 
-    process.emit('time', 'auditReport:getReport')
+    const timeEnd = time.start('auditReport:getReport')
     try {
       try {
         // first try the super fast bulk advisory listing
@@ -347,7 +348,7 @@ class AuditReport extends Map {
       this.error = er
       return null
     } finally {
-      process.emit('timeEnd', 'auditReport:getReport')
+      timeEnd()
     }
   }
 }

package/lib/place-dep.js

@@ -8,8 +8,8 @@
 // a result.
 
 const localeCompare = require('@isaacs/string-locale-compare')('en')
-const log = require('proc-log')
-const { cleanUrl } = require('npm-registry-fetch')
+const { log } = require('proc-log')
+const { redact } = require('@npmcli/redact')
 const deepestNestingTarget = require('./deepest-nesting-target.js')
 const CanPlaceDep = require('./can-place-dep.js')
 const {
@@ -188,7 +188,7 @@ class PlaceDep {
       `${this.dep.name}@${this.dep.version}`,
       this.canPlace.description,
       `for: ${this.edge.from.package._id || this.edge.from.location}`,
-      `want: ${cleanUrl(this.edge.spec || '*')}`
+      `want: ${redact(this.edge.spec || '*')}`
     )
 
     const placementType = this.canPlace.canPlace === CONFLICT

package/lib/query-selector-all.js

@@ -3,7 +3,7 @@
 const { resolve } = require('path')
 const { parser, arrayDelimiter } = require('@npmcli/query')
 const localeCompare = require('@isaacs/string-locale-compare')('en')
-const log = require('proc-log')
+const { log } = require('proc-log')
 const { minimatch } = require('minimatch')
 const npa = require('npm-package-arg')
 const pacote = require('pacote')

package/lib/shrinkwrap.js

@@ -33,7 +33,7 @@ const mismatch = (a, b) => a && b && a !== b
 // After calling this.commit(), any nodes not present in the tree will have
 // been removed from the shrinkwrap data as well.
 
-const log = require('proc-log')
+const { log } = require('proc-log')
 const YarnLock = require('./yarn-lock.js')
 const {
   readFile,
@@ -1145,6 +1145,7 @@ class Shrinkwrap {
       throw new Error('run load() before saving data')
     }
 
+    // This must be called before the lockfile conversion check below since it sets properties as part of `commit()`
     const json = this.toString(options)
     if (
       !this.hiddenLockfile
@@ -1155,6 +1156,7 @@ class Shrinkwrap {
       `Converting lock file (${relative(process.cwd(), this.filename)}) from v${this.originalLockfileVersion} -> v${this.lockfileVersion}`
       )
     }
+
     return Promise.all([
       writeFile(this.filename, json).catch(er => {
         if (this.hiddenLockfile) {

package/lib/tracker.js

@@ -1,12 +1,12 @@
-const npmlog = require('npmlog')
+const proggy = require('proggy')
 
 module.exports = cls => class Tracker extends cls {
   #progress = new Map()
-  #setProgress
 
-  constructor (options = {}) {
-    super(options)
-    this.#setProgress = !!options.progress
+  #createTracker (key, name) {
+    const tracker = new proggy.Tracker(name ?? key)
+    tracker.on('done', () => this.#progress.delete(key))
+    this.#progress.set(key, tracker)
   }
 
   addTracker (section, subsection = null, key = null) {
@@ -26,22 +26,17 @@ module.exports = cls => class Tracker extends cls {
       this.#onError(`Tracker "${section}" already exists`)
     } else if (!hasTracker && subsection === null) {
       // 1. no existing tracker, no subsection
-      // Create a new tracker from npmlog
-      // starts progress bar
-      if (this.#setProgress && this.#progress.size === 0) {
-        npmlog.enableProgress()
-      }
-
-      this.#progress.set(section, npmlog.newGroup(section))
+      // Create a new progress tracker
+      this.#createTracker(section)
     } else if (!hasTracker && subsection !== null) {
       // 2. no parent tracker and subsection
       this.#onError(`Parent tracker "${section}" does not exist`)
     } else if (!hasTracker || !hasSubtracker) {
       // 3. existing parent tracker, no subsection tracker
-      // Create a new subtracker in this.#progress from parent tracker
-      this.#progress.set(`${section}:${key}`,
-        this.#progress.get(section).newGroup(`${section}:${subsection}`)
-      )
+      // Create a new subtracker and update parents
+      const parentTracker = this.#progress.get(section)
+      parentTracker.update(parentTracker.value, parentTracker.total + 1)
+      this.#createTracker(`${section}:${key}`, `${section}:${subsection}`)
     }
     // 4. existing parent tracker, existing subsection tracker
     // skip it
@@ -70,32 +65,22 @@ module.exports = cls => class Tracker extends cls {
           this.finishTracker(section, key)
         }
       }
-
       // remove parent tracker
       this.#progress.get(section).finish()
-      this.#progress.delete(section)
-
-      // remove progress bar if all
-      // trackers are finished
-      if (this.#setProgress && this.#progress.size === 0) {
-        npmlog.disableProgress()
-      }
     } else if (!hasTracker && subsection === null) {
       // 1. no existing parent tracker, no subsection
       this.#onError(`Tracker "${section}" does not exist`)
     } else if (!hasTracker || hasSubtracker) {
       // 2. subtracker exists
       // Finish subtracker and remove from this.#progress
+      const parentTracker = this.#progress.get(section)
+      parentTracker.update(parentTracker.value + 1)
       this.#progress.get(`${section}:${key}`).finish()
-      this.#progress.delete(`${section}:${key}`)
     }
     // 3. existing parent tracker, no subsection
   }
 
   #onError (msg) {
-    if (this.#setProgress) {
-      npmlog.disableProgress()
-    }
     throw new Error(msg)
   }
 }

package/package.json

@@ -1,18 +1,19 @@
 {
   "name": "@npmcli/arborist",
-  "version": "7.4.1",
+  "version": "7.5.0",
   "description": "Manage node_modules trees",
   "dependencies": {
     "@isaacs/string-locale-compare": "^1.1.0",
     "@npmcli/fs": "^3.1.0",
-    "@npmcli/installed-package-contents": "^2.0.2",
+    "@npmcli/installed-package-contents": "^2.1.0",
     "@npmcli/map-workspaces": "^3.0.2",
-    "@npmcli/metavuln-calculator": "^7.0.0",
+    "@npmcli/metavuln-calculator": "^7.1.0",
     "@npmcli/name-from-folder": "^2.0.0",
     "@npmcli/node-gyp": "^3.0.0",
-    "@npmcli/package-json": "^5.0.0",
+    "@npmcli/package-json": "^5.1.0",
     "@npmcli/query": "^3.1.0",
-    "@npmcli/run-script": "^7.0.2",
+    "@npmcli/redact": "^1.1.0",
+    "@npmcli/run-script": "^8.0.0",
     "bin-links": "^4.0.1",
     "cacache": "^18.0.0",
     "common-ancestor-path": "^1.0.1",
@@ -22,13 +23,13 @@
     "minimatch": "^9.0.4",
     "nopt": "^7.0.0",
     "npm-install-checks": "^6.2.0",
-    "npm-package-arg": "^11.0.1",
+    "npm-package-arg": "^11.0.2",
     "npm-pick-manifest": "^9.0.0",
-    "npm-registry-fetch": "^16.2.0",
-    "npmlog": "^7.0.1",
-    "pacote": "^17.0.4",
+    "npm-registry-fetch": "^16.2.1",
+    "pacote": "^18.0.1",
     "parse-conflict-json": "^3.0.0",
-    "proc-log": "^3.0.0",
+    "proc-log": "^4.2.0",
+    "proggy": "^2.0.0",
     "promise-all-reject-late": "^1.0.0",
     "promise-call-limit": "^3.0.1",
     "read-package-json-fast": "^3.0.2",