@notabene/javascript-sdk 2.15.0-next.1 → 2.15.0-next.3

package/dist/notabene.js

@@ -368,27 +368,29 @@ function Mn(e) {
   return e.replace(/\s+/g, "").toUpperCase();
 }
 function kn(e) {
-  if (!e.name || e.name.length === 0)
+  var l;
+  if (!((l = e.name) != null && l.nameIdentifier) || e.name.nameIdentifier.length === 0)
     return "";
-  const d = e.name.find((l) => "nameIdentifierType" in l && l.nameIdentifierType === "LEGL" || "naturalPersonNameIdentifierType" in l && l.naturalPersonNameIdentifierType === "LEGL") || e.name[0], m = [];
+  const d = e.name.nameIdentifier.find((s) => s.naturalPersonNameIdentifierType === "LEGL") || e.name.nameIdentifier[0], m = [];
   return d.secondaryIdentifier && m.push(d.secondaryIdentifier), m.push(d.primaryIdentifier), m.join(" ");
 }
 function Cn(e) {
-  return !e.name || e.name.length === 0 ? "" : (e.name.find((m) => m.legalPersonNameIdentifierType === "LEGL") || e.name[0]).legalPersonName;
+  var m;
+  return !((m = e.name) != null && m.nameIdentifier) || e.name.nameIdentifier.length === 0 ? "" : (e.name.nameIdentifier.find((l) => l.legalPersonNameIdentifierType === "LEGL") || e.name.nameIdentifier[0]).legalPersonName;
 }
 function ai(e) {
-  return ("originatorPersons" in e ? e.originatorPersons : e.originatorPerson).map((d) => d.naturalPerson ? kn(d.naturalPerson) : d.legalPerson ? Cn(d.legalPerson) : "").filter((d) => d.length > 0);
+  return e.originatorPerson.map((d) => d.naturalPerson ? kn(d.naturalPerson) : d.legalPerson ? Cn(d.legalPerson) : "").filter((d) => d.length > 0);
 }
 function oi(e) {
-  return ("beneficiaryPersons" in e ? e.beneficiaryPersons : e.beneficiaryPerson).map((d) => d.naturalPerson ? kn(d.naturalPerson) : d.legalPerson ? Cn(d.legalPerson) : "").filter((d) => d.length > 0);
+  return e.beneficiaryPerson.map((d) => d.naturalPerson ? kn(d.naturalPerson) : d.legalPerson ? Cn(d.legalPerson) : "").filter((d) => d.length > 0);
 }
 async function ui(e) {
   let n;
   if (typeof e == "string")
     n = e;
-  else if ("originatorPersons" in e || "originatorPerson" in e)
+  else if ("originatorPerson" in e)
     n = ai(e).join(" ");
-  else if ("beneficiaryPersons" in e || "beneficiaryPerson" in e)
+  else if ("beneficiaryPerson" in e)
     n = oi(e).join(" ");
   else
     throw new Error("Invalid input type. Expected string, IVMS101 Originator, or IVMS101 Beneficiary");

package/package.json

@@ -10,7 +10,7 @@
   "author": "Notabene <developers@notabene.id>",
   "license": "MIT",
   "packageManager": "yarn@4.5.1",
-  "version": "2.15.0-next.1",
+  "version": "2.15.0-next.3",
   "source": "src/notabene.ts",
   "main": "dist/cjs/notabene.cjs",
   "module": "dist/esm/notabene.js",
@@ -72,6 +72,7 @@
     "@semantic-release/git": "^10.0.1",
     "@semantic-release/gitlab": "^13.2.1",
     "@semantic-release/npm": "^12.0.1",
+    "@taprsvp/types": "^1.14.0",
     "@vitest/coverage-v8": "^2.1.8",
     "eslint": "^9.14.0",
     "eslint-config-prettier": "^9.1.0",
@@ -79,6 +80,7 @@
     "fast-check": "^3.23.1",
     "globals": "^15.11.0",
     "husky": "^9.1.6",
+    "jose": "^6.1.0",
     "jsdom": "^25.0.1",
     "lint-staged": "^15.2.10",
     "prettier": "^3.3.3",
@@ -104,9 +106,5 @@
     "extends": [
       "@commitlint/config-conventional"
     ]
-  },
-  "dependencies": {
-    "@taprsvp/types": "^1.13.0",
-    "jose": "^6.1.0"
   }
 }

package/src/__tests__/notabene.test.ts

@@ -340,6 +340,56 @@ describe('Notabene', () => {
     });
   });
 
+  describe('uxUrl trailing slash normalization', () => {
+    it('should strip a single trailing slash', () => {
+      const notabene = new Notabene({
+        uxUrl: 'https://connect.notabene.id/',
+        authToken: 'token',
+      });
+      const url = new URL(notabene.componentUrl('withdrawal-assist', {}));
+      expect(url.origin).toBe('https://connect.notabene.id');
+    });
+
+    it('should strip multiple trailing slashes', () => {
+      const notabene = new Notabene({
+        uxUrl: 'https://connect.notabene.id///',
+        authToken: 'token',
+      });
+      const url = new URL(notabene.componentUrl('withdrawal-assist', {}));
+      expect(url.origin).toBe('https://connect.notabene.id');
+    });
+
+    it('should leave a clean URL unchanged', () => {
+      const notabene = new Notabene({
+        uxUrl: 'https://connect.notabene.id',
+        authToken: 'token',
+      });
+      const url = new URL(notabene.componentUrl('withdrawal-assist', {}));
+      expect(url.origin).toBe('https://connect.notabene.id');
+    });
+
+    it('should trim whitespace', () => {
+      const notabene = new Notabene({
+        uxUrl: '  https://connect.notabene.id  ',
+        authToken: 'token',
+      });
+      const url = new URL(notabene.componentUrl('withdrawal-assist', {}));
+      expect(url.origin).toBe('https://connect.notabene.id');
+    });
+
+    it('should throw for an invalid URL', () => {
+      expect(
+        () => new Notabene({ uxUrl: 'not-a-url', authToken: 'token' }),
+      ).toThrow('Invalid uxUrl');
+    });
+
+    it('should throw for a non-http protocol', () => {
+      expect(
+        () => new Notabene({ uxUrl: 'ftp://example.com', authToken: 'token' }),
+      ).toThrow('must start with http:// or https://');
+    });
+  });
+
   describe('createDepositAssist', () => {
     test.prop([
       fc.string({ minLength: 3 }), // authToken

package/src/notabene.ts

@@ -221,15 +221,7 @@ export interface NotabeneConfig {
    */
   locale?: string;
 }
-/**
- * Primary constructor for Notabene UX elements
- *
- * This class provides methods to create and manage various Notabene components
- * such as withdrawal assist, deposit assist, connect, and deposit request.
- * It also handles URL generation and fragment decoding for these components.
- *
- * @public
- */
+
 /** Trim whitespace, validate, and strip trailing slashes from a URL. */
 function normalizeUrl(url: string, field: string): string {
   const normalized = url.trim().replace(/\/+$/, '');
@@ -247,6 +239,15 @@ function normalizeUrl(url: string, field: string): string {
   return normalized;
 }
 
+/**
+ * Primary constructor for Notabene UX elements
+ *
+ * This class provides methods to create and manage various Notabene components
+ * such as withdrawal assist, deposit assist, connect, and deposit request.
+ * It also handles URL generation and fragment decoding for these components.
+ *
+ * @public
+ */
 export default class Notabene {
   private nodeUrl?: string;
   private authToken?: string;

package/src/types.ts

@@ -878,9 +878,9 @@ export interface ThresholdOptions {
  * @public
  */
 export type SectionOption =
-  | ProofTypes.SelfDeclaration
-  | ProofTypes.Screenshot
-  | ProofTypes.MicroTransfer
+  | 'self-declaration' // ProofTypes.SelfDeclaration
+  | 'screenshot' // ProofTypes.Screenshot
+  | 'microtransfer' // ProofTypes.MicroTransfer
   | 'signature'
   | 'manual-signing'
   | 'add-vasp';