@notabene/javascript-sdk 2.14.2-next.2 → 2.14.2-next.4

package/package.json

@@ -10,7 +10,7 @@
   "author": "Notabene <developers@notabene.id>",
   "license": "MIT",
   "packageManager": "yarn@4.5.1",
-  "version": "2.14.2-next.2",
+  "version": "2.14.2-next.4",
   "source": "src/notabene.ts",
   "main": "dist/cjs/notabene.cjs",
   "module": "dist/esm/notabene.js",

package/src/__tests__/notabene.test.ts

@@ -1,5 +1,5 @@
 import { fc, test } from '@fast-check/vitest';
-import { describe } from 'vitest';
+import { describe, expect, it } from 'vitest';
 import Notabene from '../notabene';
 import {
   abitraryCallbackOptions,
@@ -14,11 +14,13 @@ import {
   arbitraryWithdrawal,
 } from '../utils/arbitraries';
 
+const arbitraryNodeUrl = () => fc.webUrl().map((u) => u.replace(/\/+$/, ''));
+
 describe('Notabene', () => {
   describe('defaults', () => {
     test.prop([
       fc.string({ minLength: 3 }),
-      fc.webUrl(),
+      arbitraryNodeUrl(),
       arbitraryComponent(),
       fc.object(),
     ])(
@@ -32,7 +34,7 @@ describe('Notabene', () => {
         return (
           url.hash ===
             `#authToken=${encodeURIComponent(authToken)}&value=${encodeURIComponent(JSON.stringify(value))}` &&
-          url.searchParams.get('nodeUrl') === nodeUrl &&
+          url.searchParams.get('nodeUrl') === nodeUrl.replace(/\/+$/, '') &&
           url.pathname === `/${component}`
         );
       },
@@ -42,7 +44,7 @@ describe('Notabene', () => {
   describe('locale', () => {
     test.prop([
       fc.string({ minLength: 3 }),
-      fc.webUrl(),
+      arbitraryNodeUrl(),
       arbitraryComponent(),
       fc.object(),
       arbitraryLocale(),
@@ -84,7 +86,7 @@ describe('Notabene', () => {
   describe('with uxUrl', () => {
     test.prop([
       fc.string({ minLength: 3 }),
-      fc.webUrl(),
+      arbitraryNodeUrl(),
       arbitraryComponent(),
       fc.webAuthority(),
       fc.object(),
@@ -113,7 +115,7 @@ describe('Notabene', () => {
   describe('with value and configuration', () => {
     test.prop([
       fc.string({ minLength: 3 }),
-      fc.webUrl(),
+      arbitraryNodeUrl(),
       arbitraryComponent(),
       fc.object(),
       fc.object(),
@@ -140,7 +142,7 @@ describe('Notabene', () => {
   describe('with value and configuration', () => {
     test.prop([
       fc.string({ minLength: 3 }),
-      fc.webUrl(),
+      arbitraryNodeUrl(),
       arbitraryComponent(),
       fc.object(),
       fc.object(),
@@ -170,7 +172,7 @@ describe('Notabene', () => {
   describe('createWithdrawalAssist', () => {
     test.prop([
       fc.string({ minLength: 3 }), // authToken
-      fc.webUrl(), // nodeUrl
+      arbitraryNodeUrl(), // nodeUrl
       arbitraryWithdrawal(),
       arbitraryTransactionOptions(), // options
       abitraryCallbackOptions(), // callbacks
@@ -204,7 +206,7 @@ describe('Notabene', () => {
   describe('createDepositRequest', () => {
     test.prop([
       fc.string({ minLength: 3 }), // authToken
-      fc.webUrl(), // nodeUrl
+      arbitraryNodeUrl(), // nodeUrl
       arbitraryDepositRequest(),
       arbitraryDepositRequestOptions(), // options
       abitraryCallbackOptions(), // callbacks
@@ -238,7 +240,7 @@ describe('Notabene', () => {
   describe('createConnectWallet', () => {
     test.prop([
       fc.string({ minLength: 3 }), // authToken
-      fc.webUrl(), // nodeUrl
+      arbitraryNodeUrl(), // nodeUrl
       arbitraryConnectionRequest(),
       arbitraryConnectionOptions(), // options
       abitraryCallbackOptions(), // callbacks
@@ -268,10 +270,80 @@ describe('Notabene', () => {
       },
     );
   });
+  describe('nodeUrl trailing slash normalization', () => {
+    it('should strip a single trailing slash', () => {
+      const notabene = new Notabene({
+        nodeUrl: 'https://api.eu1.notabene.id/',
+        authToken: 'token',
+      });
+      const url = new URL(notabene.componentUrl('withdrawal-assist', {}));
+      expect(url.searchParams.get('nodeUrl')).toBe(
+        'https://api.eu1.notabene.id',
+      );
+    });
+
+    it('should strip multiple trailing slashes', () => {
+      const notabene = new Notabene({
+        nodeUrl: 'https://api.eu1.notabene.id///',
+        authToken: 'token',
+      });
+      const url = new URL(notabene.componentUrl('withdrawal-assist', {}));
+      expect(url.searchParams.get('nodeUrl')).toBe(
+        'https://api.eu1.notabene.id',
+      );
+    });
+
+    it('should leave a clean URL unchanged', () => {
+      const notabene = new Notabene({
+        nodeUrl: 'https://api.eu1.notabene.id',
+        authToken: 'token',
+      });
+      const url = new URL(notabene.componentUrl('withdrawal-assist', {}));
+      expect(url.searchParams.get('nodeUrl')).toBe(
+        'https://api.eu1.notabene.id',
+      );
+    });
+
+    it('should trim whitespace', () => {
+      const notabene = new Notabene({
+        nodeUrl: '  https://api.eu1.notabene.id  ',
+        authToken: 'token',
+      });
+      const url = new URL(notabene.componentUrl('withdrawal-assist', {}));
+      expect(url.searchParams.get('nodeUrl')).toBe(
+        'https://api.eu1.notabene.id',
+      );
+    });
+
+    it('should throw for an invalid URL', () => {
+      expect(
+        () => new Notabene({ nodeUrl: 'not-a-url', authToken: 'token' }),
+      ).toThrow('Invalid nodeUrl');
+    });
+
+    it('should throw for a non-http protocol', () => {
+      expect(
+        () =>
+          new Notabene({ nodeUrl: 'ftp://example.com', authToken: 'token' }),
+      ).toThrow('must start with http:// or https://');
+    });
+
+    it('should preserve URL paths', () => {
+      const notabene = new Notabene({
+        nodeUrl: 'https://api.notabene.id/v2',
+        authToken: 'token',
+      });
+      const url = new URL(notabene.componentUrl('withdrawal-assist', {}));
+      expect(url.searchParams.get('nodeUrl')).toBe(
+        'https://api.notabene.id/v2',
+      );
+    });
+  });
+
   describe('createDepositAssist', () => {
     test.prop([
       fc.string({ minLength: 3 }), // authToken
-      fc.webUrl(), // nodeUrl
+      arbitraryNodeUrl(), // nodeUrl
       arbitraryDeposit(),
       arbitraryTransactionOptions(), // options
       abitraryCallbackOptions(), // callbacks

package/src/notabene.ts

@@ -70,7 +70,6 @@ import {
   ErrorIdentifierCode,
   HMType,
   IdentityVerificationMethod,
-  OAuthProvider,
   PersonType,
   ProofStatus,
   ProofTypes,
@@ -113,7 +112,6 @@ export {
   ErrorIdentifierCode,
   HMType,
   IdentityVerificationMethod,
-  OAuthProvider,
   PersonType,
   ProofStatus,
   ProofTypes,
@@ -228,6 +226,23 @@ export interface NotabeneConfig {
  *
  * @public
  */
+/** Trim whitespace, validate, and strip trailing slashes from a URL. */
+function normalizeUrl(url: string, field: string): string {
+  const normalized = url.trim().replace(/\/+$/, '');
+  let parsed: URL;
+  try {
+    parsed = new URL(normalized);
+  } catch {
+    throw new Error(`Invalid ${field}: "${url}" is not a valid URL`);
+  }
+  if (!['http:', 'https:'].includes(parsed.protocol)) {
+    throw new Error(
+      `Invalid ${field}: "${url}" (must start with http:// or https://)`,
+    );
+  }
+  return normalized;
+}
+
 export default class Notabene {
   private nodeUrl?: string;
   private authToken?: string;
@@ -241,8 +256,13 @@ export default class Notabene {
    * @param config - Configuration options for the Notabene SDK
    */
   constructor(config: NotabeneConfig) {
-    this.uxUrl = config.uxUrl || 'https://connect.notabene.id';
-    this.nodeUrl = config.nodeUrl;
+    this.uxUrl = normalizeUrl(
+      config.uxUrl || 'https://connect.notabene.id',
+      'uxUrl',
+    );
+    this.nodeUrl = config.nodeUrl
+      ? normalizeUrl(config.nodeUrl, 'nodeUrl')
+      : undefined;
     this.authToken = config.authToken;
     this.theme = config.theme;
     this.locale = config.locale;

package/src/responseTransformer/utils.ts

@@ -9,7 +9,7 @@ import { Deposit, Withdrawal } from '../types';
 export function isDeposit(
   transaction: Withdrawal | Deposit,
 ): transaction is Deposit {
-  return 'source' in transaction && transaction.source !== undefined;
+  return (transaction as Deposit).source !== undefined;
 }
 
 export function isWithdrawal(

package/src/types.ts

@@ -792,7 +792,6 @@ export type VASPOptions = {
  */
 export enum IdentityVerificationMethod {
   SMS = 'sms',
-  EMAIL = 'email',
 }
 
 /**
@@ -808,14 +807,6 @@ export enum CodeVerificationStatus {
   UNREACHABLE = 'unreachable',
 }
 
-/**
- * Supported OAuth providers for authentication
- * @public
- */
-export enum OAuthProvider {
-  COINBASE = 'coinbase',
-}
-
 /**
  * Configuration options for identity verification
  * @public
@@ -823,8 +814,6 @@ export enum OAuthProvider {
 export type IdentityVerificationConfig = {
   /** The required verification method. If not specified, none will be used */
   requiredMethod?: IdentityVerificationMethod;
-  /** OAuth provider(s) to use for authentication. Can be a single provider or array of providers */
-  oAuth?: OAuthProvider[] | OAuthProvider;
 };
 
 /**
@@ -839,6 +828,7 @@ export type CounterpartyAssistConfig =
   | boolean
   | {
       counterpartyTypes: PersonType[];
+      /** @remarks Requires a transactionId to be passed in. */
       identityVerification?: IdentityVerificationConfig;
     };