@north-light/crouter 0.3.317 → 0.3.319

package/dist/core/__tests__/yield-ensures-daemon.test.js

@@ -1,55 +0,0 @@
-// Run with: node --import tsx/esm --test src/core/__tests__/yield-ensures-daemon.test.ts
-//
-// Regression: `crtr node yield` timed out into "broker gone" instead of reviving
-// in the same pane (observed 2026-06-18). The yield arms intent='refresh' and
-// the broker shuts down expecting the DAEMON to relaunch it — but requestYield
-// never ensured the daemon was running, unlike the spawn/recycle paths. With a
-// dead daemon, the broker exited and nothing revived it; the viewer redialed its
-// view.sock for ~30s and reported "broker gone". This locks in that requestYield
-// ensures the supervisor before arming the refresh.
-import { test, before, beforeEach, after } from 'node:test';
-import assert from 'node:assert/strict';
-import { mkdtempSync, rmSync } from 'node:fs';
-import { tmpdir } from 'node:os';
-import { join } from 'node:path';
-import { createNode, getNode } from '../canvas/canvas.js';
-import { closeDb, migrate, openDb } from '../canvas/db.js';
-import { requestYield } from '../runtime/promote.js';
-let home;
-function mkOrchestrator(id) {
-    const meta = {
-        node_id: id,
-        name: id,
-        created: new Date().toISOString(),
-        cwd: '/tmp/work',
-        kind: 'general',
-        mode: 'orchestrator', // already an orchestrator → yield skips the promote path
-        lifecycle: 'terminal',
-        status: 'active', // LIVE, so transition('yield') is legal
-    };
-    createNode(meta);
-}
-before(() => {
-    home = mkdtempSync(join(tmpdir(), 'crtr-yield-ensure-'));
-    process.env['CRTR_HOME'] = home;
-});
-beforeEach(() => {
-    closeDb();
-    rmSync(home, { recursive: true, force: true });
-    migrate(openDb());
-});
-after(() => {
-    closeDb();
-    rmSync(home, { recursive: true, force: true });
-    delete process.env['CRTR_HOME'];
-});
-test('requestYield ensures the daemon before arming intent=refresh', () => {
-    mkOrchestrator('n1');
-    let ensured = 0;
-    const res = requestYield('n1', {}, { ensure: () => { ensured += 1; } });
-    // The supervisor that performs the refresh-revive must have been ensured...
-    assert.equal(ensured, 1, 'requestYield must ensure the daemon is running');
-    // ...and the yield must still arm the refresh.
-    assert.equal(res.willRefresh, true);
-    assert.equal(getNode('n1')?.intent, 'refresh');
-});

package/dist/core/broker-client/__tests__/transport-relay.test.d.ts

@@ -1 +0,0 @@
-export {};

package/dist/core/broker-client/__tests__/transport-relay.test.js

@@ -1,214 +0,0 @@
-// transport-relay.test.ts — RelayTransport coverage for the remote half of
-// the Transport seam. This fast plain-`ws` stand-in for crtrd's attach endpoint
-// exercises the required route, Authorization header, one-JSON-frame-per-WS-
-// message wire, 1011/1008 unavailable-broker classification, and a failed
-// handshake without booting pi or a broker.
-import assert from 'node:assert/strict';
-import test, { after, before } from 'node:test';
-import { existsSync, mkdtempSync, rmSync } from 'node:fs';
-import { tmpdir } from 'node:os';
-import { join } from 'node:path';
-import { WebSocketServer } from 'ws';
-import { RelayTransport } from '../transport-relay.js';
-import { BrokerUnavailableError } from '../transport.js';
-import { jobDir } from '../../canvas/paths.js';
-/** Stand up a bare `ws` crtrd attach endpoint on an ephemeral loopback port.
- *  It records each request URL, Authorization header, and accepted socket so
- *  the tests assert the wire contract directly. */
-function startMockRelay() {
-    return new Promise((resolve) => {
-        const wss = new WebSocketServer({ port: 0 });
-        const authHeaders = [];
-        const requestUrls = [];
-        const sockets = [];
-        wss.on('connection', (ws, req) => {
-            authHeaders.push(req.headers.authorization ?? '');
-            requestUrls.push(req.url ?? '');
-            sockets.push(ws);
-        });
-        wss.once('listening', () => {
-            const addr = wss.address();
-            const port = typeof addr === 'object' && addr !== null ? addr.port : 0;
-            resolve({
-                target: { previewEndpoint: `http://127.0.0.1:${port}`, relayToken: 'test-token' },
-                authHeaders,
-                requestUrls,
-                sockets,
-                close: () => new Promise((res) => wss.close(() => res())),
-            });
-        });
-    });
-}
-/** Race connect/error the SAME way `viewer.ts`'s runAttach does, cleaning
- *  up whichever listener didn't fire so later `once('error', ...)` assertions
- *  in the same test see only the events they're meant to. */
-function connectTransport(transport) {
-    return new Promise((resolve, reject) => {
-        const onConnect = () => {
-            transport.off('error', onError);
-            resolve();
-        };
-        const onError = (err) => {
-            transport.off('connect', onConnect);
-            reject(err);
-        };
-        transport.once('connect', onConnect);
-        transport.once('error', onError);
-        transport.connect();
-    });
-}
-test('RelayTransport dials crtrd attach with Authorization: Bearer <token>', async () => {
-    const relay = await startMockRelay();
-    const transport = new RelayTransport('node-auth', relay.target);
-    await connectTransport(transport);
-    // `wakeParked=1` is part of the dial contract: a person attached deliberately,
-    // so the bridge wakes an exact parked resident for this caller.
-    assert.equal(relay.requestUrls[0], '/v1/nodes/node-auth/attach?wakeParked=1');
-    assert.equal(relay.authHeaders[0], 'Bearer test-token');
-    transport.destroy();
-    await relay.close();
-});
-test('RelayTransport round-trips one JSON frame per WS message, both directions', async () => {
-    const relay = await startMockRelay();
-    const transport = new RelayTransport('node-echo', relay.target);
-    await connectTransport(transport);
-    // server → client: one broker-protocol frame, one WS message.
-    const ack = { type: 'ack', for: 'hello', ok: true, detail: 'welcome' };
-    const framePromise = new Promise((resolve) => transport.once('frame', resolve));
-    relay.sockets[0].send(JSON.stringify(ack));
-    assert.deepEqual(await framePromise, ack);
-    // client → server: send() produces exactly one WS text message per frame.
-    const hello = { type: 'hello', role: 'controller', client_id: 'c1' };
-    const serverMessages = [];
-    relay.sockets[0].on('message', (data) => serverMessages.push(JSON.parse(data.toString())));
-    transport.send(hello);
-    await new Promise((r) => setTimeout(r, 50));
-    assert.deepEqual(serverMessages, [hello]);
-    transport.destroy();
-    await relay.close();
-});
-test('a 1011 close with "no running broker for <id>" surfaces BrokerUnavailableError', async () => {
-    const relay = await startMockRelay();
-    const transport = new RelayTransport('node-gone', relay.target);
-    await connectTransport(transport);
-    const errorPromise = new Promise((resolve) => transport.once('error', resolve));
-    relay.sockets[0].close(1011, 'no running broker for node-gone');
-    const err = await errorPromise;
-    assert.ok(err instanceof BrokerUnavailableError, `expected BrokerUnavailableError, got ${err}`);
-    await relay.close();
-});
-test('a 1000 normal close does NOT surface BrokerUnavailableError', async () => {
-    const relay = await startMockRelay();
-    const transport = new RelayTransport('node-normal', relay.target);
-    await connectTransport(transport);
-    let sawError;
-    transport.on('error', (err) => {
-        sawError = err;
-    });
-    const closePromise = new Promise((resolve) => transport.once('close', resolve));
-    relay.sockets[0].close(1000, 'normal');
-    await closePromise;
-    assert.equal(sawError, undefined);
-    await relay.close();
-});
-test('an immediate post-upgrade 1011 "no node <id>" close is still caught by a listener installed BEFORE connect() is dialed', async () => {
-    // Simulate a crtrd attach connection that closes 1011 immediately after its
-    // WebSocket upgrade. This is the ordering that
-    // broke `viewer.ts`'s original startup race: the transport's 'connect'
-    // (WS 'open') is structurally guaranteed to fire before any close frame can
-    // be parsed (a close can't precede the handshake that establishes the
-    // connection), so a TEMPORARY connect-race listener torn down as soon as
-    // 'connect' resolves always misses this close. The fix installs a listener
-    // that is never removed instead — reproduced here.
-    const wss = new WebSocketServer({ port: 0 });
-    wss.on('connection', (ws) => {
-        ws.close(1011, 'no node node-gone-fast');
-    });
-    await new Promise((resolve) => wss.once('listening', resolve));
-    const addr = wss.address();
-    const port = typeof addr === 'object' && addr !== null ? addr.port : 0;
-    const transport = new RelayTransport('node-gone-fast', {
-        previewEndpoint: `http://127.0.0.1:${port}`,
-        relayToken: 'test-token',
-    });
-    // Reproduce viewer.ts's durable-listener fix: installed BEFORE
-    // connect() is dialed, and never removed — exactly the guard that survives
-    // the gap a temporary connect-race listener does not.
-    let terminalError;
-    transport.on('error', (err) => {
-        if (terminalError === undefined)
-            terminalError = err;
-    });
-    await new Promise((resolve) => {
-        transport.once('connect', resolve);
-        transport.connect();
-    });
-    // Proves the structural ordering the fix accounts for: 'connect' has ALREADY
-    // resolved here, before the close was ever observed — a naive connect-race
-    // would have already declared success and torn down its error listener.
-    // Compare a boolean rather than `terminalError` itself — `assert.equal`'s
-    // TS signature asserts the narrowed type on its first argument, which would
-    // otherwise wrongly pin `terminalError` to `undefined` for the rest of this
-    // test even though the listener above can still reassign it.
-    assert.equal(terminalError === undefined, true, "connect resolves before the close is observed — that's the bug");
-    // The close lands shortly after — caught by the durable listener, not a
-    // fresh temporary one (there is none left by now).
-    await new Promise((resolve) => transport.once('close', resolve));
-    assert.ok(terminalError !== undefined && terminalError instanceof BrokerUnavailableError, `expected the durable listener to have recorded a BrokerUnavailableError, got ${terminalError}`);
-    transport.destroy();
-    await new Promise((res) => wss.close(() => res()));
-});
-// --- Phase 3 review Major 3: RelayTransport must never write LOCAL fault
-// state keyed by a REMOTE node id (it is only ever constructed for --canvas
-// attach; there is no legitimate local use case). ---
-let faultTestHome;
-before(() => {
-    faultTestHome = mkdtempSync(join(tmpdir(), 'crtr-transport-relay-fault-'));
-    process.env['CRTR_HOME'] = faultTestHome;
-});
-after(() => {
-    rmSync(faultTestHome, { recursive: true, force: true });
-    delete process.env['CRTR_HOME'];
-});
-test('RelayTransport never writes local fault state for the remote node id, even on a connect failure', async () => {
-    const nodeId = 'remote-fault-test-node';
-    const wss = new WebSocketServer({
-        port: 0,
-        verifyClient: (_info, cb) => cb(false, 401, 'unauthorized'),
-    });
-    await new Promise((resolve) => wss.once('listening', resolve));
-    const addr = wss.address();
-    const port = typeof addr === 'object' && addr !== null ? addr.port : 0;
-    const transport = new RelayTransport(nodeId, {
-        previewEndpoint: `http://127.0.0.1:${port}`,
-        relayToken: 'bad-token',
-    });
-    await new Promise((resolve) => {
-        transport.once('error', () => resolve());
-        transport.connect();
-    });
-    assert.equal(existsSync(join(jobDir(nodeId), 'fault')), false, 'a remote relay connect failure must never write a LOCAL fault file keyed by the remote node id');
-    transport.destroy();
-    await new Promise((res) => wss.close(() => res()));
-});
-test('a non-101 handshake response (401, bad token) rejects connect() with a clear error, not a hang', async () => {
-    const wss = new WebSocketServer({
-        port: 0,
-        verifyClient: (_info, cb) => cb(false, 401, 'unauthorized'),
-    });
-    await new Promise((resolve) => wss.once('listening', resolve));
-    const addr = wss.address();
-    const port = typeof addr === 'object' && addr !== null ? addr.port : 0;
-    const transport = new RelayTransport('node-401', {
-        previewEndpoint: `http://127.0.0.1:${port}`,
-        relayToken: 'bad-token',
-    });
-    const outcome = await Promise.race([
-        connectTransport(transport).then(() => 'connected', (err) => err),
-        new Promise((_, reject) => setTimeout(() => reject(new Error('timed out — connect() hung on a non-101 handshake response')), 3000)),
-    ]);
-    assert.notEqual(outcome, 'connected');
-    assert.ok(outcome instanceof Error);
-    assert.match(outcome.message, /relay transport error/);
-    await new Promise((res) => wss.close(() => res()));
-});

package/dist/core/broker-client/__tests__/transport-socket.test.d.ts

@@ -1 +0,0 @@
-export {};

package/dist/core/broker-client/__tests__/transport-socket.test.js

@@ -1,73 +0,0 @@
-import assert from 'node:assert/strict';
-import { existsSync, mkdtempSync, rmSync } from 'node:fs';
-import test from 'node:test';
-import { CrtrClient } from '../../../api/client.js';
-import { createNode } from '../../canvas/canvas.js';
-import { closeDb, migrate, openDb } from '../../canvas/db.js';
-import { apiSocketPath } from '../../canvas/paths.js';
-import { readFault } from '../../canvas/recovery.js';
-import { createApiServer } from '../../../daemon/api/server.js';
-import { SocketTransport } from '../transport-socket.js';
-async function waitFor(check, label) {
-    for (let i = 0; i < 200; i++) {
-        if (check())
-            return;
-        await new Promise((resolve) => setTimeout(resolve, 5));
-    }
-    throw new Error(`timed out waiting for ${label}`);
-}
-async function waitForSocket() {
-    const client = CrtrClient.forLocalSocket({ autostart: false });
-    await waitFor(() => existsSync(apiSocketPath()), 'the API socket path');
-    for (let i = 0; i < 200; i++) {
-        try {
-            await client.healthz();
-            return;
-        }
-        catch {
-            await new Promise((resolve) => setTimeout(resolve, 5));
-        }
-    }
-    throw new Error('timed out waiting for the API socket');
-}
-function node(nodeId) {
-    return {
-        node_id: nodeId,
-        name: nodeId,
-        created: new Date().toISOString(),
-        cwd: '/tmp/work',
-        kind: 'general',
-        mode: 'base',
-        lifecycle: 'terminal',
-        status: 'active',
-    };
-}
-test('a missing dormant broker does not leave a viewer↔broker fault', async () => {
-    const previousHome = process.env['CRTR_HOME'];
-    const home = mkdtempSync('/tmp/crtr-transport-socket-');
-    let server;
-    process.env['CRTR_HOME'] = home;
-    closeDb();
-    migrate(openDb());
-    try {
-        server = createApiServer();
-        await waitForSocket();
-        const nodeId = 'dormant-node';
-        createNode(node(nodeId));
-        const transport = new SocketTransport(nodeId);
-        await assert.rejects(transport.redial());
-        await waitFor(() => readFault(nodeId)?.link === 'viewer↔broker', 'the failed redial fault');
-        await assert.rejects(transport.redial({ brokerUnavailableIsExpected: true }));
-        await waitFor(() => readFault(nodeId) === null, 'the expected-unavailable fault clear');
-        transport.destroy();
-    }
-    finally {
-        await server?.close();
-        closeDb();
-        if (previousHome === undefined)
-            delete process.env['CRTR_HOME'];
-        else
-            process.env['CRTR_HOME'] = previousHome;
-        rmSync(home, { recursive: true, force: true });
-    }
-});

package/dist/core/canvas/__tests__/attention.test.d.ts

@@ -1 +0,0 @@
-export {};

package/dist/core/canvas/__tests__/attention.test.js

@@ -1,83 +0,0 @@
-// attention.test.ts — pending requests are attributed by requester identity.
-import { test, before, beforeEach, after } from 'node:test';
-import assert from 'node:assert/strict';
-import { mkdtempSync, rmSync } from 'node:fs';
-import { tmpdir } from 'node:os';
-import { join } from 'node:path';
-import { createPageRequest } from '../../human/requests.js';
-import { createNode } from '../canvas.js';
-import { closeDb } from '../db.js';
-import { ticketCountsForNodes, pendingTicketsForView, invalidateTicketCounts } from '../attention.js';
-import { migrate, openDb } from '../db.js';
-function meta(id, cwd, extra) {
-    return {
-        node_id: id,
-        name: id,
-        created: new Date().toISOString(),
-        cwd,
-        kind: 'general',
-        mode: 'base',
-        lifecycle: 'terminal',
-        status: 'active',
-        ...extra,
-    };
-}
-function seedPage(requestId, requesterNodeId) {
-    createPageRequest({
-        request_id: requestId,
-        requester_node_id: requesterNodeId,
-        prepared: {
-            document: '<html><head><title>Request</title></head><body>Request</body></html>',
-            manifest: {
-                schema: 'crtr.page/v2',
-                dialect: 'html',
-                title: requestId,
-                subtitle: 'Acknowledge this ticket so the request can proceed.',
-                delivery: { placement: 'inline', inbox: true, reply: true },
-                document: 'page.html',
-                steps: 1,
-                slots: [],
-            },
-        },
-    });
-}
-let home;
-let sharedCwd;
-let soloCwd;
-before(() => {
-    home = mkdtempSync(join(tmpdir(), 'crtr-attention-'));
-    sharedCwd = mkdtempSync(join(tmpdir(), 'crtr-attention-shared-'));
-    soloCwd = mkdtempSync(join(tmpdir(), 'crtr-attention-solo-'));
-    process.env['CRTR_HOME'] = home;
-});
-beforeEach(() => {
-    closeDb();
-    invalidateTicketCounts();
-    rmSync(home, { recursive: true, force: true });
-    migrate(openDb());
-});
-after(() => {
-    closeDb();
-    for (const d of [home, sharedCwd, soloCwd])
-        rmSync(d, { recursive: true, force: true });
-    delete process.env['CRTR_HOME'];
-});
-test('ticketCountsForNodes follows requester identity even when asking nodes share a cwd', () => {
-    createNode(meta('a', sharedCwd));
-    createNode(meta('b', sharedCwd));
-    createNode(meta('c', soloCwd));
-    seedPage('request-a1', 'a');
-    seedPage('request-a2', 'a');
-    seedPage('request-b', 'b');
-    seedPage('request-c', 'c');
-    assert.deepEqual(ticketCountsForNodes(['a', 'b', 'c']), { a: 2, b: 1, c: 1 });
-});
-test('pendingTicketsForView returns the asking node rather than a cwd bucket', () => {
-    createNode(meta('a', sharedCwd));
-    createNode(meta('b', sharedCwd));
-    seedPage('request-a', 'a');
-    seedPage('request-b', 'b');
-    assert.deepEqual(pendingTicketsForView('a').map(({ node_id, count }) => ({ node_id, count })), [
-        { node_id: 'a', count: 1 },
-    ]);
-});

package/dist/core/canvas/__tests__/history-transcript.test.d.ts

@@ -1 +0,0 @@
-export {};

package/dist/core/canvas/__tests__/history-transcript.test.js

@@ -1,102 +0,0 @@
-// history-transcript.test.ts — transcript artifacts carry the origin their
-// stamp recorded.
-//
-// The join is the fragile part: a stamp is physically written BEFORE the
-// message it describes, so correlation runs on the message's own epoch-ms
-// `timestamp` and never on tree position. Getting that wrong yields a corpus
-// where every origin silently reads `unknown` — which looks like a stamping
-// regression rather than a reader bug, so it is worth pinning.
-import { test, before, beforeEach, after } from 'node:test';
-import assert from 'node:assert/strict';
-import { mkdtempSync, rmSync, writeFileSync } from 'node:fs';
-import { tmpdir } from 'node:os';
-import { join } from 'node:path';
-import { createNode } from '../canvas.js';
-import { closeDb, migrate, openDb } from '../db.js';
-import { resetSession } from '../sessions.js';
-import { nodeArtifacts, groupCorpus } from '../history.js';
-const NODE = 'test-transcript-node';
-function meta(id, cwd) {
-    return {
-        node_id: id,
-        name: id,
-        created: new Date().toISOString(),
-        cwd,
-        kind: 'general',
-        mode: 'base',
-        lifecycle: 'terminal',
-        status: 'active',
-    };
-}
-function messageEntry(role, text, msgTs) {
-    return JSON.stringify({
-        type: 'message',
-        timestamp: new Date(msgTs).toISOString(),
-        message: { role, content: [{ type: 'text', text }], timestamp: msgTs },
-    });
-}
-function stampEntry(msgTs, origin) {
-    return JSON.stringify({
-        type: 'custom',
-        customType: 'crtr-stamp',
-        data: { v: 1, kind: 'message', payload: { msgTs, origin } },
-    });
-}
-/** A session file in the real on-disk shape: stamps precede their messages,
- *  one inbound turn is unstamped, and an assistant turn sits between them. */
-function seedSession(home) {
-    const file = join(home, 'session.jsonl');
-    writeFileSync(file, [
-        JSON.stringify({ type: 'custom', customType: 'crtr-stamp', data: { v: 1, kind: 'session', payload: { node: NODE, crtr: '0.0.0' } } }),
-        stampEntry(1000, { type: 'runtime', kind: 'wake', wake: { kind: 'schedule_revive', ownerId: null, armedAt: 'x' } }),
-        messageEntry('user', 'woken by cron', 1000),
-        JSON.stringify({ type: 'message', timestamp: new Date(1500).toISOString(), message: { role: 'assistant', content: [{ type: 'thinking', text: 'private' }, { type: 'toolCall', name: 'Bash' }], timestamp: 1500 } }),
-        stampEntry(2000, { type: 'runtime', kind: 'inbox', entries: [{ from: 'n1', fromName: 'child-node', kind: 'report', tier: 'normal' }] }),
-        messageEntry('user', 'a delivery', 2000),
-        messageEntry('user', 'no stamp for this one', 3000),
-    ].join('\n'), 'utf8');
-    resetSession(NODE, { sessionId: 'history-transcript-session', transcriptPath: file });
-}
-let home;
-let cwd;
-before(() => {
-    home = mkdtempSync(join(tmpdir(), 'crtr-history-transcript-'));
-    cwd = mkdtempSync(join(tmpdir(), 'crtr-history-transcript-cwd-'));
-    process.env['CRTR_HOME'] = home;
-});
-beforeEach(() => {
-    closeDb();
-    rmSync(home, { recursive: true, force: true });
-    migrate(openDb());
-});
-after(() => {
-    closeDb();
-    for (const d of [home, cwd])
-        rmSync(d, { recursive: true, force: true });
-    delete process.env['CRTR_HOME'];
-});
-test('a stamped message carries its origin; an unstamped one reads unknown', () => {
-    createNode(meta(NODE, cwd));
-    seedSession(home);
-    const arts = nodeArtifacts(NODE, ['transcript']);
-    assert.equal(arts.length, 4, 'every message entry becomes one artifact');
-    const origins = arts.map((a) => a.origin);
-    assert.deepEqual(origins, ['wake', undefined, 'inbox', 'unknown']);
-    // Origin is a property of ARRIVAL — a generated turn must not acquire one,
-    // which is what lets `--origin` exclude assistant turns without a role filter.
-    const assistant = arts.find((a) => a.role === 'assistant');
-    assert.equal(assistant?.origin, undefined);
-    // Sender attribution rides the inbox stamp's delivered entries.
-    assert.equal(arts[2]?.from, 'child-node');
-    // Private model reasoning stays out of the searchable body, matching every
-    // other human-facing transcript surface.
-    assert.ok(!assistant?.loadBody().includes('private'));
-    assert.ok(assistant?.loadBody().includes('Tool: Bash'));
-});
-test('grouping by origin counts arrivals only, and unknown is its own bucket', () => {
-    createNode(meta(NODE, cwd));
-    seedSession(home);
-    const groups = groupCorpus(nodeArtifacts(NODE, ['transcript']), 'origin');
-    assert.deepEqual(groups.map((g) => g.key).sort(), ['inbox', 'unknown', 'wake'], 'the assistant turn contributes no bucket');
-    assert.equal(groups.reduce((n, g) => n + g.count, 0), 3);
-});

package/dist/core/canvas/__tests__/remote-canvas-source.test.d.ts

@@ -1 +0,0 @@
-export {};