@north-light/crouter 0.3.292 → 0.3.294

package/dist/commands/memory/__tests__/memory-list-and-lint-ignore.test.js

@@ -94,3 +94,29 @@ test('memory write and edit set, validate, and unset lint-ignore', async () => {
     assert.ok(error instanceof CrtrError);
     assert.equal(error.code, 'usage');
 });
+test('memory edit --unset removes a legacy frontmatter field and refuses a protected one', async () => {
+    writeMemory('legacy.md', 'kind: knowledge\nname: legacy\ndescription: legacy attribution to strip\nwhen-and-why-to-read: When testing legacy field removal, this knowledge should be read because the doc exists to prove removal works.');
+    await editLeaf.run({
+        name: 'legacy',
+        scope: 'user',
+        rationale: 'drop the legacy description field',
+        unset: ['description'],
+    });
+    const afterUnset = parseFrontmatterGeneric(readFileSync(join(home, '.crouter', 'memory', 'legacy.md'), 'utf8')).data;
+    assert.equal(afterUnset?.['description'], undefined);
+    assert.equal(afterUnset?.['name'], 'legacy');
+    let error;
+    try {
+        await editLeaf.run({
+            name: 'legacy',
+            scope: 'user',
+            rationale: 'try to drop a protected field',
+            unset: ['when-and-why-to-read'],
+        });
+    }
+    catch (caught) {
+        error = caught;
+    }
+    assert.ok(error instanceof CrtrError);
+    assert.equal(error.code, 'usage');
+});

package/dist/commands/memory/edit.js

@@ -5,10 +5,14 @@ import { readText, writeText } from '../../core/fs-utils.js';
 import { loadMemoryStoreView, resolveMemoryCandidates, } from '../../core/memory-resolver.js';
 import { appendHistoryRecord, buildHistoryRecord, historyLogPathFor, readHistoryRecords, } from '../../core/memory/history.js';
 import { DOC_RATIONALE_CONSTRAINT, GUIDE_CANONICAL_NAMES, GUIDE_DOC_LINKS, GUIDE_PREDICATE_VOCABULARY, GUIDE_ROUTING_LINE, GUIDE_SURFACES, coerceGate, coerceLintIgnore, coerceSurface, memoryExtensionCatalogForDoc, memoryExtensionFieldCatalogHelp, overlayParam, parseRequestedExtensionChanges, applyExtensionChanges, literalBodySegment, serializeMemoryDocLiteral, selectorParam, requireLocalNameInStore, requireUnambiguousDoc, resolveReadSelector, } from './shared.js';
-/** Frontmatter fields an overlay flag cannot express removing. `kind` and the
- *  routing line are the document's contract (a doc without them is malformed);
- *  `origin` and `last-updated` are runtime provenance. */
+/** Frontmatter fields an overlay flag cannot express removing. Accepted for
+ *  `--unset` unconditionally — whether or not the target doc currently
+ *  carries them. */
 const CLEARABLE_FIELDS = ['short-form', 'gate', 'surfaces', 'unlisted', 'slash', 'rationale', 'lint-ignore'];
+/** `kind` and the routing line are the document's contract (a doc without
+ *  them is malformed); `origin` and `last-updated` are runtime provenance.
+ *  Never removable via `--unset`, regardless of what the doc carries. */
+const PROTECTED_FIELDS = ['kind', 'when-and-why-to-read', 'origin', 'last-updated'];
 export const editLeaf = defineLeaf({
     name: 'edit',
     description: 'revise an existing memory document, recording why',
@@ -19,7 +23,7 @@ export const editLeaf = defineLeaf({
         guide: 'The body you pipe is saved byte for byte. Nothing between stdin and disk parses, normalizes, summarizes, or rewrites it \u2014 the frontmatter fence is prepended and the text is otherwise untouched. Relaying a person\u2019s own words is therefore safe: pass them through unchanged and mark them with --verbatim.\n\n' +
             'Two different rationales exist and they never share a flag. --rationale is why THIS REVISION is happening; it is required, it lands in the revision history, and it never touches the document text. --doc-rationale replaces the document\u2019s standing `rationale` frontmatter field \u2014 the observed gap the doc exists to close.\n\n' +
             'Omitting stdin leaves the body exactly as it stands, which is how a frontmatter-only revision is made. Piping a body REPLACES the whole body; there is no partial or append mode. Emptying a document is not an edit \u2014 that intent is `crtr memory delete`.\n\n' +
-            'Omitted frontmatter flags preserve their fields. --unset is the only way to REMOVE one, and it is limited to fields a doc can legitimately live without (short-form, gate, surfaces, unlisted, slash, rationale, lint-ignore). --surface replaces the whole surfaces list rather than adding to it.\n\n' +
+            'Omitted frontmatter flags preserve their fields. --unset is the only way to REMOVE one. The canonical clearable set (short-form, gate, surfaces, unlisted, slash, rationale, lint-ignore) is always accepted; any other field name is accepted only when the document’s frontmatter already carries it — the path for dropping a legacy or non-canonical field. --surface replaces the whole surfaces list rather than adding to it.\n\n' +
             'An edit that changes nothing fails. A rationale attached to zero change is noise in the trail the history exists to build \u2014 if the doc already says what you meant, there is nothing to record.\n\n' +
             '`last-updated` is stamped on every successful edit; `origin` is preserved, so it keeps pointing at the conversation that created the doc rather than the last one to touch it.\n\n' +
             GUIDE_ROUTING_LINE + '\n\n' +
@@ -43,7 +47,7 @@ export const editLeaf = defineLeaf({
             { kind: 'flag', name: 'doc-rationale', type: 'string', required: false, constraint: DOC_RATIONALE_CONSTRAINT },
             { kind: 'flag', name: 'extension', type: 'string', required: false, repeatable: true, constraint: 'Set one declared plugin field as `extensions.<plugin>.<field>=VALUE`. The path is required in full; booleans accept only true or false, numbers require finite numeric syntax, and strings/enums preserve the literal text after the first =. Every requested field validates before the document is revised.' },
             { kind: 'flag', name: 'unset-extension', type: 'string', required: false, repeatable: true, constraint: 'Remove one explicitly persisted declared field by its full `extensions.<plugin>.<field>` path. A removed explicit value lets its declaration default apply only in structured output.' },
-            { kind: 'flag', name: 'unset', type: 'enum', choices: [...CLEARABLE_FIELDS], required: false, repeatable: true, constraint: 'Remove a frontmatter field an overlay flag cannot express removing. One field per occurrence. `kind`, `when-and-why-to-read`, `origin`, and `last-updated` are never clearable.' },
+            { kind: 'flag', name: 'unset', type: 'string', required: false, repeatable: true, constraint: `Remove a frontmatter field. One field per occurrence. ${CLEARABLE_FIELDS.join(', ')} are always accepted, whether or not the doc currently carries them. Any other field name is accepted only when the target document's frontmatter already carries it — this is the path for dropping a legacy or otherwise non-canonical field (e.g. a stale \`name:\` or \`description:\` left over from before \`when-and-why-to-read\`). Requesting a field the doc does not have fails, naming the fields it does have. \`${PROTECTED_FIELDS.join('\`, \`')}\` are never clearable.` },
             selectorParam('scope-read', {}, 'Edit resolves the address winner and refuses same-store physical collisions.'),
             selectorParam('dir'),
             selectorParam('profile'),
@@ -154,6 +158,21 @@ export const editLeaf = defineLeaf({
         setIf('rationale', input['docRationale']);
         applyExtensionChanges(frontmatter, extensionChanges.sets, extensionChanges.unsets);
         for (const field of input['unset'] ?? []) {
+            if (PROTECTED_FIELDS.includes(field)) {
+                throw usage(`--unset ${field}: ${field} is never clearable`, {
+                    memory: doc.name,
+                    next: `Protected fields are ${PROTECTED_FIELDS.join(', ')}.`,
+                });
+            }
+            if (!CLEARABLE_FIELDS.includes(field) && !Object.prototype.hasOwnProperty.call(previous, field)) {
+                const present = Object.keys(previous).filter((key) => !PROTECTED_FIELDS.includes(key));
+                throw usage(`--unset ${field}: ${doc.name} has no \`${field}\` field to unset`, {
+                    memory: doc.name,
+                    next: present.length > 0
+                        ? `Fields ${doc.name} has: ${present.join(', ')}.`
+                        : `${doc.name} carries no field eligible for --unset.`,
+                });
+            }
             delete frontmatter[field];
         }
         // Same invariant `write` raises: a workspace-open entry fires only when

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@north-light/crouter",
-  "version": "0.3.292",
+  "version": "0.3.294",
   "description": "crtr — agent runtime with memory, plugins, and marketplaces",
   "type": "module",
   "main": "dist/index.js",

package/runtime.lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@north-light/crouter",
-  "version": "0.3.292",
+  "version": "0.3.294",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@north-light/crouter",
-      "version": "0.3.292",
+      "version": "0.3.294",
       "hasInstallScript": true,
       "license": "MIT",
       "workspaces": [
@@ -4244,17 +4244,17 @@
     },
     "packages/crouter-api": {
       "name": "@north-light/crouter-api",
-      "version": "0.3.292",
+      "version": "0.3.294",
       "license": "UNLICENSED"
     },
     "packages/crouter-env-docker": {
       "name": "@north-light/crouter-env-docker",
-      "version": "0.3.292",
+      "version": "0.3.294",
       "license": "UNLICENSED"
     },
     "packages/crouter-sdk": {
       "name": "@north-light/crouter-sdk",
-      "version": "0.3.292",
+      "version": "0.3.294",
       "license": "UNLICENSED",
       "dependencies": {
         "@north-light/crouter-api": "*"