@north-light/crouter 0.3.199 → 0.3.200

package/dist/core/__tests__/helpers/harness.js

@@ -28,7 +28,7 @@ import { fileURLToPath } from 'node:url';
 import { createRequire } from 'node:module';
 import { createNode, getNode, recordPid, subscribersOf, subscriptionsOf, } from '../../canvas/canvas.js';
 import { closeDb } from '../../canvas/db.js';
-import { reviveNode } from '../../runtime/revive.js';
+import { spawnChild } from '../../runtime/spawn.js';
 import { superviseTick } from '../../../daemon/crtrd.js';
 import { DaemonFleet } from '../../../daemon/fleet.js';
 import { apiSocketPath } from '../../canvas/paths.js';
@@ -150,11 +150,11 @@ export async function createHarness(opts = {}) {
     const tmpHome = mkdtempSync(join(tmpdir(), 'crtr-harness-HOME-'));
     const session = `${opts.sessionPrefix ?? 'crtr-harness'}-${process.pid}-${Date.now().toString(36)}`;
     // The harness reads/writes the isolated canvas in-process. CRTR_PI_BINARY in
-    // OUR env makes in-process revives (superviseTick → reviveNode → openNodeWindow)
+    // OUR env makes in-process launches (spawnChild and superviseTick → reviveNode)
     // bake the fake-pi into the command string.
     process.env['CRTR_HOME'] = home;
     // HOME must be isolated in THIS process too, not just in the subprocess envs
-    // below: an in-process launch (spawnHeadlessChild's reviveNode, superviseTick
+    // below: an in-process launch (spawnHeadlessChild's spawnChild, superviseTick
     // pass-2 wakes) builds its broker env from process.env, so a real HOME here
     // makes every broker read the developer's OWN ~/.pi/agent — auth.json and the
     // managed subscription pools — instead of agentHome, and provider tests then
@@ -202,7 +202,7 @@ export async function createHarness(opts = {}) {
     resetEventSourceForTests();
     bindDaemonEventSource();
     // The harness also stands in for the daemon's FLEET: every in-harness broker
-    // launch (reviveNode from a test, superviseTick pass-2 wakes) registers its
+    // launch (spawnChild, reviveNode, superviseTick pass-2 wakes) registers its
     // ChildProcess handle here, and real child exits enqueue exit-policy jobs on
     // this serial work lane — the same single-lane discipline crtrd runs, but
     // drainable to a deterministic quiescent point. Reset first for the same
@@ -367,17 +367,9 @@ export async function createHarness(opts = {}) {
     }
     function nodeDirs() {
         try {
-            // Node ids are minted by newNodeId() (runtime/nodes.ts) as
-            // `<install>-<time36>-<rand4hex>` (a72554e3 stamped the canvas-install id
-            // onto the historical 2-segment `<time36>-<rand4hex>` shape, so the id is
-            // opaque and its segment count has already changed once — mirror
-            // profiles/manifest.ts's ID_SHAPE rather than hard-coding a segment
-            // count). Scope the scan to "one or more lowercase-alnum segments ending
-            // in an 8-hex random suffix" so a stray non-node sibling under nodes/ is
-            // never miscounted as a new node dir — e.g. a `reports/` dir created for
-            // an empty node id (the rare CI flake on compiled-seam run 27459304455 that
-            // broke the spawn counters with `expected exactly 1 new node dir, got
-            // [<id>, reports]`), or literal `reports` (no hyphen, no hex suffix).
+            // Node ids end in an 8-hex random suffix and may have any number of
+            // lowercase-alphanumeric prefix segments. Only return those node dirs so
+            // fixture cleanup never treats a non-node sibling as a canvas row.
             return readdirSync(join(home, 'nodes')).filter((d) => /^[a-z0-9]+(?:-[a-z0-9]+)*-[0-9a-f]{8}$/.test(d));
         }
         catch {
@@ -507,46 +499,16 @@ export async function createHarness(opts = {}) {
             return id;
         },
         async spawnHeadlessChild(parentId, task, o = {}) {
-            const before = new Set(nodeDirs());
-            // The synchronous CLI must reach the separate API fixture process, which
-            // creates the row and necessarily starts a fixture-owned broker before
-            // returning. Production has one daemon/fleet; the harness split exists
-            // only because spawnSync blocks this process's event loop. Retire that
-            // fixture launch immediately, then perform the authoritative boot through
-            // THIS process's reviveNode so the harness fleet owns the ChildProcess
-            // handle and its real exit event (§H harness mode a).
-            const args = ['node', 'new', task, '--parent', parentId, '--cwd', CROUTER];
-            if (o.kind)
-                args.push('--kind', o.kind);
-            if (o.mode)
-                args.push('--mode', o.mode);
-            if (o.model)
-                args.push('--model', o.model);
-            const res = cli(parentId, args);
-            if (res.code !== 0) {
-                throw new Error(`spawnHeadlessChild(${parentId}) failed (code ${res.code})\n--stdout--\n${res.stdout}\n--stderr--\n${res.stderr}`);
-            }
-            const added = nodeDirs().filter((d) => !before.has(d));
-            if (added.length !== 1) {
-                throw new Error(`spawnHeadlessChild: expected exactly 1 new node dir, got [${added.join(', ')}]`);
-            }
-            const childId = added[0];
-            closeDb();
-            const fixtureRow = getNode(childId);
-            const fixturePid = fixtureRow?.pi_pid ?? null;
-            const fixtureIdentity = fixtureRow?.pi_pid_identity ?? null;
-            const priorBoots = harness.bootCount(childId);
-            if (fixturePid !== null && fixtureIdentity !== null && recordedPidLiveness(fixturePid, fixtureIdentity) === 'alive') {
-                process.kill(fixturePid, 'SIGTERM');
-                await waitFor(() => recordedPidLiveness(fixturePid, fixtureIdentity) !== 'alive', {
-                    timeoutMs: 10_000,
-                    intervalMs: 25,
-                    label: `API-fixture broker exit for ${childId}`,
-                });
-            }
-            reviveNode(childId, { resume: false });
-            await harness.awaitBoot(childId, { minCount: priorBoots + 1 });
-            return childId;
+            const result = await spawnChild({
+                kind: o.kind ?? 'general',
+                cwd: CROUTER,
+                prompt: task,
+                parent: parentId,
+                ...(o.mode !== undefined ? { mode: o.mode } : {}),
+                ...(o.model !== undefined ? { model: o.model } : {}),
+            });
+            await harness.awaitBoot(result.node.node_id);
+            return result.node.node_id;
         },
         cli,
         async stop(nodeId, reason = 'stop', errorMessage) {

package/dist/core/__tests__/seam/broker-crash-teardown.test.js

@@ -10,11 +10,10 @@
 // lifecycle close` then tears the replacement down (shutdown frame → exit,
 // socket unlinked, status canceled, daemon leaves it).
 //
-// The harness API server is a separate process (so synchronous CLI calls can be
-// served) whose fixture fleet is inert; spawnHeadlessChild retires its fixture
-// broker and reboots the node through THIS process's reviveNode, so every
-// broker below is harness-fleet-owned and every SIGKILL's REAL ChildProcess
-// exit drives policy automatically — no synthetic delivery, no tick, no grace.
+// spawnHeadlessChild calls the production birth path in the harness process, so
+// every broker below is harness-fleet-owned from its first and only boot and
+// every SIGKILL's REAL ChildProcess exit drives policy automatically — no
+// synthetic delivery, no tick, no grace.
 // Each crash has its own real broker setup, so either top-level test remains a
 // complete journey under name filtering and pays only its own first respawn
 // backoff.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@north-light/crouter",
-  "version": "0.3.199",
+  "version": "0.3.200",
   "description": "crtr — agent runtime with memory, plugins, and marketplaces",
   "type": "module",
   "main": "dist/index.js",
@@ -83,7 +83,8 @@
     "prepublishOnly": "npm run build",
     "test": "node --conditions=crtr-src --import tsx/esm --test --test-concurrency=4 --test-timeout=10000 'src/**/__tests__/*.test.ts'",
     "test:serial": "node --conditions=crtr-src --import tsx/esm --test --test-concurrency=1 --test-timeout=60000 'src/**/__tests__/serial/*.test.ts'",
-    "test:seam": "npm run build && node --test --test-concurrency=1 --test-timeout=180000 'dist/**/__tests__/seam/*.test.js'"
+    "test:seam": "npm run build && npm run test:seam:built",
+    "test:seam:built": "node --test --test-concurrency=2 --test-timeout=180000 'dist/**/__tests__/seam/*.test.js'"
   },
   "overrides": {
     "@earendil-works/pi-ai": "0.84.1",

package/runtime.lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@north-light/crouter",
-  "version": "0.3.199",
+  "version": "0.3.200",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@north-light/crouter",
-      "version": "0.3.199",
+      "version": "0.3.200",
       "hasInstallScript": true,
       "license": "MIT",
       "dependencies": {