@north-light/crouter 0.3.172 → 0.3.174

package/dist/clients/attach/__tests__/context-message.test.js

@@ -1,85 +1,19 @@
 // Regression coverage for the attach viewer's display-only folding of
-// crouter-generated context. The body must stay agent-visible and expandable,
-// while bearings, situational updates, fresh-revive kickoffs, runtime steering,
-// recovery prompts, and node inbox digests share one compact renderer by default.
+// crouter-generated context. Two user-visible hazards are pinned here:
+//
+//   1. A folded row must never leak its body, and Ctrl+O must restore the full
+//      agent-visible content — the fold is display-only, so nothing is lost.
+//   2. A human message that merely reads like runtime recovery prose must NOT
+//      be classified as generated context; folding the user's own message away
+//      is the hazard that misclassification produces.
 import assert from 'node:assert/strict';
-import { readFileSync } from 'node:fs';
-import { dirname, join } from 'node:path';
 import test from 'node:test';
-import { fileURLToPath } from 'node:url';
-import { UserMessageComponent } from '@earendil-works/pi-coding-agent';
 import { Container } from '@earendil-works/pi-tui';
-import { applyTheme, attachMarkdownTheme } from '../config.js';
+import { applyTheme } from '../config.js';
 import { ChatView } from '../render/chat-view.js';
-import { ContextMessageComponent } from '../render/context-message.js';
-import { styleAttachMarkdownHeadings } from '../render/markdown-headings.js';
-import { AUTH_FAULT_RECOVERY_BODY, CONNECTION_FAULT_RECOVERY_BODY, CONTEXT_INTRO_CUSTOM_TYPE, CONTEXT_NUDGE_CUSTOM_TYPE, PROVIDER_FAULT_RECOVERY_BODY, REVIVE_KICKOFF_SENTINEL, RUNTIME_RESTART_CONTINUATION, STALL_REPROMPT, formatModelFallbackRecovery, formatPersonaTransition, formatStructuredOutputReprompt, generatedContextExpandedBody, generatedContextPresentation, } from '../../../shared/generated-context.js';
-const HERE = dirname(fileURLToPath(import.meta.url));
-const CHAT_VIEW = readFileSync(join(HERE, '..', 'render/chat-view.ts'), 'utf8');
-const identity = (s) => s;
+import { CONTEXT_INTRO_CUSTOM_TYPE, CONTEXT_NUDGE_CUSTOM_TYPE, REVIVE_KICKOFF_SENTINEL, RUNTIME_RESTART_CONTINUATION, formatModelFallbackRecovery, generatedContextPresentation, } from '../../../shared/generated-context.js';
 applyTheme();
-test('collapsed by default: body text is not rendered until expanded', () => {
-    const body = '<situational-context>\nthe user is mid-checkout\n</situational-context>';
-    const collapsed = new ContextMessageComponent(body, false, identity, identity, 'situational context', ' hint');
-    const collapsedRender = collapsed.render(80);
-    const collapsedLines = collapsedRender.join('\n');
-    assert.equal(collapsedRender.length, 3, 'a collapsed row has one blank line above and below');
-    assert.equal(collapsedRender[0], '');
-    assert.equal(collapsedRender.at(-1), '');
-    assert.match(collapsedLines, /\[situational context\]/);
-    assert.doesNotMatch(collapsedLines, /mid-checkout/, 'collapsed state must never leak the body');
-    collapsed.setExpanded(true);
-    const expandedRender = collapsed.render(80);
-    const expandedLines = expandedRender.join('\n');
-    assert.match(expandedLines, /mid-checkout/, 'expanded state (Ctrl+O) still shows the full body — the LLM-visible content is never lost, only the default view folds it');
-    const normalUserRender = new UserMessageComponent(styleAttachMarkdownHeadings(body), attachMarkdownTheme()).render(80);
-    assert.deepEqual(expandedRender.slice(0, -1), normalUserRender, 'expanded generated context uses the ordinary user-message surface');
-    assert.equal(expandedRender.at(-1), '', 'an expanded block leaves one blank line below its body');
-});
-test('generated rows have a leading spacer after prior transcript content', async () => {
-    const container = new Container();
-    const tui = { requestRender() { }, terminal: { rows: 40 } };
-    const view = new ChatView(tui, container, { toolOutputExpanded: false });
-    await view.applySnapshot({
-        messages: [
-            { role: 'assistant', content: [{ type: 'text', text: 'before' }], stopReason: 'stop' },
-            { role: 'user', content: `${REVIVE_KICKOFF_SENTINEL} — full disk bearings` },
-        ],
-        stats: {},
-        state: { isStreaming: false },
-    });
-    const lines = container.render(80).map((line) => line.replace(/\x1b\[[0-9;]*m/g, ''));
-    const generatedIndex = lines.findIndex((line) => line.includes('[crtr revive]'));
-    assert.notEqual(generatedIndex, -1);
-    assert.equal(lines[generatedIndex - 1], '', 'the collapsed row has one blank line above it');
-    assert.equal(lines[generatedIndex + 1], '', 'the collapsed row has one blank line below it');
-});
-test('adjacent padded transcript blocks share one blank boundary row', async () => {
-    const container = new Container();
-    const tui = { requestRender() { }, terminal: { rows: 40 } };
-    const view = new ChatView(tui, container, { toolOutputExpanded: false });
-    await view.applySnapshot({
-        messages: [
-            { role: 'assistant', content: [{ type: 'text', text: 'before' }], stopReason: 'stop' },
-            {
-                role: 'custom',
-                customType: CONTEXT_INTRO_CUSTOM_TYPE,
-                display: true,
-                content: 'bearings body',
-            },
-            { role: 'user', content: `${REVIVE_KICKOFF_SENTINEL} — full disk bearings` },
-        ],
-        stats: {},
-        state: { isStreaming: false },
-    });
-    const lines = container.render(80).map((line) => line.replace(/\x1b\[[0-9;]*m/g, ''));
-    const bearingsIndex = lines.findIndex((line) => line.includes('[crtr context]'));
-    const reviveIndex = lines.findIndex((line) => line.includes('[crtr revive]'));
-    assert.notEqual(bearingsIndex, -1);
-    assert.equal(reviveIndex, bearingsIndex + 2, 'the two padded blocks share exactly one blank row');
-    assert.equal(lines[bearingsIndex + 1], '');
-});
-test('Ctrl+O expands context, revive, and inbox details without unfolding continuations', async () => {
+test('collapsed generated context never leaks its body; Ctrl+O restores it', async () => {
     const container = new Container();
     const tui = { requestRender() { }, terminal: { rows: 40 } };
     const view = new ChatView(tui, container, { toolOutputExpanded: false });
@@ -120,103 +54,11 @@ test('Ctrl+O expands context, revive, and inbox details without unfolding contin
     assert.equal(internals.toolOutputExpanded, false);
     assert.doesNotMatch(container.render(80).join('\n'), /loaded INDEX\.md content|resume from this note|runtime-restart-continuation|private context reminder|private inbox detail/);
 });
-test('the crtr-context label/hint keep their defaults when callers omit the new params', () => {
-    const bearings = new ContextMessageComponent('some bearings body', false, identity, identity);
-    const line = bearings.render(80).join('\n');
-    assert.match(line, /\[crtr context\]/);
-    assert.match(line, /orienting bearings/);
-});
-test('expanded crtr context and revive cards disclose memory and the yield note only', () => {
-    const contextBody = [
-        '<crtr-bearings>',
-        'node and project details that stay folded',
-        '</crtr-bearings>',
-        '<memory kind="knowledge">',
-        'memory catalog that stays folded',
-        '</memory>',
-        '<auto-loaded-context>',
-        '<memory kind="knowledge" name="project">',
-        'loaded INDEX.md content',
-        '</memory>',
-        '</auto-loaded-context>',
-        '<project_context>',
-        'environment details that stay folded',
-        '</project_context>',
-    ].join('\n');
-    const context = generatedContextPresentation({
-        role: 'custom',
-        customType: CONTEXT_INTRO_CUSTOM_TYPE,
-        content: contextBody,
-    });
-    assert.equal(generatedContextExpandedBody(context), '<memory kind="knowledge" name="project">\nloaded INDEX.md content\n</memory>');
-    const reviveBody = [
-        `${REVIVE_KICKOFF_SENTINEL} — full disk bearings`,
-        '<roadmap>roadmap details that stay folded</roadmap>',
-        '<yield-message>',
-        'Resume the migration from the recorded checkpoint.',
-        '</yield-message>',
-        '<context-dir>context listing that stays folded</context-dir>',
-    ].join('\n');
-    const revive = generatedContextPresentation({ role: 'user', content: reviveBody });
-    assert.equal(generatedContextExpandedBody(revive), 'Resume the migration from the recorded checkpoint.');
-    const noYield = generatedContextPresentation({
-        role: 'user',
-        content: `${REVIVE_KICKOFF_SENTINEL}\n<yield-message/>`,
-    });
-    assert.equal(generatedContextExpandedBody(noYield), '');
-});
-test('fresh-revive kickoff and both context-nudge roles classify as generated context', () => {
-    const revive = generatedContextPresentation({
-        role: 'user',
-        content: `${REVIVE_KICKOFF_SENTINEL} — full disk bearings`,
-    });
-    assert.equal(revive?.label, 'crtr revive');
-    assert.equal(revive?.summary, 'fresh context kickoff');
-    const body = '[crtr] Context ~150k. Yield when substantial work remains.';
-    const steered = generatedContextPresentation({ role: 'user', content: body });
-    const held = generatedContextPresentation({
-        role: 'custom',
-        customType: CONTEXT_NUDGE_CUSTOM_TYPE,
-        content: body,
-    });
-    assert.equal(steered?.summary, 'Context ~150k');
-    assert.equal(held?.summary, 'Context ~150k');
-    const inbox = generatedContextPresentation({
-        role: 'user',
-        content: 'From child-node-123 — 2 updates:\n  [update] still working',
-    });
-    assert.equal(inbox?.label, 'crtr inbox');
-    assert.equal(inbox?.summary, '2 updates from child-node-123');
-});
-test('runtime steering and recovery prompts classify without hiding their full bodies', () => {
-    const personaBody = formatPersonaTransition('You are now an orchestrator.');
-    const persona = generatedContextPresentation({ role: 'user', content: personaBody });
-    assert.equal(persona?.kind, 'persona-transition');
-    assert.equal(persona?.body, personaBody);
-    const structuredBody = formatStructuredOutputReprompt(JSON.stringify({ type: 'object' }, null, 2));
-    assert.equal(generatedContextPresentation({ role: 'user', content: STALL_REPROMPT })?.summary, 'completion required');
-    assert.equal(generatedContextPresentation({ role: 'user', content: structuredBody })?.summary, 'structured output required');
-    const recoveries = [
-        [AUTH_FAULT_RECOVERY_BODY, 'provider credentials updated'],
-        [CONNECTION_FAULT_RECOVERY_BODY, 'network connection restored'],
-        [PROVIDER_FAULT_RECOVERY_BODY, 'provider retry'],
-        [formatModelFallbackRecovery('old/model', 'new/model:high', 'credential'), 'model route changed'],
-        [formatModelFallbackRecovery('custom(provider)/model', 'new/model:high', 'not-found'), 'model route changed'],
-        [RUNTIME_RESTART_CONTINUATION, 'continuing from where it left off'],
-    ];
-    for (const [body, summary] of recoveries) {
-        const presentation = generatedContextPresentation({ role: 'user', content: body });
-        assert.equal(presentation?.kind, 'recovery');
-        assert.equal(presentation?.label, 'crouter continuation');
-        assert.equal(presentation?.summary, summary);
-        assert.equal(presentation?.body, body);
-    }
+test('a human message that reads like runtime recovery is not folded as generated context', () => {
     assert.equal(generatedContextPresentation({ role: 'user', content: 'continue' }), null, 'a human one-word continue is not mistaken for runtime recovery');
-    const unmarkedModelRecovery = formatModelFallbackRecovery('custom(provider)/model', 'new/model:high', 'not-found').split('\n').slice(1, -1).join('\n');
-    assert.equal(generatedContextPresentation({ role: 'user', content: unmarkedModelRecovery }), null, 'a human message matching the recovery prose lacks the producer marker');
-});
-test('render/chat-view.ts routes the shared generated-context classification through the foldable component', () => {
-    assert.match(CHAT_VIEW, /generatedContextPresentation\(message\)/);
-    assert.match(CHAT_VIEW, /generatedContextExpandedBody\(generated\)/);
-    assert.match(CHAT_VIEW, /new ContextMessageComponent\(/);
+    // The producer marker, not the prose, is what classifies a message. Strip the
+    // marker lines off a real recovery body and it must read as a human message.
+    const marked = formatModelFallbackRecovery('custom(provider)/model', 'new/model:high', 'not-found');
+    assert.equal(generatedContextPresentation({ role: 'user', content: marked })?.kind, 'recovery');
+    assert.equal(generatedContextPresentation({ role: 'user', content: marked.split('\n').slice(1, -1).join('\n') }), null, 'a human message matching the recovery prose lacks the producer marker');
 });