@norskvideo/ctl-test-harness 0.1.23 → 0.1.24

package/compose-advancing.d.ts

@@ -4,6 +4,11 @@ export declare const DEFAULT_COMPOSE_NODE = "video_compose";
 export declare function maxNodeMediaIn(summary: unknown, node: string): number;
 export interface ComposeSample {
     frames: number;
+    /** Root workflows the visualiser listed — 0 while nothing is deployed. */
+    roots: number;
+    /** Whether any root workflow's summary carried a node of that name — a
+     *  flat 0 with the node absent is a different failure from a stalled one. */
+    nodeSeen: boolean;
     /** Why the sample is 0 when it is: the visualiser was unreachable, and how. */
     error?: string;
 }
@@ -25,6 +30,9 @@ export interface ComposeAdvancingResult {
     before: number;
     after: number;
     node: string;
+    /** From the second sample: root workflows listed, and whether the node was in any. */
+    roots: number;
+    nodeSeen: boolean;
     /** Set when a sample could not read the visualiser at all. */
     error?: string;
 }

package/compose-advancing.js

@@ -24,6 +24,10 @@ export function maxNodeMediaIn(summary, node) {
     }
     return max;
 }
+function hasNode(summary, node) {
+    const nodes = summary?.nodes;
+    return Array.isArray(nodes) && nodes.some((n) => n?.name === node);
+}
 async function getJson(fetch, url) {
     const r = await fetch(url, { signal: AbortSignal.timeout(5000) });
     if (!r.ok)
@@ -44,16 +48,24 @@ export async function composeSample(opts) {
     try {
         const wf = (await getJson(opts.fetch, `${opts.base}/workflow`));
         let max = 0;
+        let roots = 0;
+        let nodeSeen = false;
         for (const root of wf?.rootWorkflows ?? []) {
-            if (typeof root?.wfid !== "string")
+            // The engine numbers its workflows (`wfid: 3339`); a string-only check
+            // here skipped every root and the gate read a silent 0 -> 0 everywhere.
+            const wfid = root?.wfid;
+            if (typeof wfid !== "string" && typeof wfid !== "number")
                 continue;
-            const summary = await getJson(opts.fetch, `${opts.base}/workflow/${encodeURIComponent(root.wfid)}/summary`);
+            roots += 1;
+            const summary = await getJson(opts.fetch, `${opts.base}/workflow/${encodeURIComponent(String(wfid))}/summary`);
+            if (hasNode(summary, node))
+                nodeSeen = true;
             max = Math.max(max, maxNodeMediaIn(summary, node));
         }
-        return { frames: max };
+        return { frames: max, roots, nodeSeen };
     }
     catch (e) {
-        return { frames: 0, error: e instanceof Error ? e.message : String(e) };
+        return { frames: 0, roots: 0, nodeSeen: false, error: e instanceof Error ? e.message : String(e) };
     }
 }
 export async function composeFrames(opts) {
@@ -72,6 +84,8 @@ export async function composeAdvancing(opts) {
         before: before.frames,
         after: after.frames,
         node,
+        roots: after.roots,
+        nodeSeen: after.nodeSeen,
         ...(error !== undefined ? { error } : {}),
     };
 }

package/demo/gates.js

@@ -50,8 +50,17 @@ export function composeAdvancingGate(opts = {}) {
             });
             if (r.error)
                 ctx.log(`visualiser unreachable at ${base}: ${r.error}`);
-            else if (!r.advancing)
-                ctx.log(`${node} not advancing yet (${r.before} -> ${r.after})`);
+            else if (!r.advancing) {
+                // A flat 0 has three causes worth telling apart before anyone reads
+                // engine logs: nothing deployed yet, a graph without that node, or a
+                // stalled feed into a node that is there.
+                const why = r.roots === 0
+                    ? "; no root workflows deployed yet"
+                    : r.nodeSeen
+                        ? ""
+                        : `; no node named ${node} in ${r.roots} root workflow(s)`;
+                ctx.log(`${node} not advancing yet (${r.before} -> ${r.after}${why})`);
+            }
             return r.advancing;
         },
     };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@norskvideo/ctl-test-harness",
-  "version": "0.1.23",
+  "version": "0.1.24",
   "type": "module",
   "exports": {
     ".": {