@norskvideo/ctl-dev-kit 0.1.90 → 0.1.92

package/conventions/smoke.yml

@@ -263,6 +263,12 @@ jobs:
         env:
           NORSK_CTL_BINARY: ${{ runner.temp }}/norsk-ctl
           NORSK_LICENSE_FILE: ${{ runner.temp }}/norsk-license.json
+          # Where the harness copies each instance's full engine logs
+          # (/var/log/norsk -> debug.json, host-mounted under the store) before
+          # teardown nukes them. Uploaded below. `docker logs` only sees the
+          # notice+ stdout subset and a decode-error flood can drown its tail;
+          # this is the complete structured log at every level.
+          NORSK_CI_LOG_DIR: ${{ runner.temp }}/norsk-logs
         run: |
           # Outer pipefail so the step reports the journey's exit, not tee's --
           # otherwise a failed smoke run over the `| tee` below scores green.
@@ -299,6 +305,20 @@ jobs:
           path: ${{ runner.temp }}/smoke.log
           retention-days: 7
 
+      # The FULL structured engine logs (debug.json et al.), copied off the
+      # host store by the harness before teardown -- the actual place a
+      # media-node death is recorded, which `docker logs` and its stdout flood
+      # cannot show. if-no-files-found: ignore so a green run that wrote nothing
+      # here (or a launch that never reached teardown) does not fail the step.
+      - name: Upload Norsk engine logs
+        if: always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: norsk-engine-logs-attempt-${{ github.run_attempt }}
+          path: ${{ runner.temp }}/norsk-logs
+          retention-days: 7
+          if-no-files-found: ignore
+
   # Report this pipeline's result to the aggregated product CI dashboard
   # (id3as/ci-workflows). !cancelled() so a real pass/fail reports, but a
   # cancelled/superseded run does NOT — a cancellation dispatched as failure

package/conventions/workflow-shell.ts

@@ -4,9 +4,18 @@
 // question answered first — is this line inside a quoted block or not — so it is
 // asked in one place.
 
-/** 1-indexed line numbers inside a multi-line `bash -c '` block, which ends at a
- *  line that is just `'`. A one-liner closing its own quote (`bash -c 'a; b'`)
- *  opens no block — it is already balanced. */
+/** 1-indexed line numbers inside a multi-line `bash -c '` block, which ends at
+ *  the first line whose leading character is the closing `'`. A one-liner
+ *  closing its own quote (`bash -c 'a; b'`) opens no block — it is already
+ *  balanced.
+ *
+ *  The close is not always the whole line: smoke.yml ends its block with
+ *  `' 2>&1 | tee "$RUNNER_TEMP/smoke.log"`, piping the invocation into a log.
+ *  Requiring the line to be exactly `'` left the block open to end of file, so
+ *  every apostrophe below it was reported as unquoted shell — comments, and an
+ *  `if:` expression that is not shell at all. Inside a single-quoted word a
+ *  leading apostrophe can only be the close, so what follows it on that line is
+ *  outside the block and none of this guard's business. */
 export function bashBlockLines(yaml: string): Set<number> {
   const OPEN = "bash -c '";
   const inside = new Set<number>();
@@ -17,7 +26,7 @@ export function bashBlockLines(yaml: string): Set<number> {
       if (at >= 0 && !text.slice(at + OPEN.length).includes("'")) open = true;
       return;
     }
-    if (text.trim() === "'") {
+    if (text.trim().startsWith("'")) {
       open = false;
       return;
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@norskvideo/ctl-dev-kit",
-  "version": "0.1.90",
+  "version": "0.1.92",
   "type": "module",
   "exports": {
     "./create-product": "./create-product/create-product.ts",