@norskvideo/ctl-commands 0.1.13 → 0.1.14

package/commands.d.ts

@@ -45,6 +45,11 @@ export interface ProxyLogsOpts {
 }
 export interface SourceStartOpts {
     port?: number;
+    service?: string;
+    streamId?: string;
+    name?: string;
+    mediaFile?: string;
+    generate?: "bars" | "testsrc";
 }
 export interface StatsOpts {
     output?: "table" | "yaml" | "json";
@@ -298,10 +303,10 @@ export declare const commands: {
         readonly kind: "serve";
     }>;
     readonly source: {
-        readonly start: LeafCmd<(instanceId: string, preset: string, opts?: SourceStartOpts) => {
+        readonly start: LeafCmd<(instanceId: string, preset: string | undefined, opts?: SourceStartOpts) => {
             readonly kind: "source.start";
             readonly instanceId: string;
-            readonly preset: string;
+            readonly preset: string | undefined;
             readonly opts: SourceStartOpts;
         }>;
         readonly stop: LeafCmd<(instanceId: string, name: string) => {

package/commands.js

@@ -25,8 +25,14 @@ function leaf(kind, fn, ...positionals) {
     // segments, and it differs exactly by camelCase — the same transform the
     // flag renderer applies.
     const path = kind.split(".").map(camelToKebab);
-    const sig = [path[path.length - 1], ...positionals.map((p) => `<${String(p)}>`)].join(" ");
-    specs.set(kind, { kind, path, positionals: positionals.map(String) });
+    const sig = [
+        path[path.length - 1],
+        ...positionals.map((p) => {
+            const raw = String(p);
+            return raw.endsWith("?") ? `[${raw.slice(0, -1)}]` : `<${raw}>`;
+        }),
+    ].join(" ");
+    specs.set(kind, { kind, path, positionals: positionals.map((p) => String(p).replace(/\?$/, "")) });
     return Object.assign(fn, { __sig: sig });
 }
 /** Runtime source for the `get` vocabulary — the CLI's yargs `choices` and
@@ -95,7 +101,11 @@ export const commands = {
     mcp: leaf("mcp", () => ({ kind: "mcp" })),
     serve: leaf("serve", () => ({ kind: "serve" })),
     source: {
-        start: leaf("source.start", (instanceId, preset, opts = {}) => ({ kind: "source.start", instanceId, preset, opts }), "instanceId", "preset"),
+        start: leaf("source.start", 
+        // The asset may instead be named by flag (--media-file / --generate), so
+        // the preset positional is optional; the daemon refuses a request that
+        // names none or more than one.
+        (instanceId, preset, opts = {}) => ({ kind: "source.start", instanceId, preset, opts }), "instanceId", "preset?"),
         stop: leaf("source.stop", (instanceId, name) => ({ kind: "source.stop", instanceId, name }), "instanceId", "name"),
         list: leaf("source.list", () => ({ kind: "source.list" })),
         presets: leaf("source.presets", () => ({ kind: "source.presets" })),

package/format.js

@@ -32,11 +32,14 @@ export function toArgv(cmd) {
     if (!spec)
         throw new Error(`toArgv: '${cmd.kind}' is not a declared command kind`);
     const fields = cmd;
-    return [
-        ...spec.path,
-        ...spec.positionals.map((name) => String(fields[name])),
-        ...formatOpts(fields.opts),
-    ];
+    // An omitted optional positional leaves no gap: trailing undefined slots are
+    // dropped rather than rendered, which would put the literal "undefined" where
+    // the shell expects a value. Only trailing ones — dropping a middle slot
+    // would silently shift every positional after it.
+    const positionals = spec.positionals.map((name) => fields[name]);
+    while (positionals.length > 0 && positionals[positionals.length - 1] === undefined)
+        positionals.pop();
+    return [...spec.path, ...positionals.map(String), ...formatOpts(fields.opts)];
 }
 export function commandToString(cmd) {
     return ["norsk-ctl", ...toArgv(cmd)].join(" ");

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@norskvideo/ctl-commands",
-  "version": "0.1.13",
+  "version": "0.1.14",
   "type": "module",
   "exports": {
     ".": {