@nordicsemiconductor/pc-nrfconnect-shared 86.0.0 → 88.0.0

package/Changelog.md

@@ -7,6 +7,23 @@ This project does _not_ adhere to
 [Semantic Versioning](https://semver.org/spec/v2.0.0.html) but contrary to it
 every new version is a new major version.
 
+## 88 - 2023-08-17
+
+### Changed
+
+-   `html` package json property has been moved to `nrfConnectForDesktop.html`.
+-   `nrfConnectForDesktop.html` is now opt-in and apps can be built without it.
+
+### Steps to upgrade
+
+-   Change `html` to `nrfConnectForDesktop.html` in the app package json.
+
+## 87 - 2023-08-14
+
+### Fixed
+
+-   Spinner in `Dialog` components was not inlined.
+
 ## 86 - 2023-08-14
 
 ### Changed
@@ -41,9 +58,10 @@ every new version is a new major version.
 
 ### Steps to upgrade when using this package
 
--   Add an `index`-property to package.json. The following example will use the
-    index bundled with shared that works with our apps, but apps can also make
-    their own instead if needed.
+-   Following this step will make the app incompatible with the currently
+    released launcher (v4.1.2): Add an `index`-property to package.json. The
+    following example will use the index bundled with shared that works with our
+    apps, but apps can also make their own instead if needed.
 
 ```json
 {

package/coverage/cobertura-coverage.xml

@@ -1,6 +1,6 @@
 <?xml version="1.0" ?>
 <!DOCTYPE coverage SYSTEM "http://cobertura.sourceforge.net/xml/coverage-04.dtd">
-<coverage lines-valid="2531" lines-covered="1575" line-rate="0.6222" branches-valid="1086" branches-covered="392" branch-rate="0.36090000000000005" timestamp="1692020770089" complexity="0" version="0.1">
+<coverage lines-valid="2531" lines-covered="1575" line-rate="0.6222" branches-valid="1088" branches-covered="392" branch-rate="0.3602" timestamp="1692256971404" complexity="0" version="0.1">
   <sources>
     <source>/home/vsts/work/1/s</source>
   </sources>
@@ -5851,7 +5851,7 @@
         </class>
       </classes>
     </package>
-    <package name="src.utils" line-rate="0.6377" branch-rate="0.2134">
+    <package name="src.utils" line-rate="0.6377" branch-rate="0.2087">
       <classes>
         <class name="appDirs.ts" filename="src/utils/appDirs.ts" line-rate="0.4" branch-rate="0">
           <methods>
@@ -5886,7 +5886,7 @@
             <line number="8" hits="13" branch="false"/>
             <line number="10" hits="13" branch="false"/>
             <line number="12" hits="13" branch="false"/>
-            <line number="20" hits="0" branch="true" condition-coverage="0% (0/8)"/>
+            <line number="20" hits="0" branch="true" condition-coverage="0% (0/10)"/>
             <line number="21" hits="0" branch="false"/>
             <line number="31" hits="0" branch="false"/>
             <line number="40" hits="0" branch="false"/>
@@ -6550,22 +6550,22 @@
           <methods>
             <method name="(anonymous_4)" hits="39" signature="()V">
               <lines>
-                <line number="14" hits="39"/>
+                <line number="16" hits="39"/>
               </lines>
             </method>
             <method name="(anonymous_7)" hits="0" signature="()V">
               <lines>
-                <line number="31" hits="0"/>
+                <line number="33" hits="0"/>
               </lines>
             </method>
             <method name="(anonymous_8)" hits="0" signature="()V">
               <lines>
-                <line number="32" hits="0"/>
+                <line number="34" hits="0"/>
               </lines>
             </method>
             <method name="(anonymous_9)" hits="39" signature="()V">
               <lines>
-                <line number="35" hits="39"/>
+                <line number="37" hits="39"/>
               </lines>
             </method>
           </methods>
@@ -6574,16 +6574,16 @@
             <line number="8" hits="9" branch="false"/>
             <line number="9" hits="9" branch="false"/>
             <line number="12" hits="9" branch="false"/>
-            <line number="14" hits="9" branch="false"/>
-            <line number="15" hits="39" branch="false"/>
-            <line number="16" hits="39" branch="false"/>
+            <line number="16" hits="9" branch="false"/>
+            <line number="17" hits="39" branch="false"/>
             <line number="18" hits="39" branch="false"/>
-            <line number="30" hits="0" branch="false"/>
-            <line number="31" hits="9" branch="false"/>
-            <line number="32" hits="0" branch="true" condition-coverage="0% (0/1)"/>
-            <line number="33" hits="0" branch="false"/>
-            <line number="35" hits="39" branch="false"/>
-            <line number="39" hits="39" branch="false"/>
+            <line number="20" hits="39" branch="false"/>
+            <line number="32" hits="0" branch="false"/>
+            <line number="33" hits="9" branch="false"/>
+            <line number="34" hits="0" branch="true" condition-coverage="0% (0/1)"/>
+            <line number="35" hits="0" branch="false"/>
+            <line number="37" hits="39" branch="false"/>
+            <line number="41" hits="39" branch="false"/>
           </lines>
         </class>
       </classes>

package/ipc/MetaFiles.ts

@@ -61,5 +61,7 @@ export interface PackageJson {
         url: UrlString;
     };
     scripts?: ObjectContainingOptionalStrings;
-    html?: string;
+    nrfConnectForDesktop?: {
+        html?: string;
+    };
 }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@nordicsemiconductor/pc-nrfconnect-shared",
-    "version": "86.0.0",
+    "version": "88.0.0",
     "description": "Shared commodities for developing pc-nrfconnect-* packages",
     "repository": {
         "type": "git",

package/scripts/check-app-properties.ts

@@ -68,7 +68,6 @@ const checkMandatoryProperties = (packageJson: PackageJson) => {
         `description`,
         `displayName`,
         `engines.nrfconnect`,
-        `html`,
     ];
 
     const missingProperties = mandatoryProperties.filter(
@@ -86,6 +85,12 @@ const checkOptionalProperties = (packageJson: PackageJson) => {
         warn('Please provide a property `homepage` in package.json.');
     }
 
+    if (propertyIsMissing(packageJson)('nrfConnectForDesktop')) {
+        warn(
+            'Please provide a property `nrfConnectForDesktop.html` in package.json'
+        );
+    }
+
     if (propertyIsMissing(packageJson)('repository.url')) {
         warn('Please provide a property `repository.url` in package.json.');
     } else if (existsSync('./.git')) {

package/scripts/esbuild-renderer.js

@@ -27,7 +27,7 @@ const tailwindConfig = () =>
           );
 
 function options(additionalOptions) {
-    const { dependencies } = JSON.parse(
+    const { dependencies, nrfConnectForDesktop } = JSON.parse(
         fs.readFileSync('package.json', 'utf8')
     );
 
@@ -37,8 +37,10 @@ function options(additionalOptions) {
             : undefined;
     const outdir = outfile ? undefined : './dist';
 
+    const appHasOwnHtml = nrfConnectForDesktop?.html !== undefined;
+
     return {
-        format: 'iife',
+        format: appHasOwnHtml ? 'iife' : 'cjs',
         outfile,
         outdir,
         target: 'chrome89',
@@ -55,6 +57,7 @@ function options(additionalOptions) {
             'serialport',
             '@electron/remote',
             '@nordicsemiconductor/nrf-device-lib-js',
+            ...(appHasOwnHtml ? [] : ['react']),
 
             // App dependencies
             ...Object.keys(dependencies ?? {}),