@nordicsemiconductor/pc-nrfconnect-shared 245.0.0 → 247.0.0

package/dist/typings/scripts/check-app-properties.d.ts

@@ -1,4 +1,5 @@
 #!/usr/bin/env tsx
+export declare const sameRepoURLs: (url1: string, url2: string) => boolean;
 declare const runChecks: ({ checkChangelogHasCurrentEntry, }: {
     checkChangelogHasCurrentEntry: boolean;
 }) => void;

package/dist/typings/scripts/check-app-properties.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"check-app-properties.d.ts","sourceRoot":"","sources":["../../../scripts/check-app-properties.ts"],"names":[],"mappings":";AAkLA,QAAA,MAAM,SAAS,GAAI,oCAEhB;IACC,6BAA6B,EAAE,OAAO,CAAC;CAC1C,SAKA,CAAC;AAOF,eAAe,SAAS,CAAC"}
+{"version":3,"file":"check-app-properties.d.ts","sourceRoot":"","sources":["../../../scripts/check-app-properties.ts"],"names":[],"mappings":";AAmEA,eAAO,MAAM,YAAY,GAAI,MAAM,MAAM,EAAE,MAAM,MAAM,YAUtD,CAAC;AAuGF,QAAA,MAAM,SAAS,GAAI,oCAEhB;IACC,6BAA6B,EAAE,OAAO,CAAC;CAC1C,SAKA,CAAC;AAOF,eAAe,SAAS,CAAC"}

package/dist/typings/scripts/check-app-properties.test.d.ts

@@ -0,0 +1,2 @@
+export {};
+//# sourceMappingURL=check-app-properties.test.d.ts.map

package/dist/typings/scripts/check-app-properties.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"check-app-properties.test.d.ts","sourceRoot":"","sources":["../../../scripts/check-app-properties.test.ts"],"names":[],"mappings":""}

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@nordicsemiconductor/pc-nrfconnect-shared",
-    "version": "245.0.0",
+    "version": "247.0.0",
     "description": "Shared commodities for developing pc-nrfconnect-* packages",
     "repository": {
         "type": "git",

package/release_notes.md

@@ -1,36 +1,3 @@
-### Added
-
-- Added proto-slot components `Card.Header`, `Card.Header.Title`, `Card.Body`.
-- Added support for `className` and `ref` on `Card` and its proto-slot
-  components.
-- Added support for `cardTitleClassName` and `cardSubtitleClassName` on
-  `Card.Header.Title`
-- nRF54LS05 to the list of the known devices.
-
 ### Changed
 
-- Upgraded `tailwind` to `3.4.14` to allow for use of min/max width and min/max
-  height with usual spacing units instead of screen sizes.
-- Refactored `Card` component to remove dependency on bootstrap and to allow for
-  more flexibility.
-
-### Steps to upgrade when using this package
-
-#### Migrating the `Card` component
-
-The `title` and `titleButton` are no longer available on `Card`, and the overall
-structure of `Card` changed. Follow this format:
-
-```tsx
-import { Card } from '@nordicsemiconductor/pc-nrfconnect-shared';
-
-<Card>
-  <Card.Header className="tw-flex tw-flex-row tw-justify-between">
-    <Card.Header.Title cardTitle="your title here" />
-    { /* your button here */ }
-  </Card.Header>
-  <Card.Body>
-    { /* your card content here */ }
-  </Card.Body>
-</Card>
-```
+- In the repo URL check, ignore the hostname for ssh git URLs.

package/scripts/check-app-properties.test.ts

@@ -0,0 +1,60 @@
+/*
+ * Copyright (c) 2026 Nordic Semiconductor ASA
+ *
+ * SPDX-License-Identifier: LicenseRef-Nordic-4-Clause
+ */
+
+import { sameRepoURLs } from './check-app-properties';
+
+describe('sameRepoURLs', () => {
+    it('accepts equal URLs', () => {
+        expect(
+            sameRepoURLs(
+                'https://github.com/nordicsemi/pc-nrfconnect-ppk',
+                'https://github.com/nordicsemi/pc-nrfconnect-ppk',
+            ),
+        ).toBe(true);
+    });
+
+    it('rejects different URLs', () => {
+        expect(
+            sameRepoURLs(
+                'https://github.com/nordicsemi/pc-nrfconnect-ppk',
+                'https://github.com/nordicsemi/pc-nrfconnect-shared',
+            ),
+        ).toBe(false);
+    });
+
+    it('ignores a .git postfix on either URL', () => {
+        expect(
+            sameRepoURLs(
+                'https://github.com/nordicsemi/pc-nrfconnect-ppk.git',
+                'https://github.com/nordicsemi/pc-nrfconnect-ppk',
+            ),
+        ).toBe(true);
+        expect(
+            sameRepoURLs(
+                'https://github.com/nordicsemi/pc-nrfconnect-ppk',
+                'https://github.com/nordicsemi/pc-nrfconnect-ppk.git',
+            ),
+        ).toBe(true);
+    });
+
+    it('treats the protocol https and git as the same', () => {
+        expect(
+            sameRepoURLs(
+                'https://github.com/nordicsemi/pc-nrfconnect-ppk',
+                'git@github.com:nordicsemi/pc-nrfconnect-ppk.git',
+            ),
+        ).toBe(true);
+    });
+
+    it('ignores the host name for the git protocol', () => {
+        expect(
+            sameRepoURLs(
+                'https://github.com/nordicsemi/pc-nrfconnect-ppk',
+                'git@nordic-git:nordicsemi/pc-nrfconnect-ppk.git',
+            ),
+        ).toBe(true);
+    });
+});

package/scripts/check-app-properties.ts

@@ -65,6 +65,18 @@ const mustContainOneOf = (
     }
 };
 
+export const sameRepoURLs = (url1: string, url2: string) => {
+    const withoutPostfix = (gitUrl: string) => gitUrl.replace(/\.git$/, '');
+
+    const withoutProtocol = (gitUrl: string) =>
+        gitUrl.replace(/^git@[^:]+:/, 'github.com/').replace(/^https:\/\//, '');
+
+    const stripped = (gitUrl: string) =>
+        withoutProtocol(withoutPostfix(gitUrl));
+
+    return stripped(url1) === stripped(url2);
+};
+
 const checkRepoUrl = (packageJson: PackageJsonApp) => {
     if (!existsSync('./.git')) {
         return;
@@ -75,17 +87,7 @@ const checkRepoUrl = (packageJson: PackageJsonApp) => {
     }).trimEnd();
     const declaredGitUrl = packageJson.repository?.url;
 
-    const withoutPostfix = (gitUrl?: string) => gitUrl?.replace(/\.git$/, '');
-
-    const withoutProtocol = (gitUrl?: string) =>
-        gitUrl
-            ?.replace(/^git@github\.com:/, 'github.com/')
-            .replace(/^https:\/\//, '');
-
-    const stripped = (gitUrl?: string) =>
-        withoutProtocol(withoutPostfix(gitUrl));
-
-    if (stripped(realGitUrl) !== stripped(declaredGitUrl)) {
+    if (declaredGitUrl == null || !sameRepoURLs(realGitUrl, declaredGitUrl)) {
         fail(
             `package.json says the repository is located at \`${declaredGitUrl}\` but \`git remote get-url origin\` says it is at \`${realGitUrl}\`.`,
         );

package/src/Card/Card.tsx

@@ -60,7 +60,7 @@ interface CardHeaderComponent extends React.FC<CardHeaderProps> {
 const CardHeader: CardHeaderComponent = ({ children, className, ...attrs }) => (
     <header
         className={classNames(
-            `tw-border-b tw-border-solid tw-border-b-black tw-border-opacity-10 tw-py-4`,
+            `tw-border-b tw-border-solid tw-border-b-black tw-border-opacity-10 tw-pb-3 tw-pt-5`,
             className,
         )}
         {...attrs}
@@ -98,7 +98,7 @@ interface CardComponent extends React.FC<CardProps> {
 const Card: CardComponent = ({ children, className, ...attrs }) => (
     <article
         className={classNames(
-            `tw-preflight tw-relative tw-flex tw-flex-col tw-gap-4 tw-break-words tw-border tw-border-solid tw-border-black tw-border-opacity-10 tw-bg-white tw-px-4 tw-pb-4`,
+            `tw-preflight tw-relative tw-flex tw-flex-col tw-gap-3.5 tw-break-words tw-border tw-border-solid tw-border-black tw-border-opacity-10 tw-bg-white tw-px-4 tw-pb-4`,
             className,
         )}
         {...attrs}