@nordicsemiconductor/pc-nrfconnect-shared 169.0.0 → 170.0.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (4) hide show
  1. package/Changelog.md +10 -0
  2. package/package.json +1 -1
  3. package/src/About/Feedback.tsx +11 -13
  4. package/typings/generated/src/About/Feedback.d.ts.map +1 -1
package/Changelog.md CHANGED
@@ -7,6 +7,16 @@ This project does _not_ adhere to
7
7
  [Semantic Versioning](https://semver.org/spec/v2.0.0.html) but contrary to it
8
8
  every new version is a new major version.
9
9
 
10
+ ## 170.0.0 - 2024-03-25
11
+
12
+ ### Fixed
13
+
14
+ - `Feedback` gets reset after closing.
15
+
16
+ ### Removed
17
+
18
+ - `Give more feedback` button in `Feedback` dialog.
19
+
10
20
  ## 169.0.0 - 2024-03-25
11
21
 
12
22
  ### Added
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@nordicsemiconductor/pc-nrfconnect-shared",
3
- "version": "169.0.0",
3
+ "version": "170.0.0",
4
4
  "description": "Shared commodities for developing pc-nrfconnect-* packages",
5
5
  "repository": {
6
6
  "type": "git",
package/src/About/Feedback.tsx CHANGED
@@ -42,26 +42,24 @@ const FeedbackDialog = ({
42
42
  DropdownItem | undefined
43
43
  >(categoryItems ? categoryItems[0] : undefined);
44
44
 
45
+ const onClose = () => {
46
+ setFeedback('');
47
+ setSendingFeedback(false);
48
+ setSayThankYou(false);
49
+ setSelectedCategory(categoryItems ? categoryItems[0] : undefined);
50
+ onHide();
51
+ };
52
+
45
53
  return (
46
54
  <GenericDialog
47
55
  isVisible={isVisible}
48
- onHide={onHide}
56
+ onHide={onClose}
49
57
  closeOnUnfocus
50
58
  title="Feedback"
51
59
  showSpinner={sendingFeedback}
52
60
  footer={
53
61
  <>
54
- {sayThankYou ? (
55
- <DialogButton
56
- variant="secondary"
57
- onClick={() => {
58
- setSayThankYou(false);
59
- setFeedback('');
60
- }}
61
- >
62
- Give more feedback
63
- </DialogButton>
64
- ) : (
62
+ {!sayThankYou && (
65
63
  <DialogButton
66
64
  variant="primary"
67
65
  onClick={() => {
@@ -77,7 +75,7 @@ const FeedbackDialog = ({
77
75
  Send feedback
78
76
  </DialogButton>
79
77
  )}
80
- <DialogButton onClick={onHide}>Close</DialogButton>
78
+ <DialogButton onClick={onClose}>Close</DialogButton>
81
79
  </>
82
80
  }
83
81
  >
package/typings/generated/src/About/Feedback.d.ts.map CHANGED
@@ -1 +1 @@
1
- {"version":3,"file":"Feedback.d.ts","sourceRoot":"","sources":["../../../../src/About/Feedback.tsx"],"names":[],"mappings":";AAeA,MAAM,WAAW,iBAAiB;IAC9B,SAAS,EAAE,OAAO,CAAC;IACnB,MAAM,EAAE,MAAM,IAAI,CAAC;IACnB,UAAU,CAAC,EAAE,MAAM,EAAE,CAAC;CACzB;;;;AAsID,wBAgBE"}
1
+ {"version":3,"file":"Feedback.d.ts","sourceRoot":"","sources":["../../../../src/About/Feedback.tsx"],"names":[],"mappings":";AAeA,MAAM,WAAW,iBAAiB;IAC9B,SAAS,EAAE,OAAO,CAAC;IACnB,MAAM,EAAE,MAAM,IAAI,CAAC;IACnB,UAAU,CAAC,EAAE,MAAM,EAAE,CAAC;CACzB;;;;AAoID,wBAgBE"}