@nordicsemiconductor/pc-nrfconnect-shared 166.0.0 → 168.0.0

package/Changelog.md

@@ -7,6 +7,20 @@ This project does _not_ adhere to
 [Semantic Versioning](https://semver.org/spec/v2.0.0.html) but contrary to it
 every new version is a new major version.
 
+## 168.0.0 - 2024-03-22
+
+### Fixed
+
+-   `Slider` with range handle never reached max
+
+## 167.0.0 - 2024-03-08
+
+### Fixed
+
+-   `Group` will not collapse on click unless collapsible property is set
+-   `ConfirmCloseDialog` now cancels launcher's request to reload. Requires
+    engine version 4.4.1
+
 ## 166.0.0 - 2024-03-05
 
 ### Added

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@nordicsemiconductor/pc-nrfconnect-shared",
-    "version": "166.0.0",
+    "version": "168.0.0",
     "description": "Shared commodities for developing pc-nrfconnect-* packages",
     "repository": {
         "type": "git",

package/src/ConfirmBeforeClose/ConfirmCloseDialog.tsx

@@ -72,6 +72,7 @@ export default () => {
                 }
             }}
             onCancel={() => {
+                getCurrentWindow().emit('restart-cancelled');
                 dispatch(setShowCloseDialog(false));
                 confirmedDialogs.forEach(confirmedDialog =>
                     dispatch(addConfirmBeforeClose(confirmedDialog))

package/src/Group/Group.tsx

@@ -100,11 +100,14 @@ export const Group = ({
         <div className={className}>
             <button
                 className={classNames(
-                    'tw-row tw-preflight tw-flex tw-items-center tw-justify-between tw-text-left',
-                    headingFullWidth && 'tw-w-full'
+                    'tw-row tw-preflight tw- tw-flex tw-items-center tw-justify-between tw-text-left',
+                    headingFullWidth && 'tw-w-full',
+                    !collapsible && ' tw-cursor-default'
                 )}
                 type="button"
                 onClick={() => {
+                    if (!collapsible) return;
+
                     if (!collapsibleDivRef.current || !initStateSet.current)
                         return;
 

package/src/Slider/percentage.ts

@@ -12,17 +12,20 @@ export const constrainedToPercentage = (percentage: number) => {
     return percentage;
 };
 
-export const toPercentage = (value: number, rangeOrValues: RangeOrValues) => {
+export const toPercentage = (
+    valueOrIndex: number,
+    rangeOrValues: RangeOrValues
+) => {
     if (isValues(rangeOrValues)) {
-        const max = rangeOrValues.length;
+        const max = Math.max(0, rangeOrValues.length - 1);
 
         // value is an index in the case of explicit values
-        return (value * 100) / max;
+        return (valueOrIndex * 100) / max;
     }
     const min = getMin(rangeOrValues);
     const max = getMax(rangeOrValues);
 
-    return ((value - min) * 100) / (max - min);
+    return ((valueOrIndex - min) * 100) / (max - min);
 };
 
 export const fromPercentage = (
@@ -57,7 +60,6 @@ export const fromPercentage = (
                     : closestPrevIndex;
         }
 
-        console.log(computedValue, closestIndex);
         return closestIndex;
     }
 

package/typings/generated/src/ConfirmBeforeClose/ConfirmCloseDialog.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"ConfirmCloseDialog.d.ts","sourceRoot":"","sources":["../../../../src/ConfirmBeforeClose/ConfirmCloseDialog.tsx"],"names":[],"mappings":";;AAqBA,wBA+DE"}
+{"version":3,"file":"ConfirmCloseDialog.d.ts","sourceRoot":"","sources":["../../../../src/ConfirmBeforeClose/ConfirmCloseDialog.tsx"],"names":[],"mappings":";;AAqBA,wBAgEE"}

package/typings/generated/src/Group/Group.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"Group.d.ts","sourceRoot":"","sources":["../../../../src/Group/Group.tsx"],"names":[],"mappings":"AAMA,OAAO,KAA2B,MAAM,OAAO,CAAC;AAmEhD,eAAO,MAAM,KAAK;;aAYL,MAAM;;;eAGJ,MAAM,SAAS;;;;iCAIE,OAAO,KAAK,IAAI;iBAmF/C,CAAC"}
+{"version":3,"file":"Group.d.ts","sourceRoot":"","sources":["../../../../src/Group/Group.tsx"],"names":[],"mappings":"AAMA,OAAO,KAA2B,MAAM,OAAO,CAAC;AAmEhD,eAAO,MAAM,KAAK;;aAYL,MAAM;;;eAGJ,MAAM,SAAS;;;;iCAIE,OAAO,KAAK,IAAI;iBAsF/C,CAAC"}

package/typings/generated/src/Slider/percentage.d.ts

@@ -1,5 +1,5 @@
 import { RangeOrValues } from './range';
 export declare const constrainedToPercentage: (percentage: number) => number;
-export declare const toPercentage: (value: number, rangeOrValues: RangeOrValues) => number;
+export declare const toPercentage: (valueOrIndex: number, rangeOrValues: RangeOrValues) => number;
 export declare const fromPercentage: (lastValue: number, value: number, rangeOrValues: RangeOrValues, directionForward: boolean) => number;
 //# sourceMappingURL=percentage.d.ts.map

package/typings/generated/src/Slider/percentage.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"percentage.d.ts","sourceRoot":"","sources":["../../../../src/Slider/percentage.ts"],"names":[],"mappings":"AAMA,OAAO,EAA4B,aAAa,EAAE,MAAM,SAAS,CAAC;AAElE,eAAO,MAAM,uBAAuB,eAAgB,MAAM,WAIzD,CAAC;AAEF,eAAO,MAAM,YAAY,UAAW,MAAM,iBAAiB,aAAa,WAWvE,CAAC;AAEF,eAAO,MAAM,cAAc,cACZ,MAAM,SACV,MAAM,iBACE,aAAa,oBACV,OAAO,WAyC5B,CAAC"}
+{"version":3,"file":"percentage.d.ts","sourceRoot":"","sources":["../../../../src/Slider/percentage.ts"],"names":[],"mappings":"AAMA,OAAO,EAA4B,aAAa,EAAE,MAAM,SAAS,CAAC;AAElE,eAAO,MAAM,uBAAuB,eAAgB,MAAM,WAIzD,CAAC;AAEF,eAAO,MAAM,YAAY,iBACP,MAAM,iBACL,aAAa,WAY/B,CAAC;AAEF,eAAO,MAAM,cAAc,cACZ,MAAM,SACV,MAAM,iBACE,aAAa,oBACV,OAAO,WAwC5B,CAAC"}