@nordicsemiconductor/pc-nrfconnect-shared 162.0.0 → 164.0.0

package/Changelog.md

@@ -7,6 +7,18 @@ This project does _not_ adhere to
 [Semantic Versioning](https://semver.org/spec/v2.0.0.html) but contrary to it
 every new version is a new major version.
 
+## 164.0.0 - 2024-03-05
+
+### Fixed
+
+-   Device setup dialog failed to show on JLink device with no FW
+
+## 163.0.0 - 2024-03-05
+
+### Fixed
+
+-   Fixed issue with `Group` remaining expanded in some cases
+
 ## 162.0.0 - 2024-03-05
 
 ### Changed

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@nordicsemiconductor/pc-nrfconnect-shared",
-    "version": "162.0.0",
+    "version": "164.0.0",
     "description": "Shared commodities for developing pc-nrfconnect-* packages",
     "repository": {
         "type": "git",

package/src/Device/jprogOperations.ts

@@ -124,7 +124,7 @@ export const jprogDeviceSetup = (
                     programDeviceWithFw(device, firmwareOption, onProgress)
                 ),
         })),
-    isExpectedFirmware: (device, deviceInfo) => (dispatch, getState) => {
+    isExpectedFirmware: (device, deviceInfo) => async (_, getState) => {
         const fwVersions = firmwareOptions(device, firmware, deviceInfo);
         if (fwVersions.length === 0) {
             return Promise.resolve({
@@ -146,7 +146,8 @@ export const jprogDeviceSetup = (
             });
         }
 
-        return NrfutilDeviceLib.getFwInfo(device).then(info => {
+        try {
+            const info = await NrfutilDeviceLib.getFwInfo(device);
             if (info.imageInfoList.length > 0) {
                 const fw = fwVersions.find(version =>
                     info.imageInfoList.find(
@@ -161,11 +162,13 @@ export const jprogDeviceSetup = (
                     validFirmware: fw !== undefined,
                 });
             }
+        } catch {
+            // do nothing
+        }
 
-            return Promise.resolve({
-                device,
-                validFirmware: false,
-            });
+        return Promise.resolve({
+            device,
+            validFirmware: false,
         });
     },
     tryToSwitchToApplicationMode: () => () => Promise.resolve(null),

package/src/Group/Group.tsx

@@ -45,8 +45,9 @@ const collapseSection = (element: HTMLDivElement) => {
 
 const expandSection = (element: HTMLDivElement) => {
     const sectionHeight = element.scrollHeight;
+    const clientHeight = element.clientHeight;
 
-    if (sectionHeight === 0) return;
+    if (sectionHeight === clientHeight) return;
 
     element.style.height = `${sectionHeight}px`;
 

package/typings/generated/src/Device/jprogOperations.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"jprogOperations.d.ts","sourceRoot":"","sources":["../../../../src/Device/jprogOperations.ts"],"names":[],"mappings":"AAUA,OAAO,EAAE,WAAW,EAAE,UAAU,EAAE,MAAM,eAAe,CAAC;AAmGxD,eAAO,MAAM,gBAAgB,aACf,UAAU,EAAE,uEAGvB,WA0DD,CAAC"}
+{"version":3,"file":"jprogOperations.d.ts","sourceRoot":"","sources":["../../../../src/Device/jprogOperations.ts"],"names":[],"mappings":"AAUA,OAAO,EAAE,WAAW,EAAE,UAAU,EAAE,MAAM,eAAe,CAAC;AAmGxD,eAAO,MAAM,gBAAgB,aACf,UAAU,EAAE,uEAGvB,WA6DD,CAAC"}

package/typings/generated/src/Group/Group.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"Group.d.ts","sourceRoot":"","sources":["../../../../src/Group/Group.tsx"],"names":[],"mappings":"AAMA,OAAO,KAA2B,MAAM,OAAO,CAAC;AAkEhD,eAAO,MAAM,KAAK;;aAYL,MAAM;;;eAGJ,MAAM,SAAS;;;;iCAIE,OAAO,KAAK,IAAI;iBAmF/C,CAAC"}
+{"version":3,"file":"Group.d.ts","sourceRoot":"","sources":["../../../../src/Group/Group.tsx"],"names":[],"mappings":"AAMA,OAAO,KAA2B,MAAM,OAAO,CAAC;AAmEhD,eAAO,MAAM,KAAK;;aAYL,MAAM;;;eAGJ,MAAM,SAAS;;;;iCAIE,OAAO,KAAK,IAAI;iBAmF/C,CAAC"}