@nordicsemiconductor/pc-nrfconnect-shared 149.0.0 → 150.0.0

package/Changelog.md

@@ -7,6 +7,27 @@ This project does _not_ adhere to
 [Semantic Versioning](https://semver.org/spec/v2.0.0.html) but contrary to it
 every new version is a new major version.
 
+## 150.0.0 - 2024-01-18
+
+### Removed
+
+-   `Overlay` tooltip inner padding should be set by the content within it.
+
+### Added
+
+-   Ability to remove the launcher window again. This is especially needed on
+    shutdown. Otherwise when at that time someone still tries to send IPC
+    messages to the launcher window, an exception is thrown.
+
+### Fixed
+
+-   `Overlay` tooltips weren't centered due to incorrect sizing styles.
+-   When spawning the nrfutil process fails in certain ways, an uncaught
+    exception in the main process got thrown. The “certain ways” make this a bit
+    hard to reproduce: On macOS this happened, when the nrfutil executable did
+    not have the executable file mode. Usually this should not happen, because
+    we set that mode ourselves correctly.
+
 ## 149.0.0 - 2024-01-16
 
 ### Added

package/ipc/infrastructure/mainToRenderer.ts

@@ -12,6 +12,10 @@ export const registerLauncherWindowFromMain = (window: BrowserWindow) => {
     launcherWindow = window;
 };
 
+export const removeLauncherWindowFromMain = () => {
+    launcherWindow = undefined;
+};
+
 export const send =
     <T extends (...args: never[]) => void>(channel: string) =>
     (...args: Parameters<T>) =>

package/main/index.ts

@@ -15,7 +15,10 @@ import {
     inRenderer as inRendererSerialPort,
 } from '../ipc/serialPort';
 
-export { registerLauncherWindowFromMain } from '../ipc/infrastructure/mainToRenderer';
+export {
+    registerLauncherWindowFromMain,
+    removeLauncherWindowFromMain,
+} from '../ipc/infrastructure/mainToRenderer';
 
 export const appDetails = { forRenderer: forRendererAppDetails };
 export const apps = { forRenderer: forRendererApps };

package/nrfutil/sandbox.ts

@@ -374,6 +374,10 @@ export class NrfutilSandbox {
                 onStdError(data, nrfutil.pid);
             });
 
+            nrfutil.on('error', err => {
+                reject(err);
+            });
+
             nrfutil.on('close', code => {
                 controller?.signal.removeEventListener('abort', listener);
                 if (aborting) {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@nordicsemiconductor/pc-nrfconnect-shared",
-    "version": "149.0.0",
+    "version": "150.0.0",
     "description": "Shared commodities for developing pc-nrfconnect-* packages",
     "repository": {
         "type": "git",

package/src/Overlay/overlay.scss

@@ -8,14 +8,14 @@
 
 .shared-tooltip {
     div.arrow:first-child {
-        width: 20px;
-        height: 20px;
+        width: 12px;
+        height: 12px;
         pointer-events: none;
     }
 
     &.bs-tooltip-top {
         div.arrow:first-child {
-            bottom: -14px;
+            bottom: -6px;
 
             &::before {
                 border-top-color: $gray-900;
@@ -26,7 +26,7 @@
 
     &.bs-tooltip-right {
         div.arrow:first-child {
-            left: -14px;
+            left: -6px;
 
             &::before {
                 border-right-color: $gray-900;
@@ -37,7 +37,7 @@
 
     &.bs-tooltip-bottom {
         div.arrow:first-child {
-            top: -14px;
+            top: -6px;
 
             &::before {
                 border-bottom-color: $gray-900;
@@ -48,7 +48,7 @@
 
     &.bs-tooltip-left {
         div.arrow:first-child {
-            right: -14px;
+            right: -6px;
 
             &::before {
                 border-left-color: $gray-900;
@@ -59,7 +59,6 @@
 
     .tooltip-inner {
         background: $gray-900;
-        padding-top: 14px;
         min-width: 240px;
     }
 }

package/typings/generated/ipc/infrastructure/mainToRenderer.d.ts

@@ -1,5 +1,6 @@
 import { BrowserWindow, WebContents } from 'electron';
 export declare const registerLauncherWindowFromMain: (window: BrowserWindow) => void;
+export declare const removeLauncherWindowFromMain: () => void;
 export declare const send: <T extends (...args: never[]) => void>(channel: string) => (...args: Parameters<T>) => void | undefined;
 export declare const on: <T extends (...args: never[]) => void>(channel: string) => (handler: T) => Electron.IpcRenderer;
 export declare const broadcast: <T extends (...args: never[]) => void>(channel: string) => (subChannel: string, targets?: Pick<WebContents, 'send'>[], ...args: Parameters<T>) => void;

package/typings/generated/ipc/infrastructure/mainToRenderer.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"mainToRenderer.d.ts","sourceRoot":"","sources":["../../../../ipc/infrastructure/mainToRenderer.ts"],"names":[],"mappings":"AAMA,OAAO,EAAE,aAAa,EAAe,WAAW,EAAE,MAAM,UAAU,CAAC;AAInE,eAAO,MAAM,8BAA8B,WAAY,aAAa,SAEnE,CAAC;AAEF,eAAO,MAAM,IAAI,uBACQ,KAAK,EAAE,KAAK,IAAI,WAAW,MAAM,iDAEA,CAAC;AAE3D,eAAO,MAAM,EAAE,uBACU,KAAK,EAAE,KAAK,IAAI,WAAW,MAAM,yCAIjD,CAAC;AAIV,eAAO,MAAM,SAAS,uBACG,KAAK,EAAE,KAAK,IAAI,WAAW,MAAM,kBAEtC,MAAM,YACT,KAAK,WAAW,EAAE,MAAM,CAAC,EAAE,iCAKlC,CAAC;AAEX,eAAO,MAAM,aAAa,uBACD,KAAK,EAAE,KAAK,IAAI,WACxB,MAAM,cACH,MAAM,yCAMjB,CAAC"}
+{"version":3,"file":"mainToRenderer.d.ts","sourceRoot":"","sources":["../../../../ipc/infrastructure/mainToRenderer.ts"],"names":[],"mappings":"AAMA,OAAO,EAAE,aAAa,EAAe,WAAW,EAAE,MAAM,UAAU,CAAC;AAInE,eAAO,MAAM,8BAA8B,WAAY,aAAa,SAEnE,CAAC;AAEF,eAAO,MAAM,4BAA4B,YAExC,CAAC;AAEF,eAAO,MAAM,IAAI,uBACQ,KAAK,EAAE,KAAK,IAAI,WAAW,MAAM,iDAEA,CAAC;AAE3D,eAAO,MAAM,EAAE,uBACU,KAAK,EAAE,KAAK,IAAI,WAAW,MAAM,yCAIjD,CAAC;AAIV,eAAO,MAAM,SAAS,uBACG,KAAK,EAAE,KAAK,IAAI,WAAW,MAAM,kBAEtC,MAAM,YACT,KAAK,WAAW,EAAE,MAAM,CAAC,EAAE,iCAKlC,CAAC;AAEX,eAAO,MAAM,aAAa,uBACD,KAAK,EAAE,KAAK,IAAI,WACxB,MAAM,cACH,MAAM,yCAMjB,CAAC"}

package/typings/generated/main/index.d.ts

@@ -1,5 +1,5 @@
 /// <reference types="node" />
-export { registerLauncherWindowFromMain } from '../ipc/infrastructure/mainToRenderer';
+export { registerLauncherWindowFromMain, removeLauncherWindowFromMain, } from '../ipc/infrastructure/mainToRenderer';
 export declare const appDetails: {
     forRenderer: {
         registerGetAppDetails: (onGetAppDetails: (webContents: Electron.WebContents) => import("../ipc/appDetails").AppDetailsFromLauncher) => void;

package/typings/generated/main/index.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../../main/index.ts"],"names":[],"mappings":";AAiBA,OAAO,EAAE,8BAA8B,EAAE,MAAM,sCAAsC,CAAC;AAEtF,eAAO,MAAM,UAAU;;;;CAAyC,CAAC;AACjE,eAAO,MAAM,IAAI;;;;;;;;;;;;;CAAmC,CAAC;AACrD,eAAO,MAAM,cAAc;;;;CAA6C,CAAC;AACzE,eAAO,MAAM,UAAU;;;;;CAAyC,CAAC;AACjE,eAAO,MAAM,YAAY;;;;;CAA2C,CAAC;AACrE,eAAO,MAAM,WAAW;;;;;;CAEvB,CAAC;AACF,eAAO,MAAM,UAAU;;;;;;;;;;;;;;;;;;CAGtB,CAAC;AAEF,OAAO,EACH,KAAK,OAAO,EACZ,KAAK,iBAAiB,EACtB,KAAK,cAAc,EACnB,KAAK,oBAAoB,EACzB,KAAK,UAAU,EACf,KAAK,aAAa,GACrB,MAAM,kBAAkB,CAAC;AAC1B,OAAO,EACH,KAAK,oBAAoB,EACzB,KAAK,cAAc,EACnB,yBAAyB,EACzB,mBAAmB,GACtB,MAAM,2BAA2B,CAAC;AAEnC,OAAO,EAAE,KAAK,gBAAgB,EAAE,MAAM,mBAAmB,CAAC;AAC1D,YAAY,EAAE,cAAc,EAAE,MAAM,mBAAmB,CAAC;AACxD,OAAO,EACH,0BAA0B,EAC1B,wBAAwB,GAC3B,MAAM,mBAAmB,CAAC"}
+{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../../main/index.ts"],"names":[],"mappings":";AAiBA,OAAO,EACH,8BAA8B,EAC9B,4BAA4B,GAC/B,MAAM,sCAAsC,CAAC;AAE9C,eAAO,MAAM,UAAU;;;;CAAyC,CAAC;AACjE,eAAO,MAAM,IAAI;;;;;;;;;;;;;CAAmC,CAAC;AACrD,eAAO,MAAM,cAAc;;;;CAA6C,CAAC;AACzE,eAAO,MAAM,UAAU;;;;;CAAyC,CAAC;AACjE,eAAO,MAAM,YAAY;;;;;CAA2C,CAAC;AACrE,eAAO,MAAM,WAAW;;;;;;CAEvB,CAAC;AACF,eAAO,MAAM,UAAU;;;;;;;;;;;;;;;;;;CAGtB,CAAC;AAEF,OAAO,EACH,KAAK,OAAO,EACZ,KAAK,iBAAiB,EACtB,KAAK,cAAc,EACnB,KAAK,oBAAoB,EACzB,KAAK,UAAU,EACf,KAAK,aAAa,GACrB,MAAM,kBAAkB,CAAC;AAC1B,OAAO,EACH,KAAK,oBAAoB,EACzB,KAAK,cAAc,EACnB,yBAAyB,EACzB,mBAAmB,GACtB,MAAM,2BAA2B,CAAC;AAEnC,OAAO,EAAE,KAAK,gBAAgB,EAAE,MAAM,mBAAmB,CAAC;AAC1D,YAAY,EAAE,cAAc,EAAE,MAAM,mBAAmB,CAAC;AACxD,OAAO,EACH,0BAA0B,EAC1B,wBAAwB,GAC3B,MAAM,mBAAmB,CAAC"}

package/typings/generated/nrfutil/sandbox.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"sandbox.d.ts","sourceRoot":"","sources":["../../../nrfutil/sandbox.ts"],"names":[],"mappings":";AAiBA,OAAO,EACH,cAAc,EACd,QAAQ,EACR,UAAU,EACV,aAAa,EAGb,QAAQ,EACR,IAAI,EACJ,SAAS,EACT,OAAO,EACV,MAAM,gBAAgB,CAAC;AAcxB,QAAA,MAAM,UAAU,YAAa,MAAM,UAAU,MAAM,WAAW,MAAM;;;;;;;;;;;CAqBnE,CAAC;AAiDF,qBAAa,cAAc;IACvB,OAAO,EAAE,MAAM,CAAC;IAChB,MAAM,EAAE,MAAM,CAAC;IACf,OAAO,EAAE,MAAM,CAAC;IAChB,iBAAiB,EAAE,CAAC,CAAC,OAAO,EAAE,UAAU,EAAE,GAAG,CAAC,EAAE,MAAM,KAAK,IAAI,CAAC,EAAE,CAAM;IACxE,QAAQ,EAAE,QAAQ,CAAmC;IACrD,GAAG,EAAE,UAAU,CAAC,OAAO,UAAU,CAAC,CAAC;gBAEvB,OAAO,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM,EAAE,OAAO,EAAE,MAAM;IAQ5D,OAAO,CAAC,kBAAkB,CASxB;IAEK,gBAAgB,+BAUrB;IAEK,kBAAkB,yBAmBvB;IAEK,cAAc,4BACO,QAAQ,SAAS,IAAI,KAAK,IAAI,gCAmBxD;IAEK,iBAAiB,eAA4C;IAE7D,sBAAsB,oBAChB,MAAM,QACT,MAAM,EAAE,2BACU,QAAQ,SAAS,IAAI,KAAK,IAAI,0CAC5B,SAAS,KAAK,IAAI,0DACF,IAAI,4BACjC,eAAe,mBACZ,OAAO,UAAU,KAAK,OAAO,UAAU;;;OAUrD;IAEN,OAAO,CAAC,mBAAmB,CAsBrB;IAEN,OAAO,CAAC,YAAY,CAmFlB;IAEK,YAAY,YACN,MAAM,QACT,MAAM,EAAE,iBACC,MAAM,QAAQ,MAAM,KAAK,MAAM,GAAG,SAAS,qBACvC,MAAM,QAAQ,MAAM,KAAK,IAAI,eACnC,eAAe,kBACb,OAAO,UAAU,KAAK,OAAO,UAAU,mBAiEnD;IAEA,qBAAqB,oBACf,MAAM,QACT,MAAM,EAAE,2BACU,QAAQ,SAAS,IAAI,KAAK,IAAI,0CAC5B,SAAS,KAAK,IAAI,0DACF,IAAI,4BACjC,eAAe,mBACZ,OAAO,UAAU,KAAK,OAAO,UAAU;;;OAUrD;IAEN,OAAO,CAAC,kBAAkB,CAmFxB;IAEK,WAAW,YACL,MAAM,QACT,MAAM,EAAE,iBACC,MAAM,QAAQ,MAAM,KAAK,IAAI,qBACzB,MAAM,QAAQ,MAAM,KAAK,IAAI,eACnC,eAAe,kBACb,OAAO,UAAU,KAAK,OAAO,UAAU,mBA0DnD;IAEA,yBAAyB,oBACnB,MAAM,QACT,MAAM,EAAE,uDAEE,OAAO,UAAU,KAAK,OAAO,UAAU;yBA4ClC,MAAM,IAAI;;qCAKE,KAAK,KAAK,IAAI,qBA7Cf,KAAK,KAAK,IAAI;MAoDhD;IAEK,8BAA8B,eACxB,MAAM,2BACS,QAAQ,SAAS,IAAI,KAAK,IAAI,4BACzC,eAAe,SACtB,MAAM,EAAE,sCAahB;IAEK,kCAAkC,sBAC5B,MAAM,2BACS,QAAQ,SAAS,IAAI,KAAK,IAAI,4BACzC,eAAe,SACtB,MAAM,EAAE,gBAehB;IAEK,+BAA+B,sBACzB,MAAM,eACF,eAAe,SACtB,MAAM,EAAE,gBAehB;IAEK,SAAS,sBACO,UAAU,QAAQ,MAAM,KAAK,IAAI,sBA9jB1B,UAAU,QAAQ,MAAM,KAAK,IAAI,IAukB7D;IAEK,WAAW,UAAW,QAAQ,UAEnC;CACL;kCAGY,MAAM,UACP,MAAM,YACJ,MAAM,2BACQ,QAAQ,SAAS,IAAI,KAAK,IAAI;AAJ1D,wBAqBE"}
+{"version":3,"file":"sandbox.d.ts","sourceRoot":"","sources":["../../../nrfutil/sandbox.ts"],"names":[],"mappings":";AAiBA,OAAO,EACH,cAAc,EACd,QAAQ,EACR,UAAU,EACV,aAAa,EAGb,QAAQ,EACR,IAAI,EACJ,SAAS,EACT,OAAO,EACV,MAAM,gBAAgB,CAAC;AAcxB,QAAA,MAAM,UAAU,YAAa,MAAM,UAAU,MAAM,WAAW,MAAM;;;;;;;;;;;CAqBnE,CAAC;AAiDF,qBAAa,cAAc;IACvB,OAAO,EAAE,MAAM,CAAC;IAChB,MAAM,EAAE,MAAM,CAAC;IACf,OAAO,EAAE,MAAM,CAAC;IAChB,iBAAiB,EAAE,CAAC,CAAC,OAAO,EAAE,UAAU,EAAE,GAAG,CAAC,EAAE,MAAM,KAAK,IAAI,CAAC,EAAE,CAAM;IACxE,QAAQ,EAAE,QAAQ,CAAmC;IACrD,GAAG,EAAE,UAAU,CAAC,OAAO,UAAU,CAAC,CAAC;gBAEvB,OAAO,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM,EAAE,OAAO,EAAE,MAAM;IAQ5D,OAAO,CAAC,kBAAkB,CASxB;IAEK,gBAAgB,+BAUrB;IAEK,kBAAkB,yBAmBvB;IAEK,cAAc,4BACO,QAAQ,SAAS,IAAI,KAAK,IAAI,gCAmBxD;IAEK,iBAAiB,eAA4C;IAE7D,sBAAsB,oBAChB,MAAM,QACT,MAAM,EAAE,2BACU,QAAQ,SAAS,IAAI,KAAK,IAAI,0CAC5B,SAAS,KAAK,IAAI,0DACF,IAAI,4BACjC,eAAe,mBACZ,OAAO,UAAU,KAAK,OAAO,UAAU;;;OAUrD;IAEN,OAAO,CAAC,mBAAmB,CAsBrB;IAEN,OAAO,CAAC,YAAY,CAmFlB;IAEK,YAAY,YACN,MAAM,QACT,MAAM,EAAE,iBACC,MAAM,QAAQ,MAAM,KAAK,MAAM,GAAG,SAAS,qBACvC,MAAM,QAAQ,MAAM,KAAK,IAAI,eACnC,eAAe,kBACb,OAAO,UAAU,KAAK,OAAO,UAAU,mBAqEnD;IAEA,qBAAqB,oBACf,MAAM,QACT,MAAM,EAAE,2BACU,QAAQ,SAAS,IAAI,KAAK,IAAI,0CAC5B,SAAS,KAAK,IAAI,0DACF,IAAI,4BACjC,eAAe,mBACZ,OAAO,UAAU,KAAK,OAAO,UAAU;;;OAUrD;IAEN,OAAO,CAAC,kBAAkB,CAmFxB;IAEK,WAAW,YACL,MAAM,QACT,MAAM,EAAE,iBACC,MAAM,QAAQ,MAAM,KAAK,IAAI,qBACzB,MAAM,QAAQ,MAAM,KAAK,IAAI,eACnC,eAAe,kBACb,OAAO,UAAU,KAAK,OAAO,UAAU,mBA0DnD;IAEA,yBAAyB,oBACnB,MAAM,QACT,MAAM,EAAE,uDAEE,OAAO,UAAU,KAAK,OAAO,UAAU;yBA4ClC,MAAM,IAAI;;qCAKE,KAAK,KAAK,IAAI,qBA7Cf,KAAK,KAAK,IAAI;MAoDhD;IAEK,8BAA8B,eACxB,MAAM,2BACS,QAAQ,SAAS,IAAI,KAAK,IAAI,4BACzC,eAAe,SACtB,MAAM,EAAE,sCAahB;IAEK,kCAAkC,sBAC5B,MAAM,2BACS,QAAQ,SAAS,IAAI,KAAK,IAAI,4BACzC,eAAe,SACtB,MAAM,EAAE,gBAehB;IAEK,+BAA+B,sBACzB,MAAM,eACF,eAAe,SACtB,MAAM,EAAE,gBAehB;IAEK,SAAS,sBACO,UAAU,QAAQ,MAAM,KAAK,IAAI,sBAlkB1B,UAAU,QAAQ,MAAM,KAAK,IAAI,IA2kB7D;IAEK,WAAW,UAAW,QAAQ,UAEnC;CACL;kCAGY,MAAM,UACP,MAAM,YACJ,MAAM,2BACQ,QAAQ,SAAS,IAAI,KAAK,IAAI;AAJ1D,wBAqBE"}