@nordicsemiconductor/pc-nrfconnect-shared 126.0.0 → 128.0.0

package/Changelog.md

@@ -7,6 +7,19 @@ This project does _not_ adhere to
 [Semantic Versioning](https://semver.org/spec/v2.0.0.html) but contrary to it
 every new version is a new major version.
 
+## 128 - 2023-11-08
+
+### Fixed
+
+-   `NumberInputSliderWithUnit` component did not disable all sub-components
+-   `NumberInputSliderWithUnit` did not update when external value changed
+
+## 127 - 2023-11-08
+
+### Fixed
+
+-   version 126 was released as a prerelease on NPM
+
 ## 126 - 2023-11-08
 
 ### Fixed

package/coverage/cobertura-coverage.xml

@@ -1,6 +1,6 @@
 <?xml version="1.0" ?>
 <!DOCTYPE coverage SYSTEM "http://cobertura.sourceforge.net/xml/coverage-04.dtd">
-<coverage lines-valid="3440" lines-covered="1892" line-rate="0.55" branches-valid="1689" branches-covered="511" branch-rate="0.3025" timestamp="1699447179697" complexity="0" version="0.1">
+<coverage lines-valid="3440" lines-covered="1892" line-rate="0.55" branches-valid="1689" branches-covered="511" branch-rate="0.3025" timestamp="1699461197428" complexity="0" version="0.1">
   <sources>
     <source>/home/vsts/work/1/s</source>
   </sources>
@@ -5909,72 +5909,72 @@
       <classes>
         <class name="InlineInput.tsx" filename="src/InlineInput/InlineInput.tsx" line-rate="0.3" branch-rate="0.2857">
           <methods>
-            <method name="(anonymous_5)" hits="30" signature="()V">
+            <method name="(anonymous_7)" hits="30" signature="()V">
               <lines>
                 <line number="37" hits="30"/>
               </lines>
             </method>
-            <method name="(anonymous_6)" hits="30" signature="()V">
+            <method name="(anonymous_8)" hits="30" signature="()V">
               <lines>
                 <line number="42" hits="30"/>
               </lines>
             </method>
-            <method name="(anonymous_7)" hits="30" signature="()V">
+            <method name="(anonymous_9)" hits="30" signature="()V">
               <lines>
                 <line number="66" hits="30"/>
               </lines>
             </method>
-            <method name="(anonymous_8)" hits="0" signature="()V">
+            <method name="(anonymous_10)" hits="0" signature="()V">
               <lines>
                 <line number="70" hits="0"/>
               </lines>
             </method>
-            <method name="(anonymous_9)" hits="0" signature="()V">
+            <method name="(anonymous_11)" hits="0" signature="()V">
               <lines>
                 <line number="72" hits="0"/>
               </lines>
             </method>
-            <method name="(anonymous_10)" hits="0" signature="()V">
+            <method name="(anonymous_12)" hits="0" signature="()V">
               <lines>
                 <line number="73" hits="0"/>
               </lines>
             </method>
-            <method name="(anonymous_11)" hits="0" signature="()V">
+            <method name="(anonymous_13)" hits="0" signature="()V">
               <lines>
                 <line number="74" hits="0"/>
               </lines>
             </method>
-            <method name="(anonymous_12)" hits="0" signature="()V">
+            <method name="(anonymous_14)" hits="0" signature="()V">
               <lines>
                 <line number="86" hits="0"/>
               </lines>
             </method>
-            <method name="(anonymous_13)" hits="0" signature="()V">
+            <method name="(anonymous_15)" hits="0" signature="()V">
               <lines>
                 <line number="104" hits="0"/>
               </lines>
             </method>
-            <method name="(anonymous_14)" hits="0" signature="()V">
+            <method name="(anonymous_16)" hits="0" signature="()V">
               <lines>
                 <line number="126" hits="0"/>
               </lines>
             </method>
-            <method name="(anonymous_15)" hits="0" signature="()V">
+            <method name="(anonymous_17)" hits="0" signature="()V">
               <lines>
                 <line number="141" hits="0"/>
               </lines>
             </method>
-            <method name="(anonymous_16)" hits="0" signature="()V">
+            <method name="(anonymous_18)" hits="0" signature="()V">
               <lines>
                 <line number="157" hits="0"/>
               </lines>
             </method>
-            <method name="(anonymous_17)" hits="0" signature="()V">
+            <method name="(anonymous_19)" hits="0" signature="()V">
               <lines>
                 <line number="179" hits="0"/>
               </lines>
             </method>
-            <method name="(anonymous_18)" hits="0" signature="()V">
+            <method name="(anonymous_20)" hits="0" signature="()V">
               <lines>
                 <line number="182" hits="0"/>
               </lines>

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@nordicsemiconductor/pc-nrfconnect-shared",
-    "version": "126.0.0",
+    "version": "128.0.0",
     "description": "Shared commodities for developing pc-nrfconnect-* packages",
     "repository": {
         "type": "git",

package/src/InlineInput/InlineInput.tsx

@@ -34,9 +34,9 @@ useSynchronisationIfChangedFromOutside does take care of this by remembering the
 external value and comparing with it to determine whether it has changed.
 */
 
-const useSynchronisationIfChangedFromOutside = (
-    externalValue: string,
-    setInternalValue: (value: string) => void
+export const useSynchronisationIfChangedFromOutside = <T,>(
+    externalValue: T,
+    setInternalValue: (value: T) => void
 ) => {
     const previousExternalValue = useRef(externalValue);
     useEffect(() => {

package/src/InlineInput/NumberInputWithDropdown.tsx

@@ -9,6 +9,7 @@ import React, { useState } from 'react';
 import { DropdownItem } from '../Dropdown/Dropdown';
 import { RangeOrValues } from '../Slider/range';
 import classNames from '../utils/classNames';
+import { useSynchronisationIfChangedFromOutside } from './InlineInput';
 import NumberInlineInput from './NumberInlineInput';
 
 import styles from '../Dropdown/Dropdown.module.scss';
@@ -55,6 +56,8 @@ export default ({
         }
     };
 
+    useSynchronisationIfChangedFromOutside(value, setInlineValue);
+
     return (
         <div
             className={`tw-preflight tw-relative tw-w-full ${className}`}
@@ -78,6 +81,7 @@ export default ({
                     textAlignLeft
                     onValidityChanged={setIsValid}
                     preventDefaultInvalidStyle
+                    disabled={disabled}
                 />
                 <button
                     id={id}

package/typings/generated/src/InlineInput/InlineInput.d.ts

@@ -1,5 +1,6 @@
 import React from 'react';
 import './inline-input.scss';
+export declare const useSynchronisationIfChangedFromOutside: <T>(externalValue: T, setInternalValue: (value: T) => void) => T;
 interface Props {
     disabled?: boolean;
     value: string;

package/typings/generated/src/InlineInput/InlineInput.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"InlineInput.d.ts","sourceRoot":"","sources":["../../../../src/InlineInput/InlineInput.tsx"],"names":[],"mappings":"AAMA,OAAO,KAAsC,MAAM,OAAO,CAAC;AAI3D,OAAO,qBAAqB,CAAC;AAwC7B,UAAU,KAAK;IACX,QAAQ,CAAC,EAAE,OAAO,CAAC;IACnB,KAAK,EAAE,MAAM,CAAC;IACd,OAAO,CAAC,EAAE,CAAC,KAAK,EAAE,MAAM,KAAK,OAAO,CAAC;IACrC,QAAQ,EAAE,CAAC,KAAK,EAAE,MAAM,KAAK,IAAI,CAAC;IAClC,gBAAgB,CAAC,EAAE,CAAC,KAAK,EAAE,MAAM,KAAK,IAAI,CAAC;IAC3C,yBAAyB,CAAC,EAAE,MAAM,MAAM,CAAC;IACzC,yBAAyB,CAAC,EAAE,MAAM,MAAM,CAAC;IACzC,SAAS,CAAC,EAAE,MAAM,CAAC;IACnB,aAAa,CAAC,EAAE,OAAO,CAAC;IACxB,iBAAiB,CAAC,EAAE,CAAC,QAAQ,EAAE,OAAO,KAAK,IAAI,CAAC;IAChD,0BAA0B,CAAC,EAAE,OAAO,CAAC;CACxC;AAED,QAAA,MAAM,WAAW,gFA6HhB,CAAC;AAEF,eAAe,WAAW,CAAC"}
+{"version":3,"file":"InlineInput.d.ts","sourceRoot":"","sources":["../../../../src/InlineInput/InlineInput.tsx"],"names":[],"mappings":"AAMA,OAAO,KAAsC,MAAM,OAAO,CAAC;AAI3D,OAAO,qBAAqB,CAAC;AA0B7B,eAAO,MAAM,sCAAsC,wDAEf,IAAI,MAUvC,CAAC;AAEF,UAAU,KAAK;IACX,QAAQ,CAAC,EAAE,OAAO,CAAC;IACnB,KAAK,EAAE,MAAM,CAAC;IACd,OAAO,CAAC,EAAE,CAAC,KAAK,EAAE,MAAM,KAAK,OAAO,CAAC;IACrC,QAAQ,EAAE,CAAC,KAAK,EAAE,MAAM,KAAK,IAAI,CAAC;IAClC,gBAAgB,CAAC,EAAE,CAAC,KAAK,EAAE,MAAM,KAAK,IAAI,CAAC;IAC3C,yBAAyB,CAAC,EAAE,MAAM,MAAM,CAAC;IACzC,yBAAyB,CAAC,EAAE,MAAM,MAAM,CAAC;IACzC,SAAS,CAAC,EAAE,MAAM,CAAC;IACnB,aAAa,CAAC,EAAE,OAAO,CAAC;IACxB,iBAAiB,CAAC,EAAE,CAAC,QAAQ,EAAE,OAAO,KAAK,IAAI,CAAC;IAChD,0BAA0B,CAAC,EAAE,OAAO,CAAC;CACxC;AAED,QAAA,MAAM,WAAW,gFA6HhB,CAAC;AAEF,eAAe,WAAW,CAAC"}

package/typings/generated/src/InlineInput/NumberInputWithDropdown.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"NumberInputWithDropdown.d.ts","sourceRoot":"","sources":["../../../../src/InlineInput/NumberInputWithDropdown.tsx"],"names":[],"mappings":"AAMA,OAAO,KAAmB,MAAM,OAAO,CAAC;AAExC,OAAO,EAAE,YAAY,EAAE,MAAM,sBAAsB,CAAC;AACpD,OAAO,EAAE,aAAa,EAAE,MAAM,iBAAiB,CAAC;AAMhD,MAAM,MAAM,kBAAkB,GAAG,YAAY,CAAC,MAAM,CAAC,CAAC;AAEtD,UAAU,aAAa;IACnB,EAAE,CAAC,EAAE,MAAM,CAAC;IACZ,KAAK,CAAC,EAAE,KAAK,CAAC,SAAS,CAAC;IACxB,KAAK,EAAE,kBAAkB,EAAE,CAAC;IAC5B,KAAK,EAAE,MAAM,CAAC;IACd,QAAQ,EAAE,CAAC,KAAK,EAAE,MAAM,KAAK,IAAI,CAAC;IAClC,KAAK,EAAE,aAAa,CAAC;IACrB,oBAAoB,CAAC,EAAE,MAAM,CAAC;IAC9B,SAAS,CAAC,EAAE,MAAM,CAAC;IACnB,QAAQ,CAAC,EAAE,OAAO,CAAC;IACnB,KAAK,CAAC,EAAE,MAAM,CAAC;CAClB;0HAaE,aAAa;AAXhB,wBAoGE"}
+{"version":3,"file":"NumberInputWithDropdown.d.ts","sourceRoot":"","sources":["../../../../src/InlineInput/NumberInputWithDropdown.tsx"],"names":[],"mappings":"AAMA,OAAO,KAAmB,MAAM,OAAO,CAAC;AAExC,OAAO,EAAE,YAAY,EAAE,MAAM,sBAAsB,CAAC;AACpD,OAAO,EAAE,aAAa,EAAE,MAAM,iBAAiB,CAAC;AAOhD,MAAM,MAAM,kBAAkB,GAAG,YAAY,CAAC,MAAM,CAAC,CAAC;AAEtD,UAAU,aAAa;IACnB,EAAE,CAAC,EAAE,MAAM,CAAC;IACZ,KAAK,CAAC,EAAE,KAAK,CAAC,SAAS,CAAC;IACxB,KAAK,EAAE,kBAAkB,EAAE,CAAC;IAC5B,KAAK,EAAE,MAAM,CAAC;IACd,QAAQ,EAAE,CAAC,KAAK,EAAE,MAAM,KAAK,IAAI,CAAC;IAClC,KAAK,EAAE,aAAa,CAAC;IACrB,oBAAoB,CAAC,EAAE,MAAM,CAAC;IAC9B,SAAS,CAAC,EAAE,MAAM,CAAC;IACnB,QAAQ,CAAC,EAAE,OAAO,CAAC;IACnB,KAAK,CAAC,EAAE,MAAM,CAAC;CAClB;0HAaE,aAAa;AAXhB,wBAuGE"}