@nordicsemiconductor/pc-nrfconnect-shared 104.0.0 → 106.0.0

package/nrfutil/device/list.ts

@@ -4,6 +4,7 @@
  * SPDX-License-Identifier: LicenseRef-Nordic-4-Clause
  */
 
+import logger from '../../src/logging';
 import {
     DeviceTraits,
     deviceTraitsToArgs,
@@ -50,6 +51,16 @@ export default async (
 
     const onData = (data: HotplugEvent | ListEvent) => {
         if (isListEvent(data)) {
+            data.devices
+                .filter(d => !d.serialNumber)
+                .forEach(d => {
+                    logger.warn(
+                        `Device was skipped as it has no Serial number ${JSON.stringify(
+                            d
+                        )}`
+                    );
+                });
+
             onEnumerated(
                 data.devices.filter(
                     d => d.serialNumber
@@ -63,14 +74,18 @@ export default async (
             return;
         }
 
-        if (
-            data.event === 'Arrived' &&
-            data.device &&
-            data.device.serialNumber
-        ) {
-            onHotplugEvent.onDeviceArrived(
-                data.device as NrfutilDeviceWithSerialnumber
-            );
+        if (data.event === 'Arrived' && data.device) {
+            if (data.device.serialNumber) {
+                onHotplugEvent.onDeviceArrived(
+                    data.device as NrfutilDeviceWithSerialnumber
+                );
+            } else {
+                logger.warn(
+                    `Device was skipped as it has no Serial number ${JSON.stringify(
+                        data.device
+                    )}`
+                );
+            }
         } else if (data.event === 'Left') {
             onHotplugEvent.onDeviceLeft(data.id);
         }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@nordicsemiconductor/pc-nrfconnect-shared",
-    "version": "104.0.0",
+    "version": "106.0.0",
     "description": "Shared commodities for developing pc-nrfconnect-* packages",
     "repository": {
         "type": "git",
@@ -118,7 +118,8 @@
         "typescript": "4.9.5",
         "util": "0.12.5",
         "uuid": "8.3.2",
-        "winston": "3.8.2"
+        "winston": "3.8.2",
+        "xterm-headless": "^5.3.0"
     },
     "typings": "./typings/generated/src/index.d.ts",
     "eslintConfig": {

package/src/App/app.scss

@@ -67,7 +67,7 @@
 
     .core19-side-panel-container {
         width: $side-panel-width;
-        padding: 0 24px;
+        padding: 0 10px 0 24px; // 24-14(scrollbar width)=10
         background-color: $gray-50;
         height: 100%;
         margin-left: 0;
@@ -77,7 +77,8 @@
             margin-left: -$side-panel-width;
         }
 
-        overflow-y: overlay;
+        overflow-y: scroll;
+
         @include scrollbars($gray-50);
     }
 }

package/src/Device/deviceLister.ts

@@ -335,7 +335,9 @@ export const startWatchingDevices =
             const operation = await NrfutilDeviceLib.list(
                 deviceListing,
                 d => d.forEach(onDeviceArrived),
-                logger.error,
+                error => {
+                    logger.error(error);
+                },
                 { onDeviceArrived, onDeviceLeft }
             );