@nordcraft/search 1.0.45 → 1.0.47
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/dist/problems.worker.js +11 -3
- package/dist/problems.worker.js.map +1 -1
- package/dist/rules/attributes/unknownComponentAttributeRule.js +33 -0
- package/dist/rules/attributes/unknownComponentAttributeRule.js.map +1 -0
- package/dist/rules/attributes/unknownComponentAttributeRule.test.js +145 -0
- package/dist/rules/attributes/unknownComponentAttributeRule.test.js.map +1 -0
- package/dist/rules/logic/noStaticNodeCondition.js +29 -0
- package/dist/rules/logic/noStaticNodeCondition.js.map +1 -0
- package/dist/rules/logic/noStaticNodeCondition.test.js +274 -0
- package/dist/rules/logic/noStaticNodeCondition.test.js.map +1 -0
- package/dist/rules/logic/noUnnecessaryConditionFalsy.js +5 -1
- package/dist/rules/logic/noUnnecessaryConditionFalsy.js.map +1 -1
- package/dist/rules/logic/noUnnecessaryConditionTruthy.js +8 -4
- package/dist/rules/logic/noUnnecessaryConditionTruthy.js.map +1 -1
- package/dist/rules/logic/noUnnecessaryConditionTruthy.test.js +33 -4
- package/dist/rules/logic/noUnnecessaryConditionTruthy.test.js.map +1 -1
- package/dist/rules/noReferenceNodeRule.js +10 -8
- package/dist/rules/noReferenceNodeRule.js.map +1 -1
- package/dist/rules/noReferenceNodeRule.test.js +1 -1
- package/dist/rules/style/invalidStyleSyntaxRule.js +2 -2
- package/dist/rules/style/invalidStyleSyntaxRule.test.js +1 -1
- package/dist/rules/workflows/noPostNavigateAction.js +13 -2
- package/dist/rules/workflows/noPostNavigateAction.js.map +1 -1
- package/dist/rules/workflows/noPostNavigateAction.test.js +102 -1
- package/dist/rules/workflows/noPostNavigateAction.test.js.map +1 -1
- package/dist/util/contextlessEvaluateFormula.js +77 -0
- package/dist/util/contextlessEvaluateFormula.js.map +1 -0
- package/dist/util/contextlessEvaluateFormula.test.js +152 -0
- package/dist/util/contextlessEvaluateFormula.test.js.map +1 -0
- package/dist/util/helpers.test.js +1 -1
- package/dist/util/helpers.test.js.map +1 -1
- package/dist/util/removeUnused.fix.js +18 -1
- package/dist/util/removeUnused.fix.js.map +1 -1
- package/package.json +2 -2
- package/src/problems.worker.ts +18 -5
- package/src/rules/attributes/unknownComponentAttributeRule.test.ts +156 -0
- package/src/rules/attributes/unknownComponentAttributeRule.ts +40 -0
- package/src/rules/logic/noStaticNodeCondition.test.ts +290 -0
- package/src/rules/logic/noStaticNodeCondition.ts +43 -0
- package/src/rules/logic/noUnnecessaryConditionFalsy.ts +5 -4
- package/src/rules/logic/noUnnecessaryConditionTruthy.test.ts +37 -4
- package/src/rules/logic/noUnnecessaryConditionTruthy.ts +10 -8
- package/src/rules/noReferenceNodeRule.test.ts +1 -1
- package/src/rules/noReferenceNodeRule.ts +17 -10
- package/src/rules/style/invalidStyleSyntaxRule.test.ts +1 -1
- package/src/rules/style/invalidStyleSyntaxRule.ts +3 -3
- package/src/rules/workflows/noPostNavigateAction.test.ts +111 -1
- package/src/rules/workflows/noPostNavigateAction.ts +20 -3
- package/src/types.d.ts +12 -0
- package/src/util/contextlessEvaluateFormula.test.ts +190 -0
- package/src/util/contextlessEvaluateFormula.ts +110 -0
- package/src/util/helpers.test.ts +1 -1
- package/src/util/removeUnused.fix.ts +29 -1
package/dist/problems.worker.js
CHANGED
|
@@ -10,6 +10,7 @@ import { unknownApiInputRule } from './rules/apis/unknownApiInputRule';
|
|
|
10
10
|
import { unknownApiRule } from './rules/apis/unknownApiRule';
|
|
11
11
|
import { noReferenceAttributeRule } from './rules/attributes/noReferenceAttributeRule';
|
|
12
12
|
import { unknownAttributeRule } from './rules/attributes/unknownAttributeRule';
|
|
13
|
+
import { unknownComponentAttributeRule } from './rules/attributes/unknownComponentAttributeRule';
|
|
13
14
|
import { noReferenceComponentRule } from './rules/components/noReferenceComponentRule';
|
|
14
15
|
import { unknownComponentRule } from './rules/components/unknownComponentRule';
|
|
15
16
|
import { noContextConsumersRule } from './rules/context/noContextConsumersRule';
|
|
@@ -35,6 +36,7 @@ import { unknownFormulaRule } from './rules/formulas/unknownFormulaRule';
|
|
|
35
36
|
import { unknownProjectFormulaRule } from './rules/formulas/unknownProjectFormulaRule';
|
|
36
37
|
import { unknownRepeatIndexFormulaRule } from './rules/formulas/unknownRepeatIndexFormulaRule';
|
|
37
38
|
import { unknownRepeatItemFormulaRule } from './rules/formulas/unknownRepeatItemFormulaRule';
|
|
39
|
+
import { noStaticNodeCondition } from './rules/logic/noStaticNodeCondition';
|
|
38
40
|
import { noUnnecessaryConditionFalsy } from './rules/logic/noUnnecessaryConditionFalsy';
|
|
39
41
|
import { noUnnecessaryConditionTruthy } from './rules/logic/noUnnecessaryConditionTruthy';
|
|
40
42
|
import { noReferenceNodeRule } from './rules/noReferenceNodeRule';
|
|
@@ -113,6 +115,7 @@ const RULES = [
|
|
|
113
115
|
noReferenceProjectActionRule,
|
|
114
116
|
noReferenceProjectFormulaRule,
|
|
115
117
|
noReferenceVariableRule,
|
|
118
|
+
noStaticNodeCondition,
|
|
116
119
|
noUnnecessaryConditionFalsy,
|
|
117
120
|
noUnnecessaryConditionTruthy,
|
|
118
121
|
requireExtensionRule,
|
|
@@ -129,6 +132,7 @@ const RULES = [
|
|
|
129
132
|
unknownContextProviderWorkflowRule,
|
|
130
133
|
unknownContextWorkflowRule,
|
|
131
134
|
unknownCookieRule,
|
|
135
|
+
unknownComponentAttributeRule,
|
|
132
136
|
unknownEventRule,
|
|
133
137
|
unknownFormulaRule,
|
|
134
138
|
unknownProjectActionRule,
|
|
@@ -148,6 +152,10 @@ const RULES = [
|
|
|
148
152
|
const respond = (data) => postMessage(data);
|
|
149
153
|
const findProblems = (data) => {
|
|
150
154
|
const { files, options = {} } = data;
|
|
155
|
+
const idRespond = (results) => respond({
|
|
156
|
+
id: data.id,
|
|
157
|
+
results,
|
|
158
|
+
});
|
|
151
159
|
const rules = RULES.filter((rule) => (!options.categories || options.categories.includes(rule.category)) &&
|
|
152
160
|
(!options.levels || options.levels.includes(rule.level)) &&
|
|
153
161
|
!options.rulesToExclude?.includes(rule.code));
|
|
@@ -169,7 +177,7 @@ const findProblems = (data) => {
|
|
|
169
177
|
case 'per-file': {
|
|
170
178
|
if (fileType !== problem.path[0] || fileName !== problem.path[1]) {
|
|
171
179
|
if (batch.length > 0) {
|
|
172
|
-
|
|
180
|
+
idRespond(batch);
|
|
173
181
|
}
|
|
174
182
|
batch = [];
|
|
175
183
|
fileType = problem.path[0];
|
|
@@ -181,7 +189,7 @@ const findProblems = (data) => {
|
|
|
181
189
|
default: {
|
|
182
190
|
batch.push(problem);
|
|
183
191
|
if (batch.length >= (options.batchSize ?? 1)) {
|
|
184
|
-
|
|
192
|
+
idRespond(batch);
|
|
185
193
|
batch = [];
|
|
186
194
|
}
|
|
187
195
|
break;
|
|
@@ -189,7 +197,7 @@ const findProblems = (data) => {
|
|
|
189
197
|
}
|
|
190
198
|
}
|
|
191
199
|
// Send the remaining results
|
|
192
|
-
|
|
200
|
+
idRespond(batch);
|
|
193
201
|
};
|
|
194
202
|
const fixProblems = (data) => {
|
|
195
203
|
const { files, options = {}, fixRule } = data;
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"problems.worker.js","sourceRoot":"","sources":["../src/problems.worker.ts"],"names":[],"mappings":"AAEA,OAAO,EAAE,MAAM,EAAE,MAAM,eAAe,CAAA;AACtC,OAAO,EAAE,UAAU,EAAE,MAAM,cAAc,CAAA;AACzC,OAAO,EAAE,oBAAoB,EAAE,MAAM,sCAAsC,CAAA;AAC3E,OAAO,EAAE,gBAAgB,EAAE,MAAM,kCAAkC,CAAA;AACnE,OAAO,EAAE,4BAA4B,EAAE,MAAM,8CAA8C,CAAA;AAC3F,OAAO,EAAE,wBAAwB,EAAE,MAAM,0CAA0C,CAAA;AACnF,OAAO,EAAE,aAAa,EAAE,MAAM,4BAA4B,CAAA;AAC1D,OAAO,EAAE,kBAAkB,EAAE,MAAM,iCAAiC,CAAA;AACpE,OAAO,EAAE,mBAAmB,EAAE,MAAM,kCAAkC,CAAA;AACtE,OAAO,EAAE,cAAc,EAAE,MAAM,6BAA6B,CAAA;AAC5D,OAAO,EAAE,wBAAwB,EAAE,MAAM,6CAA6C,CAAA;AACtF,OAAO,EAAE,oBAAoB,EAAE,MAAM,yCAAyC,CAAA;AAC9E,OAAO,EAAE,wBAAwB,EAAE,MAAM,6CAA6C,CAAA;AACtF,OAAO,EAAE,oBAAoB,EAAE,MAAM,yCAAyC,CAAA;AAC9E,OAAO,EAAE,sBAAsB,EAAE,MAAM,wCAAwC,CAAA;AAC/E,OAAO,EAAE,yBAAyB,EAAE,MAAM,2CAA2C,CAAA;AACrF,OAAO,EAAE,iCAAiC,EAAE,MAAM,mDAAmD,CAAA;AACrG,OAAO,EAAE,0BAA0B,EAAE,MAAM,4CAA4C,CAAA;AACvF,OAAO,EAAE,6BAA6B,EAAE,MAAM,2CAA2C,CAAA;AACzF,OAAO,EAAE,8BAA8B,EAAE,MAAM,4CAA4C,CAAA;AAC3F,OAAO,EAAE,kCAAkC,EAAE,MAAM,gDAAgD,CAAA;AACnG,OAAO,EAAE,yBAAyB,EAAE,MAAM,uCAAuC,CAAA;AACjF,OAAO,EAAE,oCAAoC,EAAE,MAAM,kDAAkD,CAAA;AACvG,OAAO,EAAE,yBAAyB,EAAE,MAAM,uCAAuC,CAAA;AACjF,OAAO,EAAE,uBAAuB,EAAE,MAAM,qCAAqC,CAAA;AAC7E,OAAO,EAAE,kBAAkB,EAAE,MAAM,4BAA4B,CAAA;AAC/D,OAAO,EAAE,yBAAyB,EAAE,MAAM,0CAA0C,CAAA;AACpF,OAAO,EAAE,oBAAoB,EAAE,MAAM,qCAAqC,CAAA;AAC1E,OAAO,EAAE,gBAAgB,EAAE,MAAM,iCAAiC,CAAA;AAClE,OAAO,EAAE,uBAAuB,EAAE,MAAM,wCAAwC,CAAA;AAChF,OAAO,EAAE,iBAAiB,EAAE,MAAM,oCAAoC,CAAA;AACtE,OAAO,EAAE,+BAA+B,EAAE,MAAM,kDAAkD,CAAA;AAClG,OAAO,EAAE,6BAA6B,EAAE,MAAM,gDAAgD,CAAA;AAC9F,OAAO,EAAE,kBAAkB,EAAE,MAAM,qCAAqC,CAAA;AACxE,OAAO,EAAE,yBAAyB,EAAE,MAAM,4CAA4C,CAAA;AACtF,OAAO,EAAE,6BAA6B,EAAE,MAAM,gDAAgD,CAAA;AAC9F,OAAO,EAAE,4BAA4B,EAAE,MAAM,+CAA+C,CAAA;AAC5F,OAAO,EAAE,2BAA2B,EAAE,MAAM,2CAA2C,CAAA;AACvF,OAAO,EAAE,4BAA4B,EAAE,MAAM,4CAA4C,CAAA;AACzF,OAAO,EAAE,mBAAmB,EAAE,MAAM,6BAA6B,CAAA;AACjE,OAAO,EAAE,oBAAoB,EAAE,MAAM,8BAA8B,CAAA;AACnE,OAAO,EAAE,oBAAoB,EAAE,MAAM,oCAAoC,CAAA;AACzE,OAAO,EAAE,wBAAwB,EAAE,MAAM,wCAAwC,CAAA;AACjF,OAAO,EAAE,sBAAsB,EAAE,MAAM,sCAAsC,CAAA;AAC7E,OAAO,EAAE,iBAAiB,EAAE,MAAM,2BAA2B,CAAA;AAC7D,OAAO,EAAE,yBAAyB,EAAE,MAAM,iDAAiD,CAAA;AAC3F,OAAO,EAAE,0BAA0B,EAAE,MAAM,kDAAkD,CAAA;AAC7F,OAAO,EAAE,uBAAuB,EAAE,MAAM,+CAA+C,CAAA;AACvF,OAAO,EAAE,uBAAuB,EAAE,MAAM,2CAA2C,CAAA;AACnF,OAAO,EAAE,mBAAmB,EAAE,MAAM,uCAAuC,CAAA;AAC3E,OAAO,EAAE,yBAAyB,EAAE,MAAM,6CAA6C,CAAA;AACvF,OAAO,EAAE,8BAA8B,EAAE,MAAM,kDAAkD,CAAA;AACjG,OAAO,EAAE,oBAAoB,EAAE,MAAM,wCAAwC,CAAA;AAC7E,OAAO,EAAE,gCAAgC,EAAE,MAAM,oDAAoD,CAAA;AACrG,OAAO,EAAE,kCAAkC,EAAE,MAAM,sDAAsD,CAAA;AACzG,OAAO,EAAE,0BAA0B,EAAE,MAAM,8CAA8C,CAAA;AACzF,OAAO,EAAE,mCAAmC,EAAE,MAAM,uDAAuD,CAAA;AAC3G,OAAO,EAAE,0BAA0B,EAAE,MAAM,8CAA8C,CAAA;AACzF,OAAO,EAAE,4BAA4B,EAAE,MAAM,gDAAgD,CAAA;AAC7F,OAAO,EAAE,aAAa,EAAE,MAAM,iBAAiB,CAAA;AA0C/C,MAAM,KAAK,GAAG;IACZ,oBAAoB,CAAC,EAAE,IAAI,EAAE,sBAAsB,EAAE,IAAI,EAAE,YAAY,EAAE,CAAC;IAC1E,kCAAkC,CAAC,EAAE,GAAG,EAAE,GAAG,EAAE,SAAS,EAAE,MAAM,EAAE,CAAC;IACnE,kCAAkC,CAAC;QACjC,GAAG,EAAE,KAAK;QACV,SAAS,EAAE,KAAK;QAChB,gBAAgB,EAAE,IAAI;KACvB,CAAC;IACF,kCAAkC,CAAC,EAAE,GAAG,EAAE,KAAK,EAAE,SAAS,EAAE,KAAK,EAAE,CAAC;IACpE,yBAAyB,CAAC,aAAa,CAAC;IACxC,yBAAyB,CAAC,OAAO,CAAC;IAClC,6BAA6B,CAAC,CAAC,IAAI,EAAE,IAAI,CAAC,EAAE,CAAC,IAAI,EAAE,QAAQ,EAAE,UAAU,CAAC,CAAC;IACzE,8BAA8B,CAAC,CAAC,IAAI,EAAE,IAAI,CAAC,EAAE,CAAC,IAAI,CAAC,CAAC;IACpD,oFAAoF;IACpF,6BAA6B,CAC3B,CAAC,OAAO,CAAC,EACT,CAAC,SAAS,EAAE,UAAU,EAAE,OAAO,EAAE,OAAO,EAAE,OAAO,EAAE,IAAI,CAAC,CACzD;IACD,oFAAoF;IACpF,oFAAoF;IACpF,oFAAoF;IACpF,8BAA8B,CAAC,CAAC,OAAO,CAAC,EAAE,CAAC,OAAO,EAAE,OAAO,EAAE,OAAO,CAAC,CAAC;IACtE,iFAAiF;IACjF,6BAA6B,CAAC,CAAC,IAAI,CAAC,EAAE,CAAC,IAAI,EAAE,IAAI,EAAE,QAAQ,EAAE,UAAU,CAAC,CAAC;IACzE,iFAAiF;IACjF,iFAAiF;IACjF,8BAA8B,CAAC,CAAC,IAAI,CAAC,EAAE,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC;IACpD,qFAAqF;IACrF,6BAA6B,CAAC,CAAC,QAAQ,CAAC,EAAE,CAAC,QAAQ,EAAE,UAAU,EAAE,IAAI,CAAC,CAAC;IACvE,uFAAuF;IACvF,6BAA6B,CAAC,CAAC,UAAU,CAAC,EAAE,CAAC,QAAQ,CAAC,CAAC;IACvD,qFAAqF;IACrF,8BAA8B,CAAC,CAAC,UAAU,CAAC,EAAE,CAAC,QAAQ,CAAC,CAAC;IACxD,iFAAiF;IACjF,6BAA6B,CAC3B,CAAC,IAAI,CAAC,EACN,CAAC,IAAI,EAAE,IAAI,EAAE,KAAK,EAAE,QAAQ,EAAE,UAAU,CAAC,CAC1C;IACD,yBAAyB;IACzB,kBAAkB;IAClB,yBAAyB;IACzB,8BAA8B;IAC9B,oCAAoC;IACpC,yBAAyB;IACzB,sBAAsB;IACtB,gBAAgB;IAChB,aAAa;IACb,iBAAiB;IACjB,sBAAsB;IACtB,uBAAuB;IACvB,oBAAoB;IACpB,kBAAkB;IAClB,wBAAwB;IACxB,+BAA+B;IAC/B,wBAAwB;IACxB,gCAAgC;IAChC,oBAAoB;IACpB,mBAAmB;IACnB,4BAA4B;IAC5B,6BAA6B;IAC7B,uBAAuB;IACvB,2BAA2B;IAC3B,4BAA4B;IAC5B,oBAAoB;IACpB,cAAc;IACd,mBAAmB;IACnB,oBAAoB;IACpB,oBAAoB;IACpB,oCAAoC;IACpC,oBAAoB;IACpB,wBAAwB;IACxB,yBAAyB;IACzB,iCAAiC;IACjC,0BAA0B;IAC1B,kCAAkC;IAClC,0BAA0B;IAC1B,iBAAiB;IACjB,gBAAgB;IAChB,kBAAkB;IAClB,wBAAwB;IACxB,kCAAkC;IAClC,yBAAyB;IACzB,6BAA6B;IAC7B,4BAA4B;IAC5B,0BAA0B;IAC1B,uBAAuB;IACvB,mCAAmC;IACnC,0BAA0B;IAC1B,uBAAuB;IACvB,mBAAmB;IACnB,yBAAyB;IACzB,4BAA4B;CAC7B,CAAA;
|
|
1
|
+
{"version":3,"file":"problems.worker.js","sourceRoot":"","sources":["../src/problems.worker.ts"],"names":[],"mappings":"AAEA,OAAO,EAAE,MAAM,EAAE,MAAM,eAAe,CAAA;AACtC,OAAO,EAAE,UAAU,EAAE,MAAM,cAAc,CAAA;AACzC,OAAO,EAAE,oBAAoB,EAAE,MAAM,sCAAsC,CAAA;AAC3E,OAAO,EAAE,gBAAgB,EAAE,MAAM,kCAAkC,CAAA;AACnE,OAAO,EAAE,4BAA4B,EAAE,MAAM,8CAA8C,CAAA;AAC3F,OAAO,EAAE,wBAAwB,EAAE,MAAM,0CAA0C,CAAA;AACnF,OAAO,EAAE,aAAa,EAAE,MAAM,4BAA4B,CAAA;AAC1D,OAAO,EAAE,kBAAkB,EAAE,MAAM,iCAAiC,CAAA;AACpE,OAAO,EAAE,mBAAmB,EAAE,MAAM,kCAAkC,CAAA;AACtE,OAAO,EAAE,cAAc,EAAE,MAAM,6BAA6B,CAAA;AAC5D,OAAO,EAAE,wBAAwB,EAAE,MAAM,6CAA6C,CAAA;AACtF,OAAO,EAAE,oBAAoB,EAAE,MAAM,yCAAyC,CAAA;AAC9E,OAAO,EAAE,6BAA6B,EAAE,MAAM,kDAAkD,CAAA;AAChG,OAAO,EAAE,wBAAwB,EAAE,MAAM,6CAA6C,CAAA;AACtF,OAAO,EAAE,oBAAoB,EAAE,MAAM,yCAAyC,CAAA;AAC9E,OAAO,EAAE,sBAAsB,EAAE,MAAM,wCAAwC,CAAA;AAC/E,OAAO,EAAE,yBAAyB,EAAE,MAAM,2CAA2C,CAAA;AACrF,OAAO,EAAE,iCAAiC,EAAE,MAAM,mDAAmD,CAAA;AACrG,OAAO,EAAE,0BAA0B,EAAE,MAAM,4CAA4C,CAAA;AACvF,OAAO,EAAE,6BAA6B,EAAE,MAAM,2CAA2C,CAAA;AACzF,OAAO,EAAE,8BAA8B,EAAE,MAAM,4CAA4C,CAAA;AAC3F,OAAO,EAAE,kCAAkC,EAAE,MAAM,gDAAgD,CAAA;AACnG,OAAO,EAAE,yBAAyB,EAAE,MAAM,uCAAuC,CAAA;AACjF,OAAO,EAAE,oCAAoC,EAAE,MAAM,kDAAkD,CAAA;AACvG,OAAO,EAAE,yBAAyB,EAAE,MAAM,uCAAuC,CAAA;AACjF,OAAO,EAAE,uBAAuB,EAAE,MAAM,qCAAqC,CAAA;AAC7E,OAAO,EAAE,kBAAkB,EAAE,MAAM,4BAA4B,CAAA;AAC/D,OAAO,EAAE,yBAAyB,EAAE,MAAM,0CAA0C,CAAA;AACpF,OAAO,EAAE,oBAAoB,EAAE,MAAM,qCAAqC,CAAA;AAC1E,OAAO,EAAE,gBAAgB,EAAE,MAAM,iCAAiC,CAAA;AAClE,OAAO,EAAE,uBAAuB,EAAE,MAAM,wCAAwC,CAAA;AAChF,OAAO,EAAE,iBAAiB,EAAE,MAAM,oCAAoC,CAAA;AACtE,OAAO,EAAE,+BAA+B,EAAE,MAAM,kDAAkD,CAAA;AAClG,OAAO,EAAE,6BAA6B,EAAE,MAAM,gDAAgD,CAAA;AAC9F,OAAO,EAAE,kBAAkB,EAAE,MAAM,qCAAqC,CAAA;AACxE,OAAO,EAAE,yBAAyB,EAAE,MAAM,4CAA4C,CAAA;AACtF,OAAO,EAAE,6BAA6B,EAAE,MAAM,gDAAgD,CAAA;AAC9F,OAAO,EAAE,4BAA4B,EAAE,MAAM,+CAA+C,CAAA;AAC5F,OAAO,EAAE,qBAAqB,EAAE,MAAM,qCAAqC,CAAA;AAC3E,OAAO,EAAE,2BAA2B,EAAE,MAAM,2CAA2C,CAAA;AACvF,OAAO,EAAE,4BAA4B,EAAE,MAAM,4CAA4C,CAAA;AACzF,OAAO,EAAE,mBAAmB,EAAE,MAAM,6BAA6B,CAAA;AACjE,OAAO,EAAE,oBAAoB,EAAE,MAAM,8BAA8B,CAAA;AACnE,OAAO,EAAE,oBAAoB,EAAE,MAAM,oCAAoC,CAAA;AACzE,OAAO,EAAE,wBAAwB,EAAE,MAAM,wCAAwC,CAAA;AACjF,OAAO,EAAE,sBAAsB,EAAE,MAAM,sCAAsC,CAAA;AAC7E,OAAO,EAAE,iBAAiB,EAAE,MAAM,2BAA2B,CAAA;AAC7D,OAAO,EAAE,yBAAyB,EAAE,MAAM,iDAAiD,CAAA;AAC3F,OAAO,EAAE,0BAA0B,EAAE,MAAM,kDAAkD,CAAA;AAC7F,OAAO,EAAE,uBAAuB,EAAE,MAAM,+CAA+C,CAAA;AACvF,OAAO,EAAE,uBAAuB,EAAE,MAAM,2CAA2C,CAAA;AACnF,OAAO,EAAE,mBAAmB,EAAE,MAAM,uCAAuC,CAAA;AAC3E,OAAO,EAAE,yBAAyB,EAAE,MAAM,6CAA6C,CAAA;AACvF,OAAO,EAAE,8BAA8B,EAAE,MAAM,kDAAkD,CAAA;AACjG,OAAO,EAAE,oBAAoB,EAAE,MAAM,wCAAwC,CAAA;AAC7E,OAAO,EAAE,gCAAgC,EAAE,MAAM,oDAAoD,CAAA;AACrG,OAAO,EAAE,kCAAkC,EAAE,MAAM,sDAAsD,CAAA;AACzG,OAAO,EAAE,0BAA0B,EAAE,MAAM,8CAA8C,CAAA;AACzF,OAAO,EAAE,mCAAmC,EAAE,MAAM,uDAAuD,CAAA;AAC3G,OAAO,EAAE,0BAA0B,EAAE,MAAM,8CAA8C,CAAA;AACzF,OAAO,EAAE,4BAA4B,EAAE,MAAM,gDAAgD,CAAA;AAC7F,OAAO,EAAE,aAAa,EAAE,MAAM,iBAAiB,CAAA;AA0C/C,MAAM,KAAK,GAAG;IACZ,oBAAoB,CAAC,EAAE,IAAI,EAAE,sBAAsB,EAAE,IAAI,EAAE,YAAY,EAAE,CAAC;IAC1E,kCAAkC,CAAC,EAAE,GAAG,EAAE,GAAG,EAAE,SAAS,EAAE,MAAM,EAAE,CAAC;IACnE,kCAAkC,CAAC;QACjC,GAAG,EAAE,KAAK;QACV,SAAS,EAAE,KAAK;QAChB,gBAAgB,EAAE,IAAI;KACvB,CAAC;IACF,kCAAkC,CAAC,EAAE,GAAG,EAAE,KAAK,EAAE,SAAS,EAAE,KAAK,EAAE,CAAC;IACpE,yBAAyB,CAAC,aAAa,CAAC;IACxC,yBAAyB,CAAC,OAAO,CAAC;IAClC,6BAA6B,CAAC,CAAC,IAAI,EAAE,IAAI,CAAC,EAAE,CAAC,IAAI,EAAE,QAAQ,EAAE,UAAU,CAAC,CAAC;IACzE,8BAA8B,CAAC,CAAC,IAAI,EAAE,IAAI,CAAC,EAAE,CAAC,IAAI,CAAC,CAAC;IACpD,oFAAoF;IACpF,6BAA6B,CAC3B,CAAC,OAAO,CAAC,EACT,CAAC,SAAS,EAAE,UAAU,EAAE,OAAO,EAAE,OAAO,EAAE,OAAO,EAAE,IAAI,CAAC,CACzD;IACD,oFAAoF;IACpF,oFAAoF;IACpF,oFAAoF;IACpF,8BAA8B,CAAC,CAAC,OAAO,CAAC,EAAE,CAAC,OAAO,EAAE,OAAO,EAAE,OAAO,CAAC,CAAC;IACtE,iFAAiF;IACjF,6BAA6B,CAAC,CAAC,IAAI,CAAC,EAAE,CAAC,IAAI,EAAE,IAAI,EAAE,QAAQ,EAAE,UAAU,CAAC,CAAC;IACzE,iFAAiF;IACjF,iFAAiF;IACjF,8BAA8B,CAAC,CAAC,IAAI,CAAC,EAAE,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC;IACpD,qFAAqF;IACrF,6BAA6B,CAAC,CAAC,QAAQ,CAAC,EAAE,CAAC,QAAQ,EAAE,UAAU,EAAE,IAAI,CAAC,CAAC;IACvE,uFAAuF;IACvF,6BAA6B,CAAC,CAAC,UAAU,CAAC,EAAE,CAAC,QAAQ,CAAC,CAAC;IACvD,qFAAqF;IACrF,8BAA8B,CAAC,CAAC,UAAU,CAAC,EAAE,CAAC,QAAQ,CAAC,CAAC;IACxD,iFAAiF;IACjF,6BAA6B,CAC3B,CAAC,IAAI,CAAC,EACN,CAAC,IAAI,EAAE,IAAI,EAAE,KAAK,EAAE,QAAQ,EAAE,UAAU,CAAC,CAC1C;IACD,yBAAyB;IACzB,kBAAkB;IAClB,yBAAyB;IACzB,8BAA8B;IAC9B,oCAAoC;IACpC,yBAAyB;IACzB,sBAAsB;IACtB,gBAAgB;IAChB,aAAa;IACb,iBAAiB;IACjB,sBAAsB;IACtB,uBAAuB;IACvB,oBAAoB;IACpB,kBAAkB;IAClB,wBAAwB;IACxB,+BAA+B;IAC/B,wBAAwB;IACxB,gCAAgC;IAChC,oBAAoB;IACpB,mBAAmB;IACnB,4BAA4B;IAC5B,6BAA6B;IAC7B,uBAAuB;IACvB,qBAAqB;IACrB,2BAA2B;IAC3B,4BAA4B;IAC5B,oBAAoB;IACpB,cAAc;IACd,mBAAmB;IACnB,oBAAoB;IACpB,oBAAoB;IACpB,oCAAoC;IACpC,oBAAoB;IACpB,wBAAwB;IACxB,yBAAyB;IACzB,iCAAiC;IACjC,0BAA0B;IAC1B,kCAAkC;IAClC,0BAA0B;IAC1B,iBAAiB;IACjB,6BAA6B;IAC7B,gBAAgB;IAChB,kBAAkB;IAClB,wBAAwB;IACxB,kCAAkC;IAClC,yBAAyB;IACzB,6BAA6B;IAC7B,4BAA4B;IAC5B,0BAA0B;IAC1B,uBAAuB;IACvB,mCAAmC;IACnC,0BAA0B;IAC1B,uBAAuB;IACvB,mBAAmB;IACnB,yBAAyB;IACzB,4BAA4B;CAC7B,CAAA;AAgCD,MAAM,OAAO,GAAG,CAAC,IAAc,EAAE,EAAE,CAAC,WAAW,CAAC,IAAI,CAAC,CAAA;AAErD,MAAM,YAAY,GAAG,CAAC,IAAsB,EAAE,EAAE;IAC9C,MAAM,EAAE,KAAK,EAAE,OAAO,GAAG,EAAE,EAAE,GAAG,IAAI,CAAA;IACpC,MAAM,SAAS,GAAG,CAAC,OAAiB,EAAE,EAAE,CACtC,OAAO,CAAC;QACN,EAAE,EAAE,IAAI,CAAC,EAAE;QACX,OAAO;KACR,CAAC,CAAA;IACJ,MAAM,KAAK,GAAG,KAAK,CAAC,MAAM,CACxB,CAAC,IAAI,EAAE,EAAE,CACP,CAAC,CAAC,OAAO,CAAC,UAAU,IAAI,OAAO,CAAC,UAAU,CAAC,QAAQ,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;QACnE,CAAC,CAAC,OAAO,CAAC,MAAM,IAAI,OAAO,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QACxD,CAAC,OAAO,CAAC,cAAc,EAAE,QAAQ,CAAC,IAAI,CAAC,IAAI,CAAC,CAC/C,CAAA;IAED,IAAI,KAAK,GAAa,EAAE,CAAA;IACxB,IAAI,QAAqC,CAAA;IACzC,IAAI,QAAqC,CAAA;IACzC,KAAK,MAAM,OAAO,IAAI,aAAa,CAAC;QAClC,KAAK;QACL,KAAK;QACL,YAAY,EAAE,OAAO,CAAC,YAAY;QAClC,aAAa,EAAE,OAAO,CAAC,aAAa;QACpC,KAAK,EAAE,OAAO,CAAC,KAAK;KACrB,CAAC,EAAE,CAAC;QACH,QAAQ,OAAO,CAAC,SAAS,EAAE,CAAC;YAC1B,KAAK,KAAK,CAAC,CAAC,CAAC;gBACX,KAAK,CAAC,IAAI,CAAC,OAAO,CAAC,CAAA;gBACnB,MAAK;YACP,CAAC;YACD,KAAK,UAAU,CAAC,CAAC,CAAC;gBAChB,IAAI,QAAQ,KAAK,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,IAAI,QAAQ,KAAK,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC;oBACjE,IAAI,KAAK,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;wBACrB,SAAS,CAAC,KAAK,CAAC,CAAA;oBAClB,CAAC;oBACD,KAAK,GAAG,EAAE,CAAA;oBACV,QAAQ,GAAG,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;oBAC1B,QAAQ,GAAG,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;gBAC5B,CAAC;gBAED,KAAK,CAAC,IAAI,CAAC,OAAO,CAAC,CAAA;gBACnB,MAAK;YACP,CAAC;YAED,OAAO,CAAC,CAAC,CAAC;gBACR,KAAK,CAAC,IAAI,CAAC,OAAO,CAAC,CAAA;gBACnB,IAAI,KAAK,CAAC,MAAM,IAAI,CAAC,OAAO,CAAC,SAAS,IAAI,CAAC,CAAC,EAAE,CAAC;oBAC7C,SAAS,CAAC,KAAK,CAAC,CAAA;oBAChB,KAAK,GAAG,EAAE,CAAA;gBACZ,CAAC;gBACD,MAAK;YACP,CAAC;QACH,CAAC;IACH,CAAC;IAED,6BAA6B;IAC7B,SAAS,CAAC,KAAK,CAAC,CAAA;AAClB,CAAC,CAAA;AAED,MAAM,WAAW,GAAG,CAAC,IAAqB,EAAE,EAAE;IAC5C,MAAM,EAAE,KAAK,EAAE,OAAO,GAAG,EAAE,EAAE,OAAO,EAAE,GAAG,IAAI,CAAA;IAC7C,MAAM,IAAI,GAAG,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,KAAK,OAAO,CAAC,CAAA;IAClD,IAAI,CAAC,IAAI,EAAE,CAAC;QACV,MAAM,IAAI,KAAK,CAAC,qBAAqB,IAAI,CAAC,OAAO,EAAE,CAAC,CAAA;IACtD,CAAC;IAED,MAAM,YAAY,GAAG,UAAU,CAAC;QAC9B,KAAK;QACL,IAAI;QACJ,OAAO,EAAE,IAAI,CAAC,OAAO;QACrB,YAAY,EAAE,OAAO,CAAC,YAAY;QAClC,aAAa,EAAE,OAAO,CAAC,aAAa;QACpC,KAAK,EAAE,OAAO,CAAC,KAAK;KACrB,CAAC,CAAA;IACF,iBAAiB;IACjB,MAAM,aAAa,GAAG,MAAM,CAAC,EAAE,iBAAiB,EAAE,IAAI,EAAE,CAAC,CAAA;IACzD,MAAM,IAAI,GAAG,aAAa,CAAC,IAAI,CAAC,KAAK,EAAE,YAAY,CAAC,CAAA;IACpD,sCAAsC;IACtC,OAAO,CAAC;QACN,EAAE,EAAE,IAAI,CAAC,EAAE;QACX,KAAK,EAAE,IAAI;QACX,OAAO,EAAE,IAAI,CAAC,OAAO;QACrB,OAAO,EAAE,IAAI,CAAC,OAAO;KACtB,CAAC,CAAA;AACJ,CAAC,CAAA;AAED;;GAEG;AACH,SAAS,GAAG,CAAC,KAA4B,EAAE,EAAE;IAC3C,IAAI,SAAS,IAAI,KAAK,CAAC,IAAI,EAAE,CAAC;QAC5B,WAAW,CAAC,KAAK,CAAC,IAAI,CAAC,CAAA;IACzB,CAAC;SAAM,CAAC;QACN,YAAY,CAAC,KAAK,CAAC,IAAI,CAAC,CAAA;IAC1B,CAAC;AACH,CAAC,CAAA"}
|
|
@@ -0,0 +1,33 @@
|
|
|
1
|
+
import { isDefined } from '@nordcraft/core/dist/utils/util';
|
|
2
|
+
import { removeFromPathFix } from '../../util/removeUnused.fix';
|
|
3
|
+
export const unknownComponentAttributeRule = {
|
|
4
|
+
code: 'unknown component attribute',
|
|
5
|
+
level: 'error',
|
|
6
|
+
category: 'Unknown Reference',
|
|
7
|
+
visit: (report, { path, files, value, nodeType }) => {
|
|
8
|
+
if (nodeType !== 'component-node' ||
|
|
9
|
+
value.type !== 'component' ||
|
|
10
|
+
// eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
|
|
11
|
+
Object.keys(value.attrs ?? {}).length === 0) {
|
|
12
|
+
return;
|
|
13
|
+
}
|
|
14
|
+
const component = value.package
|
|
15
|
+
? files.packages?.[value.package].components?.[value.name]
|
|
16
|
+
: files.components[value.name];
|
|
17
|
+
if (!component) {
|
|
18
|
+
return;
|
|
19
|
+
}
|
|
20
|
+
for (const attrKey of Object.keys(value.attrs)) {
|
|
21
|
+
// eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
|
|
22
|
+
if (!isDefined(component.attributes?.[attrKey])) {
|
|
23
|
+
report([...path, 'attrs', attrKey], { name: attrKey }, [
|
|
24
|
+
'delete-component-attribute',
|
|
25
|
+
]);
|
|
26
|
+
}
|
|
27
|
+
}
|
|
28
|
+
},
|
|
29
|
+
fixes: {
|
|
30
|
+
'delete-component-attribute': removeFromPathFix,
|
|
31
|
+
},
|
|
32
|
+
};
|
|
33
|
+
//# sourceMappingURL=unknownComponentAttributeRule.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"unknownComponentAttributeRule.js","sourceRoot":"","sources":["../../../src/rules/attributes/unknownComponentAttributeRule.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,SAAS,EAAE,MAAM,iCAAiC,CAAA;AAE3D,OAAO,EAAE,iBAAiB,EAAE,MAAM,6BAA6B,CAAA;AAE/D,MAAM,CAAC,MAAM,6BAA6B,GAErC;IACH,IAAI,EAAE,6BAA6B;IACnC,KAAK,EAAE,OAAO;IACd,QAAQ,EAAE,mBAAmB;IAC7B,KAAK,EAAE,CAAC,MAAM,EAAE,EAAE,IAAI,EAAE,KAAK,EAAE,KAAK,EAAE,QAAQ,EAAE,EAAE,EAAE;QAClD,IACE,QAAQ,KAAK,gBAAgB;YAC7B,KAAK,CAAC,IAAI,KAAK,WAAW;YAC1B,uEAAuE;YACvE,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,KAAK,IAAI,EAAE,CAAC,CAAC,MAAM,KAAK,CAAC,EAC3C,CAAC;YACD,OAAM;QACR,CAAC;QACD,MAAM,SAAS,GAAG,KAAK,CAAC,OAAO;YAC7B,CAAC,CAAC,KAAK,CAAC,QAAQ,EAAE,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC,UAAU,EAAE,CAAC,KAAK,CAAC,IAAI,CAAC;YAC1D,CAAC,CAAC,KAAK,CAAC,UAAU,CAAC,KAAK,CAAC,IAAI,CAAC,CAAA;QAChC,IAAI,CAAC,SAAS,EAAE,CAAC;YACf,OAAM;QACR,CAAC;QACD,KAAK,MAAM,OAAO,IAAI,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,KAAK,CAAC,EAAE,CAAC;YAC/C,uEAAuE;YACvE,IAAI,CAAC,SAAS,CAAC,SAAS,CAAC,UAAU,EAAE,CAAC,OAAO,CAAC,CAAC,EAAE,CAAC;gBAChD,MAAM,CAAC,CAAC,GAAG,IAAI,EAAE,OAAO,EAAE,OAAO,CAAC,EAAE,EAAE,IAAI,EAAE,OAAO,EAAE,EAAE;oBACrD,4BAA4B;iBAC7B,CAAC,CAAA;YACJ,CAAC;QACH,CAAC;IACH,CAAC;IACD,KAAK,EAAE;QACL,4BAA4B,EAAE,iBAAiB;KAChD;CACF,CAAA"}
|
|
@@ -0,0 +1,145 @@
|
|
|
1
|
+
import { valueFormula } from '@nordcraft/core/dist/formula/formulaUtils';
|
|
2
|
+
import { describe, expect, test } from 'bun:test';
|
|
3
|
+
import { fixProject } from '../../fixProject';
|
|
4
|
+
import { searchProject } from '../../searchProject';
|
|
5
|
+
import { unknownComponentAttributeRule } from './unknownComponentAttributeRule';
|
|
6
|
+
describe('find unknownComponentAttribute', () => {
|
|
7
|
+
test('should report unknown component attributes', () => {
|
|
8
|
+
const problems = Array.from(searchProject({
|
|
9
|
+
files: {
|
|
10
|
+
components: {
|
|
11
|
+
referenced: {
|
|
12
|
+
name: 'referenced',
|
|
13
|
+
nodes: {},
|
|
14
|
+
attributes: {
|
|
15
|
+
first: {
|
|
16
|
+
name: 'first',
|
|
17
|
+
testValue: valueFormula(null),
|
|
18
|
+
},
|
|
19
|
+
second: {
|
|
20
|
+
name: 'second',
|
|
21
|
+
testValue: valueFormula(null),
|
|
22
|
+
},
|
|
23
|
+
},
|
|
24
|
+
apis: {},
|
|
25
|
+
formulas: {},
|
|
26
|
+
variables: {},
|
|
27
|
+
},
|
|
28
|
+
test: {
|
|
29
|
+
name: 'test',
|
|
30
|
+
nodes: {
|
|
31
|
+
root: {
|
|
32
|
+
type: 'component',
|
|
33
|
+
name: 'referenced',
|
|
34
|
+
events: {},
|
|
35
|
+
children: [],
|
|
36
|
+
style: {},
|
|
37
|
+
attrs: {
|
|
38
|
+
first: valueFormula('exists'),
|
|
39
|
+
third: valueFormula('does not exist'),
|
|
40
|
+
},
|
|
41
|
+
},
|
|
42
|
+
},
|
|
43
|
+
formulas: {},
|
|
44
|
+
apis: {},
|
|
45
|
+
attributes: {},
|
|
46
|
+
variables: {},
|
|
47
|
+
},
|
|
48
|
+
},
|
|
49
|
+
},
|
|
50
|
+
rules: [unknownComponentAttributeRule],
|
|
51
|
+
}));
|
|
52
|
+
expect(problems).toHaveLength(1);
|
|
53
|
+
expect(problems[0].code).toBe('unknown component attribute');
|
|
54
|
+
expect(problems[0].details).toEqual({ name: 'third' });
|
|
55
|
+
});
|
|
56
|
+
test('should not report component attributes that exist', () => {
|
|
57
|
+
const problems = Array.from(searchProject({
|
|
58
|
+
files: {
|
|
59
|
+
components: {
|
|
60
|
+
test: {
|
|
61
|
+
name: 'test',
|
|
62
|
+
nodes: {
|
|
63
|
+
root: {
|
|
64
|
+
type: 'element',
|
|
65
|
+
attrs: {
|
|
66
|
+
known: valueFormula('exists'),
|
|
67
|
+
},
|
|
68
|
+
classes: {},
|
|
69
|
+
events: {},
|
|
70
|
+
tag: 'div',
|
|
71
|
+
children: [],
|
|
72
|
+
style: {},
|
|
73
|
+
},
|
|
74
|
+
},
|
|
75
|
+
formulas: {},
|
|
76
|
+
apis: {},
|
|
77
|
+
variables: {},
|
|
78
|
+
attributes: {
|
|
79
|
+
known: {
|
|
80
|
+
name: 'known',
|
|
81
|
+
testValue: { type: 'value', value: null },
|
|
82
|
+
},
|
|
83
|
+
},
|
|
84
|
+
},
|
|
85
|
+
},
|
|
86
|
+
},
|
|
87
|
+
rules: [unknownComponentAttributeRule],
|
|
88
|
+
}));
|
|
89
|
+
expect(problems).toEqual([]);
|
|
90
|
+
});
|
|
91
|
+
});
|
|
92
|
+
describe('fix unknownComponentAttribute', () => {
|
|
93
|
+
test('should remove unknown component attributes', () => {
|
|
94
|
+
const files = {
|
|
95
|
+
components: {
|
|
96
|
+
referenced: {
|
|
97
|
+
name: 'referenced',
|
|
98
|
+
nodes: {},
|
|
99
|
+
attributes: {
|
|
100
|
+
first: {
|
|
101
|
+
name: 'first',
|
|
102
|
+
testValue: valueFormula(null),
|
|
103
|
+
},
|
|
104
|
+
second: {
|
|
105
|
+
name: 'second',
|
|
106
|
+
testValue: valueFormula(null),
|
|
107
|
+
},
|
|
108
|
+
},
|
|
109
|
+
apis: {},
|
|
110
|
+
formulas: {},
|
|
111
|
+
variables: {},
|
|
112
|
+
},
|
|
113
|
+
test: {
|
|
114
|
+
name: 'test',
|
|
115
|
+
nodes: {
|
|
116
|
+
root: {
|
|
117
|
+
type: 'component',
|
|
118
|
+
name: 'referenced',
|
|
119
|
+
events: {},
|
|
120
|
+
children: [],
|
|
121
|
+
style: {},
|
|
122
|
+
attrs: {
|
|
123
|
+
first: valueFormula('exists'),
|
|
124
|
+
third: valueFormula('does not exist'),
|
|
125
|
+
},
|
|
126
|
+
},
|
|
127
|
+
},
|
|
128
|
+
formulas: {},
|
|
129
|
+
apis: {},
|
|
130
|
+
attributes: {},
|
|
131
|
+
variables: {},
|
|
132
|
+
},
|
|
133
|
+
},
|
|
134
|
+
};
|
|
135
|
+
const fixedProject = fixProject({
|
|
136
|
+
files,
|
|
137
|
+
rule: unknownComponentAttributeRule,
|
|
138
|
+
fixType: 'delete-component-attribute',
|
|
139
|
+
});
|
|
140
|
+
expect(fixedProject.components.test.nodes.root.attrs).toEqual({
|
|
141
|
+
first: valueFormula('exists'),
|
|
142
|
+
});
|
|
143
|
+
});
|
|
144
|
+
});
|
|
145
|
+
//# sourceMappingURL=unknownComponentAttributeRule.test.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"unknownComponentAttributeRule.test.js","sourceRoot":"","sources":["../../../src/rules/attributes/unknownComponentAttributeRule.test.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,YAAY,EAAE,MAAM,2CAA2C,CAAA;AAExE,OAAO,EAAE,QAAQ,EAAE,MAAM,EAAE,IAAI,EAAE,MAAM,UAAU,CAAA;AACjD,OAAO,EAAE,UAAU,EAAE,MAAM,kBAAkB,CAAA;AAC7C,OAAO,EAAE,aAAa,EAAE,MAAM,qBAAqB,CAAA;AACnD,OAAO,EAAE,6BAA6B,EAAE,MAAM,iCAAiC,CAAA;AAE/E,QAAQ,CAAC,gCAAgC,EAAE,GAAG,EAAE;IAC9C,IAAI,CAAC,4CAA4C,EAAE,GAAG,EAAE;QACtD,MAAM,QAAQ,GAAG,KAAK,CAAC,IAAI,CACzB,aAAa,CAAC;YACZ,KAAK,EAAE;gBACL,UAAU,EAAE;oBACV,UAAU,EAAE;wBACV,IAAI,EAAE,YAAY;wBAClB,KAAK,EAAE,EAAE;wBACT,UAAU,EAAE;4BACV,KAAK,EAAE;gCACL,IAAI,EAAE,OAAO;gCACb,SAAS,EAAE,YAAY,CAAC,IAAI,CAAC;6BAC9B;4BACD,MAAM,EAAE;gCACN,IAAI,EAAE,QAAQ;gCACd,SAAS,EAAE,YAAY,CAAC,IAAI,CAAC;6BAC9B;yBACF;wBACD,IAAI,EAAE,EAAE;wBACR,QAAQ,EAAE,EAAE;wBACZ,SAAS,EAAE,EAAE;qBACd;oBACD,IAAI,EAAE;wBACJ,IAAI,EAAE,MAAM;wBACZ,KAAK,EAAE;4BACL,IAAI,EAAE;gCACJ,IAAI,EAAE,WAAW;gCACjB,IAAI,EAAE,YAAY;gCAClB,MAAM,EAAE,EAAE;gCACV,QAAQ,EAAE,EAAE;gCACZ,KAAK,EAAE,EAAE;gCACT,KAAK,EAAE;oCACL,KAAK,EAAE,YAAY,CAAC,QAAQ,CAAC;oCAC7B,KAAK,EAAE,YAAY,CAAC,gBAAgB,CAAC;iCACtC;6BACF;yBACF;wBACD,QAAQ,EAAE,EAAE;wBACZ,IAAI,EAAE,EAAE;wBACR,UAAU,EAAE,EAAE;wBACd,SAAS,EAAE,EAAE;qBACd;iBACF;aACF;YACD,KAAK,EAAE,CAAC,6BAA6B,CAAC;SACvC,CAAC,CACH,CAAA;QAED,MAAM,CAAC,QAAQ,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAA;QAChC,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,6BAA6B,CAAC,CAAA;QAC5D,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,OAAO,CAAC,EAAE,IAAI,EAAE,OAAO,EAAE,CAAC,CAAA;IACxD,CAAC,CAAC,CAAA;IAEF,IAAI,CAAC,mDAAmD,EAAE,GAAG,EAAE;QAC7D,MAAM,QAAQ,GAAG,KAAK,CAAC,IAAI,CACzB,aAAa,CAAC;YACZ,KAAK,EAAE;gBACL,UAAU,EAAE;oBACV,IAAI,EAAE;wBACJ,IAAI,EAAE,MAAM;wBACZ,KAAK,EAAE;4BACL,IAAI,EAAE;gCACJ,IAAI,EAAE,SAAS;gCACf,KAAK,EAAE;oCACL,KAAK,EAAE,YAAY,CAAC,QAAQ,CAAC;iCAC9B;gCACD,OAAO,EAAE,EAAE;gCACX,MAAM,EAAE,EAAE;gCACV,GAAG,EAAE,KAAK;gCACV,QAAQ,EAAE,EAAE;gCACZ,KAAK,EAAE,EAAE;6BACV;yBACF;wBACD,QAAQ,EAAE,EAAE;wBACZ,IAAI,EAAE,EAAE;wBACR,SAAS,EAAE,EAAE;wBACb,UAAU,EAAE;4BACV,KAAK,EAAE;gCACL,IAAI,EAAE,OAAO;gCACb,SAAS,EAAE,EAAE,IAAI,EAAE,OAAO,EAAE,KAAK,EAAE,IAAI,EAAE;6BAC1C;yBACF;qBACF;iBACF;aACF;YACD,KAAK,EAAE,CAAC,6BAA6B,CAAC;SACvC,CAAC,CACH,CAAA;QACD,MAAM,CAAC,QAAQ,CAAC,CAAC,OAAO,CAAC,EAAE,CAAC,CAAA;IAC9B,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA;AAEF,QAAQ,CAAC,+BAA+B,EAAE,GAAG,EAAE;IAC7C,IAAI,CAAC,4CAA4C,EAAE,GAAG,EAAE;QACtD,MAAM,KAAK,GAAiB;YAC1B,UAAU,EAAE;gBACV,UAAU,EAAE;oBACV,IAAI,EAAE,YAAY;oBAClB,KAAK,EAAE,EAAE;oBACT,UAAU,EAAE;wBACV,KAAK,EAAE;4BACL,IAAI,EAAE,OAAO;4BACb,SAAS,EAAE,YAAY,CAAC,IAAI,CAAC;yBAC9B;wBACD,MAAM,EAAE;4BACN,IAAI,EAAE,QAAQ;4BACd,SAAS,EAAE,YAAY,CAAC,IAAI,CAAC;yBAC9B;qBACF;oBACD,IAAI,EAAE,EAAE;oBACR,QAAQ,EAAE,EAAE;oBACZ,SAAS,EAAE,EAAE;iBACd;gBACD,IAAI,EAAE;oBACJ,IAAI,EAAE,MAAM;oBACZ,KAAK,EAAE;wBACL,IAAI,EAAE;4BACJ,IAAI,EAAE,WAAW;4BACjB,IAAI,EAAE,YAAY;4BAClB,MAAM,EAAE,EAAE;4BACV,QAAQ,EAAE,EAAE;4BACZ,KAAK,EAAE,EAAE;4BACT,KAAK,EAAE;gCACL,KAAK,EAAE,YAAY,CAAC,QAAQ,CAAC;gCAC7B,KAAK,EAAE,YAAY,CAAC,gBAAgB,CAAC;6BACtC;yBACF;qBACF;oBACD,QAAQ,EAAE,EAAE;oBACZ,IAAI,EAAE,EAAE;oBACR,UAAU,EAAE,EAAE;oBACd,SAAS,EAAE,EAAE;iBACd;aACF;SACF,CAAA;QACD,MAAM,YAAY,GAAG,UAAU,CAAC;YAC9B,KAAK;YACL,IAAI,EAAE,6BAA6B;YACnC,OAAO,EAAE,4BAA4B;SACtC,CAAC,CAAA;QACF,MAAM,CACH,YAAY,CAAC,UAAU,CAAC,IAAK,CAAC,KAAK,CAAC,IAA2B,CAAC,KAAK,CACvE,CAAC,OAAO,CAAC;YACR,KAAK,EAAE,YAAY,CAAC,QAAQ,CAAC;SAC9B,CAAC,CAAA;IACJ,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA"}
|
|
@@ -0,0 +1,29 @@
|
|
|
1
|
+
import { contextlessEvaluateFormula } from '../../util/contextlessEvaluateFormula';
|
|
2
|
+
import { removeFromPathFix, removeNodeFromPathFix, } from '../../util/removeUnused.fix';
|
|
3
|
+
export const noStaticNodeCondition = {
|
|
4
|
+
code: 'no-static-node-condition',
|
|
5
|
+
level: 'warning',
|
|
6
|
+
category: 'Quality',
|
|
7
|
+
visit: (report, { path: nodePath, value, nodeType }) => {
|
|
8
|
+
if (nodeType !== 'component-node' || !value.condition) {
|
|
9
|
+
return;
|
|
10
|
+
}
|
|
11
|
+
const { isStatic, result } = contextlessEvaluateFormula(value.condition);
|
|
12
|
+
if (isStatic) {
|
|
13
|
+
const conditionPath = [...nodePath, 'condition'];
|
|
14
|
+
// - if truthy: "Condition is always true, you can safely remove the condition as it will always be rendered."
|
|
15
|
+
// - if falsy: "Condition is always false, you can safely remove the entire node as it will never be rendered."
|
|
16
|
+
report(conditionPath, {
|
|
17
|
+
result,
|
|
18
|
+
}, Boolean(result) === true ? ['remove-condition'] : ['remove-node']);
|
|
19
|
+
}
|
|
20
|
+
},
|
|
21
|
+
fixes: {
|
|
22
|
+
'remove-condition': removeFromPathFix,
|
|
23
|
+
'remove-node': (({ path, ...data }) => removeNodeFromPathFix({
|
|
24
|
+
path: path.slice(0, -1),
|
|
25
|
+
...data,
|
|
26
|
+
})),
|
|
27
|
+
},
|
|
28
|
+
};
|
|
29
|
+
//# sourceMappingURL=noStaticNodeCondition.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"noStaticNodeCondition.js","sourceRoot":"","sources":["../../../src/rules/logic/noStaticNodeCondition.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,0BAA0B,EAAE,MAAM,uCAAuC,CAAA;AAClF,OAAO,EACL,iBAAiB,EACjB,qBAAqB,GACtB,MAAM,6BAA6B,CAAA;AAEpC,MAAM,CAAC,MAAM,qBAAqB,GAE7B;IACH,IAAI,EAAE,0BAA0B;IAChC,KAAK,EAAE,SAAS;IAChB,QAAQ,EAAE,SAAS;IACnB,KAAK,EAAE,CAAC,MAAM,EAAE,EAAE,IAAI,EAAE,QAAQ,EAAE,KAAK,EAAE,QAAQ,EAAE,EAAE,EAAE;QACrD,IAAI,QAAQ,KAAK,gBAAgB,IAAI,CAAC,KAAK,CAAC,SAAS,EAAE,CAAC;YACtD,OAAM;QACR,CAAC;QAED,MAAM,EAAE,QAAQ,EAAE,MAAM,EAAE,GAAG,0BAA0B,CAAC,KAAK,CAAC,SAAS,CAAC,CAAA;QACxE,IAAI,QAAQ,EAAE,CAAC;YACb,MAAM,aAAa,GAAG,CAAC,GAAG,QAAQ,EAAE,WAAW,CAAC,CAAA;YAChD,8GAA8G;YAC9G,+GAA+G;YAC/G,MAAM,CACJ,aAAa,EACb;gBACE,MAAM;aACP,EACD,OAAO,CAAC,MAAM,CAAC,KAAK,IAAI,CAAC,CAAC,CAAC,CAAC,kBAAkB,CAAC,CAAC,CAAC,CAAC,CAAC,aAAa,CAAC,CAClE,CAAA;QACH,CAAC;IACH,CAAC;IACD,KAAK,EAAE;QACL,kBAAkB,EAAE,iBAAiB;QACrC,aAAa,EAAE,CAAC,CAAC,EAAE,IAAI,EAAE,GAAG,IAAI,EAAE,EAAE,EAAE,CACpC,qBAAqB,CAAC;YACpB,IAAI,EAAE,IAAI,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;YACvB,GAAG,IAAI;SACR,CAAC,CAA0B;KAC/B;CACF,CAAA"}
|
|
@@ -0,0 +1,274 @@
|
|
|
1
|
+
import { describe, expect, test } from 'bun:test';
|
|
2
|
+
import { fixProject } from '../../fixProject';
|
|
3
|
+
import { searchProject } from '../../searchProject';
|
|
4
|
+
import { noStaticNodeCondition } from './noStaticNodeCondition';
|
|
5
|
+
describe('noStaticNodeCondition', () => {
|
|
6
|
+
test('should report node condition that is always truthy', () => {
|
|
7
|
+
const problems = Array.from(searchProject({
|
|
8
|
+
files: {
|
|
9
|
+
components: {
|
|
10
|
+
test: {
|
|
11
|
+
name: 'test',
|
|
12
|
+
nodes: {
|
|
13
|
+
root: {
|
|
14
|
+
type: 'element',
|
|
15
|
+
attrs: {},
|
|
16
|
+
classes: {},
|
|
17
|
+
events: {},
|
|
18
|
+
tag: 'div',
|
|
19
|
+
children: [],
|
|
20
|
+
style: {},
|
|
21
|
+
condition: {
|
|
22
|
+
type: 'value',
|
|
23
|
+
value: true,
|
|
24
|
+
},
|
|
25
|
+
},
|
|
26
|
+
},
|
|
27
|
+
formulas: {},
|
|
28
|
+
apis: {},
|
|
29
|
+
attributes: {},
|
|
30
|
+
variables: {},
|
|
31
|
+
},
|
|
32
|
+
},
|
|
33
|
+
},
|
|
34
|
+
rules: [noStaticNodeCondition],
|
|
35
|
+
}));
|
|
36
|
+
expect(problems).toHaveLength(1);
|
|
37
|
+
expect(problems[0].code).toBe('no-static-node-condition');
|
|
38
|
+
expect(problems[0].details).toEqual({
|
|
39
|
+
result: true,
|
|
40
|
+
});
|
|
41
|
+
expect(problems[0].fixes).toEqual(['remove-condition']);
|
|
42
|
+
expect(problems[0].path).toEqual([
|
|
43
|
+
'components',
|
|
44
|
+
'test',
|
|
45
|
+
'nodes',
|
|
46
|
+
'root',
|
|
47
|
+
'condition',
|
|
48
|
+
]);
|
|
49
|
+
});
|
|
50
|
+
test('should report node condition that is always falsy', () => {
|
|
51
|
+
const problems = Array.from(searchProject({
|
|
52
|
+
files: {
|
|
53
|
+
components: {
|
|
54
|
+
test: {
|
|
55
|
+
name: 'test',
|
|
56
|
+
nodes: {
|
|
57
|
+
root: {
|
|
58
|
+
type: 'element',
|
|
59
|
+
attrs: {},
|
|
60
|
+
classes: {},
|
|
61
|
+
events: {},
|
|
62
|
+
tag: 'div',
|
|
63
|
+
children: [],
|
|
64
|
+
style: {},
|
|
65
|
+
condition: {
|
|
66
|
+
type: 'value',
|
|
67
|
+
value: false,
|
|
68
|
+
},
|
|
69
|
+
},
|
|
70
|
+
},
|
|
71
|
+
formulas: {},
|
|
72
|
+
apis: {},
|
|
73
|
+
attributes: {},
|
|
74
|
+
variables: {},
|
|
75
|
+
},
|
|
76
|
+
},
|
|
77
|
+
},
|
|
78
|
+
rules: [noStaticNodeCondition],
|
|
79
|
+
}));
|
|
80
|
+
expect(problems).toHaveLength(1);
|
|
81
|
+
expect(problems[0].code).toBe('no-static-node-condition');
|
|
82
|
+
expect(problems[0].details).toEqual({
|
|
83
|
+
result: false,
|
|
84
|
+
});
|
|
85
|
+
});
|
|
86
|
+
test('should not report node condition that is dynamic', () => {
|
|
87
|
+
const problems = Array.from(searchProject({
|
|
88
|
+
files: {
|
|
89
|
+
components: {
|
|
90
|
+
test: {
|
|
91
|
+
name: 'test',
|
|
92
|
+
nodes: {
|
|
93
|
+
root: {
|
|
94
|
+
type: 'element',
|
|
95
|
+
attrs: {},
|
|
96
|
+
classes: {},
|
|
97
|
+
events: {},
|
|
98
|
+
tag: 'div',
|
|
99
|
+
children: [],
|
|
100
|
+
style: {},
|
|
101
|
+
condition: {
|
|
102
|
+
type: 'apply',
|
|
103
|
+
name: 'randomNumber',
|
|
104
|
+
arguments: [],
|
|
105
|
+
},
|
|
106
|
+
},
|
|
107
|
+
},
|
|
108
|
+
formulas: {},
|
|
109
|
+
apis: {},
|
|
110
|
+
attributes: {},
|
|
111
|
+
variables: {},
|
|
112
|
+
},
|
|
113
|
+
},
|
|
114
|
+
},
|
|
115
|
+
rules: [noStaticNodeCondition],
|
|
116
|
+
}));
|
|
117
|
+
expect(problems).toHaveLength(0);
|
|
118
|
+
});
|
|
119
|
+
test('should fix static truthy condition by removing the condition', () => {
|
|
120
|
+
const files = {
|
|
121
|
+
components: {
|
|
122
|
+
test: {
|
|
123
|
+
name: 'test',
|
|
124
|
+
nodes: {
|
|
125
|
+
root: {
|
|
126
|
+
type: 'element',
|
|
127
|
+
attrs: {},
|
|
128
|
+
classes: {},
|
|
129
|
+
events: {},
|
|
130
|
+
tag: 'div',
|
|
131
|
+
children: [],
|
|
132
|
+
style: {},
|
|
133
|
+
condition: {
|
|
134
|
+
type: 'value',
|
|
135
|
+
value: true,
|
|
136
|
+
},
|
|
137
|
+
},
|
|
138
|
+
},
|
|
139
|
+
formulas: {},
|
|
140
|
+
apis: {},
|
|
141
|
+
attributes: {},
|
|
142
|
+
variables: {},
|
|
143
|
+
},
|
|
144
|
+
},
|
|
145
|
+
};
|
|
146
|
+
const fixedFiles = fixProject({
|
|
147
|
+
files,
|
|
148
|
+
rule: noStaticNodeCondition,
|
|
149
|
+
fixType: 'remove-condition',
|
|
150
|
+
});
|
|
151
|
+
expect(fixedFiles).toMatchInlineSnapshot(`
|
|
152
|
+
{
|
|
153
|
+
"components": {
|
|
154
|
+
"test": {
|
|
155
|
+
"apis": {},
|
|
156
|
+
"attributes": {},
|
|
157
|
+
"formulas": {},
|
|
158
|
+
"name": "test",
|
|
159
|
+
"nodes": {
|
|
160
|
+
"root": {
|
|
161
|
+
"attrs": {},
|
|
162
|
+
"children": [],
|
|
163
|
+
"classes": {},
|
|
164
|
+
"events": {},
|
|
165
|
+
"style": {},
|
|
166
|
+
"tag": "div",
|
|
167
|
+
"type": "element",
|
|
168
|
+
},
|
|
169
|
+
},
|
|
170
|
+
"variables": {},
|
|
171
|
+
},
|
|
172
|
+
},
|
|
173
|
+
}
|
|
174
|
+
`);
|
|
175
|
+
});
|
|
176
|
+
test("should fix static falsy condition by removing the node and any parents' references to it", () => {
|
|
177
|
+
const files = {
|
|
178
|
+
components: {
|
|
179
|
+
test: {
|
|
180
|
+
name: 'test',
|
|
181
|
+
nodes: {
|
|
182
|
+
root: {
|
|
183
|
+
type: 'element',
|
|
184
|
+
attrs: {},
|
|
185
|
+
classes: {},
|
|
186
|
+
events: {},
|
|
187
|
+
tag: 'div',
|
|
188
|
+
children: ['alwaysHiddenElement', 'sometimesVisibleElement'],
|
|
189
|
+
style: {},
|
|
190
|
+
},
|
|
191
|
+
alwaysHiddenElement: {
|
|
192
|
+
type: 'element',
|
|
193
|
+
attrs: {},
|
|
194
|
+
classes: {},
|
|
195
|
+
events: {},
|
|
196
|
+
tag: 'div',
|
|
197
|
+
children: [],
|
|
198
|
+
style: {},
|
|
199
|
+
condition: {
|
|
200
|
+
type: 'value',
|
|
201
|
+
value: false,
|
|
202
|
+
},
|
|
203
|
+
},
|
|
204
|
+
sometimesVisibleElement: {
|
|
205
|
+
type: 'element',
|
|
206
|
+
attrs: {},
|
|
207
|
+
classes: {},
|
|
208
|
+
events: {},
|
|
209
|
+
tag: 'div',
|
|
210
|
+
children: [],
|
|
211
|
+
style: {},
|
|
212
|
+
condition: {
|
|
213
|
+
type: 'path',
|
|
214
|
+
path: ['Variables', 'maybe'],
|
|
215
|
+
},
|
|
216
|
+
},
|
|
217
|
+
},
|
|
218
|
+
formulas: {},
|
|
219
|
+
apis: {},
|
|
220
|
+
attributes: {},
|
|
221
|
+
variables: {},
|
|
222
|
+
},
|
|
223
|
+
},
|
|
224
|
+
};
|
|
225
|
+
const fixedFiles = fixProject({
|
|
226
|
+
files,
|
|
227
|
+
rule: noStaticNodeCondition,
|
|
228
|
+
fixType: 'remove-node',
|
|
229
|
+
});
|
|
230
|
+
expect(fixedFiles).toMatchInlineSnapshot(`
|
|
231
|
+
{
|
|
232
|
+
"components": {
|
|
233
|
+
"test": {
|
|
234
|
+
"apis": {},
|
|
235
|
+
"attributes": {},
|
|
236
|
+
"formulas": {},
|
|
237
|
+
"name": "test",
|
|
238
|
+
"nodes": {
|
|
239
|
+
"root": {
|
|
240
|
+
"attrs": {},
|
|
241
|
+
"children": [
|
|
242
|
+
"sometimesVisibleElement",
|
|
243
|
+
],
|
|
244
|
+
"classes": {},
|
|
245
|
+
"events": {},
|
|
246
|
+
"style": {},
|
|
247
|
+
"tag": "div",
|
|
248
|
+
"type": "element",
|
|
249
|
+
},
|
|
250
|
+
"sometimesVisibleElement": {
|
|
251
|
+
"attrs": {},
|
|
252
|
+
"children": [],
|
|
253
|
+
"classes": {},
|
|
254
|
+
"condition": {
|
|
255
|
+
"path": [
|
|
256
|
+
"Variables",
|
|
257
|
+
"maybe",
|
|
258
|
+
],
|
|
259
|
+
"type": "path",
|
|
260
|
+
},
|
|
261
|
+
"events": {},
|
|
262
|
+
"style": {},
|
|
263
|
+
"tag": "div",
|
|
264
|
+
"type": "element",
|
|
265
|
+
},
|
|
266
|
+
},
|
|
267
|
+
"variables": {},
|
|
268
|
+
},
|
|
269
|
+
},
|
|
270
|
+
}
|
|
271
|
+
`);
|
|
272
|
+
});
|
|
273
|
+
});
|
|
274
|
+
//# sourceMappingURL=noStaticNodeCondition.test.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"noStaticNodeCondition.test.js","sourceRoot":"","sources":["../../../src/rules/logic/noStaticNodeCondition.test.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,QAAQ,EAAE,MAAM,EAAE,IAAI,EAAE,MAAM,UAAU,CAAA;AACjD,OAAO,EAAE,UAAU,EAAE,MAAM,kBAAkB,CAAA;AAC7C,OAAO,EAAE,aAAa,EAAE,MAAM,qBAAqB,CAAA;AACnD,OAAO,EAAE,qBAAqB,EAAE,MAAM,yBAAyB,CAAA;AAE/D,QAAQ,CAAC,uBAAuB,EAAE,GAAG,EAAE;IACrC,IAAI,CAAC,oDAAoD,EAAE,GAAG,EAAE;QAC9D,MAAM,QAAQ,GAAG,KAAK,CAAC,IAAI,CACzB,aAAa,CAAC;YACZ,KAAK,EAAE;gBACL,UAAU,EAAE;oBACV,IAAI,EAAE;wBACJ,IAAI,EAAE,MAAM;wBACZ,KAAK,EAAE;4BACL,IAAI,EAAE;gCACJ,IAAI,EAAE,SAAS;gCACf,KAAK,EAAE,EAAE;gCACT,OAAO,EAAE,EAAE;gCACX,MAAM,EAAE,EAAE;gCACV,GAAG,EAAE,KAAK;gCACV,QAAQ,EAAE,EAAE;gCACZ,KAAK,EAAE,EAAE;gCACT,SAAS,EAAE;oCACT,IAAI,EAAE,OAAO;oCACb,KAAK,EAAE,IAAI;iCACZ;6BACF;yBACF;wBACD,QAAQ,EAAE,EAAE;wBACZ,IAAI,EAAE,EAAE;wBACR,UAAU,EAAE,EAAE;wBACd,SAAS,EAAE,EAAE;qBACd;iBACF;aACF;YACD,KAAK,EAAE,CAAC,qBAAqB,CAAC;SAC/B,CAAC,CACH,CAAA;QAED,MAAM,CAAC,QAAQ,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAA;QAChC,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,0BAA0B,CAAC,CAAA;QACzD,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,OAAO,CAAC;YAClC,MAAM,EAAE,IAAI;SACb,CAAC,CAAA;QACF,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,OAAO,CAAC,CAAC,kBAAkB,CAAC,CAAC,CAAA;QACvD,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,OAAO,CAAC;YAC/B,YAAY;YACZ,MAAM;YACN,OAAO;YACP,MAAM;YACN,WAAW;SACZ,CAAC,CAAA;IACJ,CAAC,CAAC,CAAA;IAEF,IAAI,CAAC,mDAAmD,EAAE,GAAG,EAAE;QAC7D,MAAM,QAAQ,GAAG,KAAK,CAAC,IAAI,CACzB,aAAa,CAAC;YACZ,KAAK,EAAE;gBACL,UAAU,EAAE;oBACV,IAAI,EAAE;wBACJ,IAAI,EAAE,MAAM;wBACZ,KAAK,EAAE;4BACL,IAAI,EAAE;gCACJ,IAAI,EAAE,SAAS;gCACf,KAAK,EAAE,EAAE;gCACT,OAAO,EAAE,EAAE;gCACX,MAAM,EAAE,EAAE;gCACV,GAAG,EAAE,KAAK;gCACV,QAAQ,EAAE,EAAE;gCACZ,KAAK,EAAE,EAAE;gCACT,SAAS,EAAE;oCACT,IAAI,EAAE,OAAO;oCACb,KAAK,EAAE,KAAK;iCACb;6BACF;yBACF;wBACD,QAAQ,EAAE,EAAE;wBACZ,IAAI,EAAE,EAAE;wBACR,UAAU,EAAE,EAAE;wBACd,SAAS,EAAE,EAAE;qBACd;iBACF;aACF;YACD,KAAK,EAAE,CAAC,qBAAqB,CAAC;SAC/B,CAAC,CACH,CAAA;QAED,MAAM,CAAC,QAAQ,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAA;QAChC,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,0BAA0B,CAAC,CAAA;QACzD,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,OAAO,CAAC;YAClC,MAAM,EAAE,KAAK;SACd,CAAC,CAAA;IACJ,CAAC,CAAC,CAAA;IAEF,IAAI,CAAC,kDAAkD,EAAE,GAAG,EAAE;QAC5D,MAAM,QAAQ,GAAG,KAAK,CAAC,IAAI,CACzB,aAAa,CAAC;YACZ,KAAK,EAAE;gBACL,UAAU,EAAE;oBACV,IAAI,EAAE;wBACJ,IAAI,EAAE,MAAM;wBACZ,KAAK,EAAE;4BACL,IAAI,EAAE;gCACJ,IAAI,EAAE,SAAS;gCACf,KAAK,EAAE,EAAE;gCACT,OAAO,EAAE,EAAE;gCACX,MAAM,EAAE,EAAE;gCACV,GAAG,EAAE,KAAK;gCACV,QAAQ,EAAE,EAAE;gCACZ,KAAK,EAAE,EAAE;gCACT,SAAS,EAAE;oCACT,IAAI,EAAE,OAAO;oCACb,IAAI,EAAE,cAAc;oCACpB,SAAS,EAAE,EAAE;iCACd;6BACF;yBACF;wBACD,QAAQ,EAAE,EAAE;wBACZ,IAAI,EAAE,EAAE;wBACR,UAAU,EAAE,EAAE;wBACd,SAAS,EAAE,EAAE;qBACd;iBACF;aACF;YACD,KAAK,EAAE,CAAC,qBAAqB,CAAC;SAC/B,CAAC,CACH,CAAA;QAED,MAAM,CAAC,QAAQ,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAA;IAClC,CAAC,CAAC,CAAA;IAEF,IAAI,CAAC,8DAA8D,EAAE,GAAG,EAAE;QACxE,MAAM,KAAK,GAAiB;YAC1B,UAAU,EAAE;gBACV,IAAI,EAAE;oBACJ,IAAI,EAAE,MAAM;oBACZ,KAAK,EAAE;wBACL,IAAI,EAAE;4BACJ,IAAI,EAAE,SAAS;4BACf,KAAK,EAAE,EAAE;4BACT,OAAO,EAAE,EAAE;4BACX,MAAM,EAAE,EAAE;4BACV,GAAG,EAAE,KAAK;4BACV,QAAQ,EAAE,EAAE;4BACZ,KAAK,EAAE,EAAE;4BACT,SAAS,EAAE;gCACT,IAAI,EAAE,OAAO;gCACb,KAAK,EAAE,IAAI;6BACZ;yBACF;qBACF;oBACD,QAAQ,EAAE,EAAE;oBACZ,IAAI,EAAE,EAAE;oBACR,UAAU,EAAE,EAAE;oBACd,SAAS,EAAE,EAAE;iBACd;aACF;SACF,CAAA;QACD,MAAM,UAAU,GAAG,UAAU,CAAC;YAC5B,KAAK;YACL,IAAI,EAAE,qBAAqB;YAC3B,OAAO,EAAE,kBAAkB;SAC5B,CAAC,CAAA;QACF,MAAM,CAAC,UAAU,CAAC,CAAC,qBAAqB,CAAC;;;;;;;;;;;;;;;;;;;;;;;KAuBxC,CAAC,CAAA;IACJ,CAAC,CAAC,CAAA;IAEF,IAAI,CAAC,0FAA0F,EAAE,GAAG,EAAE;QACpG,MAAM,KAAK,GAAiB;YAC1B,UAAU,EAAE;gBACV,IAAI,EAAE;oBACJ,IAAI,EAAE,MAAM;oBACZ,KAAK,EAAE;wBACL,IAAI,EAAE;4BACJ,IAAI,EAAE,SAAS;4BACf,KAAK,EAAE,EAAE;4BACT,OAAO,EAAE,EAAE;4BACX,MAAM,EAAE,EAAE;4BACV,GAAG,EAAE,KAAK;4BACV,QAAQ,EAAE,CAAC,qBAAqB,EAAE,yBAAyB,CAAC;4BAC5D,KAAK,EAAE,EAAE;yBACV;wBACD,mBAAmB,EAAE;4BACnB,IAAI,EAAE,SAAS;4BACf,KAAK,EAAE,EAAE;4BACT,OAAO,EAAE,EAAE;4BACX,MAAM,EAAE,EAAE;4BACV,GAAG,EAAE,KAAK;4BACV,QAAQ,EAAE,EAAE;4BACZ,KAAK,EAAE,EAAE;4BACT,SAAS,EAAE;gCACT,IAAI,EAAE,OAAO;gCACb,KAAK,EAAE,KAAK;6BACb;yBACF;wBACD,uBAAuB,EAAE;4BACvB,IAAI,EAAE,SAAS;4BACf,KAAK,EAAE,EAAE;4BACT,OAAO,EAAE,EAAE;4BACX,MAAM,EAAE,EAAE;4BACV,GAAG,EAAE,KAAK;4BACV,QAAQ,EAAE,EAAE;4BACZ,KAAK,EAAE,EAAE;4BACT,SAAS,EAAE;gCACT,IAAI,EAAE,MAAM;gCACZ,IAAI,EAAE,CAAC,WAAW,EAAE,OAAO,CAAC;6BAC7B;yBACF;qBACF;oBACD,QAAQ,EAAE,EAAE;oBACZ,IAAI,EAAE,EAAE;oBACR,UAAU,EAAE,EAAE;oBACd,SAAS,EAAE,EAAE;iBACd;aACF;SACF,CAAA;QAED,MAAM,UAAU,GAAG,UAAU,CAAC;YAC5B,KAAK;YACL,IAAI,EAAE,qBAAqB;YAC3B,OAAO,EAAE,aAAa;SACvB,CAAC,CAAA;QAEF,MAAM,CAAC,UAAU,CAAC,CAAC,qBAAqB,CAAC;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;KAyCxC,CAAC,CAAA;IACJ,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA"}
|
|
@@ -1,3 +1,4 @@
|
|
|
1
|
+
import { contextlessEvaluateFormula } from '../../util/contextlessEvaluateFormula';
|
|
1
2
|
export const noUnnecessaryConditionFalsy = {
|
|
2
3
|
code: 'no-unnecessary-condition-falsy',
|
|
3
4
|
level: 'info',
|
|
@@ -6,7 +7,10 @@ export const noUnnecessaryConditionFalsy = {
|
|
|
6
7
|
if (nodeType !== 'formula' || value.type !== 'and') {
|
|
7
8
|
return;
|
|
8
9
|
}
|
|
9
|
-
if (value.arguments.some((arg) =>
|
|
10
|
+
if (value.arguments.some((arg) => {
|
|
11
|
+
const { result, isStatic } = contextlessEvaluateFormula(arg.formula);
|
|
12
|
+
return isStatic && Boolean(result) === false;
|
|
13
|
+
})) {
|
|
10
14
|
report(path);
|
|
11
15
|
}
|
|
12
16
|
},
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"noUnnecessaryConditionFalsy.js","sourceRoot":"","sources":["../../../src/rules/logic/noUnnecessaryConditionFalsy.ts"],"names":[],"mappings":"
|
|
1
|
+
{"version":3,"file":"noUnnecessaryConditionFalsy.js","sourceRoot":"","sources":["../../../src/rules/logic/noUnnecessaryConditionFalsy.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,0BAA0B,EAAE,MAAM,uCAAuC,CAAA;AAElF,MAAM,CAAC,MAAM,2BAA2B,GAAS;IAC/C,IAAI,EAAE,gCAAgC;IACtC,KAAK,EAAE,MAAM;IACb,QAAQ,EAAE,SAAS;IACnB,KAAK,EAAE,CAAC,MAAM,EAAE,EAAE,IAAI,EAAE,KAAK,EAAE,QAAQ,EAAE,EAAE,EAAE;QAC3C,IAAI,QAAQ,KAAK,SAAS,IAAI,KAAK,CAAC,IAAI,KAAK,KAAK,EAAE,CAAC;YACnD,OAAM;QACR,CAAC;QAED,IACE,KAAK,CAAC,SAAS,CAAC,IAAI,CAAC,CAAC,GAAG,EAAE,EAAE;YAC3B,MAAM,EAAE,MAAM,EAAE,QAAQ,EAAE,GAAG,0BAA0B,CAAC,GAAG,CAAC,OAAO,CAAC,CAAA;YACpE,OAAO,QAAQ,IAAI,OAAO,CAAC,MAAM,CAAC,KAAK,KAAK,CAAA;QAC9C,CAAC,CAAC,EACF,CAAC;YACD,MAAM,CAAC,IAAI,CAAC,CAAA;QACd,CAAC;IACH,CAAC;CACF,CAAA"}
|