@nordcraft/search 1.0.44 → 1.0.46

package/src/rules/style-variables/ambiguousStyleVariableSyntaxRule.test.ts

@@ -1,278 +0,0 @@
-import { describe, expect, test } from 'bun:test'
-import { searchProject } from '../../searchProject'
-import { ambiguousStyleVariableSyntaxRule } from './ambiguousStyleVariableSyntaxRule'
-
-describe('ambiguousStyleVariableSyntaxRule', () => {
-  test('should report when there are style variables with the same name but different syntax', () => {
-    const problems = Array.from(
-      searchProject({
-        files: {
-          components: {
-            component1: {
-              name: 'component1',
-              nodes: {
-                node1: {
-                  type: 'element',
-                  customProperties: {
-                    '--my-variable': {
-                      syntax: { type: 'primitive', name: 'length' },
-                      formula: { type: 'value', value: '10px' },
-                    },
-                  },
-                  attrs: {},
-                  style: {},
-                  children: [],
-                  events: {},
-                  classes: {},
-                  tag: 'div',
-                },
-              },
-              apis: {},
-              attributes: {},
-              variables: {},
-              formulas: {},
-            },
-            component2: {
-              name: 'component2',
-              nodes: {
-                node2: {
-                  type: 'element',
-                  customProperties: {
-                    '--my-variable': {
-                      syntax: { type: 'primitive', name: 'color' },
-                      formula: { type: 'value', value: '#ff0000' },
-                    },
-                  },
-                  attrs: {},
-                  style: {},
-                  children: [],
-                  events: {},
-                  classes: {},
-                  tag: 'div',
-                },
-              },
-              apis: {},
-              attributes: {},
-              variables: {},
-              formulas: {},
-            },
-          },
-        },
-        rules: [ambiguousStyleVariableSyntaxRule],
-      }),
-    )
-    expect(problems).toHaveLength(2)
-    expect(problems[0].code).toBe('ambiguous style variable syntax')
-    expect(problems[1].code).toBe('ambiguous style variable syntax')
-    expect(problems[0].details.name).toBe('--my-variable')
-    expect(problems[1].details.name).toBe('--my-variable')
-    expect(problems[0].details.duplicates).toEqual([
-      {
-        path: [
-          'components',
-          'component2',
-          'nodes',
-          'node2',
-          'customProperties',
-          '--my-variable',
-        ],
-        syntax: { type: 'primitive', name: 'color' },
-      },
-    ])
-    expect(problems[1].details.duplicates).toEqual([
-      {
-        path: [
-          'components',
-          'component1',
-          'nodes',
-          'node1',
-          'customProperties',
-          '--my-variable',
-        ],
-        syntax: { type: 'primitive', name: 'length' },
-      },
-    ])
-  })
-
-  test('should not report when style variables have same name and same syntax', () => {
-    const problems = Array.from(
-      searchProject({
-        files: {
-          components: {
-            component1: {
-              name: 'component1',
-              nodes: {
-                node1: {
-                  type: 'element',
-                  customProperties: {
-                    '--my-variable': {
-                      syntax: { type: 'primitive', name: 'length' },
-                      formula: { type: 'value', value: '10px' },
-                    },
-                  },
-                  attrs: {},
-                  style: {},
-                  children: [],
-                  events: {},
-                  classes: {},
-                  tag: 'div',
-                },
-              },
-              apis: {},
-              attributes: {},
-              variables: {},
-              formulas: {},
-            },
-            component2: {
-              name: 'component2',
-              nodes: {
-                node2: {
-                  type: 'element',
-                  customProperties: {
-                    '--my-variable': {
-                      syntax: { type: 'primitive', name: 'length' },
-                      formula: { type: 'value', value: '20px' },
-                    },
-                  },
-                  attrs: {},
-                  style: {},
-                  children: [],
-                  events: {},
-                  classes: {},
-                  tag: 'div',
-                },
-              },
-              apis: {},
-              attributes: {},
-              variables: {},
-              formulas: {},
-            },
-          },
-        },
-        rules: [ambiguousStyleVariableSyntaxRule],
-      }),
-    )
-    expect(problems).toHaveLength(0)
-  })
-
-  test('should handle variant customProperties too', () => {
-    const problems = Array.from(
-      searchProject({
-        files: {
-          components: {
-            component1: {
-              name: 'component1',
-              nodes: {
-                node1: {
-                  type: 'element',
-                  customProperties: {
-                    '--my-variable': {
-                      syntax: { type: 'primitive', name: 'length' },
-                      formula: { type: 'value', value: '10px' },
-                    },
-                  },
-                  variants: [
-                    {
-                      breakpoint: 'medium',
-                      style: {},
-                      customProperties: {
-                        '--my-variable': {
-                          syntax: { type: 'primitive', name: 'color' },
-                          formula: { type: 'value', value: '#ff0000' },
-                        },
-                      },
-                    },
-                  ],
-                  attrs: {},
-                  style: {},
-                  children: [],
-                  events: {},
-                  classes: {},
-                  tag: 'div',
-                },
-              },
-              apis: {},
-              attributes: {},
-              variables: {},
-              formulas: {},
-            },
-          },
-        },
-        rules: [ambiguousStyleVariableSyntaxRule],
-      }),
-    )
-
-    // Should flag both the base and the variant for conflicting syntax
-    expect(problems).toHaveLength(2)
-    expect(problems.map((p) => p.details.name)).toEqual([
-      '--my-variable',
-      '--my-variable',
-    ])
-  })
-
-  test('should ignore non-primitive syntax', () => {
-    const problems = Array.from(
-      searchProject({
-        files: {
-          components: {
-            component1: {
-              name: 'component1',
-              nodes: {
-                node1: {
-                  type: 'element',
-                  customProperties: {
-                    '--my-variable': {
-                      syntax: {
-                        type: 'keyword',
-                        keywords: ['auto', 'inherit'],
-                      },
-                      formula: { type: 'value', value: '10px' },
-                    },
-                  },
-                  attrs: {},
-                  style: {},
-                  children: [],
-                  events: {},
-                  classes: {},
-                  tag: 'div',
-                },
-              },
-              apis: {},
-              attributes: {},
-              variables: {},
-              formulas: {},
-            },
-            component2: {
-              name: 'component2',
-              nodes: {
-                node2: {
-                  type: 'element',
-                  customProperties: {
-                    '--my-variable': {
-                      syntax: { type: 'primitive', name: 'color' },
-                      formula: { type: 'value', value: '#ff0000' },
-                    },
-                  },
-                  attrs: {},
-                  style: {},
-                  children: [],
-                  events: {},
-                  classes: {},
-                  tag: 'div',
-                },
-              },
-              apis: {},
-              attributes: {},
-              variables: {},
-              formulas: {},
-            },
-          },
-        },
-        rules: [ambiguousStyleVariableSyntaxRule],
-      }),
-    )
-
-    // Should not report because non-primitive should be skipped
-    expect(problems).toHaveLength(0)
-  })
-})

package/src/rules/style-variables/ambiguousStyleVariableSyntaxRule.ts

@@ -1,65 +0,0 @@
-import type { CssSyntaxNode } from '@nordcraft/core/dist/styling/customProperty'
-import { getAllCustomPropertiesBySyntax } from '../../memos/getAllCustomPropertiesBySyntax'
-import type { Rule } from '../../types'
-
-export const ambiguousStyleVariableSyntaxRule: Rule<{
-  name: string
-  duplicates: Array<{ path: string[]; syntax: CssSyntaxNode }>
-}> = {
-  code: 'ambiguous style variable syntax',
-  level: 'error',
-  category: 'Other',
-  visit: (report, args) => {
-    const { nodeType, value, files, memo, path } = args
-    if (nodeType !== 'component-node') return
-    if (value.type !== 'element' && value.type !== 'component') return
-
-    const check = (
-      propName: string,
-      syntax: CssSyntaxNode,
-      basePath: Array<string | number>,
-    ) => {
-      if (syntax.type !== 'primitive') return
-      const allCustomPropertiesBySyntax = getAllCustomPropertiesBySyntax(memo, {
-        files,
-      })[propName]
-
-      const conflicts = Object.entries(allCustomPropertiesBySyntax)
-        .filter(([name]) => name !== syntax.name)
-        .flatMap(([, entries]) => entries)
-
-      if (conflicts.length > 0) {
-        report(basePath, {
-          name: propName,
-          duplicates: conflicts,
-        })
-      }
-    }
-
-    for (const [propName, prop] of Object.entries(
-      value.customProperties ?? {},
-    )) {
-      check(propName, prop.syntax, [
-        ...path,
-        'customProperties',
-        propName,
-        'name',
-      ])
-    }
-
-    value.variants?.forEach((variant, variantIndex) => {
-      for (const [propName, prop] of Object.entries(
-        variant.customProperties ?? {},
-      )) {
-        check(propName, prop.syntax, [
-          ...path,
-          'variants',
-          String(variantIndex),
-          'customProperties',
-          propName,
-          'name',
-        ])
-      }
-    })
-  },
-}