@nordcraft/runtime 1.0.23 → 1.0.25

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (8) hide show
  1. package/dist/custom-element.main.esm.js +2 -2
  2. package/dist/custom-element.main.esm.js.map +4 -4
  3. package/dist/page.main.esm.js +2 -2
  4. package/dist/page.main.esm.js.map +4 -4
  5. package/dist/utils/setAttribute.js +18 -9
  6. package/dist/utils/setAttribute.js.map +1 -1
  7. package/package.json +4 -4
  8. package/src/utils/setAttribute.ts +16 -8
package/dist/utils/setAttribute.js CHANGED
@@ -16,17 +16,26 @@ export function setAttribute(elem, attr, value) {
16
16
  break;
17
17
  case 'value':
18
18
  case 'type': {
19
- let val = value;
20
- if (elem instanceof HTMLProgressElement) {
21
- // An HTMLProgressElement will break other elements in our editor if the value is not a (finite) number
22
- // See docs here https://developer.mozilla.org/en-US/docs/Web/HTML/Element/progress#value
23
- // and original issue here https://discord.com/channels/972416966683926538/1317827591230722048
24
- if (!isDefined(value) || !Number.isFinite(Number(value))) {
25
- val = 0;
19
+ if (elem instanceof SVGElement) {
20
+ // The type attribute on SVG elements should just be added as an attribute
21
+ // See https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/type
22
+ if (toBoolean(value)) {
23
+ elem.setAttribute(attr, String(value));
26
24
  }
27
25
  }
28
- ;
29
- elem[attr] = toBoolean(val) ? String(val) : undefined;
26
+ else {
27
+ let val = value;
28
+ if (elem instanceof HTMLProgressElement) {
29
+ // An HTMLProgressElement will break other elements in our editor if the value is not a (finite) number
30
+ // See docs here https://developer.mozilla.org/en-US/docs/Web/HTML/Element/progress#value
31
+ // and original issue here https://discord.com/channels/972416966683926538/1317827591230722048
32
+ if (!isDefined(value) || !Number.isFinite(Number(value))) {
33
+ val = 0;
34
+ }
35
+ }
36
+ ;
37
+ elem[attr] = toBoolean(val) ? String(val) : undefined;
38
+ }
30
39
  break;
31
40
  }
32
41
  case 'muted':
package/dist/utils/setAttribute.js.map CHANGED
@@ -1 +1 @@
1
- {"version":3,"file":"setAttribute.js","sourceRoot":"","sources":["../../src/utils/setAttribute.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,SAAS,EAAE,SAAS,EAAE,MAAM,iCAAiC,CAAA;AAEtE;;GAEG;AACH,MAAM,UAAU,YAAY,CAC1B,IAA8C,EAC9C,IAAY,EACZ,KAAU;IAEV,QAAQ,IAAI,EAAE,CAAC;QACb,KAAK,WAAW,CAAC;QACjB,KAAK,KAAK;YACR,IAAI,IAAI,YAAY,gBAAgB,EAAE,CAAC;gBACrC,CAAC;gBAAC,IAAY,CAAC,IAAI,CAAC,GAAG,KAAK,CAAA;YAC9B,CAAC;iBAAM,CAAC;gBACN,IAAI,CAAC,YAAY,CAAC,IAAI,EAAE,MAAM,CAAC,KAAK,CAAC,CAAC,CAAA;YACxC,CAAC;YACD,MAAK;QACP,KAAK,OAAO,CAAC;QACb,KAAK,MAAM,CAAC,CAAC,CAAC;YACZ,IAAI,GAAG,GAAG,KAAK,CAAA;YACf,IAAI,IAAI,YAAY,mBAAmB,EAAE,CAAC;gBACxC,uGAAuG;gBACvG,yFAAyF;gBACzF,8FAA8F;gBAC9F,IAAI,CAAC,SAAS,CAAC,KAAK,CAAC,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC;oBACzD,GAAG,GAAG,CAAC,CAAA;gBACT,CAAC;YACH,CAAC;YACD,CAAC;YAAC,IAAY,CAAC,IAAI,CAAC,GAAG,SAAS,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,SAAS,CAAA;YAC/D,MAAK;QACP,CAAC;QACD,KAAK,OAAO,CAAC;QACb,KAAK,UAAU;YACb,IAAI,IAAI,YAAY,gBAAgB,EAAE,CAAC;gBACrC,CAAC;gBAAC,IAAY,CAAC,IAAI,CAAC,GAAG,SAAS,CAAC,KAAK,CAAC,CAAA;YACzC,CAAC;iBAAM,CAAC;gBACN,IAAI,CAAC,YAAY,CAAC,IAAI,EAAE,MAAM,CAAC,KAAK,CAAC,CAAC,CAAA;YACxC,CAAC;YACD,MAAK;QACP;YACE,IAAI,SAAS,CAAC,KAAK,CAAC,EAAE,CAAC;gBACrB,IAAI,CAAC,YAAY,CAAC,IAAI,EAAE,MAAM,CAAC,KAAK,CAAC,CAAC,CAAA;gBACtC;gBACE,8CAA8C;gBAC9C,IAAI,KAAK,WAAW;oBACpB,QAAQ,CAAC,IAAI,CAAC,YAAY,CAAC,WAAW,CAAC,KAAK,QAAQ,EACpD,CAAC;oBACD,UAAU,CAAC,GAAG,EAAE,CAAC,IAAI,CAAC,KAAK,EAAE,EAAE,GAAG,CAAC,CAAA;gBACrC,CAAC;YACH,CAAC;iBAAM,CAAC;gBACN,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,CAAA;YAC5B,CAAC;IACL,CAAC;AACH,CAAC"}
1
+ {"version":3,"file":"setAttribute.js","sourceRoot":"","sources":["../../src/utils/setAttribute.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,SAAS,EAAE,SAAS,EAAE,MAAM,iCAAiC,CAAA;AAEtE;;GAEG;AACH,MAAM,UAAU,YAAY,CAC1B,IAA8C,EAC9C,IAAY,EACZ,KAAU;IAEV,QAAQ,IAAI,EAAE,CAAC;QACb,KAAK,WAAW,CAAC;QACjB,KAAK,KAAK;YACR,IAAI,IAAI,YAAY,gBAAgB,EAAE,CAAC;gBACrC,CAAC;gBAAC,IAAY,CAAC,IAAI,CAAC,GAAG,KAAK,CAAA;YAC9B,CAAC;iBAAM,CAAC;gBACN,IAAI,CAAC,YAAY,CAAC,IAAI,EAAE,MAAM,CAAC,KAAK,CAAC,CAAC,CAAA;YACxC,CAAC;YACD,MAAK;QACP,KAAK,OAAO,CAAC;QACb,KAAK,MAAM,CAAC,CAAC,CAAC;YACZ,IAAI,IAAI,YAAY,UAAU,EAAE,CAAC;gBAC/B,0EAA0E;gBAC1E,sEAAsE;gBACtE,IAAI,SAAS,CAAC,KAAK,CAAC,EAAE,CAAC;oBACrB,IAAI,CAAC,YAAY,CAAC,IAAI,EAAE,MAAM,CAAC,KAAK,CAAC,CAAC,CAAA;gBACxC,CAAC;YACH,CAAC;iBAAM,CAAC;gBACN,IAAI,GAAG,GAAG,KAAK,CAAA;gBACf,IAAI,IAAI,YAAY,mBAAmB,EAAE,CAAC;oBACxC,uGAAuG;oBACvG,yFAAyF;oBACzF,8FAA8F;oBAC9F,IAAI,CAAC,SAAS,CAAC,KAAK,CAAC,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC;wBACzD,GAAG,GAAG,CAAC,CAAA;oBACT,CAAC;gBACH,CAAC;gBACD,CAAC;gBAAC,IAAY,CAAC,IAAI,CAAC,GAAG,SAAS,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,SAAS,CAAA;YACjE,CAAC;YACD,MAAK;QACP,CAAC;QACD,KAAK,OAAO,CAAC;QACb,KAAK,UAAU;YACb,IAAI,IAAI,YAAY,gBAAgB,EAAE,CAAC;gBACrC,CAAC;gBAAC,IAAY,CAAC,IAAI,CAAC,GAAG,SAAS,CAAC,KAAK,CAAC,CAAA;YACzC,CAAC;iBAAM,CAAC;gBACN,IAAI,CAAC,YAAY,CAAC,IAAI,EAAE,MAAM,CAAC,KAAK,CAAC,CAAC,CAAA;YACxC,CAAC;YACD,MAAK;QACP;YACE,IAAI,SAAS,CAAC,KAAK,CAAC,EAAE,CAAC;gBACrB,IAAI,CAAC,YAAY,CAAC,IAAI,EAAE,MAAM,CAAC,KAAK,CAAC,CAAC,CAAA;gBACtC;gBACE,8CAA8C;gBAC9C,IAAI,KAAK,WAAW;oBACpB,QAAQ,CAAC,IAAI,CAAC,YAAY,CAAC,WAAW,CAAC,KAAK,QAAQ,EACpD,CAAC;oBACD,UAAU,CAAC,GAAG,EAAE,CAAC,IAAI,CAAC,KAAK,EAAE,EAAE,GAAG,CAAC,CAAA;gBACrC,CAAC;YACH,CAAC;iBAAM,CAAC;gBACN,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,CAAA;YAC5B,CAAC;IACL,CAAC;AACH,CAAC"}
package/package.json CHANGED
@@ -4,13 +4,13 @@
4
4
  "type": "module",
5
5
  "homepage": "https://github.com/nordcraftengine/nordcraft",
6
6
  "dependencies": {
7
- "@nordcraft/core": "1.0.23",
8
- "@nordcraft/std-lib": "1.0.23",
7
+ "@nordcraft/core": "1.0.25",
8
+ "@nordcraft/std-lib": "1.0.25",
9
9
  "fast-deep-equal": "3.1.3",
10
10
  "path-to-regexp": "6.3.0"
11
11
  },
12
12
  "devDependencies": {
13
- "@happy-dom/global-registrator": "17.5.6"
13
+ "@happy-dom/global-registrator": "18.0.1"
14
14
  },
15
15
  "scripts": {
16
16
  "build": "tsc && bun scripts/build.js",
@@ -21,5 +21,5 @@
21
21
  "files": ["dist", "src"],
22
22
  "main": "dist/page.main.js",
23
23
  "types": "dist/page.main.d.ts",
24
- "version": "1.0.23"
24
+ "version": "1.0.25"
25
25
  }
package/src/utils/setAttribute.ts CHANGED
@@ -19,16 +19,24 @@ export function setAttribute(
19
19
  break
20
20
  case 'value':
21
21
  case 'type': {
22
- let val = value
23
- if (elem instanceof HTMLProgressElement) {
24
- // An HTMLProgressElement will break other elements in our editor if the value is not a (finite) number
25
- // See docs here https://developer.mozilla.org/en-US/docs/Web/HTML/Element/progress#value
26
- // and original issue here https://discord.com/channels/972416966683926538/1317827591230722048
27
- if (!isDefined(value) || !Number.isFinite(Number(value))) {
28
- val = 0
22
+ if (elem instanceof SVGElement) {
23
+ // The type attribute on SVG elements should just be added as an attribute
24
+ // See https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/type
25
+ if (toBoolean(value)) {
26
+ elem.setAttribute(attr, String(value))
29
27
  }
28
+ } else {
29
+ let val = value
30
+ if (elem instanceof HTMLProgressElement) {
31
+ // An HTMLProgressElement will break other elements in our editor if the value is not a (finite) number
32
+ // See docs here https://developer.mozilla.org/en-US/docs/Web/HTML/Element/progress#value
33
+ // and original issue here https://discord.com/channels/972416966683926538/1317827591230722048
34
+ if (!isDefined(value) || !Number.isFinite(Number(value))) {
35
+ val = 0
36
+ }
37
+ }
38
+ ;(elem as any)[attr] = toBoolean(val) ? String(val) : undefined
30
39
  }
31
- ;(elem as any)[attr] = toBoolean(val) ? String(val) : undefined
32
40
  break
33
41
  }
34
42
  case 'muted':